https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32975 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 146700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146700&action=edit Bug 32975: Error in package.json's definition of css:build vs css:build:prod The "css:build" command runs "gulp css && gulp css --view opac", processes that build CSS in a development context. The "css:build:prod" currently runs "gulp build && gulp css --view opac", which runs the production-oriented command "gulp build" (for the staff interface), but runs "gulp css --view opac" which is the same devel-environment command as above. It should be "gulp build && gulp build --view opac" To test, apply the patch and run the two commands and check these two files to confirm the difference: koha-tmpl/intranet-tmpl/prog/css/staff-global.css koha-tmpl/opac-tmpl/bootstra/css/opac.css "yarn css:build" should create unminimized versions of those files. "yarn css:build:prod" should create minimized versions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32975 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146700|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 146701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146701&action=edit Bug 32975: Error in package.json's definition of css:build vs css:build:prod The "css:build" command runs "gulp css && gulp css --view opac", processes that build CSS in a development context. The "css:build:prod" currently runs "gulp build && gulp css --view opac", which runs the production-oriented command "gulp build" (for the staff interface), but runs "gulp css --view opac" which is the same devel-environment command as above. It should be "gulp build && gulp build --view opac" To test, apply the patch and run the two commands and check these two files to confirm the difference: koha-tmpl/intranet-tmpl/prog/css/staff-global.css koha-tmpl/opac-tmpl/bootstra/css/opac.css "yarn css:build" should create unminimized versions of those files. "yarn css:build:prod" should create minimized versions. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32975 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146701|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 146710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146710&action=edit Bug 32975: Error in package.json's definition of css:build vs css:build:prod The "css:build" command runs "gulp css && gulp css --view opac", processes that build CSS in a development context. The "css:build:prod" currently runs "gulp build && gulp css --view opac", which runs the production-oriented command "gulp build" (for the staff interface), but runs "gulp css --view opac" which is the same devel-environment command as above. It should be "gulp build && gulp build --view opac" To test, apply the patch and run the two commands and check these two files to confirm the difference: koha-tmpl/intranet-tmpl/prog/css/staff-global.css koha-tmpl/opac-tmpl/bootstra/css/opac.css "yarn css:build" should create unminimized versions of those files. "yarn css:build:prod" should create minimized versions. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32975 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32978 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32978 [Bug 32978] 'npm install' fails in ktd on aarch64, giving unsupported architecture error for node-sass -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32975 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32975 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #6 from Mason James <mtj@kohaaloha.com> --- (In reply to Tomás Cohen Arazi from comment #5)

Pushed to master for 23.05.

this looks to be missing from master, can you push? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32975 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |martin.renvoize@ptfs-europe | |.com --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Dependency not in 22.11.x series.. no backport required. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32975 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs documenting |RESOLVED --- Comment #10 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- This seems to be backend stuff, nothing to be added to the manual. I will close, but feel free to add details as to what needs to be documented, and I will add it to the manual. -- You are receiving this mail because: You are watching all bug changes.