[Bug 35612] New: Branchcode information for all customer fees lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Bug ID: 35612 Summary: Branchcode information for all customer fees lines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: pirkko-liisa.lauhikari@ouka.fi QA Contact: testopia@bugs.koha-community.org We would like to have branchcode recorded to the OVERDUE fees in accountlines table. Configurability is desired, so that it is possible to choose which library is recorded. Options could be customer's home library, issuing library and item's home library. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 --- Comment #1 from Pirkko-Liisa Lauhikari <pirkko-liisa.lauhikari@ouka.fi> --- We hope also, that branchcode information for all customer fees lines. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Agreed it would be helpful to consistently populate the branchcode for accountlines. For overdues fines, I believe the branch used to calculate the fine is determined by the CircControl and HomeOrHoldingBranch system preferences. Accountlines should record the branch used to calculate the fine. The longoverdue cron also follows CircControl but fails to record that branch in accountlines. It should do so. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Assignee|koha-bugs@lists.koha-commun |Laura.escamilla@bywatersolu |ity.org |tions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39802 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36506 Status|ASSIGNED |BLOCKED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 [Bug 36506] Processing Fee should be configurable by branch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 --- Comment #3 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 186567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186567&action=edit Bug 35612: Added new AccountLinesBranchSource system preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 --- Comment #4 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 186568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186568&action=edit Bug 35612: Added branch code logic -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 --- Comment #5 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 186569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186569&action=edit Bug 35612: sysprefs.sql updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 --- Comment #6 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 186570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186570&action=edit Bug 35612: Added the system preference within the Circulation and Fines policy in Administration To test: 1. Set system preferences: * FinesMode: Calculate and Charge * AccountLinesBranchSource: (this will be tested with different values later) 2. Set circulation rules: * Ensure a circulation rule exists that charges overdue fines for the item type and branch you're testing with. 3. Check out an item to a test patron with a due date in the past (to trigger overdue). 4. Run the fines cronjob: perl /usr/share/koha/bin/cronjobs/fines.pl 5. Verify fines appear on the patron’s Accounting tab in the staff interface. 6. Confirm branchcode is NULL in the database: * SELECT accountlines_id, branchcode, debit_type_code FROM accountlines ORDER BY accountlines_id DESC LIMIT 10; * Expect to see branchcode = NULL for the OVERDUE debit. 7. Apply the patch to your Koha instance. 8. Run updatedatabase 9. Run restart_all 10. In the staff interface, go to Administration → System Preferences, search for AccountLinesBranchSource, and set it to: "the library the item was checked out from" (checkoutbranch) 11. Repeat steps 3–6. 12. Confirm that in the SQL output, the branchcode now matches the checkout branch of the item. 13. Repeat steps 10–12 with each of the following AccountLinesBranchSource values: * itemhomebranch: The item’s home library * patronhomebranch: The patron’s home library * checkoutbranch: The checkout library (already tested) * none: Should result in NULL branchcode * Confirm that: The correct branch is recorded in the branchcode field of accountlines. When set to none, branchcode is again NULL. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 --- Comment #7 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 186571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186571&action=edit Bug 35612: Tests run perl t/db_dependent/Koha/Account.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Rather than adding a system preference to determine which branch is used or recorded for a debit, the goal here is to allow the existing system preferences -- CircControl, LostChargesControl (see bug 39802) -- to determine which branch's rules should be used to calculate the fee and then record that context in accountlines. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|36506 |39802 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 [Bug 36506] Processing Fee should be configurable by branch https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39802 [Bug 39802] Add CircControl equivalent system preference for lost item fees and actions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Branchcode information for |Record branch context in |all customer fees lines |accountlines.branchcode for | |LOST and PROCESSING fees --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #8)
Rather than adding a system preference to determine which branch is used or recorded for a debit, the goal here is to allow the existing system preferences -- CircControl, LostChargesControl (see bug 39802) -- to determine which branch's rules should be used to calculate the fee and then record that context in accountlines.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36506 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 [Bug 36506] Processing Fee should be configurable by branch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Record branch context in |Record branch context in |accountlines.branchcode for |accountlines.branchcode for |LOST and PROCESSING fees |OVERDUE, LOST, and | |PROCESSING fees --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I got so busy thinking about lost items I forgot that Pirkko-Liisa started this bug with OVERDUEs. OVERDUEs also fail to record the branch used to determine the fee and should also be covered in this work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186567|0 |1 is obsolete| | Attachment #186568|0 |1 is obsolete| | Attachment #186569|0 |1 is obsolete| | Attachment #186570|0 |1 is obsolete| | Attachment #186571|0 |1 is obsolete| | --- Comment #11 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 187919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187919&action=edit Bug 35612: Recorded branch context in accountlines.branchcode for OVERDUE, LOST, and PROCESSING fees -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 --- Comment #12 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 187920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187920&action=edit Bug 35612: Unit test Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 --- Comment #13 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 187921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187921&action=edit Bug 35612: Unit tests for Overdues.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 --- Comment #14 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 187922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187922&action=edit Bug 35612: Updates to Circulation.pm To test: There are dependencies for this patch so you’ll need to apply bugs 36506 and 39802 1. Create three test libraries — I used the following existing branches in K-T-D: 1. FPL (use as item’s home library) 2. CPL (use as checkout/holding library) 3. PVL (use as patron home library) 2. Create a patron with home library PVL — Olga Rivera is an example patron. 3. Create an item with: 1. homebranch = FPL 2. holdingbranch = CPL 4. System preferences: 1. FinesMode: set to Calculate and charge. 2. Within Circulation rules ensure a rule exists that charges overdue fines for the item type/branch you’re using. 5. Check out the item you created or selected to your patron and set the due date to a past date so that it is overdue. 6. Run fines: perl /usr/share/koha/bin/cronjobs/fines.pl 7. Confirm an OVERDUE fine appears on the patron’s account. 8. SQL check (expect branchcode is NULL for the OVERDUE line): SELECT accountlines_id, branchcode, debit_type_code FROM accountlines ORDER BY accountlines_id DESC LIMIT 10; 9. Apply the patch, run updatedatabase, then restart_all. 10. Enable the system preference CircControl: select an option of PatronLibrary, PickupLibrary, or ItemHomeLibrary 11. Enable the HomeOrHoldingBranch system preference: homebranch or holdingbranch (only matters when CircControl = ItemHomeLibrary) 12. Repeat steps 3-6 for the following scenarios. 1. CircControl = PatronLibrary → expect PVL (patron’s home). 2. CircControl = PickupLibrary → expect CPL (checkout/issuing branch). 3. CircControl = ItemHomeLibrary + HomeOrHoldingBranch = homebranch → expect FPL (item’s home). 4. CircControl = ItemHomeLibrary + HomeOrHoldingBranch = holdingbranch → expect CPL (item’s holding). 13. Next we’re going to test this with ‘Lost Items’ 14. Make sure WhenLostChargeReplacementFee syspref is set to Charge 15. Set the LostChargesControl syspref to one of the following PatronLibrary, PickupLibrary, or ItemHomeLibrary 16. Replacement price on the item must be > 0, otherwise no LOST debit is created. 17. First test this manually by setting the item to lost. 18. Start by confirming that an item is currently checked out to the test patron (checked out at CPL). 19. Set preferences for the scenario. 20. Mark the checked out item as lost. 21. SQL check (find the most recent LOST row): SELECT accountlines_id, branchcode, debit_type_code FROM accountlines ORDER BY accountlines_id DESC LIMIT 10; 22. Next test this by using the longoverdue cron 23. Re-checkout the item (as above), adjust longoverdue rules so cron will mark it lost. 24. Run perl /usr/share/koha/bin/cronjobs/longoverdue.pl --lost 30=1 --charge 1 --confirm --verbose 25. SQL check again for the new LOST row. 26. Test for the following scenarios: 1. LostChargesControl = PatronLibrary → expect PVL (patron’s home). 2. LostChargesControl = PickupLibrary → expect CPL (checkout/issuing branch). 3. LostChargesControl = ItemHomeLibrary + HomeOrHoldingBranch = homebranch → expect FPL (item’s home). 4. LostChargesControl = ItemHomeLibrary + HomeOrHoldingBranch = holdingbranch → expect CPL (item’s holding). 27. Make sure that if the replacement price is 0 → no LOST debit should be created. 28. And ensure that if WhenLostChargeReplacementFee = Don’t charge → no LOST debit should be created. 29. Turn FinesMode OFF (i.e., not “Calculate and charge”), run fines again → no new OVERDUE debits should be added. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 --- Comment #15 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- I forgot to add in my test plan to run prove t/db_dependent/Overdues.t prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #16 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- This all worked great for OVERDUE and LOST fees. But with the patches from this bug applied I'm not getting PROCESSING fees generated at all when items are lost. I do get processing fees with just BZ 36506 and BZ 39802 applied. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187919|0 |1 is obsolete| | Attachment #187920|0 |1 is obsolete| | Attachment #187921|0 |1 is obsolete| | Attachment #187922|0 |1 is obsolete| | --- Comment #17 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 189137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189137&action=edit Bug 35612: Recorded branch context in accountlines.branchcode for OVERDUE, LOST, and PROCESSING fees. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 --- Comment #18 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 192345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192345&action=edit Bug 35612: Unit test - Checkout.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 --- Comment #19 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 192346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192346&action=edit Bug 35612: Unit test - Overdues.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 --- Comment #20 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 192347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192347&action=edit Bug 35612: Unit test - Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 --- Comment #21 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 192348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192348&action=edit Bug 35612: Update to Accounts.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 --- Comment #22 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 192349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192349&action=edit Bug 35612: Unit tests - Accounts.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #23 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- This has merge errors due to changes in Bug 40680: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189876&action=diff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189137|0 |1 is obsolete| | Attachment #192345|0 |1 is obsolete| | Attachment #192346|0 |1 is obsolete| | Attachment #192347|0 |1 is obsolete| | Attachment #192348|0 |1 is obsolete| | Attachment #192349|0 |1 is obsolete| | --- Comment #24 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 192385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192385&action=edit Bug 35612: Recorded branch context in accountlines.branchcode for OVERDUE, LOST, and PROCESSING fees. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 --- Comment #25 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 192386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192386&action=edit Bug 35612: Unit test - Checkout.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 --- Comment #26 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 192387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192387&action=edit Bug 35612: Unit test - Overdues.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 --- Comment #27 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 192388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192388&action=edit Bug 35612: Unit test - Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 --- Comment #28 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 192389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192389&action=edit Bug 35612: Update to Accounts.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 --- Comment #29 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 192390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192390&action=edit Bug 35612: Unit tests - Accounts.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192385|0 |1 is obsolete| | --- Comment #30 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 192497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192497&action=edit Bug 35612: Recorded branch context in accountlines.branchcode for OVERDUE, LOST, and PROCESSING fees. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192386|0 |1 is obsolete| | --- Comment #31 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 192498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192498&action=edit Bug 35612: Unit test - Checkout.t Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192387|0 |1 is obsolete| | --- Comment #32 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 192499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192499&action=edit Bug 35612: Unit test - Overdues.t Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192388|0 |1 is obsolete| | --- Comment #33 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 192500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192500&action=edit Bug 35612: Unit test - Circulation.t Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192389|0 |1 is obsolete| | --- Comment #34 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 192501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192501&action=edit Bug 35612: Update to Accounts.pm Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192390|0 |1 is obsolete| | --- Comment #35 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 192502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192502&action=edit Bug 35612: Unit tests - Accounts.t Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192497|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192498|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192499|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192500|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192501|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192502|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 --- Comment #36 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192513&action=edit Bug 35612: Recorded branch context for OVERDUE, LOST, and PROCESSING fees This patch ensures that the accountlines.branchcode field correctly records which branch's circulation rules were applied when creating OVERDUE, LOST, and PROCESSING fee debits. Previously, this field was often NULL or set to the logged-in user's branch, making it difficult to track which branch's policies governed the fee calculation. Changes made: 1. New helper method: Koha::Checkout->branch_for_fee_context() - Centralizes branch resolution logic based on system preferences - For LOST/PROCESSING: honors LostChargesControl preference - For OVERDUE: honors CircControl preference - Respects HomeOrHoldingBranch when choosing item's branch - Supports both Koha objects and plain hashrefs - Returns branchcode or undef if context unavailable 2. C4::Accounts::chargelostitem() - Now accepts optional $opts hashref parameter - Accepts interface, library_id, and issue_id in options - Determines appropriate branch using branch_for_fee_context - Passes resolved branch to add_debit as library_id - Issue_id lookup handles bundled items correctly 3. C4::Circulation::LostItem() - Calls branch_for_fee_context before chargelostitem - Passes interface context ('cron' for cronjob, otherwise current) - Passes resolved branch and issue_id to chargelostitem 4. C4::Overdues::UpdateFine() - Calls branch_for_fee_context to determine OVERDUE branch - Passes result as library_id to add_debit - Resolves long-standing FIXME about branch selection 5. misc/cronjobs/longoverdue.pl - Determines branch context before marking items lost - Passes library_id to LostItem when charging fees The branch resolution logic respects these system preferences: - CircControl: PatronLibrary | PickupLibrary | ItemHomeLibrary - LostChargesControl: PatronLibrary | PickupLibrary | ItemHomeLibrary - HomeOrHoldingBranch: homebranch | holdingbranch Test plan: 1. Create three test libraries (e.g., FPL, CPL, PVL) 2. Create a test patron with home library PVL 3. Create an item with: - homebranch = FPL - holdingbranch = CPL 4. Set system preferences: - FinesMode: Calculate and charge - Create circulation rule that charges overdue fines 5. Test OVERDUE fees with CircControl: a. Set CircControl = PatronLibrary, HomeOrHoldingBranch = homebranch b. Check out item to patron at CPL, backdate to be overdue c. Run: perl /usr/share/koha/bin/cronjobs/fines.pl d. Check accountlines: SELECT accountlines_id, branchcode, debit_type_code FROM accountlines ORDER BY accountlines_id DESC LIMIT 5; e. Verify branchcode = PVL (patron's home library) f. Delete the fine, repeat with CircControl = PickupLibrary g. Verify branchcode = CPL (checkout library) h. Delete the fine, repeat with CircControl = ItemHomeLibrary i. Verify branchcode = FPL (item's home library) j. Change HomeOrHoldingBranch = holdingbranch, repeat k. Verify branchcode = CPL (item's holding library) 6. Test LOST fees with LostChargesControl: a. Set WhenLostChargeReplacementFee = Charge b. Set item replacement price > 0 c. Ensure item is checked out to patron d. Set LostChargesControl = PatronLibrary e. Mark item as lost in staff interface f. Check accountlines for LOST debit g. Verify branchcode = PVL (patron's home library) h. Return item, re-checkout, repeat with LostChargesControl = PickupLibrary i. Verify branchcode = CPL (checkout library) j. Repeat with LostChargesControl = ItemHomeLibrary + homebranch k. Verify branchcode = FPL (item's home) l. Repeat with LostChargesControl = ItemHomeLibrary + holdingbranch m. Verify branchcode = CPL (item's holding) 7. Test longoverdue cronjob: a. Re-checkout item with due date triggering longoverdue b. Run: perl /usr/share/koha/bin/cronjobs/longoverdue.pl --lost 30=1 --charge 1 --confirm --verbose c. Verify LOST debit created with correct branchcode per LostChargesControl 8. Test edge cases: - WhenLostChargeReplacementFee = Don't charge → no LOST debit - Replacement price = 0 → no LOST debit - FinesMode = Don't calculate → no OVERDUE debits Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 --- Comment #37 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192514&action=edit Bug 35612: Add unit test for Koha::Checkout->branch_for_fee_context Adds test coverage for the new branch_for_fee_context class method. Tests are minimal at this stage but verify the method exists and can be called. More comprehensive testing is covered in the C4::Accounts, C4::Circulation, and C4::Overdues test additions. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 --- Comment #38 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192515&action=edit Bug 35612: Add tests for branch context recording in OVERDUE fees Adds comprehensive test coverage for C4::Overdues::UpdateFine to verify that the branchcode field is correctly populated based on CircControl and HomeOrHoldingBranch system preferences. Tests verify: - CircControl = PatronLibrary uses patron's home branch - CircControl = PickupLibrary uses checkout/issue branch - CircControl = ItemHomeLibrary respects HomeOrHoldingBranch: * homebranch: uses item's home library * holdingbranch: uses item's holding library The tests create distinct libraries for each context (patron home, item home, item holding, checkout branch) and verify the correct branch is recorded in accountlines.branchcode for OVERDUE debits. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 --- Comment #39 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192516&action=edit Bug 35612: Add tests for branch context recording in LOST fees via LostItem Adds comprehensive test coverage for C4::Circulation::LostItem to verify that LOST and PROCESSING fee debits correctly record branchcode based on LostChargesControl and HomeOrHoldingBranch system preferences. Tests verify: - LostChargesControl = PatronLibrary uses patron's home branch - LostChargesControl = PickupLibrary uses checkout/issue branch - LostChargesControl = ItemHomeLibrary respects HomeOrHoldingBranch: * homebranch: uses item's home library * holdingbranch: uses item's holding library Tests cover both LOST and PROCESSING fee types and verify the branch context is preserved when fees are charged via the LostItem function, which is called both from the staff interface when manually marking items lost and from the longoverdue cronjob. The tests also verify correct behavior when mark_lost_from = 'cronjob' to ensure the interface context is properly set for batch operations. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 --- Comment #40 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192517&action=edit Bug 35612: Fix incorrect primary key reference Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 --- Comment #41 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192518&action=edit Bug 35612: Add tests for chargelostitem branch context Adds test coverage for C4::Accounts::chargelostitem to verify that LOST and PROCESSING fee debits correctly record branchcode based on LostChargesControl and HomeOrHoldingBranch system preferences. Tests verify all scenarios: 1. LostChargesControl behavior: - PatronLibrary: Uses patron's home branch - ItemHomeLibrary + homebranch: Uses item's home library - ItemHomeLibrary + holdingbranch: Uses item's holding library 2. Explicit library_id override: - When library_id is passed in options, it takes precedence 3. Deduplication logic: - Prevents duplicate LOST charges for same itemnumber+issue_id - Regression test for item_id column name bug 4. Issue_id handling: - Correctly looks up issue_id when not provided - Handles bundled items (looks up host item's checkout) 5. Processing fees: - Honors the same branch logic as LOST fees - Correctly applies lost_item_processing_fee circulation rule using the appropriate branch context This test subtest was added to the existing "C4::Accounts::chargelostitem tests" section and increases the test plan from 4 to 5 subtests. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 --- Comment #42 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192519&action=edit Bug 35612: (QA follow-up) Fix uninitialized value warnings When LostChargesControl system preference is not set (undefined), the code was generating 'Use of uninitialized value' warnings when comparing $lost_control_pref in string equality checks. This adds defined checks before the comparisons to handle the case where the preference is undefined, treating it the same as 'ItemHomeLibrary' (the default). Test plan: 1. Run prove t/db_dependent/Circulation.t 2. Verify all tests pass without warnings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 --- Comment #43 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192520&action=edit Bug 35612: (QA follow-up) Use interface parameter and remove self-referential use This patch fixes two issues: 1. C4::Accounts::chargelostitem now properly uses the $interface variable that was set from $opts->{interface} instead of calling C4::Context->interface directly. This ensures the interface parameter is honored, particularly important for cronjob context. 2. Removes the self-referential 'use Koha::Checkout;' statement in Koha/Checkout.pm which is logically incorrect (a module should not use itself). Test plan: 1. Run prove t/db_dependent/Accounts.t 2. Run prove t/db_dependent/Koha/Checkout.t 3. Verify all tests pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 --- Comment #44 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192521&action=edit Bug 35612: (QA follow-up) Document undef handling in branch_for_fee_context Improves POD documentation for branch_for_fee_context to: - Document all parameters (patron, item, issue objects) - Explain the resolution logic for each control preference - Clarify that returning undef is acceptable behavior - Note how undef is handled by calling code Adds inline comment explaining that undef return value is gracefully handled by Koha::Account->add_debit. This addresses concerns about unclear undef handling and improves maintainability. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 --- Comment #45 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192522&action=edit Bug 35612: (QA follow-up) Add test for undefined LostChargesControl preference Adds test coverage for the case where LostChargesControl system preference is not set (returns undef). This ensures the code handles this gracefully and defaults to ItemHomeLibrary behavior. The test verifies that: - No warnings are generated when the preference is undefined - The default behavior (ItemHomeLibrary) is applied correctly - The correct branch (item homebranch) is recorded in accountlines This improves test coverage and prevents regression of the fix for uninitialized value warnings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 --- Comment #46 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- I restored the test plans in the commits and enhanced the commit messages throughout. QA was fun here, there's quite a lot of refactoring going on for what on the face of it sounds like a trivial patch. Tests are passing, QA scripts are happy and I added a few minor QA follow-ups. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Keywords|release-notes-needed | Text to go in the| |This enhancement allows the release notes| |optional recording of the | |branch used when generating | |an accountline. | | | |For OVERDUE fees, the | |branch chosen by | |CircControl will be | |reflected here. For LOST | |and PROCESSING fees, the | |branch chosen by | |LostChargesControl will be | |reflected here. | | | |This development will allow | |librarians to reference | |charges against the circ | |rules to determine which | |branches rule was applied | |when creating a fine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40445 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40445 [Bug 40445] Point of Sale reconciliation input during daily summaries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|39802 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39802 [Bug 39802] Add CircControl equivalent system preference for lost item fees and actions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 --- Comment #47 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |jacob.omara@openfifth.co.uk --- Comment #48 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Enhancement, not backporting. Scream at me if you feel strongly it should be backported. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org