https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 87713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87713&action=edit Bug 21946: Database updates -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 87715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87715&action=edit Bug 21946: Update C4::Circulation->TooMany to check parent itemtypes To test: 1 - prove -v t/db_dependent/Circulation/TooMany.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 87717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87717&action=edit Bug 21946: Fix display of parent types -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 87719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87719&action=edit Bug 21946: Display parent-child relationship on smart-rules.pl To test: 1 - Set some itemtypes to have a parent 2 - Browse to Administration -> Circulation and fines rules 3 - Note new description of parent/child relationships at top of page 4 - Note that itemtype dropdown for circ rules shows child types under parents 5 - Set a rule for a child type 6 - Note it displays as Parent->Child 7 - Have three child types under a parent 8 - Set the parent 'Current checkouts allowed' to 3 9 - Set the children 'Current checkouts allowed' to: type1 = 2 type2 = 1 type3 = 1 10 - Create some items of the type above 11 - Note you can checkout 2 of type 1, and not 3 12 - Note you can checkout 1 of type 2, but not 2 13 - Note that you now cannot checkout any of type3 14 - Note you cannot checkout any of the parent type 15 - Return one of the other items and note you can now checkout an item of type3 16 - Return another item and note you can checkout an item of the parent type 17 - Return all 18 - Set the parent type to 1 19 - Now note you can only checkout 1 of any of the children 20 - Set the parent to 0 21 - Note you cannot checkout any of the child types -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #8 from Liz Rea <wizzyrea@gmail.com> --- Hi Nick, As you probably expected, I have some comments for you. :D On itemtypes.pl: - Would like to see the parent code column be the parent description instead; optionally, as below, put the parent code in parens. - Potentially, would like to see the ability to add many children to one parent itype. A little on the fence about this. To me it is slightly more logical to go to the parent and add all of the children at once (say, a series of addable dropdowns like the advanced search page has for adding additional search terms) than it is to go to each child and define the parent. - As long as the parents and children are grouped (they appear to be), I think we can get away with omitting the parent in the description, for ex: Mixed Materials | MX | (no parent, this is the parent) -- Maps | MP | Mixed Materials (MX) -- Music | MU | Mixed Materials (MX) -- Visual materials | VM | Mixed Materials (MX) I think that's all I have at the moment. I'm going through this one quite slowly :) Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from Liz Rea <wizzyrea@gmail.com> --- Hi Nick, As we talked about, this mostly works except that it only restricts items per branch hierarchically. I think you know where to look so I won't try and describe it fully bceause that could be very confusing. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87713|0 |1 is obsolete| | Attachment #87714|0 |1 is obsolete| | Attachment #87715|0 |1 is obsolete| | Attachment #87716|0 |1 is obsolete| | Attachment #87717|0 |1 is obsolete| | Attachment #87718|0 |1 is obsolete| | Attachment #87719|0 |1 is obsolete| | Attachment #88392|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 88574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88574&action=edit Bug 21946: Database updates -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 88576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88576&action=edit Bug 21946: Update C4::Circulation->TooMany to check parent itemtypes To test: 1 - prove -v t/db_dependent/Circulation/TooMany.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 88578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88578&action=edit Bug 21946: Fix display of parent types -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 88580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88580&action=edit Bug 21946: Display parent-child relationship on smart-rules.pl To test: 1 - Set some itemtypes to have a parent 2 - Browse to Administration -> Circulation and fines rules 3 - Note new description of parent/child relationships at top of page 4 - Note that itemtype dropdown for circ rules shows child types under parents 5 - Set a rule for a child type 6 - Note it displays as Parent->Child 7 - Have three child types under a parent 8 - Set the parent 'Current checkouts allowed' to 3 9 - Set the children 'Current checkouts allowed' to: type1 = 2 type2 = 1 type3 = 1 10 - Create some items of the type above 11 - Note you can checkout 2 of type 1, and not 3 12 - Note you can checkout 1 of type 2, but not 2 13 - Note that you now cannot checkout any of type3 14 - Note you cannot checkout any of the parent type 15 - Return one of the other items and note you can now checkout an item of type3 16 - Return another item and note you can checkout an item of the parent type 17 - Return all 18 - Set the parent type to 1 19 - Now note you can only checkout 1 of any of the children 20 - Set the parent to 0 21 - Note you cannot checkout any of the child types -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Bug 21946 depends on bug 22759, which changed state. Bug 22759 Summary: Circulation rules for maxissueqty are applied per branch even for defaults https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22759 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88574|0 |1 is obsolete| | Attachment #88575|0 |1 is obsolete| | Attachment #88576|0 |1 is obsolete| | Attachment #88577|0 |1 is obsolete| | Attachment #88578|0 |1 is obsolete| | Attachment #88579|0 |1 is obsolete| | Attachment #88580|0 |1 is obsolete| | Attachment #88581|0 |1 is obsolete| | --- Comment #19 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 88926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88926&action=edit Bug 21946: Database updates Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #21 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 88928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88928&action=edit Bug 21946: Update C4::Circulation->TooMany to check parent itemtypes To test: 1 - prove -v t/db_dependent/Circulation/TooMany.t Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #23 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 88930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88930&action=edit Bug 21946: Fix display of parent types Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #25 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 88932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88932&action=edit Bug 21946: Display parent-child relationship on smart-rules.pl To test: 1 - Set some itemtypes to have a parent 2 - Browse to Administration -> Circulation and fines rules 3 - Note new description of parent/child relationships at top of page 4 - Note that itemtype dropdown for circ rules shows child types under parents 5 - Set a rule for a child type 6 - Note it displays as Parent->Child 7 - Have three child types under a parent 8 - Set the parent 'Current checkouts allowed' to 3 9 - Set the children 'Current checkouts allowed' to: type1 = 2 type2 = 1 type3 = 1 10 - Create some items of the type above 11 - Note you can checkout 2 of type 1, and not 3 12 - Note you can checkout 1 of type 2, but not 2 13 - Note that you now cannot checkout any of type3 14 - Note you cannot checkout any of the parent type 15 - Return one of the other items and note you can now checkout an item of type3 16 - Return another item and note you can checkout an item of the parent type 17 - Return all 18 - Set the parent type to 1 19 - Now note you can only checkout 1 of any of the children 20 - Set the parent to 0 21 - Note you cannot checkout any of the child types Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #27 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 88934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88934&action=edit Bug 21946: (QA follow-up) - remove console.log To make QA tools happy Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88926|0 |1 is obsolete| | --- Comment #30 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 89167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89167&action=edit Bug 21946: Database updates Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88928|0 |1 is obsolete| | --- Comment #32 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 89169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89169&action=edit Bug 21946: Update C4::Circulation->TooMany to check parent itemtypes To test: 1 - prove -v t/db_dependent/Circulation/TooMany.t Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88930|0 |1 is obsolete| | --- Comment #34 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 89171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89171&action=edit Bug 21946: Fix display of parent types Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88932|0 |1 is obsolete| | --- Comment #36 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 89173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89173&action=edit Bug 21946: Display parent-child relationship on smart-rules.pl To test: 1 - Set some itemtypes to have a parent 2 - Browse to Administration -> Circulation and fines rules 3 - Note new description of parent/child relationships at top of page 4 - Note that itemtype dropdown for circ rules shows child types under parents 5 - Set a rule for a child type 6 - Note it displays as Parent->Child 7 - Have three child types under a parent 8 - Set the parent 'Current checkouts allowed' to 3 9 - Set the children 'Current checkouts allowed' to: type1 = 2 type2 = 1 type3 = 1 10 - Create some items of the type above 11 - Note you can checkout 2 of type 1, and not 3 12 - Note you can checkout 1 of type 2, but not 2 13 - Note that you now cannot checkout any of type3 14 - Note you cannot checkout any of the parent type 15 - Return one of the other items and note you can now checkout an item of type3 16 - Return another item and note you can checkout an item of the parent type 17 - Return all 18 - Set the parent type to 1 19 - Now note you can only checkout 1 of any of the children 20 - Set the parent to 0 21 - Note you cannot checkout any of the child types Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88934|0 |1 is obsolete| | --- Comment #38 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 89175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89175&action=edit Bug 21946: (QA follow-up) - remove console.log To make QA tools happy Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #40 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #29)

7. I am really not sure the comparisons with '*' in smart-rules.tt are correct.

Apologies, I don't see an issue with this, can you explain a bit more? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #42 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #41)

Forget that, I had the new version in mind (NULL in DB instead of '*'). At some point we really will need it (bug 15522) in I think, we will need to stop building stuffs that will conflict with it. Why not implement on top of it instead?

I think that will need work at this point. I believe the idea was to take care of the architecture, make sure it comes out as we planned without any great changes in structure during QA etc. Then work on the interface. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #44 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I realized now that while this contains quite some changes to issuingrules, it doesn't add a new column. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89167|0 |1 is obsolete| | Attachment #89168|0 |1 is obsolete| | Attachment #89169|0 |1 is obsolete| | Attachment #89170|0 |1 is obsolete| | Attachment #89171|0 |1 is obsolete| | Attachment #89172|0 |1 is obsolete| | Attachment #89173|0 |1 is obsolete| | Attachment #89174|0 |1 is obsolete| | Attachment #89175|0 |1 is obsolete| | Attachment #89176|0 |1 is obsolete| | --- Comment #45 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 93075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93075&action=edit Bug 21946: Database updates Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #47 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 93077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93077&action=edit Bug 21946: Update Administration->Item types to allow for defining parent types To test: 1 - Browse to Administration -> Item types 2 - Not a new colum for prent type 3 - Edit an existing type and not you can select any type (except the current) as a parent 4 - Select one 5 - Edit the type you selected as parent 6 - Note it cannot have a parent defined 7 - Edit a new type, note you can select a parent Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #49 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 93079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93079&action=edit Bug 21946: Use objects for displaying circulation rules Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #51 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 93081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93081&action=edit Bug 21946: (follow-up) Correct dropdown when editing rule Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #53 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 93083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93083&action=edit Bug 21946: (follow-up) Address QA concerns 1 - Correct hashref for searching 2 - Correct undef for all (this only simplifies later logic so didn't affect outcomes) 3 - remove duplicated query 4 - Use get_column instead of loops 5 - Fix typo 6 - Whitespace fixes removed from earlier patches -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |cbrannon@cdalibrary.org --- Comment #55 from Christopher Brannon <cbrannon@cdalibrary.org> --- Accidentally doing this myself right off the bat, I am going to fail this, simply because you can set an itemtype to be a parent of itself. I don't know if it will cause any problems or not, but this probably should not be allowed to happen. Just in case. Unless you can guarentee it will not cause a problem it is done by mistake. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #57 from Christopher Brannon <cbrannon@cdalibrary.org> --- Cosmetics: * Step 4, there is a blank line between the parent and the children. Can we get rid of this? * I would suggest a '-' before the children. This seems to be universal in showing the children in a list. * When the child is picked, only the child shows in the dropdown, but when saved, it shows the parent->child. Maybe it is a limitation of the dropdown object, but it would be nice to seee it all while editing. Maybe if the '-' is added, it would help. I think there is an issue with understanding how this works. Right now it looks like the parent, with its own set of rules would overrule ALL the children rules. But that is not the case. In this case, only the number of checkouts overrides the children. I think it needs to be clearer, somehow, how items behave under the parent. Having an itemtype act as both an itemtype and parent may be confusing, especially since not all of the rules of the parent apply to the child. Otherwise, it works as described. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93076|0 |1 is obsolete| | --- Comment #59 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 93087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93087&action=edit Bug 21946: Update C4::Circulation->TooMany to check parent itemtypes To test: 1 - prove -v t/db_dependent/Circulation/TooMany.t Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93078|0 |1 is obsolete| | --- Comment #61 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 93089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93089&action=edit Bug 21946: Fix display of parent types Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93080|0 |1 is obsolete| | --- Comment #63 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 93091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93091&action=edit Bug 21946: Display parent-child relationship on smart-rules.pl To test: 1 - Set some itemtypes to have a parent 2 - Browse to Administration -> Circulation and fines rules 3 - Note new description of parent/child relationships at top of page 4 - Note that itemtype dropdown for circ rules shows child types under parents 5 - Set a rule for a child type 6 - Note it displays as Parent->Child 7 - Have three child types under a parent 8 - Set the parent 'Current checkouts allowed' to 3 9 - Set the children 'Current checkouts allowed' to: type1 = 2 type2 = 1 type3 = 1 10 - Create some items of the type above 11 - Note you can checkout 2 of type 1, and not 3 12 - Note you can checkout 1 of type 2, but not 2 13 - Note that you now cannot checkout any of type3 14 - Note you cannot checkout any of the parent type 15 - Return one of the other items and note you can now checkout an item of type3 16 - Return another item and note you can checkout an item of the parent type 17 - Return all 18 - Set the parent type to 1 19 - Now note you can only checkout 1 of any of the children 20 - Set the parent to 0 21 - Note you cannot checkout any of the child types Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93082|0 |1 is obsolete| | --- Comment #65 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 93093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93093&action=edit Bug 21946: (QA follow-up) - remove console.log To make QA tools happy Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93084|0 |1 is obsolete| | --- Comment #67 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 93095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93095&action=edit Bug 21946: DO NOT PUSH - Schema updates Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93087|0 |1 is obsolete| | --- Comment #69 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 93097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93097&action=edit Bug 21946: Update C4::Circulation->TooMany to check parent itemtypes To test: 1 - prove -v t/db_dependent/Circulation/TooMany.t Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93089|0 |1 is obsolete| | --- Comment #71 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 93099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93099&action=edit Bug 21946: Fix display of parent types Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93091|0 |1 is obsolete| | --- Comment #73 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 93101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93101&action=edit Bug 21946: Display parent-child relationship on smart-rules.pl To test: 1 - Set some itemtypes to have a parent 2 - Browse to Administration -> Circulation and fines rules 3 - Note new description of parent/child relationships at top of page 4 - Note that itemtype dropdown for circ rules shows child types under parents 5 - Set a rule for a child type 6 - Note it displays as Parent->Child 7 - Have three child types under a parent 8 - Set the parent 'Current checkouts allowed' to 3 9 - Set the children 'Current checkouts allowed' to: type1 = 2 type2 = 1 type3 = 1 10 - Create some items of the type above 11 - Note you can checkout 2 of type 1, and not 3 12 - Note you can checkout 1 of type 2, but not 2 13 - Note that you now cannot checkout any of type3 14 - Note you cannot checkout any of the parent type 15 - Return one of the other items and note you can now checkout an item of type3 16 - Return another item and note you can checkout an item of the parent type 17 - Return all 18 - Set the parent type to 1 19 - Now note you can only checkout 1 of any of the children 20 - Set the parent to 0 21 - Note you cannot checkout any of the child types Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93093|0 |1 is obsolete| | --- Comment #75 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 93103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93103&action=edit Bug 21946: (QA follow-up) - remove console.log To make QA tools happy Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93095|0 |1 is obsolete| | --- Comment #77 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 93105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93105&action=edit Bug 21946: DO NOT PUSH - Schema updates Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93097|0 |1 is obsolete| | --- Comment #80 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 96978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96978&action=edit Bug 21946: Update C4::Circulation->TooMany to check parent itemtypes To test: 1 - prove -v t/db_dependent/Circulation/TooMany.t Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93099|0 |1 is obsolete| | --- Comment #82 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 96980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96980&action=edit Bug 21946: Fix display of parent types Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93101|0 |1 is obsolete| | --- Comment #84 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 96982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96982&action=edit Bug 21946: Display parent-child relationship on smart-rules.pl To test: 1 - Set some itemtypes to have a parent 2 - Browse to Administration -> Circulation and fines rules 3 - Note new description of parent/child relationships at top of page 4 - Note that itemtype dropdown for circ rules shows child types under parents 5 - Set a rule for a child type 6 - Note it displays as Parent->Child 7 - Have three child types under a parent 8 - Set the parent 'Current checkouts allowed' to 3 9 - Set the children 'Current checkouts allowed' to: type1 = 2 type2 = 1 type3 = 1 10 - Create some items of the type above 11 - Note you can checkout 2 of type 1, and not 3 12 - Note you can checkout 1 of type 2, but not 2 13 - Note that you now cannot checkout any of type3 14 - Note you cannot checkout any of the parent type 15 - Return one of the other items and note you can now checkout an item of type3 16 - Return another item and note you can checkout an item of the parent type 17 - Return all 18 - Set the parent type to 1 19 - Now note you can only checkout 1 of any of the children 20 - Set the parent to 0 21 - Note you cannot checkout any of the child types Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93103|0 |1 is obsolete| | --- Comment #86 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 96984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96984&action=edit Bug 21946: (QA follow-up) - remove console.log To make QA tools happy Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93105|0 |1 is obsolete| | --- Comment #88 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 96986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96986&action=edit Bug 21946: DO NOT PUSH - Schema updates Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #90 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Looks like this dev will conflict with bug 15522. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #91 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #90)

Looks like this dev will conflict with bug 15522.

Agreed, but I don't think that should be a blocker here. 15522 needs some work, we are gathering notes to post on that bug. This is a much desired feature and should be allowed to proceed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #93 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Christopher Brannon from comment #92)

It seems this only has the ability to have a single parent set. What about when you have a set limit for a smaller group, like video media, but you also have a bigger group that this group is a part of that has a limit? Can a group have a parent?

No, this development only allows for a single level groups, they cannot be nested -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #96 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 99420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99420&action=edit Bug 21946: Update C4::Circulation->TooMany to check parent itemtypes To test: 1 - prove -v t/db_dependent/Circulation/TooMany.t Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #98 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 99422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99422&action=edit Bug 21946: Display parent-child relationship on smart-rules.pl To test: 1 - Set some itemtypes to have a parent 2 - Browse to Administration -> Circulation and fines rules 3 - Note new description of parent/child relationships at top of page 4 - Note that itemtype dropdown for circ rules shows child types under parents 5 - Set a rule for a child type 6 - Note it displays as Parent->Child 7 - Have three child types under a parent 8 - Set the parent 'Current checkouts allowed' to 3 9 - Set the children 'Current checkouts allowed' to: type1 = 2 type2 = 1 type3 = 1 10 - Create some items of the type above 11 - Note you can checkout 2 of type 1, and not 3 12 - Note you can checkout 1 of type 2, but not 2 13 - Note that you now cannot checkout any of type3 14 - Note you cannot checkout any of the parent type 15 - Return one of the other items and note you can now checkout an item of type3 16 - Return another item and note you can checkout an item of the parent type 17 - Return all 18 - Set the parent type to 1 19 - Now note you can only checkout 1 of any of the children 20 - Set the parent to 0 21 - Note you cannot checkout any of the child types Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #100 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 99424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99424&action=edit Bug 21946: DO NOT PUSH - Schema updates -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud@biblibre.com QA Contact|testopia@bugs.koha-communit |alex.arnaud@biblibre.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99420|0 |1 is obsolete| | --- Comment #106 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 107036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107036&action=edit Bug 21946: Update C4::Circulation->TooMany to check parent itemtypes To test: 1 - prove -v t/db_dependent/Circulation/TooMany.t Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99422|0 |1 is obsolete| | --- Comment #108 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 107038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107038&action=edit Bug 21946: Display parent-child relationship on smart-rules.pl To test: 1 - Set some itemtypes to have a parent 2 - Browse to Administration -> Circulation and fines rules 3 - Note new description of parent/child relationships at top of page 4 - Note that itemtype dropdown for circ rules shows child types under parents 5 - Set a rule for a child type 6 - Note it displays as Parent->Child 7 - Have three child types under a parent 8 - Set the parent 'Current checkouts allowed' to 3 9 - Set the children 'Current checkouts allowed' to: type1 = 2 type2 = 1 type3 = 1 10 - Create some items of the type above 11 - Note you can checkout 2 of type 1, and not 3 12 - Note you can checkout 1 of type 2, but not 2 13 - Note that you now cannot checkout any of type3 14 - Note you cannot checkout any of the parent type 15 - Return one of the other items and note you can now checkout an item of type3 16 - Return another item and note you can checkout an item of the parent type 17 - Return all 18 - Set the parent type to 1 19 - Now note you can only checkout 1 of any of the children 20 - Set the parent to 0 21 - Note you cannot checkout any of the child types Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #110 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 107040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107040&action=edit Bug 21946: Add test for parent method -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99424|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107036|0 |1 is obsolete| | --- Comment #113 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 107279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107279&action=edit Bug 21946: Update C4::Circulation->TooMany to check parent itemtypes To test: 1 - prove -v t/db_dependent/Circulation/TooMany.t Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107038|0 |1 is obsolete| | --- Comment #115 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 107281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107281&action=edit Bug 21946: Display parent-child relationship on smart-rules.pl To test: 1 - Set some itemtypes to have a parent 2 - Browse to Administration -> Circulation and fines rules 3 - Note new description of parent/child relationships at top of page 4 - Note that itemtype dropdown for circ rules shows child types under parents 5 - Set a rule for a child type 6 - Note it displays as Parent->Child 7 - Have three child types under a parent 8 - Set the parent 'Current checkouts allowed' to 3 9 - Set the children 'Current checkouts allowed' to: type1 = 2 type2 = 1 type3 = 1 10 - Create some items of the type above 11 - Note you can checkout 2 of type 1, and not 3 12 - Note you can checkout 1 of type 2, but not 2 13 - Note that you now cannot checkout any of type3 14 - Note you cannot checkout any of the parent type 15 - Return one of the other items and note you can now checkout an item of type3 16 - Return another item and note you can checkout an item of the parent type 17 - Return all 18 - Set the parent type to 1 19 - Now note you can only checkout 1 of any of the children 20 - Set the parent to 0 21 - Note you cannot checkout any of the child types Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107040|0 |1 is obsolete| | --- Comment #117 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 107283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107283&action=edit Bug 21946: Add test for parent method Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA Keywords| |release-notes-needed Severity|enhancement |new feature --- Comment #120 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 1. There is an ergonomic issue in the circ rules page: https://snipboard.io/ARHowm.jpg There is a space for the label of the optgroup. I don't think we should use an optgroup, maybe more a margin? 2. We should have a "hint" on the item type form to explain what it this "parent" thing 3. This is only affecting checkouts, why? Is there a plan to extend it to holds for instance? 4. Reading the code it seems that it does not affect on site checkouts. I think it should be done in this patchset -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #123 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #120)

1. There is an ergonomic issue in the circ rules page: Owen fixed this - Thanks Owen!

2. We should have a "hint" on the item type form to explain what it this "parent" thing

Added a hint - there is a description on circ rules page, so I think referring to that should be enough

3. This is only affecting checkouts, why? Is there a plan to extend it to holds for instance?

No current development but it does open that possibility

4. Reading the code it seems that it does not affect on site checkouts. I think it should be done in this patchset

I think this will require some refactoring and I have some questions about how the rules for on-site are applied - I would like to take this one on as a separate bug -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107278|0 |1 is obsolete| | --- Comment #125 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 107686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107686&action=edit Bug 21946: Database updates Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107280|0 |1 is obsolete| | --- Comment #127 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 107688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107688&action=edit Bug 21946: Update Administration->Item types to allow for defining parent types To test: 1 - Browse to Administration -> Item types 2 - Not a new colum for prent type 3 - Edit an existing type and not you can select any type (except the current) as a parent 4 - Select one 5 - Edit the type you selected as parent 6 - Note it cannot have a parent defined 7 - Edit a new type, note you can select a parent Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107282|0 |1 is obsolete| | --- Comment #129 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 107690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107690&action=edit Bug 21946: Update unit tests to pass under ES Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107467|0 |1 is obsolete| | --- Comment #131 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 107692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107692&action=edit Bug 21946: (follow-up) Add optgroup label in circ rules This patch adds a label to the optgroup showing child itemtypes in the circulation and fine rules interface. The parent itemtype description is the optgroup label, and then the parent itemtype is repeated as an <option> with the additional label "All" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #133 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 107694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107694&action=edit Bug 21946: DBIC schema changes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #134 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 107701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107701&action=edit Bug 21946: (follow-up) Restore join to biblioitems -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #135 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 107733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107733&action=edit Bug 21946: Restore defined vs "" The tests still pass. Was the original change really useful? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #137 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I've written some follow-up patches that I attached to bug 26132. Could you have a look? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Circulation |and plumbing | CC| |gmcharlt@gmail.com, | |kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26782 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26782 [Bug 26782] Circulation conditions: first 2 columns show as sortable, but cannot be sorted -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This feature adds the release notes| |ability to define some | |itemtypes as 'parent' to | |other item types for | |defining circulation | |limits. | | | |This allows to | |create 'groups' of related | |items types. E.g. - a | |library has both Blu-ray | |and DVD itemtypes - these | |can be grouped under the | |'Media' itemtype. The | |checkout limit for Media | |will then apply to both | |Blu-ray and DVD. | | | |So if a | |library says a patron can | |have 4 dvds - 4 blu-ray - | |and sets Media to have a | |limit of 4 then patrons can | |have up to 4 items of | |either type (e.g. 1 DVD, 3 | |blu-rays) but will be | |prevented form checking out | |more of either type by the | |limit on the parent. | | | |Parent rules only apply to | |checkout limits -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com Change sponsored?|--- |Sponsored Text to go in the|This feature adds the |This feature was sponsored release notes|ability to define some |by VOKAL and adds the |itemtypes as 'parent' to |ability to define some |other item types for |itemtypes as 'parent' to |defining circulation |other item types for |limits. |defining circulation | |limits. |This allows to | |create 'groups' of related |This allows to |items types. E.g. - a |create 'groups' of related |library has both Blu-ray |items types. E.g. - a |and DVD itemtypes - these |library has both Blu-ray |can be grouped under the |and DVD itemtypes - these |'Media' itemtype. The |can be grouped under the |checkout limit for Media |'Media' itemtype. The |will then apply to both |checkout limit for Media |Blu-ray and DVD. |will then apply to both | |Blu-ray and DVD. |So if a | |library says a patron can |So if a |have 4 dvds - 4 blu-ray - |library says a patron can |and sets Media to have a |have 4 dvds - 4 blu-ray - |limit of 4 then patrons can |and sets Media to have a |have up to 4 items of |limit of 4 then patrons can |either type (e.g. 1 DVD, 3 |have up to 4 items of |blu-rays) but will be |either type (e.g. 1 DVD, 3 |prevented from checking out |blu-rays) but will be |more of either type by the |prevented from checking out |limit on the parent. |more of either type by the | |limit on the parent. |Parent rules only apply to | |checkout limits. |Parent rules only apply to | |checkout limits. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30324 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30324 [Bug 30324] Parent and child itemtype checkout limits not enforced as expected -- You are receiving this mail because: You are watching all bug changes.