[Bug 42605] New: Acquisition Items not listed during receipt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 Bug ID: 42605 Summary: Acquisition Items not listed during receipt Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: 1 - Ensure AcqCreateItem is set to 'placing an order' at syspref or on basket 2 - Open a basket, add an order, and add several items 3 - Close the basket and receive shipments 4 - Select the order and 'Receive selected' or click 'Receive' on the order 5 - No items are listed in the items section -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 Andrii Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=43211 Assignee|koha-bugs@lists.koha-commun |nugged@gmail.com |ity.org | Depends on| |41563 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41563 [Bug 41563] Tidy kohaTable block - acqui -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 --- Comment #1 from Andrii Nugged <nugged@gmail.com> --- Created attachment 203731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203731&action=edit Bug 42605: Preserve acquisition preference string values Bug 41563 converted AcqCreateItem and UniqueItemFields to booleans when adding them to Koha.prefs. Both preferences are strings: AcqCreateItem controls where items are created, while UniqueItemFields contains a pipe-separated list. When a basket inherits AcqCreateItem=ordering, the boolean value matches none of the receiving page branches and existing items are hidden. When items are created on receiving, the numeric UniqueItemFields value also fails when the page calls split(). Preserve both string values in Koha.prefs. Add a Cypress regression test which renders orderreceive.pl and verifies the values exposed to JavaScript. Test plan: 1. Set AcqCreateItem to "placing an order". 2. Create a basket which uses the system preference, add an order with an item, close the basket, and receive a shipment. 3. Confirm the existing item and its Receive checkbox are displayed. 4. Set the basket to create items when receiving and confirm the item creation form opens without a UniqueItemFields.split error. 5. Run: yarn cypress run --spec \ t/cypress/integration/Acquisitions/OrderReceivePreferences_spec.ts Co-Authored-By: Loontik <loontik@nugged.team> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 Andrii Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 Andrii Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203731|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 --- Comment #2 from Andrii Nugged <nugged@gmail.com> --- Created attachment 203732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203732&action=edit Bug 42605: Preserve acquisition preference string values Bug 41563 converted AcqCreateItem and UniqueItemFields to booleans when adding them to Koha.prefs. Both preferences are strings: AcqCreateItem controls where items are created, while UniqueItemFields contains a pipe-separated list. When a basket inherits AcqCreateItem=ordering, the boolean value matches none of the receiving page branches and existing items are hidden. When items are created on receiving, the numeric UniqueItemFields value also fails when the page calls split(). Preserve both string values in Koha.prefs. Add a Cypress regression test which renders orderreceive.pl and verifies the values exposed to JavaScript. Test plan: Before applying the patch: 1. Set AcqCreateItem to "placing an order" and UniqueItemFields to "barcode". 2. Create a basket that inherits the system preference. Add an order with one item, close the basket, and start receiving it. 3. Confirm that the Items table has no existing item row and no Receive checkbox. 4. Set AcqCreateItem to "receiving an order" and open the same order for receiving. 5. Confirm that the Items section is empty: no item-entry fields and no Add item button are shown. Apply the patch. After applying the patch: 1. Set AcqCreateItem back to "placing an order" and open the order for receiving again. 2. Confirm that its existing item is listed and has a Receive checkbox. 3. Set AcqCreateItem to "receiving an order" and open the same order again. 4. Confirm that the Items section contains item-entry fields and an Add item button. Co-Authored-By: Loontik <loontik@nugged.team> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203732|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 203760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203760&action=edit Bug 42605: Preserve acquisition preference string values Bug 41563 converted AcqCreateItem and UniqueItemFields to booleans when adding them to Koha.prefs. Both preferences are strings: AcqCreateItem controls where items are created, while UniqueItemFields contains a pipe-separated list. When a basket inherits AcqCreateItem=ordering, the boolean value matches none of the receiving page branches and existing items are hidden. When items are created on receiving, the numeric UniqueItemFields value also fails when the page calls split(). Preserve both string values in Koha.prefs. Add a Cypress regression test which renders orderreceive.pl and verifies the values exposed to JavaScript. Test plan: Before applying the patch: 1. Set AcqCreateItem to "placing an order" and UniqueItemFields to "barcode". 2. Create a basket that inherits the system preference. Add an order with one item, close the basket, and start receiving it. 3. Confirm that the Items table has no existing item row and no Receive checkbox. 4. Set AcqCreateItem to "receiving an order" and open the same order for receiving. 5. Confirm that the Items section is empty: no item-entry fields and no Add item button are shown. Apply the patch. After applying the patch: 1. Set AcqCreateItem back to "placing an order" and open the order for receiving again. 2. Confirm that its existing item is listed and has a Receive checkbox. 3. Set AcqCreateItem to "receiving an order" and open the same order again. 4. Confirm that the Items section contains item-entry fields and an Add item button. Co-Authored-By: Loontik <loontik@nugged.team> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m QA Contact|testopia@bugs.koha-communit |blawlor@clamsnet.org |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 --- Comment #4 from Andrii Nugged <nugged@gmail.com> --- Created attachment 203821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203821&action=edit Bug 42605: Test order receiving preference behavior The existing regression test checks the values exposed through Koha.prefs, but does not exercise the receiving UI. It also stores row arrays returned by cy.task("query") and passes them back to cy.set_syspref(), which restores both preferences as "[object Object]" instead of their original values. Store the scalar preference values and clean up the invoice explicitly. Exercise the rendered receiving behavior for a basket that inherits AcqCreateItem, one that explicitly overrides it with "ordering", and a basket that creates items on receiving. The explicit "ordering" case is a control: it does not use the broken system-preference fallback and already works without the production fix. The empty items table occurs when the basket uses the system preference, while the receiving case covers the UniqueItemFields split path. This changes tests only. Test plan: Before applying the patches: 1. Set AcqCreateItem to "placing an order" and UniqueItemFields to "barcode". 2. Create one basket that uses the system preference and another basket explicitly set to create items when placing an order. Add an order with an item to each basket, close both baskets, and receive the orders. 3. Confirm that the inherited basket has no existing item row or Receive checkbox, while the explicitly configured basket displays both. 4. Create a basket set to create items when receiving. Add an order, close the basket, and receive the order. 5. Confirm that no item-entry fields or Add item button are displayed. Apply both patches on this bug. After applying the patches: 1. Receive the order from the inherited basket again. 2. Confirm that its existing item and Receive checkbox are displayed. 3. Confirm that the explicitly configured basket still displays its item and Receive checkbox. 4. Receive the order from the basket that creates items when receiving. 5. Confirm that the item-entry fields and Add item button are displayed. Co-Authored-By: Loontik <loontik@nugged.team> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 Andrii Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203760|0 |1 is obsolete| | Attachment #203821|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 203824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203824&action=edit Bug 42605: Preserve acquisition preference string values Bug 41563 converted AcqCreateItem and UniqueItemFields to booleans when adding them to Koha.prefs. Both preferences are strings: AcqCreateItem controls where items are created, while UniqueItemFields contains a pipe-separated list. When a basket inherits AcqCreateItem=ordering, the boolean value matches none of the receiving page branches and existing items are hidden. When items are created on receiving, the numeric UniqueItemFields value also fails when the page calls split(). Preserve both string values in Koha.prefs. Add a Cypress regression test which renders orderreceive.pl and verifies the values exposed to JavaScript. Test plan: Before applying the patch: 1. Set AcqCreateItem to "placing an order" and UniqueItemFields to "barcode". 2. Create a basket that inherits the system preference. Add an order with one item, close the basket, and start receiving it. 3. Confirm that the Items table has no existing item row and no Receive checkbox. 4. Set AcqCreateItem to "receiving an order" and open the same order for receiving. 5. Confirm that the Items section is empty: no item-entry fields and no Add item button are shown. Apply the patch. After applying the patch: 1. Set AcqCreateItem back to "placing an order" and open the order for receiving again. 2. Confirm that its existing item is listed and has a Receive checkbox. 3. Set AcqCreateItem to "receiving an order" and open the same order again. 4. Confirm that the Items section contains item-entry fields and an Add item button. Co-Authored-By: Loontik <loontik@nugged.team> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 203825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203825&action=edit Bug 42605: Test order receiving preference behavior The existing regression test checks the values exposed through Koha.prefs, but does not exercise the receiving UI. It also stores row arrays returned by cy.task("query") and passes them back to cy.set_syspref(), which restores both preferences as "[object Object]" instead of their original values. Store the scalar preference values and clean up the invoice explicitly. Exercise the rendered receiving behavior for a basket that inherits AcqCreateItem, one that explicitly overrides it with "ordering", and a basket that creates items on receiving. The explicit "ordering" case is a control: it does not use the broken system-preference fallback and already works without the production fix. The empty items table occurs when the basket uses the system preference, while the receiving case covers the UniqueItemFields split path. This changes tests only. Test plan: Before applying the patches: 1. Set AcqCreateItem to "placing an order" and UniqueItemFields to "barcode". 2. Create one basket that uses the system preference and another basket explicitly set to create items when placing an order. Add an order with an item to each basket, close both baskets, and receive the orders. 3. Confirm that the inherited basket has no existing item row or Receive checkbox, while the explicitly configured basket displays both. 4. Create a basket set to create items when receiving. Add an order, close the basket, and receive the order. 5. Confirm that no item-entry fields or Add item button are displayed. Apply both patches on this bug. After applying the patches: 1. Receive the order from the inherited basket again. 2. Confirm that its existing item and Receive checkbox are displayed. 3. Confirm that the explicitly configured basket still displays its item and Receive checkbox. 4. Receive the order from the basket that creates items when receiving. 5. Confirm that the item-entry fields and Add item button are displayed. Co-Authored-By: Loontik <loontik@nugged.team> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #7 from David Nind <david@davidnind.com> --- I've signed off, but I think the commit message for the second patch should reflect the patch, not just repeat the first patch. Suggested commit message: Bug 42605: Update tests Updates Cypress tests. Test plan: 1. Tests should pass: cypress run --spec t/cypress/integration/Acquisitions/OrderReceivePreferences_spec.ts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 --- Comment #8 from Andrii Nugged <nugged@gmail.com> --- Created attachment 203838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203838&action=edit Bug 42605: Add automated tests Store scalar preference values when saving the acquisition preferences and clean up the invoice explicitly. Exercise the rendered receiving behavior for a basket that inherits AcqCreateItem, one that explicitly overrides it with "ordering", and a basket that creates items on receiving. Keep the explicit "ordering" case as a control for behavior that already works without the production fix. This changes tests only. Automated tests: yarn cypress run --spec \ t/cypress/integration/Acquisitions/OrderReceivePreferences_spec.ts Co-Authored-By: Loontik <loontik@nugged.team> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 Andrii Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203825|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 --- Comment #9 from David Nind <david@davidnind.com> --- Thanks Andrii! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203824|0 |1 is obsolete| | Attachment #203838|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 204086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204086&action=edit Bug 42605: Preserve acquisition preference string values Bug 41563 converted AcqCreateItem and UniqueItemFields to booleans when adding them to Koha.prefs. Both preferences are strings: AcqCreateItem controls where items are created, while UniqueItemFields contains a pipe-separated list. When a basket inherits AcqCreateItem=ordering, the boolean value matches none of the receiving page branches and existing items are hidden. When items are created on receiving, the numeric UniqueItemFields value also fails when the page calls split(). Preserve both string values in Koha.prefs. Add a Cypress regression test which renders orderreceive.pl and verifies the values exposed to JavaScript. Test plan: Before applying the patch: 1. Set AcqCreateItem to "placing an order" and UniqueItemFields to "barcode". 2. Create a basket that inherits the system preference. Add an order with one item, close the basket, and start receiving it. 3. Confirm that the Items table has no existing item row and no Receive checkbox. 4. Set AcqCreateItem to "receiving an order" and open the same order for receiving. 5. Confirm that the Items section is empty: no item-entry fields and no Add item button are shown. Apply the patch. After applying the patch: 1. Set AcqCreateItem back to "placing an order" and open the order for receiving again. 2. Confirm that its existing item is listed and has a Receive checkbox. 3. Set AcqCreateItem to "receiving an order" and open the same order again. 4. Confirm that the Items section contains item-entry fields and an Add item button. Co-Authored-By: Loontik <loontik@nugged.team> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 204087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204087&action=edit Bug 42605: Add automated tests Store scalar preference values when saving the acquisition preferences and clean up the invoice explicitly. Exercise the rendered receiving behavior for a basket that inherits AcqCreateItem, one that explicitly overrides it with "ordering", and a basket that creates items on receiving. Keep the explicit "ordering" case as a control for behavior that already works without the production fix. This changes tests only. Automated tests: yarn cypress run --spec \ t/cypress/integration/Acquisitions/OrderReceivePreferences_spec.ts Co-Authored-By: Loontik <loontik@nugged.team> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|blawlor@clamsnet.org |jonathan.druart@gmail.com CC| |jonathan.druart@gmail.com --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Fixed conflict with bug 43211. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 --- Comment #13 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #14 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Could this please be backported to 26.05 :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Keywords| |rel_26_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 Mark Hofstetter <mark@hofstetter.at> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mark@hofstetter.at --- Comment #15 from Mark Hofstetter <mark@hofstetter.at> --- please backport, thx! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00 |26.11.00,26.05.04 released in| | CC| |lucas@bywatersolutions.com Keywords|rel_26_05_candidate | Status|Pushed to main |Pushed to stable --- Comment #16 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 26.05.x for upcoming 26.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 Priti Pore <porepriti321@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |porepriti321@gmail.com Status|Pushed to stable |RESOLVED --- Comment #17 from Priti Pore <porepriti321@gmail.com> --- Fix AcqCreateItem and UniqueItemFields boolean casting in orderreceive.tt Open the file Template Toolkit file orderreceive.tt - sudo nano +460 /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt Check for these two specific variables: AcqCreateItem: AcqCreateItem: [% Koha.Preference('AcqCreateItem') ? 1 : 0 | html %], In Koha, the system preference AcqCreateItem is not a toggle (Yes/No). It is a choice with three distinct string values: 'ordering' → Create items when placing an order 'receiving' → Create items when receiving an order 'cataloguing' → Do not create items in acquisitions; create them later in cataloguing Later in orderreceive.tt, the script determines whether to show the item subform and barcode fields Because Koha.prefs.AcqCreateItem was converted to 1: The equality check 1 == 'receiving' evaluates to false. The equality check 1 == 'ordering' also evaluates to false. The frontend JavaScript fails to match any valid workflow state. As a result, it skips rendering the item input fields, suppresses the barcode inputs, and leaves the modal stuck or the items table completely blank. The template must pass the raw string value enclosed in quotes:: AcqCreateItem: "[% Koha.Preference('AcqCreateItem') | html %]", UniqueItemFields: UniqueItemFields: [% Koha.Preference('UniqueItemFields') ? 1 : 0 | html %], it sends 0 or 1. Downstream, Koha executes UniqueItemFields.split(','), which throws TypeError: UniqueItemFields.split is not a function and freezes the modal. Change it to: UniqueItemFields: "[% Koha.Preference('UniqueItemFields') | html %]", Clear Cache and Restart # Clear template compile cache sudo rm -rf /var/cache/koha/vu-main/templates/* # Restart Plack for vu-main (or Apache if not running Plack) sudo koha-plack --restart vu-main sudo systemctl restart apache2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 --- Comment #18 from David Nind <david@davidnind.com> --- I'm not sure what comment #17 is about. There is no context about what the text in the comment means, or is intended to achieve (it doesn't make any sense to me anyway!). It also changes the status to RESOLVED FIXED - does it need to be ported back any further? (I thought only release maintainers should make this change.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 Priti Pore <porepriti321@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- GIT URL| |https://github.com/Priti980 | |/bugzilla-fixes/pull/1 --- Comment #19 from Priti Pore <porepriti321@gmail.com> --- I have implemented a solution for this issue by fixing the template logic in orderreceive.tt. You can view the code changes directly on GitHub here: https://github.com You can access the raw patch file directly at: https://github.com.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 --- Comment #20 from Priti Pore <porepriti321@gmail.com> --- Correction for my previous comment links: You can view the code changes directly on GitHub here: https://github.com You can access the raw patch file directly at: https://github.com/Priti980/bugzilla-fixes/pull/1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- GIT URL|https://github.com/Priti980 | |/bugzilla-fixes/pull/1 | --- Comment #21 from David Nind <david@davidnind.com> --- Hi Priti Pore. I'm still confused about your comments. Is this an alternative fix that you've made to your own installation, or are proposing this as a fix instead? Or do the existing patches for the bug that are now pushed for Koha 26.11.00 and 26.05.04 not fully fix the issue, or create additional issues? If the later, then posting the issue on a new bug and linking to this one is the normal approach to take after a patch is pushed to the codebase. Feel free to ask for help on the Koha Community Chat channels https://chat.koha-community.org/ (particularly the Development channel). Or come along to the Koha-US Baby-Devs special interest group meeting https://koha-us.org/special-interest-groups/ (scroll down to Baby Devs) Also to note, the Koha Community doesn't use the GitHub/pull request mechanism for Koha patches - see the Development Handbook https://wiki.koha-community.org/wiki/Developer_handbook and koha-testing-docker which we use as the development environment https://gitlab.com/koha-community/koha-testing-docker These are also good resources if you are new to Koha development: - The Koha development workflow https://wiki.koha-community.org/wiki/Development_workflow - The "How to hack Koha" tutorial which can be accessed from the development environment once set up at [your-staff-interface-url/cgi-bin/koha/how-to.pl] David Nind Big note: Status needs changing backed to "Pushed to stable", so it can be reviewed by release maintainers, or changed to needs documenting if it doesn't need to be back ported to supported releases. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 --- Comment #22 from Priti Pore <porepriti321@gmail.com> --- Hi David, Thank you very much for the clarification and guidance! I am quite new to Koha development and testing workflows, so my earlier comment was simply a local workaround we used on our own installation to address the issue in our immediate environment—not an official replacement patch. I apologize for any confusion caused! Thank you for sharing the developer workflow guides, koha-testing-docker, and the Baby-Devs links. As a beginner, these resources are incredibly helpful, and I look forward to learning the proper community workflow going forward. Best regards, Priti -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |BLOCKED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 --- Comment #23 from David Nind <david@davidnind.com> --- (In reply to Priti Pore from comment #22)
Hi David,
Thank you very much for the clarification and guidance!
I am quite new to Koha development and testing workflows, so my earlier comment was simply a local workaround we used on our own installation to address the issue in our immediate environment—not an official replacement patch.
I apologize for any confusion caused!
Thank you for sharing the developer workflow guides, koha-testing-docker, and the Baby-Devs links. As a beginner, these resources are incredibly helpful, and I look forward to learning the proper community workflow going forward.
Best regards,
Priti
Welcome Priti! It can be a daunting task learning about the Koha development process! Please feel free to join the Mattermost Chat and ask questions - most of the community chat takes place here. Particularly with getting the development environment and workflow. I mostly test bugs, and am not a developer. Feel free to contact me if you need any help with that. David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 --- Comment #24 from David Nind <david@davidnind.com> --- Status changed back to "Pushed to stable" -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org