[Bug 9674] New: Replace YUI buttons and menu on acquisitions pages with Bootstrap
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9674 Bug ID: 9674 Summary: Replace YUI buttons and menu on acquisitions pages with Bootstrap Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org The toolbar include file (acquisitions-toolbar.inc) used on several acquisitions pages (supplier.pl, booksellers.pl, etc.) uses YUI for buttons and button menus. It should use Bootstrap instead. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9674 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9674 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15639&action=edit Bug 9674 - Replace YUI buttons and menu on acquisitions pages with Bootstrap This patch converts the toolbar on acquisitions pages to Bootstrap, replacing YUI button code with Bootstrap markup. To test, view acquisitions pages and confirm that buttons look correct and work correctly: - acqui-home.pl (Acquisitions home page) - booksellers.pl (Acquisitions -> Vendor search) - supplier.pl (Acquisitions -> Vendor search -> Vendor) - aqcontract.pl (Acquisitions -> Vendor search -> Vendor -> Contracts) - uncertainprice.pl (Aquisitions -> Vendor search -> Vendor -> Uncertain prices) View these pages for vendors with and without orders. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9674 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15639|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15640 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15640&action=edit [SIGNED-OFF] Bug 9674 - Replace YUI buttons and menu on acquisitions pages with Bootstrap This patch converts the toolbar on acquisitions pages to Bootstrap, replacing YUI button code with Bootstrap markup. To test, view acquisitions pages and confirm that buttons look correct and work correctly: - acqui-home.pl (Acquisitions home page) - booksellers.pl (Acquisitions -> Vendor search) - supplier.pl (Acquisitions -> Vendor search -> Vendor) - aqcontract.pl (Acquisitions -> Vendor search -> Vendor -> Contracts) - uncertainprice.pl (Aquisitions -> Vendor search -> Vendor -> Uncertain prices) View these pages for vendors with and without orders. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Buttons works. No errors. Tested vendors with and without orders (delete button in last case) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9674 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9674 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9674 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15640|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 15827 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15827&action=edit [PASSED QA] Bug 9674 - Replace YUI buttons and menu on acquisitions pages with Bootstrap This patch converts the toolbar on acquisitions pages to Bootstrap, replacing YUI button code with Bootstrap markup. To test, view acquisitions pages and confirm that buttons look correct and work correctly: - acqui-home.pl (Acquisitions home page) - booksellers.pl (Acquisitions -> Vendor search) - supplier.pl (Acquisitions -> Vendor search -> Vendor) - aqcontract.pl (Acquisitions -> Vendor search -> Vendor -> Contracts) - uncertainprice.pl (Aquisitions -> Vendor search -> Vendor -> Uncertain prices) View these pages for vendors with and without orders. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Buttons works. No errors. Tested vendors with and without orders (delete button in last case) Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, changes are consistent. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9674 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9674 --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- I look forward to another follow-up that adds Bootstrap on the basket groups page. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org