[Bug 9445] New: Use DataTables in local use system preferences editor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Bug ID: 9445 Summary: Use DataTables in local use system preferences editor Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/systempreferences.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org The "old" system preferences editor, used now only for local use preferences, uses the old tablesorter plugin. It should use DataTables instead. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14755 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14755&action=edit Bug 9445 - Use DataTables in local use system preferences editor Replace the tablesorter plugin with the DataTables plugin in the local use system preferences editor. This patch moves embedding of the toolbar and table-sorting JS from within the body of the page to the <head> for sake of consistency. To test, open the system preferences editor to the Local Use tab. Confirm that table sorting works correctly. In this configuration there should be no pager and no results filtering. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14755|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14771 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14771&action=edit Bug 9445 - Use DataTables in local use system preferences editor Replace the tablesorter plugin with the DataTables plugin in the local use system preferences editor. This patch moves embedding of the toolbar and table-sorting JS from within the body of the page to the <head> for sake of consistency. To test, open the system preferences editor to the Local Use tab. Confirm that table sorting works correctly. In this configuration there should be no pager and no results filtering. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14771|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15700 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15700&action=edit Bug 9445 [Revised] Use DataTables in local use system preferences editor Replace the tablesorter plugin with the DataTables plugin in the local use system preferences editor. This patch moves embedding of the toolbar and table-sorting JS from within the body of the page to the <head> for sake of consistency. To test, open the system preferences editor to the Local Use tab. Confirm that table sorting works correctly. In this configuration there should be no pager and no results filtering. Revision corrects template path to datatables assets. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15700|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15744 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15744&action=edit [SIGNED-OFF] Bug 9445 [Revised] Use DataTables in local use system preferences editor Replace the tablesorter plugin with the DataTables plugin in the local use system preferences editor. This patch moves embedding of the toolbar and table-sorting JS from within the body of the page to the <head> for sake of consistency. To test, open the system preferences editor to the Local Use tab. Confirm that table sorting works correctly. In this configuration there should be no pager and no results filtering. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Tab sorting works. No errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: Add datatable on the systempreferences.pl page (local use only). Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15744|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15775 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15775&action=edit Bug 9445 [Revised] Use DataTables in local use system preferences editor Replace the tablesorter plugin with the DataTables plugin in the local use system preferences editor. This patch moves embedding of the toolbar and table-sorting JS from within the body of the page to the <head> for sake of consistency. To test, open the system preferences editor to the Local Use tab. Confirm that table sorting works correctly. In this configuration there should be no pager and no results filtering. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Tab sorting works. No errors. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch adds Datatables, but it does not remove tablesorter from the page. It probably should. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #7)
This patch adds Datatables, but it does not remove tablesorter from the page. It probably should.
Ho yes, good catch. I don't understand when this code is used but it should be deleted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15775|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15810&action=edit Bug 9445 [Revised] Use DataTables in local use system preferences editor Replace the tablesorter plugin with the DataTables plugin in the local use system preferences editor. This patch moves embedding of the toolbar and table-sorting JS from within the body of the page to the <head> for sake of consistency. To test, open the system preferences editor to the Local Use tab. Confirm that table sorting works correctly. In this configuration there should be no pager and no results filtering. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Tab sorting works. No errors. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Further revision removes old tablesorter code -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Returning to "Passed QA" as per jcamins' instructions. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org