[Bug 40678] New: Book drop mode choice is not remembered if a wrong transfer modal is generated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40678 Bug ID: 40678 Summary: Book drop mode choice is not remembered if a wrong transfer modal is generated Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com To recreate: 1. Put an item in transfer to a different library than the logged in branch 2. Go to Circulation > Check in 3. Choose the "Book drop mode" option and check in a few items NOT from step 1. 4. See the "Book drop mode" choice is remembered after every selection. 5. Check in the item from step 1 to make a wrong transfer 6. The modal pops up for wrong transfer, click confirm 7. Now the choice of "Book drop mode" is forgotten. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40678 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40678 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185587&action=edit Bug 40678: Add hidden value to remember dropboxmode selection To test: 1. Put an item in transfer to a different library than the logged in branch 2. Go to Circulation > Check in 3. Choose the "Book drop mode" option and check in a few items NOT from step 1. 4. See the "Book drop mode" choice is remembered after every selection. 5. Check in the item from step 1 to make a wrong transfer 6. The modal pops up for wrong transfer, click confirm 7. Now the choice of "Book drop mode" is forgotten. 8. APPLY PATCH 9. Try again, this time the "Book drop mode" selction should be retained -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40678 --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- The same is true for "Forgive overdue charges", I think we can also fix that here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40678 --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185588&action=edit Bug 40678: Add hidden value to remember exemptfine selection To test: -Same test plan as with "Book drop mode" but for "Forgive overdue charges" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40678 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Book drop mode choice is |Choices are not remembered |not remembered if a wrong |if a wrong transfer modal |transfer modal is generated |is generated -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40678 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40678 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patchset fixes a bug release notes| |where the "Drop box mode" | |and "Forgive overdue | |charges" checkbox values | |were not retained when a | |wrong transfer modal is | |displayed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40678 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40678 WPPL Sandboxes <noticestest@notices.westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185587|0 |1 is obsolete| | --- Comment #4 from WPPL Sandboxes <noticestest@notices.westlakelibrary.org> --- Created attachment 185777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185777&action=edit Bug 40678: Add hidden value to remember dropboxmode selection To test: 1. Put an item in transfer to a different library than the logged in branch 2. Go to Circulation > Check in 3. Choose the "Book drop mode" option and check in a few items NOT from step 1. 4. See the "Book drop mode" choice is remembered after every selection. 5. Check in the item from step 1 to make a wrong transfer 6. The modal pops up for wrong transfer, click confirm 7. Now the choice of "Book drop mode" is forgotten. 8. APPLY PATCH 9. Try again, this time the "Book drop mode" selction should be retained Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40678 WPPL Sandboxes <noticestest@notices.westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185588|0 |1 is obsolete| | --- Comment #5 from WPPL Sandboxes <noticestest@notices.westlakelibrary.org> --- Created attachment 185778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185778&action=edit Bug 40678: Add hidden value to remember exemptfine selection To test: -Same test plan as with "Book drop mode" but for "Forgive overdue charges" Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40678 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |cj.lynce@westlakelibrary.or | |g --- Comment #6 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Patch works as advertised, both 'Book drop mode' and 'Forgive Overdue Charges' are remembered when the 'wrong transfer' modal is generated. Testing notes: Enable 'finesMode' syspref to test 'Forgive Overdue Charges' checkbox. Thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40678 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> ---
Testing notes: Enable 'finesMode' syspref to test 'Forgive Overdue Charges' checkbox.
Thanks for pointing that out, CJ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40678 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40678 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185777|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 185871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185871&action=edit Bug 40678: Add hidden value to remember dropboxmode selection To test: 1. Put an item in transfer to a different library than the logged in branch 2. Go to Circulation > Check in 3. Choose the "Book drop mode" option and check in a few items NOT from step 1. 4. See the "Book drop mode" choice is remembered after every selection. 5. Check in the item from step 1 to make a wrong transfer 6. The modal pops up for wrong transfer, click confirm 7. Now the choice of "Book drop mode" is forgotten. 8. APPLY PATCH 9. Try again, this time the "Book drop mode" selction should be retained Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40678 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185778|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 185872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185872&action=edit Bug 40678: Add hidden value to remember exemptfine selection To test: -Same test plan as with "Book drop mode" but for "Forgive overdue charges" Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40678 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40678 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40678 --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40678 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40678 --- Comment #11 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40678 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|25.11.00,25.05.04 |25.11.00,25.05.04,24.11.10 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40678 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #13 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org