https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34031 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34031 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34034 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34034 [Bug 34034] Move translatable strings out of opac-bottom.inc: OverDrive and OpenLibrary -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34031 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152402|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 155205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155205&action=edit Bug 34031: Move various translatable strings out of opac-bottom.inc This patch moves some JS variable definitions out of opac-bottom.inc. These variables where defined so that they could be picked up for translation, but they can now be moved to the corresponding <script> blocks. Many other of these variables are not used at all and have been removed. To test you should have EnableOpacSearchHistory, OPACPrivacy, and opacreadinghistory enabled. Apply the patch and log into the OPAC as a user with suggestions, search history, and checkout history. - Click your user menu at the top of the page and click the "Clear" link for search history. You should see a confirmation, "Are you sure you want to delete your search history?" Confirming should trigger your search history deletion. - From your user summary page, click "Privacy." Under "Immediate deletion," clicking any of the delete buttons should trigger a confirmation, "Warning: Cannot be undone. Please confirm once again" - From your user summary page, click "Purchase suggestions." - Without checking any checkbox, click the "Delete selected" button at the bottom. You should see an alert, "No suggestion was selected." Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34031 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34031 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34031 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155896|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156708&action=edit Bug 34031: Move various translatable strings out of opac-bottom.inc This patch moves some JS variable definitions out of opac-bottom.inc. These variables where defined so that they could be picked up for translation, but they can now be moved to the corresponding <script> blocks. Many other of these variables are not used at all and have been removed. To test you should have EnableOpacSearchHistory, OPACPrivacy, and opacreadinghistory enabled. Apply the patch and log into the OPAC as a user with suggestions, search history, and checkout history. - Click your user menu at the top of the page and click the "Clear" link for search history. You should see a confirmation, "Are you sure you want to delete your search history?" Confirming should trigger your search history deletion. - From your user summary page, click "Privacy." Under "Immediate deletion," clicking any of the delete buttons should trigger a confirmation, "Warning: Cannot be undone. Please confirm once again" - From your user summary page, click "Purchase suggestions." - Without checking any checkbox, click the "Delete selected" button at the bottom. You should see an alert, "No suggestion was selected." Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34031 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34031 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.