[Bug 19066] New: Add branchcode to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Bug ID: 19066 Summary: Add branchcode to accountlines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com For the purposes of statistics, it appears that it would help many libraries to have branchcode recorded in the accountlines table. For payments, the field would contain the code for the branch the payment was made at. For manual invoices, it would be the code of the library that created the invoice. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 65769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65769&action=edit Bug 19066 - Update Database -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 65770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65770&action=edit Bug 19066 - Update Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 65771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65771&action=edit Bug 19066 - Add branchcode to accountlines For the purposes of statistics, it appears that it would help many libraries to have branchcode recorded in the accountlines table. For payments, the field would contain the code for the branch the payment was made at. For manual invoices, it would be the code of the library that created the invoice. Test Plan: 1) Apply this patch set 2) Create and pay some fees 3) Note the branchcode for those fees and payments is set to your logged in branch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- *** Bug 7595 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 65771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65771 Bug 19066 - Add branchcode to accountlines Review of attachment 65771: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19066&attachment=65771) ----------------------------------------------------------------- Looking for test that triggers "third" part of Circulation.pm changes. prove t/db_dependent/Reserves/ prove t/db_dependent/Accounts.t Just that one little change needs triggering before I'll sign off. Read last Koha/Account comment, then first, then second. ::: C4/Circulation.pm @@ +2872,3 @@
# Charge a new rental fee, if applicable? my ( $charge, $type ) = GetIssuingCharges( $itemnumber, $borrowernumber ); if ( $charge > 0 ) {
Do we have a test that triggers this? I haven't found it yet. ::: Koha/Account.pm @@ +69,5 @@
my $lines = $params->{lines}; my $type = $params->{type} || 'payment'; + my $branchcode = $params->{branchcode}; + + $library_id ||= C4::Context->userenv ? C4::Context->userenv->{'branch'} : undef;
But why line 73 and change the line? @@ +74,2 @@
my $userenv = C4::Context->userenv;
Why not just after $userenv here, and keep the line identical? @@ -194,5 @@
note => $note, } )->store();
- $library_id ||= $userenv ? $userenv->{'branch'} : undef;
Yes, this needs to move. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Status|Needs Signoff |Failed QA --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- prove -r t/db_dependent fails after applying the patch. Constraint errors related to test builder, I suspect. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to M. Tompsett from comment #6)
prove -r t/db_dependent fails after applying the patch. Constraint errors related to test builder, I suspect.
Can you please make it explicit what tests are failing? Otherwise its around an hour of waiting for something to fail... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 67756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67756&action=edit Bug 19066 [QA Followup] - Fix related unit test failures -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67756|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 67757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67757&action=edit Bug 19066 [QA Followup] - Fix related unit test failures -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david.bourgault@inlibro.com --- Comment #10 from David Bourgault <david.bourgault@inlibro.com> --- Patch doesnt apply for me on master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65769|0 |1 is obsolete| | Attachment #65770|0 |1 is obsolete| | Attachment #65771|0 |1 is obsolete| | Attachment #67757|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71153&action=edit Bug 19066 - Update Database -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71154&action=edit Bug 19066 - Add branchcode to accountlines For the purposes of statistics, it appears that it would help many libraries to have branchcode recorded in the accountlines table. For payments, the field would contain the code for the branch the payment was made at. For manual invoices, it would be the code of the library that created the invoice. Test Plan: 1) Apply this patch set 2) Create and pay some fees 3) Note the branchcode for those fees and payments is set to your logged in branch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71155&action=edit Bug 19066 - Update Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71153|0 |1 is obsolete| | Attachment #71154|0 |1 is obsolete| | Attachment #71155|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 73185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73185&action=edit Bug 19066 - Update Database -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 73186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73186&action=edit Bug 19066 - Add branchcode to accountlines For the purposes of statistics, it appears that it would help many libraries to have branchcode recorded in the accountlines table. For payments, the field would contain the code for the branch the payment was made at. For manual invoices, it would be the code of the library that created the invoice. Test Plan: 1) Apply this patch set 2) Create and pay some fees 3) Note the branchcode for those fees and payments is set to your logged in branch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 73187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73187&action=edit Bug 19066 - Update Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #17 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 73186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73186 Bug 19066 - Add branchcode to accountlines Review of attachment 73186: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19066&attachment=73186) ----------------------------------------------------------------- ::: Koha/Account.pm @@ +76,4 @@
my $account_type = $params->{account_type}; my $offset_type = $params->{offset_type} || $type eq 'writeoff' ? 'Writeoff' : 'Payment';
+ $library_id ||= C4::Context->userenv ? C4::Context->userenv->{'branch'} : undef;
why not below the $userenv below? Less referencing, shorter line, and easier to read. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to M. Tompsett from comment #17)
Comment on attachment 73186 [details] [review] Bug 19066 - Add branchcode to accountlines
Review of attachment 73186 [details] [review]: -----------------------------------------------------------------
::: Koha/Account.pm @@ +76,4 @@
my $account_type = $params->{account_type}; my $offset_type = $params->{offset_type} || $type eq 'writeoff' ? 'Writeoff' : 'Payment';
+ $library_id ||= C4::Context->userenv ? C4::Context->userenv->{'branch'} : undef;
why not below the $userenv below? Less referencing, shorter line, and easier to read. :)
I'm not sure what you are referencing? Can you point me to the line numbers? Or if you'd rather submit a patch I'd be happy to sign it! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #19 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 73595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73595&action=edit Bug 19066: Follow up to reduce C4::Context references -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to M. Tompsett from comment #19)
Created attachment 73595 [details] [review] Bug 19066: Follow up to reduce C4::Context references
Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Cab Vinton <bibliwho@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliwho@gmail.com --- Comment #21 from Cab Vinton <bibliwho@gmail.com> --- Issue with Sandbox 06 -- Some problems occurred applying patches from bug 19066: <h1>Something went wrong !</h1>Applying: Bug 19066 - Update Database Applying: Bug 19066 - Add branchcode to accountlines .git/rebase-apply/patch:83: trailing whitespace. = C4::Context->userenv->{'number'} if C4::Context->userenv; warning: 1 line adds whitespace errors. Using index info to reconstruct a base tree... M C4/Accounts.pm M C4/Circulation.pm M C4/Reserves.pm M Koha/Account.pm M t/db_dependent/Accounts.t .git/rebase-apply/patch:83: trailing whitespace. = C4::Context->userenv->{'number'} if C4::Context->userenv; warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Accounts.t CONFLICT (content): Merge conflict in t/db_dependent/Accounts.t Auto-merging Koha/Account.pm Auto-merging C4/Reserves.pm Auto-merging C4/Circulation.pm Auto-merging C4/Accounts.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 19066 - Add branchcode to accountlines The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 19066 - Add branchcode to accountlines 73185 - Bug 19066 - Update Database 73186 - Bug 19066 - Add branchcode to accountlines 73187 - Bug 19066 - Update Schema 73595 - Bug 19066: Follow up to reduce C4::Context references Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-19066---Add-branchcode-to-accountlines-ArAGEA.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73187|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73185|0 |1 is obsolete| | Attachment #73186|0 |1 is obsolete| | Attachment #73595|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 77281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77281&action=edit Bug 19066: Update Database -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 77282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77282&action=edit Bug 19066: Add branchcode to accountlines For the purposes of statistics, it appears that it would help many libraries to have branchcode recorded in the accountlines table. For payments, the field would contain the code for the branch the payment was made at. For manual invoices, it would be the code of the library that created the invoice. Test Plan: 1) Apply this patch set 2) Create and pay some fees 3) Note the branchcode for those fees and payments is set to your logged in branch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 77283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77283&action=edit Bug 19066: Update Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Cab Vinton <bibliwho@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #25 from Cab Vinton <bibliwho@gmail.com> --- Software error in PTFS Sandbox 0: DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.branchcode' in 'field list' at /home/koha/src/Koha/Objects.pm line 209 For help, please send mail to the webmaster (webmaster@ptfs-europe.co.uk), giving this error message and the time and date of the error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Cab Vinton <bibliwho@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #26 from Cab Vinton <bibliwho@gmail.com> --- Re-tried & patch applied. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77282|0 |1 is obsolete| | Attachment #77283|0 |1 is obsolete| | --- Comment #27 from Lisette Scheer <lisetteslatah@gmail.com> --- Created attachment 78900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78900&action=edit Bug 19066: Add branchcode to accountlines For the purposes of statistics, it appears that it would help many libraries to have branchcode recorded in the accountlines table. For payments, the field would contain the code for the branch the payment was made at. For manual invoices, it would be the code of the library that created the invoice. Test Plan: 1) Apply this patch set 2) Create and pay some fees 3) Note the branchcode for those fees and payments is set to your logged in branch Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #28 from Lisette Scheer <lisetteslatah@gmail.com> --- Created attachment 78901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78901&action=edit Bug 19066: Update Schema Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #29 from Michal Denar <black23@gmail.com> --- Please rebase on master Error: CONFLICT (content): Merge conflict in Koha/Schema/Result/Accountline.pm Thank You Mike -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #30 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Please call it library_id, following the latest use. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77281|0 |1 is obsolete| | Attachment #78900|0 |1 is obsolete| | Attachment #78901|0 |1 is obsolete| | --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 81144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81144&action=edit Bug 19066: Update Database -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 81145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81145&action=edit Bug 19066: Add branchcode to accountlines For the purposes of statistics, it appears that it would help many libraries to have branchcode recorded in the accountlines table. For payments, the field would contain the code for the branch the payment was made at. For manual invoices, it would be the code of the library that created the invoice. Test Plan: 1) Apply this patch set 2) Create and pay some fees 3) Note the branchcode for those fees and payments is set to your logged in branch Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 81146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81146&action=edit Bug 19066: Update Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #34 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Same as bug 21401. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21401 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21401 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21401 [Bug 21401] Account offsets should save the transacting library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81144|0 |1 is obsolete| | Attachment #81145|0 |1 is obsolete| | Attachment #81146|0 |1 is obsolete| | --- Comment #35 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 81253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81253&action=edit Bug 19066: Update Database Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #36 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 81254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81254&action=edit Bug 19066: Add branchcode to accountlines For the purposes of statistics, it appears that it would help many libraries to have branchcode recorded in the accountlines table. For payments, the field would contain the code for the branch the payment was made at. For manual invoices, it would be the code of the library that created the invoice. Test Plan: 1) Apply this patch set 2) Create and pay some fees 3) Note the branchcode for those fees and payments is set to your logged in branch Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #37 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 81255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81255&action=edit Bug 19066: Update Schema Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21678 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21678 [Bug 21678] Adding debit "Renewal of Rental Item" and "Reserve Charge" does not create account offset -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #38 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Tomás Cohen Arazi from comment #30)
Please call it library_id, following the latest use.
This has been discussed on bug 21401 comment 14. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #39 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 81684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81684&action=edit Bug 19066: (QA follow-up) Move db update to perl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm.. I'm working on a push to using Koha::Accounts more.. see the graph dangling off bug 21002 . Attempting to rebase my work on top of this I can see at least a couple of places where we're missing things here.. I'm going to set to failed qa whilst I add the followups. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Koha::Account->add_credit isn't handled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81912&action=edit Bug 19066: (QA follow-up) Add handling in add_credit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #43 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Back to Signed Off.. Tomas, did you fancy taking a look at my follow-up and verifying the add_credit use.. do we need to also account for library_id in the API endpoints. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 [Bug 21002] Add Koha::Account::add_debit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #44 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Martin Renvoize from comment #43)
Back to Signed Off.. Tomas, did you fancy taking a look at my follow-up and verifying the add_credit use.. do we need to also account for library_id in the API endpoints.
Everything looks correct. But t/db_dependent/Accounts.t is failing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #45 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 81918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81918&action=edit Bug 19066: (QA follow-up) Remove bad and unecessary test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Sally Healey <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED --- Comment #46 from Tomás Cohen Arazi <tomascohen@gmail.com> --- With Kyle's permission, I'm taking this one. I will complete the tests, so they cover all the changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #47 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82047&action=edit Bug 19066: Tests for AddRenewal AddIssuingCharge and ChargeReserveFee This patch adds some tests that cover functions changed by this patchset. A bug in ChargeReserveFee is highlighted. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #48 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82048&action=edit Bug 19066: (QA follow-up) Fix ChargeReserveFee This patch fixes a bug in ChargeReserveFee: To test: - Run: $ kshell k$ prove t/db_dependent/Reserves.t => FAIL: Tests fail because branchcode is not set - Apply this patch - Run: k$ prove t/db_dependent/Reserves.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21786 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21786 [Bug 21786] Routes for credits should include library_id -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82048|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82047|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #49 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82084&action=edit Bug 19066: Tests for AddRenewal AddIssuingCharge and ChargeReserveFee This patch adds some tests that cover functions changed by this patchset. A bug in ChargeReserveFee is highlighted. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #50 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82086&action=edit Bug 19066: (QA follow-up) Fix ChargeReserveFee This patch fixes a bug in ChargeReserveFee: To test: - Run: $ kshell k$ prove t/db_dependent/Reserves.t => FAIL: Tests fail because branchcode is not set - Apply this patch - Run: k$ prove t/db_dependent/Reserves.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #51 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82087&action=edit Bug 19066: Add tests for Koha::Account->pay This patch adds tests for Koha::Account->pay, to make sure the library_id param is used to set the branchcode attribute. The use of userenv to set branchcode if library_id not passed is removed. Responsability is left to the callers to pass library_id. To test: - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => SUCCESS: Tests pass! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21788 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21788 [Bug 21788] C4::Circulation::ProcessOfflinePayment should pass library_id to ->pay -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21801 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21801 [Bug 21801] paycollect.pl should pass library_id when adding accountlines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #52 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- With all the followups this is looking solid to me now.. I'd happily add a second QA stamp to the whole set. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82084|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81253|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81254|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81255|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82087|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81684|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81912|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81918|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82086|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #53 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82469&action=edit Bug 19066: Update Database Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #54 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82470&action=edit Bug 19066: Add branchcode to accountlines For the purposes of statistics, it appears that it would help many libraries to have branchcode recorded in the accountlines table. For payments, the field would contain the code for the branch the payment was made at. For manual invoices, it would be the code of the library that created the invoice. Test Plan: 1) Apply this patch set 2) Create and pay some fees 3) Note the branchcode for those fees and payments is set to your logged in branch Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #55 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82471&action=edit Bug 19066: Update Schema Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #56 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82473&action=edit Bug 19066: (QA follow-up) Move db update to perl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #57 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82474&action=edit Bug 19066: (QA follow-up) Add handling in add_credit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #58 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82475&action=edit Bug 19066: (QA follow-up) Remove bad and unecessary test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #59 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82476&action=edit Bug 19066: Tests for AddRenewal AddIssuingCharge and ChargeReserveFee This patch adds some tests that cover functions changed by this patchset. A bug in ChargeReserveFee is highlighted. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #60 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82477&action=edit Bug 19066: (QA follow-up) Fix ChargeReserveFee This patch fixes a bug in ChargeReserveFee: To test: - Run: $ kshell k$ prove t/db_dependent/Reserves.t => FAIL: Tests fail because branchcode is not set - Apply this patch - Run: k$ prove t/db_dependent/Reserves.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #61 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82478&action=edit Bug 19066: Add tests for Koha::Account->pay This patch adds tests for Koha::Account->pay, to make sure the library_id param is used to set the branchcode attribute. The use of userenv to set branchcode if library_id not passed is removed. Responsability is left to the callers to pass library_id. To test: - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => SUCCESS: Tests pass! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82469|0 |1 is obsolete| | --- Comment #62 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83067&action=edit Bug 19066: Update Database Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82470|0 |1 is obsolete| | --- Comment #63 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83068&action=edit Bug 19066: Add branchcode to accountlines For the purposes of statistics, it appears that it would help many libraries to have branchcode recorded in the accountlines table. For payments, the field would contain the code for the branch the payment was made at. For manual invoices, it would be the code of the library that created the invoice. Test Plan: 1) Apply this patch set 2) Create and pay some fees 3) Note the branchcode for those fees and payments is set to your logged in branch Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82471|0 |1 is obsolete| | --- Comment #64 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83069&action=edit Bug 19066: Update Schema Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82473|0 |1 is obsolete| | --- Comment #65 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83070&action=edit Bug 19066: (QA follow-up) Move db update to perl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82474|0 |1 is obsolete| | --- Comment #66 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83071&action=edit Bug 19066: (QA follow-up) Add handling in add_credit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82475|0 |1 is obsolete| | --- Comment #67 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83072&action=edit Bug 19066: (QA follow-up) Remove bad and unecessary test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82476|0 |1 is obsolete| | --- Comment #68 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83073&action=edit Bug 19066: Tests for AddRenewal AddIssuingCharge and ChargeReserveFee This patch adds some tests that cover functions changed by this patchset. A bug in ChargeReserveFee is highlighted. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82477|0 |1 is obsolete| | --- Comment #69 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83074&action=edit Bug 19066: (QA follow-up) Fix ChargeReserveFee This patch fixes a bug in ChargeReserveFee: To test: - Run: $ kshell k$ prove t/db_dependent/Reserves.t => FAIL: Tests fail because branchcode is not set - Apply this patch - Run: k$ prove t/db_dependent/Reserves.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82478|0 |1 is obsolete| | --- Comment #70 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83075&action=edit Bug 19066: Add tests for Koha::Account->pay This patch adds tests for Koha::Account->pay, to make sure the library_id param is used to set the branchcode attribute. The use of userenv to set branchcode if library_id not passed is removed. Responsability is left to the callers to pass library_id. To test: - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => SUCCESS: Tests pass! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83067|0 |1 is obsolete| | --- Comment #71 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83076&action=edit Bug 19066: Update Database Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83068|0 |1 is obsolete| | --- Comment #72 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83077&action=edit Bug 19066: Add branchcode to accountlines For the purposes of statistics, it appears that it would help many libraries to have branchcode recorded in the accountlines table. For payments, the field would contain the code for the branch the payment was made at. For manual invoices, it would be the code of the library that created the invoice. Test Plan: 1) Apply this patch set 2) Create and pay some fees 3) Note the branchcode for those fees and payments is set to your logged in branch Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83069|0 |1 is obsolete| | --- Comment #73 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83078&action=edit Bug 19066: Update Schema Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83070|0 |1 is obsolete| | --- Comment #74 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83079&action=edit Bug 19066: (QA follow-up) Move db update to perl Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83071|0 |1 is obsolete| | --- Comment #75 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83080&action=edit Bug 19066: (QA follow-up) Add handling in add_credit Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83072|0 |1 is obsolete| | --- Comment #76 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83081&action=edit Bug 19066: (QA follow-up) Remove bad and unecessary test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83073|0 |1 is obsolete| | --- Comment #77 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83082&action=edit Bug 19066: Tests for AddRenewal AddIssuingCharge and ChargeReserveFee This patch adds some tests that cover functions changed by this patchset. A bug in ChargeReserveFee is highlighted. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83074|0 |1 is obsolete| | --- Comment #78 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83083&action=edit Bug 19066: (QA follow-up) Fix ChargeReserveFee This patch fixes a bug in ChargeReserveFee: To test: - Run: $ kshell k$ prove t/db_dependent/Reserves.t => FAIL: Tests fail because branchcode is not set - Apply this patch - Run: k$ prove t/db_dependent/Reserves.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83075|0 |1 is obsolete| | --- Comment #79 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83084&action=edit Bug 19066: Add tests for Koha::Account->pay This patch adds tests for Koha::Account->pay, to make sure the library_id param is used to set the branchcode attribute. The use of userenv to set branchcode if library_id not passed is removed. Responsability is left to the callers to pass library_id. To test: - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => SUCCESS: Tests pass! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #80 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Rebased, Retested and added my own SO lines as a second more recent QA after the recent changes to master. Did anyone sponsor this work.. there are no 'Sponsored-by' lines ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16461 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16461 [Bug 16461] Add some information (branch and barcode) in fine description for overdue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16639 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #81 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Ack.. yet another thing I've found we've missed... at least it's not pushed yet. Whenever we add a reference like this we really should ensure referential integrity by defining a foreign key constraint. I'll add this to the DB update. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #82 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83275&action=edit Bug 19066: (QA follow-up) Define foreign key for branchcode Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83076|0 |1 is obsolete| | --- Comment #83 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 83519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83519&action=edit Bug 19066: Update Database Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83077|0 |1 is obsolete| | --- Comment #84 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 83520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83520&action=edit Bug 19066: Add branchcode to accountlines For the purposes of statistics, it appears that it would help many libraries to have branchcode recorded in the accountlines table. For payments, the field would contain the code for the branch the payment was made at. For manual invoices, it would be the code of the library that created the invoice. Test Plan: 1) Apply this patch set 2) Create and pay some fees 3) Note the branchcode for those fees and payments is set to your logged in branch Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83078|0 |1 is obsolete| | --- Comment #85 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 83521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83521&action=edit Bug 19066: Update Schema Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83079|0 |1 is obsolete| | --- Comment #86 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 83522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83522&action=edit Bug 19066: (QA follow-up) Move db update to perl Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83080|0 |1 is obsolete| | --- Comment #87 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 83523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83523&action=edit Bug 19066: (QA follow-up) Add handling in add_credit Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83081|0 |1 is obsolete| | --- Comment #88 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 83524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83524&action=edit Bug 19066: (QA follow-up) Remove bad and unecessary test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83082|0 |1 is obsolete| | --- Comment #89 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 83525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83525&action=edit Bug 19066: Tests for AddRenewal AddIssuingCharge and ChargeReserveFee This patch adds some tests that cover functions changed by this patchset. A bug in ChargeReserveFee is highlighted. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83083|0 |1 is obsolete| | --- Comment #90 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 83526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83526&action=edit Bug 19066: (QA follow-up) Fix ChargeReserveFee This patch fixes a bug in ChargeReserveFee: To test: - Run: $ kshell k$ prove t/db_dependent/Reserves.t => FAIL: Tests fail because branchcode is not set - Apply this patch - Run: k$ prove t/db_dependent/Reserves.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83084|0 |1 is obsolete| | --- Comment #91 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 83527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83527&action=edit Bug 19066: Add tests for Koha::Account->pay This patch adds tests for Koha::Account->pay, to make sure the library_id param is used to set the branchcode attribute. The use of userenv to set branchcode if library_id not passed is removed. Responsability is left to the callers to pass library_id. To test: - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => SUCCESS: Tests pass! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83275|0 |1 is obsolete| | --- Comment #92 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 83528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83528&action=edit Bug 19066: (QA follow-up) Define foreign key for branchcode Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud@biblibre.com --- Comment #93 from Alex Arnaud <alex.arnaud@biblibre.com> --- Rebased against master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #94 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #95 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83628&action=edit Bug 19066: (RM follow-up) Fix test count and structure error Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22066 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22066 [Bug 22066] Branchcode should be recorded for manual credits -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #96 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.11.x series -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancements adds release notes| |recording of the branch an | |account transaction was | |performed. | | | |For payments it | |will be the signed in | |branch when payment is | |collected. | |For manual | |invoices/credits it is the | |signed in branch when the | |line is created. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|19.05 |--- Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15985 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org