[Bug 37362] New: Do not show the lists button if there are no public lists and opacuserlogin is off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37362 Bug ID: 37362 Summary: Do not show the lists button if there are no public lists and opacuserlogin is off Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org If all of the following are true: - Lists are enabled (virtualshelves is on) - opacuserlogin is turned off (users cannot create their own lists) - There are no public lists ...then we should not show the "Lists" button in the OPAC header. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37362 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37362 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 168996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168996&action=edit Bug 37362: Do not show the lists button if there are no public lists and opacuserlogin is off This patch updates the OPAC header so that if opacuserlogin is off and there are no public shelves, the Lists button does not appear. If opacuserlogin is turned off the only kind of lists the user can interact with are public ones, and without public lists there's nothing to do. To test, apply the patch and test the arrangement of the OPAC header in these cases: - opacuserlogin is on, user is logged in, and there are no public lists: - The Lists button appears and contains only "Your lists" menu items. - opacuserlogin is on, user is logged in, and there are public lists: - The Lists button appears and the menu contains controls for both public and private lists. - opacuserlogin is off and there are public lists: - The Lists button appears and shows only controls for public lists. - opacuserlogin is off and there are no public lists: - The Lists button does not appear. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37362 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37362 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168996|0 |1 is obsolete| | --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 169012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169012&action=edit Bug 37362: Do not show the lists button if there are no public lists and opacuserlogin is off This patch updates the OPAC header so that if opacuserlogin is off and there are no public shelves, the Lists button does not appear. If opacuserlogin is turned off the only kind of lists the user can interact with are public ones, and without public lists there's nothing to do. To test, apply the patch and test the arrangement of the OPAC header in these cases: - opacuserlogin is on, user is logged in, and there are no public lists: - The Lists button appears and contains only "Your lists" menu items. - opacuserlogin is on, user is logged in, and there are public lists: - The Lists button appears and the menu contains controls for both public and private lists. - opacuserlogin is off and there are public lists: - The Lists button appears and shows only controls for public lists. - opacuserlogin is off and there are no public lists: - The Lists button does not appear. Sponsored-by: Athens County Public Libraries Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37362 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, but probably due to Bootsrap 5 changes this no longer applies cleanly and the differences are a bit hard to see for whitespace changes. Please rebase! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37362 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37362 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169012|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 171027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171027&action=edit Bug 37362: Do not show the lists button if there are no public lists and opacuserlogin is off This patch updates the OPAC header so that if opacuserlogin is off and there are no public shelves, the Lists button does not appear. If opacuserlogin is turned off the only kind of lists the user can interact with are public ones, and without public lists there's nothing to do. To test, apply the patch and test the arrangement of the OPAC header in these cases: - opacuserlogin is on, user is logged in, and there are no public lists: - The Lists button appears and contains only "Your lists" menu items. - opacuserlogin is on, user is logged in, and there are public lists: - The Lists button appears and the menu contains controls for both public and private lists. - opacuserlogin is off and there are public lists: - The Lists button appears and shows only controls for public lists. - opacuserlogin is off and there are no public lists: - The Lists button does not appear. Sponsored-by: Athens County Public Libraries Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37362 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37362 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171027|0 |1 is obsolete| | --- Comment #5 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 171804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171804&action=edit Bug 37362: Do not show the lists button if there are no public lists and opacuserlogin is off This patch updates the OPAC header so that if opacuserlogin is off and there are no public shelves, the Lists button does not appear. If opacuserlogin is turned off the only kind of lists the user can interact with are public ones, and without public lists there's nothing to do. To test, apply the patch and test the arrangement of the OPAC header in these cases: - opacuserlogin is on, user is logged in, and there are no public lists: - The Lists button appears and contains only "Your lists" menu items. - opacuserlogin is on, user is logged in, and there are public lists: - The Lists button appears and the menu contains controls for both public and private lists. - opacuserlogin is off and there are public lists: - The Lists button appears and shows only controls for public lists. - opacuserlogin is off and there are no public lists: - The Lists button does not appear. Sponsored-by: Athens County Public Libraries Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37362 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |Laura.escamilla@bywatersolu |y.org |tions.com CC| |Laura.escamilla@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37362 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37362 --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37362 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to main |RESOLVED CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Doesn;t apply clean to 24.05.x, rebase if needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org