[Bug 35877] New: Use template wrapper to build Bootstrap accordion components
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35877 Bug ID: 35877 Summary: Use template wrapper to build Bootstrap accordion components Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Like the conversion of Bootstrap tabs to WRAPPER-generated markup, I would like to create a set of WRAPPERs for Bootstrap accordion components, found on these pages: - Table settings - Notice editor - Patrons requesting modification -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35877 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35877 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35880 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35880 [Bug 35880] Use template wrapper for accordions: Patrons requesting modifications -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35877 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35882 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35882 [Bug 35882] Use template wrapper for accordions: Notices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35877 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35883 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35883 [Bug 35883] Use template wrapper for accordions: Table settings administration -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35877 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35877 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 161328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161328&action=edit Bug 35877: Use template wrapper to build Bootstrap accordion components This patch adds Template::Toolkit WRAPPER blocks to html_helpers.inc so that templates can build Bootstrap accordion components while keeping the Bootstrap structural markup separate. Each individual component of a Bootstrap accordion interface is defined: - Group container - Collapsible item - Item heading - Item content Included is a usage example: [ WRAPPER accordion id="accordion container id" ] [ WRAPPER accordion_item ] [ WRAPPER accordion_heading panel_id = "panel id" ] [Clickable panel heading ] [ END ] [ WRAPPER accordion_panel panel_id = "panel id" ] [Expanding content panel] [ END ] [ END ] [ END ] To test, apply this patch and one of the dependent patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35877 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35877 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161328|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 161739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161739&action=edit Bug 35877: Use template wrapper to build Bootstrap accordion components This patch adds Template::Toolkit WRAPPER blocks to html_helpers.inc so that templates can build Bootstrap accordion components while keeping the Bootstrap structural markup separate. Each individual component of a Bootstrap accordion interface is defined: - Group container - Collapsible item - Item heading - Item content Included is a usage example: [ WRAPPER accordion id="accordion container id" ] [ WRAPPER accordion_item ] [ WRAPPER accordion_heading panel_id = "panel id" ] [Clickable panel heading ] [ END ] [ WRAPPER accordion_panel panel_id = "panel id" ] [Expanding content panel] [ END ] [ END ] [ END ] To test, apply this patch and one of the dependent patches. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35877 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Signed Off |Failed QA --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- The documentation says: [ WRAPPER accordion id="accordion container id" ] but `id` is not used inside accordion block. `panelgroup_id` is used instead. Bug 35880 and bug 35883 use `panelgroup_id` but bug 35882 uses `id`. Either the doc should be fixed or the block should be fixed to match the doc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35877 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |julian.maurice@biblibre.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35877 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35877 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161739|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 163719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163719&action=edit Bug 35877: Use template wrapper to build Bootstrap accordion components This patch adds Template::Toolkit WRAPPER blocks to html_helpers.inc so that templates can build Bootstrap accordion components while keeping the Bootstrap structural markup separate. Each individual component of a Bootstrap accordion interface is defined: - Group container - Collapsible item - Item heading - Item content Included is a usage example: [ WRAPPER accordion id="accordion container id" ] [ WRAPPER accordion_item ] [ WRAPPER accordion_heading panel_id = "panel id" ] [Clickable panel heading ] [ END ] [ WRAPPER accordion_panel panel_id = "panel id" ] [Expanding content panel] [ END ] [ END ] [ END ] To test, apply this patch and one of the dependent patches. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35877 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 163720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163720&action=edit Bug 35877: (follow-up) Correct accordion wrapper parameter name -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35877 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163719|0 |1 is obsolete| | --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 163886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163886&action=edit Bug 35877: Use template wrapper to build Bootstrap accordion components This patch adds Template::Toolkit WRAPPER blocks to html_helpers.inc so that templates can build Bootstrap accordion components while keeping the Bootstrap structural markup separate. Each individual component of a Bootstrap accordion interface is defined: - Group container - Collapsible item - Item heading - Item content Included is a usage example: [ WRAPPER accordion id="accordion container id" ] [ WRAPPER accordion_item ] [ WRAPPER accordion_heading panel_id = "panel id" ] [Clickable panel heading ] [ END ] [ WRAPPER accordion_panel panel_id = "panel id" ] [Expanding content panel] [ END ] [ END ] [ END ] To test, apply this patch and one of the dependent patches. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35877 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163720|0 |1 is obsolete| | --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 163887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163887&action=edit Bug 35877: (follow-up) Correct accordion wrapper parameter name Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35877 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35877 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35877 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35877 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not backported -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35877 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs documenting |RESOLVED --- Comment #10 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Code structure change, nothing to add/edit in the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org