https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25354 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 104239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104239&action=edit Bug 25354: Clean up JavaScript markup in cataloging plugin scripts This patch makes some minor changes to the JavaScript generated by the cataloging plugins: <script> "type" attribute removed; single-line comments converted to multi-line style; obsolete //<![CDATA[ marks removed. These changes help the JavaScript conform to current coding guidelines. The comment style change allows for whitespace in the scripts to be collapsed by the Template::Toolkit "collapse" filter. Since the patch makes small cosmetic changes to many files it may be easiest to test this patch by visually inspecting the changes. It's also simple to test some plugins which are enabled by default (at least in MARC21): In the basic MARC editor, the leader, 007, and 008. In the item editor, subfield d - Date acquired. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25354 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104239|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 109857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109857&action=edit Bug 25354: Clean up JavaScript markup in cataloging plugin scripts This patch makes some minor changes to the JavaScript generated by the cataloging plugins: <script> "type" attribute removed; single-line comments converted to multi-line style; obsolete //<![CDATA[ marks removed. These changes help the JavaScript conform to current coding guidelines. The comment style change allows for whitespace in the scripts to be collapsed by the Template::Toolkit "collapse" filter. Since the patch makes small cosmetic changes to many files it may be easiest to test this patch by visually inspecting the changes. It's also simple to test some plugins which are enabled by default (at least in MARC21): In the basic MARC editor, the leader, 007, and 008. In the item editor, subfield d - Date acquired. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25354 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109857|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 111047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111047&action=edit Bug 25354: Clean up JavaScript markup in cataloging plugin scripts This patch makes some minor changes to the JavaScript generated by the cataloging plugins: <script> "type" attribute removed; single-line comments converted to multi-line style; obsolete //<![CDATA[ marks removed. These changes help the JavaScript conform to current coding guidelines. The comment style change allows for whitespace in the scripts to be collapsed by the Template::Toolkit "collapse" filter. Since the patch makes small cosmetic changes to many files it may be easiest to test this patch by visually inspecting the changes. It's also simple to test some plugins which are enabled by default (at least in MARC21): In the basic MARC editor, the leader, 007, and 008. In the item editor, subfield d - Date acquired. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25354 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111047|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111537&action=edit Bug 25354: Clean up JavaScript markup in cataloging plugin scripts This patch makes some minor changes to the JavaScript generated by the cataloging plugins: <script> "type" attribute removed; single-line comments converted to multi-line style; obsolete //<![CDATA[ marks removed. These changes help the JavaScript conform to current coding guidelines. The comment style change allows for whitespace in the scripts to be collapsed by the Template::Toolkit "collapse" filter. Since the patch makes small cosmetic changes to many files it may be easiest to test this patch by visually inspecting the changes. It's also simple to test some plugins which are enabled by default (at least in MARC21): In the basic MARC editor, the leader, 007, and 008. In the item editor, subfield d - Date acquired. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25354 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.