[Bug 25389] New: Inconsistent naming of account_credit_type for lost and returned items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25389 Bug ID: 25389 Summary: Inconsistent naming of account_credit_type for lost and returned items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Bug 23805 creates the account_credit_types table with the type "LOST_RETURN." Bug 22563 updates all existing "CR" account lines to "LOST_RETURNED." I've got no preference between the two wordings, but we should be consistent about it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25389 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna@gmail.com, | |kelly@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25389 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25389 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- If I check in a lost item on 19.11, the accountline for the lost fee shows debit_type_code LOST with status RETURNED. The accountline that gets created for the credit -- what would have been accounttype 'CR' in 19.05 - has credit_type_code "LOST_RETURN." I think bug 22563 got the value wrong when updating old credits. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25389 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Martin, I think you would be probably the best to have a look here - I am a little lost with the new status still. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25389 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23805, 22563 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 [Bug 23805] Add a dedicated credit_types table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25389 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- You are completely right :(.. Working on a fix now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25389 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |blocker -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25389 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 104678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104678&action=edit Bug 25389: Correct original DB update for bug 22563 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25389 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 104679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104679&action=edit Bug 25389: Correct stray cases of LOST_RETURNED The original DB update for bug 22563 incorrectly mapped CR to LOST_RETURNED as aposed to LOST_RETURN. This patch catches such cases and updates them in the update for bug 23805 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25389 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 104680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104680&action=edit Bug 25389: Catch LOST_RETURNED in DB update 19.12.00.021 An errant update from bug 22563 could lead to cases of LOST_RETURNED as aposed to LOST_RETURN as an account_credit_type. This patch adds code to deal with those cases to the update for bug 24592 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25389 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 104681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104681&action=edit Bug 25389: Catch errant cases of LOST_RETURNED For upgrades taking place after the fix for the update in bug 24592 was pushed, we need to catch any last remaining error cases and correct them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25389 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25389 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- It may be safer to skip the first patch entirely.. I'm open to peoples opinions there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25389 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- If I read this right: The first two patches fix the upgrade for site that have not yet upgraded to 19.11 The last two patches will fix sites going to 20.05 We will still need a patch to fix sites that got the bad upgrade in 19.11? The last patch moves to LOST_FOUND, but that isn't introduced before 20.05 (bug 24592) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25389 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_candidate, | |RM_priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25389 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- So, each patch will need some careful backporting to their various branches to catch in the right place. This set was for master.. I suppose to be safe I could create a corresponding set that applies cleanly to 19.11.x.. you are correct.. the final patch would need modifying to LOST_RETURN for that case. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25389 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25389 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104678|0 |1 is obsolete| | Attachment #104679|0 |1 is obsolete| | Attachment #104680|0 |1 is obsolete| | Attachment #104681|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 104755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104755&action=edit Bug 25389: Correct original DB update for bug 22563 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25389 --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 104756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104756&action=edit Bug 25389: Correct stray cases of LOST_RETURNED The original DB update for bug 22563 incorrectly mapped CR to LOST_RETURNED as aposed to LOST_RETURN. This patch catches such cases and updates them in the update for bug 23805 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25389 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 104757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104757&action=edit Bug 25389: Catch LOST_RETURNED in DB update 19.12.00.021 An errant update from bug 22563 could lead to cases of LOST_RETURNED as aposed to LOST_RETURN as an account_credit_type. This patch adds code to deal with those cases to the update for bug 24592 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25389 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 104758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104758&action=edit Bug 25389: Catch errant cases of LOST_RETURNED For upgrades taking place after the fix for the update in bug 24592 was pushed, we need to catch any last remaining error cases and correct them. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25389 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25389 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104755|0 |1 is obsolete| | Attachment #104756|0 |1 is obsolete| | Attachment #104757|0 |1 is obsolete| | Attachment #104758|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104775&action=edit Bug 25389: Correct original DB update for bug 22563 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25389 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104776&action=edit Bug 25389: Correct stray cases of LOST_RETURNED The original DB update for bug 22563 incorrectly mapped CR to LOST_RETURNED as aposed to LOST_RETURN. This patch catches such cases and updates them in the update for bug 23805 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25389 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104777&action=edit Bug 25389: Catch LOST_RETURNED in DB update 19.12.00.021 An errant update from bug 22563 could lead to cases of LOST_RETURNED as aposed to LOST_RETURN as an account_credit_type. This patch adds code to deal with those cases to the update for bug 24592 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25389 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104778&action=edit Bug 25389: Catch errant cases of LOST_RETURNED For upgrades taking place after the fix for the update in bug 24592 was pushed, we need to catch any last remaining error cases and correct them. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25389 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25389 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25389 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25478 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25478 [Bug 25478] Inconsistent naming of account_credit_type for lost and returned items [19.11 Version] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25389 --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- See bug 25478 for a pre-ported version for easy application to the 19.11.x branch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25389 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_05_candidate, | |RM_priority | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org