https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20881 --- Comment #1 from paxed <pasi.kallinen@joensuu.fi> --- Created attachment 75809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75809&action=edit Bug 20881: Order receiving: Price filter missing on_editing -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20881 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |normal CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is quite a problem working with comma-separated decimals, upping severity a bit. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20881 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75809|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 76195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76195&action=edit Bug 20881: Order receiving: Price filter missing on_editing When the Price-filter is used on editable data, it should have the on_editing -tag. Add it to the orderreceive.tt Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> To test: - Set CurrencyFormat to FR - Create a basket with orders in acq - Close it - Receive shipment and pick order line to receive - On this screen verify that the actual cost appears as comma-separated - Apply patch - Refresh page - Verify that the actual cost now appears .-separated -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20881 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76195|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76236&action=edit Bug 20881: Order receiving: Price filter missing on_editing When the Price-filter is used on editable data, it should have the on_editing -tag. Add it to the orderreceive.tt Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> To test: - Set CurrencyFormat to FR - Create a basket with orders in acq - Close it - Receive shipment and pick order line to receive - On this screen verify that the actual cost appears as comma-separated - Apply patch - Refresh page - Verify that the actual cost now appears .-separated Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20881 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20881 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Depends on| |13352 --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.08 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13352 [Bug 13352] Editing amount in Acquisitions budget causes error due to formatting -- You are receiving this mail because: You are watching all bug changes.