https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think at the moment it's built so it's possible to order records without items - so not sure what you suggest would/should work in general. Some libraries might want to allow orders on articles without items. I think if we do that, we should try to fill the form in for the user. Having found the article, they might not like to be forced to enter the information into a form, that was obvious on the record before. But it would probably not be easy to split up $g correctly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 73143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73143&action=edit Bug 20310: Redirect article record without items for article requests If an article record has been catalogued separately, has no items and contains a reference to its host via MARC21 field 773 (host item entry), this patch makes an article request redirect to the host record while copying title, author and page info (from 773$g). This is accomplished by using the new Koha::Biblio->host_record method. Note: Subfield 773$g may contain additional information on volume and issue number etc. It will be very hard or perhaps impossible to parse $g and copy these details into the corresponding fields of the article request form for all possible variations used in libraries. A similar remark can be made for selecting the correct item (when item level is used). We could try this on a future report, but will probably need at least a preference to define the expected format. Test plan: [1] Enable article requests. Add rules for an ART and a SER itemtype. [2] Create a SER host biblio record. [3] Create an ART biblio record, no items. Include a 773w pointing to the SER record with '(MARCorgcode)[recno]' (keep the parentheses, remove the square brackets when inserting the biblionumber). Include text in 773$g too. [4] Place an article request on the ART record. Verify that it redirects you to the SER record while copying title, author, page info. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Maksim Sen <maksim.sen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73142|0 |1 is obsolete| | --- Comment #4 from Maksim Sen <maksim.sen@inlibro.com> --- Created attachment 73805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73805&action=edit Bug 20310: Introduce Koha::Biblio->host_record This is a more generic method that allows you to get to the host record as defined in MARC21 field 773$w. Test plan: Run t/db_dependent/Koha/Biblio/host_record.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Maksim Sen <maksim.sen@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to paxed from comment #5)

Comment on attachment 73805 [details] [review] Bug 20310: Introduce Koha::Biblio->host_record

Shouldn't this also check that the 003 fields match? AFAIUI, 001+003 is unique, 001 is not guaranteed to be - because you could import data from different organization.

Not sure if this is done consistently in Koha, but sounds good. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 --- Comment #8 from paxed <pasi.kallinen@joensuu.fi> --- Comment on attachment 73805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73805 Bug 20310: Introduce Koha::Biblio->host_record The MARC21 documentation from the Finnish National Library says the 773$w is just the RCN, nothing else - so the regex will fail for us. Even the loc.gov MARC21 spec just says "$w - Record control number", so I don't know why their examples have the issuing org listed in the field too. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- But the prefix is correct, found the documentation: http://www.loc.gov/marc/bibliographic/ecbdcntf.html -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Restoring order of original patch still hoping for a response from Maksim. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to paxed from comment #8)

Comment on attachment 73805 [details] [review] Bug 20310: Introduce Koha::Biblio->host_record

The MARC21 documentation from the Finnish National Library says the 773$w is just the RCN, nothing else - so the regex will fail for us.

It should no longer. Allows this case now. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to paxed from comment #5)

Comment on attachment 73805 [details] [review] Bug 20310: Introduce Koha::Biblio->host_record

Shouldn't this also check that the 003 fields match? AFAIUI, 001+003 is unique, 001 is not guaranteed to be - because you could import data from different organization.

Added a check with pref MARCOrgCode -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to paxed from comment #17)

(In reply to Marcel de Rooy from comment #16)

...

(In reply to paxed from comment #5)

...

Comment on attachment 73805 [details] [review] [review] [review] Bug 20310: Introduce Koha::Biblio->host_record

Shouldn't this also check that the 003 fields match? AFAIUI, 001+003 is unique, 001 is not guaranteed to be - because you could import data from different organization.

Added a check with pref MARCOrgCode

But if you import data from another org then the orgcode (field 003) for those records won't be your org, but something else. You should match the 773$w orgcode to the host biblio 003

Hi paxed, I understand your point. But I am not so sure if we do these checks somewhere in Koha. In my proposal I ignore (Remote)x and only look at z or (My)z. If record z from (My)z is found, I do not check if 001==z and 003==My. Similarly, if record x from (Remote)x would be in our system (which I don't know) we also don't know if 001==x and 003==Remote. Practical question would be too: Do we really want to check all 773 contents and pull all 001, 003s? Since this logic is all about record control number handling in Koha and imo outside the scope of this report, we c/should move further refinements to a new report. But I have doubts about what we should check. This is a discussion on its own.. Thx for your feedback though. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to paxed from comment #19)

in Koha/Biblio.pm, you have:

my $marc = C4::Biblio::GetMarcBiblio($self->biblionumber);

but in C4/Biblio.pm, GetMarcBiblio does this:

my $biblionumber = $params->{biblionumber};

causing:

Can't use string ("11") as a HASH ref while "strict refs" in use at /usr/share/koha/lib/C4/Biblio.pm line 1131.

Yeah, that was changed recently. I wrote the patch originally on 16.11.. And the associated test mocked GetMarcBiblio. So it did not fail. Thx for reporting. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73805|0 |1 is obsolete| | --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 74992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74992&action=edit Bug 20310: Introduce Koha::Biblio->host_record This is a more generic method that allows you to get to the host record as defined in MARC21 field 773$w. Test plan: Run t/db_dependent/Koha/Biblio/host_record.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Maksim Sen <maksim.sen@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74000|0 |1 is obsolete| | --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 74994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74994&action=edit Bug 20310: (follow-up) Allow repeatable $w even without org code As mentioned in the BZ comments, we might expect people to add $w subfields without a MARC organization code. And we should keep in mind that 773 is repeatable, and both $g as well as $w is also repeatable. Added these cases into sub host_record, including tests. Test plan: Run t/db_dependent/Koha/Biblio/host_record.t again Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74992|0 |1 is obsolete| | --- Comment #24 from Hugo Agud <hagud@orex.es> --- Created attachment 88887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88887&action=edit Bug 20310: Introduce Koha::Biblio->host_record This is a more generic method that allows you to get to the host record as defined in MARC21 field 773$w. Test plan: Run t/db_dependent/Koha/Biblio/host_record.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Maksim Sen <maksim.sen@inlibro.com> Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74994|0 |1 is obsolete| | --- Comment #26 from Hugo Agud <hagud@orex.es> --- Created attachment 88889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88889&action=edit Bug 20310: (follow-up) Allow repeatable $w even without org code As mentioned in the BZ comments, we might expect people to add $w subfields without a MARC organization code. And we should keep in mind that 773 is repeatable, and both $g as well as $w is also repeatable. Added these cases into sub host_record, including tests. Test plan: Run t/db_dependent/Koha/Biblio/host_record.t again Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm starting to look at this with a view to QAing... but, as the conversation has gone towards how we deal with multi-part records and 773,001,003 handling it might be helpful to get some peoples thoughts and any updates over on the Wiki: https://wiki.koha-community.org/wiki/Multipart_Bibliographics. Some time ago I tried hard to understand it all with a view to trying to get it 'right' in Koha eventually. It would be lovely for that effort to be picked up again. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- If I understand the code correctly, it assumes the the first $w contains a valid biblionumber, with or without proper prefix. I think this assumption can't hold up. At the moment, we expect in $w a number, that is also in 001 of a matching record. Ideally with a 003 that has the matching prefix, but this is not checked. So: Analytic: $w(MARCOrgCode)rcn Host: 001 rcn 003 MARCOrgCode Actually... we probably should also check 035, but that is a different issue: 035 (MARCOrgCode)rcn In Koha there is no way to automatically enforce 001 = biblionumber. And if you want to do it, it's tedious, as you have to save first to create the biblionumber before you can enter it in 001. There is even a new feature for Rancor, that allows you to create custom 001, that are not relating to biblionumber at all. The risk I see with this feature as is, is that the number from $w might accidentally match a biblionumber. So we would create unwanted redirects. You can't turn it off. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Note: If you use the 'addd child record' feature in Koha, it will copy 001 to $w. While it might not be super fast, maybe we could change the host_record feature to look for a matching 001 instead of just biblionumber? It would make this work along the current assumptions. Also: We should add UNIMARC support. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 --- Comment #34 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 109751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109751&action=edit Bug 20310: Redirect article record without items for article requests If an article record has been catalogued separately, has no items and contains a reference to its host via MARC21 field 773 (host item entry), this patch makes an article request redirect to the host record while copying title, author and page info (from 773$g). This is accomplished by using the new Koha::Biblio->host_record method. Note: Subfield 773$g may contain additional information on volume and issue number etc. It will be very hard or perhaps impossible to parse $g and copy these details into the corresponding fields of the article request form for all possible variations used in libraries. A similar remark can be made for selecting the correct item (when item level is used). We could try this on a future report, but will probably need at least a preference to define the expected format. Test plan: [1] Enable article requests. Add rules for an ART and a SER itemtype. [2] Create a SER host biblio record. [3] Create an ART biblio record, no items. Include a 773w pointing to the SER record with '(MARCorgcode)[recno]' (keep the parentheses, remove the square brackets when inserting the biblionumber). Include text in 773$g too. [4] Place an article request on the ART record. Verify that it redirects you to the SER record while copying title, author, page info. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 --- Comment #36 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 109753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109753&action=edit Bug 20310: Adding a pref to control behavior If people want to control the redirection, we could add a pref like ArticleRequestsHostRedirection. If it is not enabled, the party is over. Test plan: Test if redirection stops on a child and host when you disable. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 --- Comment #38 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #31)

Also: We should add UNIMARC support.

This can be done later (when there is a need). The code in Biblio can be easily extended. We're starting with MARC21 now. Not all features come in all flavors rightaway ;) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109751|0 |1 is obsolete| | --- Comment #41 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 111468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111468&action=edit Bug 20310: Redirect article record without items for article requests If an article record has been catalogued separately, has no items and contains a reference to its host via MARC21 field 773 (host item entry), this patch makes an article request redirect to the host record while copying title, author and page info (from 773$g). This is accomplished by using the new Koha::Biblio->host_record method. Note: Subfield 773$g may contain additional information on volume and issue number etc. It will be very hard or perhaps impossible to parse $g and copy these details into the corresponding fields of the article request form for all possible variations used in libraries. A similar remark can be made for selecting the correct item (when item level is used). We could try this on a future report, but will probably need at least a preference to define the expected format. Test plan: [1] Enable article requests. Add rules for an ART and a SER itemtype. [2] Create a SER host biblio record. [3] Create an ART biblio record, no items. Include a 773w pointing to the SER record with '(MARCorgcode)[recno]' (keep the parentheses, remove the square brackets when inserting the biblionumber). Include text in 773$g too. [4] Place an article request on the ART record. Verify that it redirects you to the SER record while copying title, author, page info. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109753|0 |1 is obsolete| | --- Comment #43 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 111470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111470&action=edit Bug 20310: Adding a pref to control behavior If people want to control the redirection, we could add a pref like ArticleRequestsHostRedirection. If it is not enabled, the party is over. Test plan: Test if redirection stops on a child and host when you disable. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111467|0 |1 is obsolete| | --- Comment #45 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 118976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118976&action=edit Bug 20310: Introduce Koha::Biblio->host_record This is a more generic method that allows you to get to the host record as defined in MARC21 field 773$w. This control number is looked up in the search engine (MARC21 field 001). Note: The current implementation is based on MARC21 and does not change behavior for UNIMARC. This includes the follow-up originally submitted separately on Bugzilla, dealing with multiple 773 fields. Test plan: Run t/db_dependent/Koha/Biblio/host_record.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> https://bugs.koha-community.org/show_bug.cgi?id=20130 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111469|0 |1 is obsolete| | --- Comment #47 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 118978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118978&action=edit Bug 20310: (follow-up) Add or remove orgcode in second try We did remove an orgcode, but we could also do the other way around. Note: Hard to include in the unit test since it mocks the whole search engine part. Test plan: [1] Run t/db_dependent/Koha/Biblio/host_record.t [2] Test host 001 = number and child 773 = (org)number [3] Test host 001 = (org)number and child 773 = number Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> https://bugs.koha-community.org/show_bug.cgi?id=20130 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 --- Comment #49 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 119346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119346&action=edit Bug 20310: (follow-up) Check if biblio exists; 755 host_record.t In order to prevent an error like: Can't call method "host_record" on an undefined value at opac/opac-request-article.pl Also chmod's host_record.t to 755 (File must have the exec flag) Test plan: Change the URL so that the biblionumber does not exist. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize@ptfs-europe |testopia@bugs.koha-communit |.com |y.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 --- Comment #52 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #51)

Oops, I started looking at this on Friday but got pulled away into other things.. I hope to get back to it later this week.

One comment so far however.. I think the 'host_record' relationship accessor could be generalised a little more to make it less specific to this feature and thus adoptable by other uses in the future. I'm happy to undertake this as a QA follow-up. I think we should move the item count test and syspref check out of the module method and into the controllers instead.. as much as this goes against the instinct to make sure it's testable I think this will lead to a much more flexible low level object method... I wonder if we could move the test into the integration tests so it's still caught but at the controller level rather than the object?

Great, Martin. Please note that this patch is already dating from 2018 and unless there are specific developments underway that could directly be tied in, I would prefer to get this further instead of making it more generic for some future development not yet identified. In short, please add some more details or references to other bugs that you have in mind. Thanks for your support. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118977|0 |1 is obsolete| | --- Comment #54 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 122470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122470&action=edit Bug 20310: Redirect article record without items for article requests If an article record has been catalogued separately, has no items and contains a reference to its host via MARC21 field 773 (host item entry), this patch makes an article request redirect to the host record while copying title, author and page info (from 773$g). This is accomplished by using the new Koha::Biblio->host_record method. Note: Subfield 773$g may contain additional information on volume and issue number etc. It will be very hard or perhaps impossible to parse $g and copy these details into the corresponding fields of the article request form for all possible variations used in libraries. A similar remark can be made for selecting the correct item (when item level is used). We could try this on a future report, but will probably need at least a preference to define the expected format. Test plan: [1] Enable article requests. Add rules for an ART and a SER itemtype. [2] Create a SER host biblio record. [3] Create an ART biblio record, no items. Include a 773w pointing to the SER record with '(MARCorgcode)[recno]' (keep the parentheses, remove the square brackets when inserting the biblionumber). Include text in 773$g too. [4] Place an article request on the ART record. Verify that it redirects you to the SER record while copying title, author, page info. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118979|0 |1 is obsolete| | --- Comment #56 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 122472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122472&action=edit Bug 20310: Adding a pref to control behavior If people want to control the redirection, we could add a pref like ArticleRequestsHostRedirection. If it is not enabled, the party is over. Test plan: Test if redirection stops on a child and host when you disable. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 --- Comment #58 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 122474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122474&action=edit Bug 20310: (follow-up) Move syspref check into controller I believe the syspref check is better placed in the controller. This way the host_record method is not so closely tied to the articel requests feature and may subsequently prove useful to future use cases. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 --- Comment #59 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 122475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122475&action=edit Bug 20310: (follow-up) Rename method to get_marc_host This method is a mix of database relationship accessor and marc field accessor. We have get_marc_notes already and other patches in the queue are also starting to introduce get_marc_* named methods. This patch updates the method name to conform with that scheme. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 --- Comment #61 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #60)

This all appears to work reasonably well.. I've not dug deeply into how these patches relate to bug 11175, so that may be worth considering during QA.

Thx for signing off. That is an interesting reference indeed. It adds $biblio->components, actually going the other way around from host to children. Looking for records that contain a 773 with that biblionumber or associated control number. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122469|0 |1 is obsolete| | Attachment #122470|0 |1 is obsolete| | Attachment #122471|0 |1 is obsolete| | Attachment #122472|0 |1 is obsolete| | Attachment #122473|0 |1 is obsolete| | Attachment #122474|0 |1 is obsolete| | Attachment #122475|0 |1 is obsolete| | --- Comment #62 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 122725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122725&action=edit Bug 20310: Introduce Koha::Biblio->host_record This is a more generic method that allows you to get to the host record as defined in MARC21 field 773$w. This control number is looked up in the search engine (MARC21 field 001). Note: The current implementation is based on MARC21 and does not change behavior for UNIMARC. This includes the follow-up originally submitted separately on Bugzilla, dealing with multiple 773 fields. Test plan: Run t/db_dependent/Koha/Biblio/host_record.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 --- Comment #64 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 122727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122727&action=edit Bug 20310: (follow-up) Add or remove orgcode in second try We did remove an orgcode, but we could also do the other way around. Note: Hard to include in the unit test since it mocks the whole search engine part. Test plan: [1] Run t/db_dependent/Koha/Biblio/host_record.t [2] Test host 001 = number and child 773 = (org)number [3] Test host 001 = (org)number and child 773 = number Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 --- Comment #66 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 122729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122729&action=edit Bug 20310: (follow-up) Check if biblio exists; 755 host_record.t In order to prevent an error like: Can't call method "host_record" on an undefined value at opac/opac-request-article.pl Also chmod's host_record.t to 755 (File must have the exec flag) Test plan: Change the URL so that the biblionumber does not exist. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 --- Comment #68 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 122731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122731&action=edit Bug 20310: (follow-up) Rename method to get_marc_host This method is a mix of database relationship accessor and marc field accessor. We have get_marc_notes already and other patches in the queue are also starting to introduce get_marc_* named methods. This patch updates the method name to conform with that scheme. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 --- Comment #70 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Nick Clemens from comment #69)

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Cool. Thanks -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 --- Comment #71 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 --- Comment #73 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Could you add release notes for this Marcel? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This new feature add the release notes| |`ArticleRequestsHostRedirec | |tion` system preference. | | | |When enabled, if a user | |attempts to place an | |article request from an | |analytic record the system | |will automatically populate | |some details in the request | |from using data from the | |host record. Summary|Article requests: Use |Article requests: Can we |details from host record |redirect article records |for article records placed |without items to host |on records without items |record? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Article requests: Can we |Article requests: Use |redirect article records |details from the host |without items to host |record when submitting an |record? |article request on an | |analytic record without | |attached items -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27507 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29441 -- You are receiving this mail because: You are watching all bug changes.