[Bug 15774] New: Additional fields for baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Bug ID: 15774 Summary: Additional fields for baskets Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: jweaver@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: nicole@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Jesse, since we will have 3 different places to configure the additional fields, it would be great to have a configuration page in the admin area to configure all of them on the same page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #2 from Jesse Weaver <jweaver@bywatersolutions.com> --- That's exactly the plan, Jonathan. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #3 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 48224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48224&action=edit Bug 15774: Add additional fields to order baskets This also moves the admin page for additional fields for all tables to a single common screen, and factors out display/input parsing logic. Test plan: 1. Create an additional field for a subscription (under Serials -> Add subscription fields). 2. Apply patch. 3. Visit Additional fields under administration, and verify that the field created above still shows under the list for the subscription table. 4. Create at least four fields for aqbasket for each combination of searchable/not-searchable and with/without an authorized value. 5. Create an order basket, and verify that all fields are visible and correctly save. 6. Edit the basket, verifying that changes to these additional fields are saved. 7. Add an order to the basket (contents are irrelevant). 8. Go to advanced search within acquisitions. 9. Verify that only the searchable fields show in the form, and that their contents may be searched. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11844 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The tablename is not saved when I create a new field for aqbasket. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jweaver@bywatersolutions.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Note that I would prefer to this patch based on top of bug 11844. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #6 from Jesse Weaver <jweaver@bywatersolutions.com> --- I'll fix these issues, but could I ask you to prepare a patch to rebase bug 11844? There's a bit of mucking around that has to be done that I'd prefer was done by somebody familiar with the code. I'll happily QA it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have changed the status of bug 11844 to "does not apply". Hopefully Julian will rebase it quickly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amy@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48224|0 |1 is obsolete| | --- Comment #8 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 53608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53608&action=edit Bug 15774: Add additional fields to order baskets This also moves the admin page for additional fields for all tables to a single common screen, and factors out display/input parsing logic. Test plan: 1. Create an additional field for a subscription (under Serials -> Add subscription fields). 2. Apply patch. 3. Visit Additional fields under administration, and verify that the field created above still shows under the list for the subscription table. 4. Create at least four fields for aqbasket for each combination of searchable/not-searchable and with/without an authorized value. 5. Create an order basket, and verify that all fields are visible and correctly save. 6. Edit the basket, verifying that changes to these additional fields are saved. 7. Add an order to the basket (contents are irrelevant). 8. Go to advanced search within acquisitions. 9. Verify that only the searchable fields show in the form, and that their contents may be searched. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #9 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 53609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53609&action=edit Bug 15774: (QA followup) Make sure that tablename is correctly saved This should fix QA issues, rebasing 11844 shortly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11844 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 [Bug 11844] Additional fields for order lines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- QA comments: 1/ Regression: On serials/serials-search.pl, the filters are not filled with what the users searched for and the additional fields linked to an AV are not displayed as a dropdown list. 2/ What does mean an additional field linked to a MARC field for aqbasket? I think that this option should be hidden for this table (additional fields admin page, /acqui/histsearch.pl, add basket page, etc.) 3/ No test coverage for update_fields_from_query, get_filters_from_query and get_filters_as_values. 4/ When searching an order, there is no way not to set a "all" value for additional fields linked to AV. 5/ When searching an order and the search does not return any results, the field should contain what the user filled in. 6/ update_fields_from_query and get_filters_from_query should not deal with the CGI object. It would be better to pass the relevant variables instead. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jweaver@bywatersolutions.co |nick@bywatersolutions.com |m | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can this be rescued? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Patrick Robitaille <patrick.robitaille@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@collecto | |.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53608|0 |1 is obsolete| | --- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 72078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72078&action=edit Bug 15774: Add additional fields to order baskets This also moves the admin page for additional fields for all tables to a single common screen, and factors out display/input parsing logic. Test plan: 1. Create an additional field for a subscription (under Serials -> Add subscription fields). 2. Apply patch. 3. Visit Additional fields under administration, and verify that the field created above still shows under the list for the subscription table. 4. Create at least four fields for aqbasket for each combination of searchable/not-searchable and with/without an authorized value. 5. Create an order basket, and verify that all fields are visible and correctly save. 6. Edit the basket, verifying that changes to these additional fields are saved. 7. Add an order to the basket (contents are irrelevant). 8. Go to advanced search within acquisitions. 9. Verify that only the searchable fields show in the form, and that their contents may be searched. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53609|0 |1 is obsolete| | --- Comment #13 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 72079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72079&action=edit Bug 15774: (QA followup) Make sure that tablename is correctly saved -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #14 from Julian Maurice <julian.maurice@biblibre.com> --- Patches rebased on master QA comments in comment 10 still need to be addressed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #15 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 72085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72085&action=edit Bug 15774: Fix AV categories dropdown list in admin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #16 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 72086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72086&action=edit Bug 15774: Fix additional fields filters Addresses the following QA comments: 1/ Regression: On serials/serials-search.pl, the filters are not filled with what the users searched for and the additional fields linked to an AV are not displayed as a dropdown list. 4/ When searching an order, there is no way not to set a "all" value for additional fields linked to AV. 5/ When searching an order and the search does not return any results, the field should contain what the user filled in. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774#c10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #17 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Jonathan Druart from comment #10)
2/ What does mean an additional field linked to a MARC field for aqbasket? I think that this option should be hidden for this table (additional fields admin page, /acqui/histsearch.pl, add basket page, etc.)
I think we should answer to that before fixing the other issues. Changing status to In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- I agree with Jonathan, I don't think that option makes sense and should be hidden/disabled for basket fields. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Great - follow up patch? :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #19)
Great - follow up patch? :)
Will attempt, having some issues in the code right now, will dig later -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72078|0 |1 is obsolete| | --- Comment #21 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 75083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75083&action=edit Bug 15774: Add additional fields to order baskets This also moves the admin page for additional fields for all tables to a single common screen, and factors out display/input parsing logic. Test plan: 1. Create an additional field for a subscription (under Serials -> Add subscription fields). 2. Apply patch. 3. Visit Additional fields under administration, and verify that the field created above still shows under the list for the subscription table. 4. Create at least four fields for aqbasket for each combination of searchable/not-searchable and with/without an authorized value. 5. Create an order basket, and verify that all fields are visible and correctly save. 6. Edit the basket, verifying that changes to these additional fields are saved. 7. Add an order to the basket (contents are irrelevant). 8. Go to advanced search within acquisitions. 9. Verify that only the searchable fields show in the form, and that their contents may be searched. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72079|0 |1 is obsolete| | --- Comment #22 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 75084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75084&action=edit Bug 15774: (QA followup) Make sure that tablename is correctly saved -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72086|0 |1 is obsolete| | --- Comment #23 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 75085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75085&action=edit Bug 15774: Fix additional fields filters Addresses the following QA comments: 1/ Regression: On serials/serials-search.pl, the filters are not filled with what the users searched for and the additional fields linked to an AV are not displayed as a dropdown list. 4/ When searching an order, there is no way not to set a "all" value for additional fields linked to AV. 5/ When searching an order and the search does not return any results, the field should contain what the user filled in. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774#c10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #24 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 75086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75086&action=edit Bug 15774: Use Koha::Object(s) for additional fields A lot of code can be removed just by using Koha::Object It also makes fetching and updating additional field values easier. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #25 from Julian Maurice <julian.maurice@biblibre.com> --- Patches rebased on master + new patch (attachment 75086) Reset bug status to Needs signoff since the last patch brings a lot of changes. To test, use test plan from comment 21 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #26 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 75336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75336&action=edit Bug 15774: Add POD and license notices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #27 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 75354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75354&action=edit Bug 15774: Show additional field values in edit form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72085|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75354|0 |1 is obsolete| | --- Comment #28 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 75361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75361&action=edit Bug 15774: Show additional field values in edit form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- i tried to rebase this... but failed :( The method Koha::Subscription->additional_field_values is not covered by tests! Nick, could you give this a go? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75083|0 |1 is obsolete| | Attachment #75084|0 |1 is obsolete| | Attachment #75085|0 |1 is obsolete| | Attachment #75086|0 |1 is obsolete| | Attachment #75336|0 |1 is obsolete| | Attachment #75361|0 |1 is obsolete| | --- Comment #30 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 79976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79976&action=edit Bug 15774: Add additional fields to order baskets This also moves the admin page for additional fields for all tables to a single common screen, and factors out display/input parsing logic. Test plan: 1. Create an additional field for a subscription (under Serials -> Add subscription fields). 2. Apply patch. 3. Visit Additional fields under administration, and verify that the field created above still shows under the list for the subscription table. 4. Create at least four fields for aqbasket for each combination of searchable/not-searchable and with/without an authorized value. 5. Create an order basket, and verify that all fields are visible and correctly save. 6. Edit the basket, verifying that changes to these additional fields are saved. 7. Add an order to the basket (contents are irrelevant). 8. Go to advanced search within acquisitions. 9. Verify that only the searchable fields show in the form, and that their contents may be searched. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #31 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 79977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79977&action=edit Bug 15774: (QA follow-up) Make sure that tablename is correctly saved -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #32 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 79978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79978&action=edit Bug 15774: Fix additional fields filters Addresses the following QA comments: 1/ Regression: On serials/serials-search.pl, the filters are not filled with what the users searched for and the additional fields linked to an AV are not displayed as a dropdown list. 4/ When searching an order, there is no way not to set a "all" value for additional fields linked to AV. 5/ When searching an order and the search does not return any results, the field should contain what the user filled in. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774#c10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #33 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 79979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79979&action=edit Bug 15774: Use Koha::Object(s) for additional fields A lot of code can be removed just by using Koha::Object It also makes fetching and updating additional field values easier. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #34 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 79980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79980&action=edit Bug 15774: Add POD and license notices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #35 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 79981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79981&action=edit Bug 15774: Show additional field values in edit form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #36 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 79982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79982&action=edit Bug 15774: (follow-up) Add html filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79976|0 |1 is obsolete| | --- Comment #37 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 80060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80060&action=edit Bug 15774: Add additional fields to order baskets This also moves the admin page for additional fields for all tables to a single common screen, and factors out display/input parsing logic. Test plan: 1. Create an additional field for a subscription (under Serials -> Add subscription fields). 2. Apply patch. 3. Visit Additional fields under administration, and verify that the field created above still shows under the list for the subscription table. 4. Create at least four fields for aqbasket for each combination of searchable/not-searchable and with/without an authorized value. 5. Create an order basket, and verify that all fields are visible and correctly save. 6. Edit the basket, verifying that changes to these additional fields are saved. 7. Add an order to the basket (contents are irrelevant). 8. Go to advanced search within acquisitions. 9. Verify that only the searchable fields show in the form, and that their contents may be searched. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79977|0 |1 is obsolete| | --- Comment #38 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 80061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80061&action=edit Bug 15774: (QA follow-up) Make sure that tablename is correctly saved Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79978|0 |1 is obsolete| | --- Comment #39 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 80062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80062&action=edit Bug 15774: Fix additional fields filters Addresses the following QA comments: 1/ Regression: On serials/serials-search.pl, the filters are not filled with what the users searched for and the additional fields linked to an AV are not displayed as a dropdown list. 4/ When searching an order, there is no way not to set a "all" value for additional fields linked to AV. 5/ When searching an order and the search does not return any results, the field should contain what the user filled in. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774#c10 Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79979|0 |1 is obsolete| | --- Comment #40 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 80063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80063&action=edit Bug 15774: Use Koha::Object(s) for additional fields A lot of code can be removed just by using Koha::Object It also makes fetching and updating additional field values easier. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79980|0 |1 is obsolete| | --- Comment #41 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 80064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80064&action=edit Bug 15774: Add POD and license notices Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79981|0 |1 is obsolete| | --- Comment #42 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 80065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80065&action=edit Bug 15774: Show additional field values in edit form Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79982|0 |1 is obsolete| | --- Comment #43 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 80066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80066&action=edit Bug 15774: (follow-up) Add html filters Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #44 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 80680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80680&action=edit Bug 15774: Fix JS check when AV and MARC field are both selected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #45 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- * Tests missing for GetHistory * + my $rs = Koha::Database->new->schema->resultset('AdditionalFieldValue'); must be Koha::AdditionalFieldValue instead. I would suggest to have a look at Koha::Patron::Category and how the 'branch_limitation' add/update/remove is done, in order to follow an existing pattern * additional_field_values must return a Koha::Objects * Should not search_additional_fields be more search_*by*_additional_fields? I think we agreed on "filter_by_*" somewhere else (Martin?) * + # TODO Add column additional_field_values.tablename to avoid subquery ? I do not think it is relevant, we want the tablename at additional_fields level * + for my $field (Koha::AdditionalFields->search({ tablename => 'aqbasket' })) { Better to use while ->next instead These patches are great, please provide a quick follow-up and we will make it part of 18.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #46 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think search_by doesn't sound quite right... search_on? search_in? Native speaker? :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #47 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- How's about 'filter_by' as per the suggestions/discussion over on bug 11983 ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #48 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Katrin Fischer from comment #46)
I think search_by doesn't sound quite right... search_on? search_in? Native speaker? :)
search_for? I don't like filter_by, because filter_by suggests we are taking a given set and shrinking it. No such thing is passed. We are searching, but it is limited for a particular set of conditions. The rest would describe the condition. And why not just get_by_marc_field (would do tagfield, but tagsubfield is included, I believe), get_by_kohafield? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80060|0 |1 is obsolete| | Attachment #80061|0 |1 is obsolete| | Attachment #80062|0 |1 is obsolete| | Attachment #80063|0 |1 is obsolete| | Attachment #80064|0 |1 is obsolete| | Attachment #80065|0 |1 is obsolete| | Attachment #80066|0 |1 is obsolete| | Attachment #80680|0 |1 is obsolete| | --- Comment #49 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 81490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81490&action=edit Bug 15774: Add additional fields to order baskets This also moves the admin page for additional fields for all tables to a single common screen, and factors out display/input parsing logic. Test plan: 1. Create an additional field for a subscription (under Serials -> Add subscription fields). 2. Apply patch. 3. Visit Additional fields under administration, and verify that the field created above still shows under the list for the subscription table. 4. Create at least four fields for aqbasket for each combination of searchable/not-searchable and with/without an authorized value. 5. Create an order basket, and verify that all fields are visible and correctly save. 6. Edit the basket, verifying that changes to these additional fields are saved. 7. Add an order to the basket (contents are irrelevant). 8. Go to advanced search within acquisitions. 9. Verify that only the searchable fields show in the form, and that their contents may be searched. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #50 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 81491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81491&action=edit Bug 15774: (QA follow-up) Make sure that tablename is correctly saved Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #51 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 81492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81492&action=edit Bug 15774: Fix additional fields filters Addresses the following QA comments: 1/ Regression: On serials/serials-search.pl, the filters are not filled with what the users searched for and the additional fields linked to an AV are not displayed as a dropdown list. 4/ When searching an order, there is no way not to set a "all" value for additional fields linked to AV. 5/ When searching an order and the search does not return any results, the field should contain what the user filled in. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774#c10 Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #52 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 81493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81493&action=edit Bug 15774: Use Koha::Object(s) for additional fields A lot of code can be removed just by using Koha::Object It also makes fetching and updating additional field values easier. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #53 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 81494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81494&action=edit Bug 15774: Add POD and license notices Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #54 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 81495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81495&action=edit Bug 15774: Show additional field values in edit form Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #55 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 81496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81496&action=edit Bug 15774: (follow-up) Add html filters Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #56 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 81497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81497&action=edit Bug 15774: Fix JS check when AV and MARC field are both selected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #57 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to M. Tompsett from comment #48)
(In reply to Katrin Fischer from comment #46)
I think search_by doesn't sound quite right... search_on? search_in? Native speaker? :)
search_for? I don't like filter_by, because filter_by suggests we are taking a given set and shrinking it. No such thing is passed. We are searching, but it is limited for a particular set of conditions. The rest would describe the condition. And why not just get_by_marc_field (would do tagfield, but tagsubfield is included, I believe), get_by_kohafield?
But you are filtering... you pass in a resultset (whether that be a new one or an existing already partially filtered one) and then refine it by filtering down... We're trying to bring consistency to the objects, so to me filter_by which is already being discussed elsewhere seems to make sense. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #58 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 81833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81833&action=edit Bug 15774: (follow-up) Address QA issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81490|0 |1 is obsolete| | Attachment #81491|0 |1 is obsolete| | Attachment #81492|0 |1 is obsolete| | Attachment #81493|0 |1 is obsolete| | Attachment #81494|0 |1 is obsolete| | Attachment #81495|0 |1 is obsolete| | Attachment #81496|0 |1 is obsolete| | Attachment #81497|0 |1 is obsolete| | Attachment #81833|0 |1 is obsolete| | --- Comment #59 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81837&action=edit Bug 15774: Add additional fields to order baskets This also moves the admin page for additional fields for all tables to a single common screen, and factors out display/input parsing logic. Test plan: 1. Create an additional field for a subscription (under Serials -> Add subscription fields). 2. Apply patch. 3. Visit Additional fields under administration, and verify that the field created above still shows under the list for the subscription table. 4. Create at least four fields for aqbasket for each combination of searchable/not-searchable and with/without an authorized value. 5. Create an order basket, and verify that all fields are visible and correctly save. 6. Edit the basket, verifying that changes to these additional fields are saved. 7. Add an order to the basket (contents are irrelevant). 8. Go to advanced search within acquisitions. 9. Verify that only the searchable fields show in the form, and that their contents may be searched. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #60 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81838&action=edit Bug 15774: (QA follow-up) Make sure that tablename is correctly saved Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #61 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81839&action=edit Bug 15774: Fix additional fields filters Addresses the following QA comments: 1/ Regression: On serials/serials-search.pl, the filters are not filled with what the users searched for and the additional fields linked to an AV are not displayed as a dropdown list. 4/ When searching an order, there is no way not to set a "all" value for additional fields linked to AV. 5/ When searching an order and the search does not return any results, the field should contain what the user filled in. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774#c10 Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #62 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81840&action=edit Bug 15774: Use Koha::Object(s) for additional fields A lot of code can be removed just by using Koha::Object It also makes fetching and updating additional field values easier. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #63 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81841&action=edit Bug 15774: Add POD and license notices Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #64 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81842&action=edit Bug 15774: Show additional field values in edit form Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #65 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81843&action=edit Bug 15774: (follow-up) Add html filters Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #66 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81844&action=edit Bug 15774: Fix JS check when AV and MARC field are both selected Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #67 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81845&action=edit Bug 15774: (follow-up) Address QA issues Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #68 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81846&action=edit Bug 15774: Use the include file to display the subscription's additional fields We have it, why not to use it? Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #69 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81847&action=edit Bug 15774: Fix insert and update for subscription Call it a typo Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #70 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81848&action=edit Bug 15774: Add missing tests for GetSubscription Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #71 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81849&action=edit Bug 15774: Add missing tests for Koha::Object::Mixin::AdditionalFields Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #72 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81850&action=edit Bug 15774: Fix and unify additional_fields in C4::Serials Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #73 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81851&action=edit Bug 15774: Do not fetch additional fields from GetSubscription Finally we do not want that, they should be fetch when needed Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #74 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81852&action=edit Bug 15774: Remove unecessary returned value for ->delete Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81848|0 |1 is obsolete| | --- Comment #75 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 81848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81848 Bug 15774: Add missing tests for GetSubscription We finally do not need that I'd say. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #76 from Nick Clemens <nick@bywatersolutions.com> --- This needs a new permission now to reflect changes made by 14391 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #77 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Nick Clemens from comment #76)
This needs a new permission now to reflect changes made by 14391
Hm, are these under administration now? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_18_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #78 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Some conflicts: CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/histsearch.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/histsearch.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc Auto-merging admin/additional-fields.pl Auto-merging acqui/histsearch.pl CONFLICT (content): Merge conflict in acqui/histsearch.pl Auto-merging acqui/basket.pl Auto-merging C4/Acquisition.pm CONFLICT (content): Merge conflict in C4/Acquisition.pm error: Failed to merge in the changes. For permissions: Until this patch everyone with any serials permission could add/update additional fields: { serials => '*' }, It's a little hard to find a good pref for a feature that spans multiple-modules now. I think a new admin permission might make the most sense. Then update patrons with serials permissions to have that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #79 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Patches rebased: https://gitlab.com/joubu/Koha/commits/bug_15774 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81837|0 |1 is obsolete| | Attachment #81838|0 |1 is obsolete| | Attachment #81839|0 |1 is obsolete| | Attachment #81840|0 |1 is obsolete| | Attachment #81841|0 |1 is obsolete| | Attachment #81842|0 |1 is obsolete| | Attachment #81843|0 |1 is obsolete| | Attachment #81844|0 |1 is obsolete| | Attachment #81845|0 |1 is obsolete| | Attachment #81846|0 |1 is obsolete| | Attachment #81847|0 |1 is obsolete| | Attachment #81849|0 |1 is obsolete| | Attachment #81850|0 |1 is obsolete| | Attachment #81851|0 |1 is obsolete| | Attachment #81852|0 |1 is obsolete| | --- Comment #80 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83349&action=edit Bug 15774: Add additional fields to order baskets This also moves the admin page for additional fields for all tables to a single common screen, and factors out display/input parsing logic. Test plan: 1. Create an additional field for a subscription (under Serials -> Add subscription fields). 2. Apply patch. 3. Visit Additional fields under administration, and verify that the field created above still shows under the list for the subscription table. 4. Create at least four fields for aqbasket for each combination of searchable/not-searchable and with/without an authorized value. 5. Create an order basket, and verify that all fields are visible and correctly save. 6. Edit the basket, verifying that changes to these additional fields are saved. 7. Add an order to the basket (contents are irrelevant). 8. Go to advanced search within acquisitions. 9. Verify that only the searchable fields show in the form, and that their contents may be searched. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #81 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83350&action=edit Bug 15774: (QA follow-up) Make sure that tablename is correctly saved Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #82 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83351&action=edit Bug 15774: Fix additional fields filters Addresses the following QA comments: 1/ Regression: On serials/serials-search.pl, the filters are not filled with what the users searched for and the additional fields linked to an AV are not displayed as a dropdown list. 4/ When searching an order, there is no way not to set a "all" value for additional fields linked to AV. 5/ When searching an order and the search does not return any results, the field should contain what the user filled in. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774#c10 Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #83 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83352&action=edit Bug 15774: Use Koha::Object(s) for additional fields A lot of code can be removed just by using Koha::Object It also makes fetching and updating additional field values easier. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #84 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83353&action=edit Bug 15774: Add POD and license notices Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #85 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83354&action=edit Bug 15774: Show additional field values in edit form Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #86 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83355&action=edit Bug 15774: (follow-up) Add html filters Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #87 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83356&action=edit Bug 15774: Fix JS check when AV and MARC field are both selected Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #88 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83357&action=edit Bug 15774: (follow-up) Address QA issues Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #89 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83358&action=edit Bug 15774: Use the include file to display the subscription's additional fields We have it, why not to use it? Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #90 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83359&action=edit Bug 15774: Fix insert and update for subscription Call it a typo Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #91 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83360&action=edit Bug 15774: Add missing tests for Koha::Object::Mixin::AdditionalFields Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #92 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83361&action=edit Bug 15774: Fix and unify additional_fields in C4::Serials Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #93 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83362&action=edit Bug 15774: Do not fetch additional fields from GetSubscription Finally we do not want that, they should be fetch when needed Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #94 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83363&action=edit Bug 15774: Remove unecessary returned value for ->delete Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #95 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83364&action=edit Bug 15774: Add permission for managing additional fields To test: 1 - Have three borrowers, one with order_manage permission, one with edit_subscription permisson, andone with both 2 - Apply patch, updatedatabase 3 - Verify all three now have the manage_additional_fields permission 4 - Visit the admin page with these users, they should all see the 'Manage additional fields' link 5 - Click the link 6 - User with order_manage should see 'Order baskest' 7 - User with edit_subscription should see 'Subscriptions' 8 - User with both should see both 9 - Remove the additional permissions from a user - they should see a note about needing additional permissions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #96 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 83364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83364 Bug 15774: Add permission for managing additional fields Review of attachment 83364: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15774&attachment=83364) ----------------------------------------------------------------- Hi Nick, I like he approach of the new permission depending on order_manage and edit_subscription, but I think it's not quite ready yet. Trying to comment with Splinter. 1) You need to update installer/data/mysql/userpermissions.sql so the permission is installed for new installations. ::: admin/additional-fields.pl @@ +33,5 @@
+my $op = $input->param('op') // ( $tablename ? 'list' : 'list_tables' ); + +if( $op ne 'list_tables' ){ + $flagsrequired{acquisition} = 'order_manage' if $tablename eq 'aqbasket'; + $flagsrequired{serials} = 'edit_subscription' if $tablename eq 'subscription';
2) I think you'd want to change this to use the new permission now. ::: installer/data/mysql/atomicupdate/Bug_15774_add_additional_fields_permissions.perl @@ +6,5 @@
+ (3,'manage_additional_fields','Add, edit, or delete additional custom fields for baskets or subscriptions (also requires order_manage or edit_subscription permissions)') + }); + $dbh->do( q{ + INSERT INTO user_permissions (borrowernumber, module_bit, code) + SELECT borrowernumber, 3, 'manage_additional_fields' FROM borrowers WHERE borrowernumber IN (SELECT DISTINCT borrowernumber FROM user_permissions WHERE code = 'order_manage' OR code = 'edit_subscription');
3) This will work for everyone who has not full Serials permission. If the top level "Serials" permission is checked, the granular ones are not in user_permissions. You also need to check for those using the bit operation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83349|0 |1 is obsolete| | Attachment #83350|0 |1 is obsolete| | Attachment #83351|0 |1 is obsolete| | Attachment #83352|0 |1 is obsolete| | Attachment #83353|0 |1 is obsolete| | Attachment #83354|0 |1 is obsolete| | Attachment #83355|0 |1 is obsolete| | Attachment #83356|0 |1 is obsolete| | Attachment #83357|0 |1 is obsolete| | Attachment #83358|0 |1 is obsolete| | Attachment #83359|0 |1 is obsolete| | Attachment #83360|0 |1 is obsolete| | Attachment #83361|0 |1 is obsolete| | Attachment #83362|0 |1 is obsolete| | Attachment #83363|0 |1 is obsolete| | Attachment #83364|0 |1 is obsolete| | --- Comment #97 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83444&action=edit Bug 15774: Add additional fields to order baskets This also moves the admin page for additional fields for all tables to a single common screen, and factors out display/input parsing logic. Test plan: 1. Create an additional field for a subscription (under Serials -> Add subscription fields). 2. Apply patch. 3. Visit Additional fields under administration, and verify that the field created above still shows under the list for the subscription table. 4. Create at least four fields for aqbasket for each combination of searchable/not-searchable and with/without an authorized value. 5. Create an order basket, and verify that all fields are visible and correctly save. 6. Edit the basket, verifying that changes to these additional fields are saved. 7. Add an order to the basket (contents are irrelevant). 8. Go to advanced search within acquisitions. 9. Verify that only the searchable fields show in the form, and that their contents may be searched. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #98 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83445&action=edit Bug 15774: (QA follow-up) Make sure that tablename is correctly saved Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #99 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83446&action=edit Bug 15774: Fix additional fields filters Addresses the following QA comments: 1/ Regression: On serials/serials-search.pl, the filters are not filled with what the users searched for and the additional fields linked to an AV are not displayed as a dropdown list. 4/ When searching an order, there is no way not to set a "all" value for additional fields linked to AV. 5/ When searching an order and the search does not return any results, the field should contain what the user filled in. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774#c10 Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #100 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83447&action=edit Bug 15774: Use Koha::Object(s) for additional fields A lot of code can be removed just by using Koha::Object It also makes fetching and updating additional field values easier. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #101 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83448&action=edit Bug 15774: Add POD and license notices Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #102 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83449&action=edit Bug 15774: Show additional field values in edit form Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #103 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83450&action=edit Bug 15774: (follow-up) Add html filters Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #104 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83451&action=edit Bug 15774: Fix JS check when AV and MARC field are both selected Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #105 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83452&action=edit Bug 15774: (follow-up) Address QA issues Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #106 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83453&action=edit Bug 15774: Use the include file to display the subscription's additional fields We have it, why not to use it? Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #107 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83454&action=edit Bug 15774: Fix insert and update for subscription Call it a typo Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #108 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83455&action=edit Bug 15774: Add missing tests for Koha::Object::Mixin::AdditionalFields Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #109 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83456&action=edit Bug 15774: Fix and unify additional_fields in C4::Serials Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #110 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83457&action=edit Bug 15774: Do not fetch additional fields from GetSubscription Finally we do not want that, they should be fetch when needed Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #111 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83458&action=edit Bug 15774: Remove unecessary returned value for ->delete Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #112 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83459&action=edit Bug 15774: Add permission for managing additional fields To test: 1 - Have three borrowers, one with order_manage permission, one with edit_subscription permisson, andone with both 2 - Apply patch, updatedatabase 3 - Verify all three now have the manage_additional_fields permission 4 - Visit the admin page with these users, they should all see the 'Manage additional fields' link 5 - Click the link 6 - User with order_manage should see 'Order baskest' 7 - User with edit_subscription should see 'Subscriptions' 8 - User with both should see both 9 - Remove the additional permissions from a user - they should see a note about needing additional permissions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #113 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- ah, I think I understand 2) now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #114 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #96)
I like the approach of the new permission depending on order_manage and edit_subscription Excellent!
1) You need to update installer/data/mysql/userpermissions.sql so the permission is installed for new installations. Done!
::: admin/additional-fields.pl @@ +33,5 @@
+my $op = $input->param('op') // ( $tablename ? 'list' : 'list_tables' ); + +if( $op ne 'list_tables' ){ + $flagsrequired{acquisition} = 'order_manage' if $tablename eq 'aqbasket'; + $flagsrequired{serials} = 'edit_subscription' if $tablename eq 'subscription';
2) I think you'd want to change this to use the new permission now. I do set it in the lines above - the main permission gets you to the page, you need the others to access the individual modules
::: installer/data/mysql/atomicupdate/ Bug_15774_add_additional_fields_permissions.perl @@ +6,5 @@
+ (3,'manage_additional_fields','Add, edit, or delete additional custom fields for baskets or subscriptions (also requires order_manage or edit_subscription permissions)') + }); + $dbh->do( q{ + INSERT INTO user_permissions (borrowernumber, module_bit, code) + SELECT borrowernumber, 3, 'manage_additional_fields' FROM borrowers WHERE borrowernumber IN (SELECT DISTINCT borrowernumber FROM user_permissions WHERE code = 'order_manage' OR code = 'edit_subscription');
3) This will work for everyone who has not full Serials permission. If the top level "Serials" permission is checked, the granular ones are not in user_permissions. You also need to check for those using the bit operation.
Updated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_18_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #115 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, but there are some conflicts. Please rebase, I'll try to come back to this soon: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 15774: Add additional fields to order baskets Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/includes/serials-menu.inc M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt M koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt M koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt M koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt M serials/serials-search.pl M serials/subscription-add.pl Falling back to patching base and 3-way merge... Auto-merging serials/subscription-add.pl CONFLICT (content): Merge conflict in serials/subscription-add.pl Auto-merging serials/serials-search.pl CONFLICT (content): Merge conflict in serials/serials-search.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt Removing koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/serials-menu.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/serials-menu.inc Auto-merging admin/additional-fields.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 15774: Add additional fields to order baskets The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-15774-Add-additional-fields-to-order-baskets-LGaSot.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83444|0 |1 is obsolete| | Attachment #83445|0 |1 is obsolete| | Attachment #83446|0 |1 is obsolete| | Attachment #83447|0 |1 is obsolete| | Attachment #83448|0 |1 is obsolete| | Attachment #83449|0 |1 is obsolete| | Attachment #83450|0 |1 is obsolete| | Attachment #83451|0 |1 is obsolete| | Attachment #83452|0 |1 is obsolete| | Attachment #83453|0 |1 is obsolete| | Attachment #83454|0 |1 is obsolete| | Attachment #83455|0 |1 is obsolete| | Attachment #83456|0 |1 is obsolete| | Attachment #83457|0 |1 is obsolete| | Attachment #83458|0 |1 is obsolete| | Attachment #83459|0 |1 is obsolete| | --- Comment #116 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 85333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85333&action=edit Bug 15774: Add additional fields to order baskets This also moves the admin page for additional fields for all tables to a single common screen, and factors out display/input parsing logic. Test plan: 1. Create an additional field for a subscription (under Serials -> Add subscription fields). 2. Apply patch. 3. Visit Additional fields under administration, and verify that the field created above still shows under the list for the subscription table. 4. Create at least four fields for aqbasket for each combination of searchable/not-searchable and with/without an authorized value. 5. Create an order basket, and verify that all fields are visible and correctly save. 6. Edit the basket, verifying that changes to these additional fields are saved. 7. Add an order to the basket (contents are irrelevant). 8. Go to advanced search within acquisitions. 9. Verify that only the searchable fields show in the form, and that their contents may be searched. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #117 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 85334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85334&action=edit Bug 15774: (QA follow-up) Make sure that tablename is correctly saved Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #118 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 85335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85335&action=edit Bug 15774: Fix additional fields filters Addresses the following QA comments: 1/ Regression: On serials/serials-search.pl, the filters are not filled with what the users searched for and the additional fields linked to an AV are not displayed as a dropdown list. 4/ When searching an order, there is no way not to set a "all" value for additional fields linked to AV. 5/ When searching an order and the search does not return any results, the field should contain what the user filled in. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774#c10 Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #119 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 85336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85336&action=edit Bug 15774: Use Koha::Object(s) for additional fields A lot of code can be removed just by using Koha::Object It also makes fetching and updating additional field values easier. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #120 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 85337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85337&action=edit Bug 15774: Add POD and license notices Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #121 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 85338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85338&action=edit Bug 15774: Show additional field values in edit form Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #122 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 85339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85339&action=edit Bug 15774: (follow-up) Add html filters Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #123 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 85340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85340&action=edit Bug 15774: Fix JS check when AV and MARC field are both selected Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #124 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 85341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85341&action=edit Bug 15774: (follow-up) Address QA issues Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #125 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 85342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85342&action=edit Bug 15774: Use the include file to display the subscription's additional fields We have it, why not to use it? Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #126 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 85343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85343&action=edit Bug 15774: Fix insert and update for subscription Call it a typo Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #127 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 85344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85344&action=edit Bug 15774: Add missing tests for Koha::Object::Mixin::AdditionalFields Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #128 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 85345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85345&action=edit Bug 15774: Fix and unify additional_fields in C4::Serials Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #129 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 85346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85346&action=edit Bug 15774: Do not fetch additional fields from GetSubscription Finally we do not want that, they should be fetch when needed Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #130 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 85347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85347&action=edit Bug 15774: Remove unecessary returned value for ->delete Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #131 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 85348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85348&action=edit Bug 15774: Add permission for managing additional fields To test: 1 - Have three borrowers, one with order_manage permission, one with edit_subscription permisson, andone with both 2 - Apply patch, updatedatabase 3 - Verify all three now have the manage_additional_fields permission 4 - Visit the admin page with these users, they should all see the 'Manage additional fields' link 5 - Click the link 6 - User with order_manage should see 'Order baskest' 7 - User with edit_subscription should see 'Subscriptions' 8 - User with both should see both 9 - Remove the additional permissions from a user - they should see a note about needing additional permissions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com Status|Signed Off |Failed QA --- Comment #132 from Josef Moravec <josef.moravec@gmail.com> --- Sorry, but QA tools are not happy: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/additional-fields.tt FAIL forbidden patterns forbidden pattern: Attribute type should not be used for script tags (bug 20053) (line 180) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt FAIL forbidden patterns forbidden pattern: merge marker (=======) (line 212) forbidden pattern: merge marker (>>>>>>>) (line 214) forbidden pattern: merge marker (<<<<<<<) (line 206) FAIL valid_template parse error - /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt line 225: unexpected end of input FAIL serials/serials-search.pl FAIL valid serials/serials-search.pl had compilation errors. Global symbol "$additional_fields" requires explicit package name (did you forget to declare "my $additional_fields"?) Global symbol "$additional_field_filters" requires explicit package name (did you forget to declare "my $additional_field_filters"?) Also, I have one concern: this patchset does much more than this report describes. I would like to see, at least the refactoring part of this code (change to Koha::Object and adapt current codebase on it) as own report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #133 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Josef Moravec from comment #132)
Also, I have one concern: this patchset does much more than this report describes. I would like to see, at least the refactoring part of this code (change to Koha::Object and adapt current codebase on it) as own report.
The patch set is huge, and the dependency with bug 11844 tricky. I would not suggest such changes as we may broke everything (again). What advantage(s) could it bring here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #134 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- /broke/break/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off Patch complexity|Medium patch |Large patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #135 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 85792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85792&action=edit Bug 15774: (follow-up) fix rebase issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #136 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Josef Moravec from comment #132)
Sorry, but QA tools are not happy:
Fixed QA tool errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #137 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Jonathan Druart from comment #133)
(In reply to Josef Moravec from comment #132)
Also, I have one concern: this patchset does much more than this report describes. I would like to see, at least the refactoring part of this code (change to Koha::Object and adapt current codebase on it) as own report.
The patch set is huge, and the dependency with bug 11844 tricky. I would not suggest such changes as we may broke everything (again).
What advantage(s) could it bring here?
Thanks for discussion, I will not block it then. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85333|0 |1 is obsolete| | Attachment #85334|0 |1 is obsolete| | Attachment #85335|0 |1 is obsolete| | Attachment #85336|0 |1 is obsolete| | Attachment #85337|0 |1 is obsolete| | Attachment #85338|0 |1 is obsolete| | Attachment #85339|0 |1 is obsolete| | Attachment #85340|0 |1 is obsolete| | Attachment #85341|0 |1 is obsolete| | Attachment #85342|0 |1 is obsolete| | Attachment #85343|0 |1 is obsolete| | Attachment #85344|0 |1 is obsolete| | Attachment #85345|0 |1 is obsolete| | Attachment #85346|0 |1 is obsolete| | Attachment #85347|0 |1 is obsolete| | Attachment #85348|0 |1 is obsolete| | Attachment #85792|0 |1 is obsolete| | --- Comment #138 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85806&action=edit Bug 15774: Add additional fields to order baskets This also moves the admin page for additional fields for all tables to a single common screen, and factors out display/input parsing logic. Test plan: 1. Create an additional field for a subscription (under Serials -> Add subscription fields). 2. Apply patch. 3. Visit Additional fields under administration, and verify that the field created above still shows under the list for the subscription table. 4. Create at least four fields for aqbasket for each combination of searchable/not-searchable and with/without an authorized value. 5. Create an order basket, and verify that all fields are visible and correctly save. 6. Edit the basket, verifying that changes to these additional fields are saved. 7. Add an order to the basket (contents are irrelevant). 8. Go to advanced search within acquisitions. 9. Verify that only the searchable fields show in the form, and that their contents may be searched. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #139 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85807&action=edit Bug 15774: (QA follow-up) Make sure that tablename is correctly saved Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #140 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85808&action=edit Bug 15774: Fix additional fields filters Addresses the following QA comments: 1/ Regression: On serials/serials-search.pl, the filters are not filled with what the users searched for and the additional fields linked to an AV are not displayed as a dropdown list. 4/ When searching an order, there is no way not to set a "all" value for additional fields linked to AV. 5/ When searching an order and the search does not return any results, the field should contain what the user filled in. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774#c10 Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #141 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85809&action=edit Bug 15774: Use Koha::Object(s) for additional fields A lot of code can be removed just by using Koha::Object It also makes fetching and updating additional field values easier. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #142 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85810&action=edit Bug 15774: Add POD and license notices Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #143 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85811&action=edit Bug 15774: Show additional field values in edit form Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #144 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85812&action=edit Bug 15774: (follow-up) Add html filters Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #145 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85813&action=edit Bug 15774: Fix JS check when AV and MARC field are both selected Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #146 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85814&action=edit Bug 15774: (follow-up) Address QA issues Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #147 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85815&action=edit Bug 15774: Use the include file to display the subscription's additional fields We have it, why not to use it? Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #148 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85816&action=edit Bug 15774: Fix insert and update for subscription Call it a typo Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #149 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85817&action=edit Bug 15774: Add missing tests for Koha::Object::Mixin::AdditionalFields Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #150 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85818&action=edit Bug 15774: Fix and unify additional_fields in C4::Serials Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #151 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85819&action=edit Bug 15774: Do not fetch additional fields from GetSubscription Finally we do not want that, they should be fetch when needed Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #152 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85820&action=edit Bug 15774: Remove unecessary returned value for ->delete Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #153 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85821&action=edit Bug 15774: Add permission for managing additional fields To test: 1 - Have three borrowers, one with order_manage permission, one with edit_subscription permisson, andone with both 2 - Apply patch, updatedatabase 3 - Verify all three now have the manage_additional_fields permission 4 - Visit the admin page with these users, they should all see the 'Manage additional fields' link 5 - Click the link 6 - User with order_manage should see 'Order baskest' 7 - User with edit_subscription should see 'Subscriptions' 8 - User with both should see both 9 - Remove the additional permissions from a user - they should see a note about needing additional permissions Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #154 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85822&action=edit Bug 15774: (follow-up) fix rebase issues Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #155 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85823&action=edit Bug 15774: (QA follow-up) Fix use statemenets Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #156 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85824&action=edit Bug 15774: (QA follow-up) Remove asset of datables.css, and corresponding plugins It is now part of doc-head-close.inc Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed by Module Maintainer --- Comment #157 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed by Module Maintainer |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #158 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 86411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86411&action=edit Bug 15774: (follow-up) Fix TestBuilder.t so it doesn't catch wrong classes Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #159 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- New feature will not be backported to 18.11.x series -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds the release notes| |ability to define | |additional fields to store | |information about | |acquisition baskets. | | | |It | |refactors and centralizes | |the code used to add fields | |to subscriptions as well. | | | |Users can name additional | |fields, tie them to | |authorized values, and | |specify whether the fields | |can be searched in the | |acquisitions module. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22934 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22934 [Bug 22934] Add missing use statement to Koha::AdditionalFieldValue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the|This enhancement adds the |This new feature adds the release notes|ability to define |ability to define |additional fields to store |additional fields to store |information about |information about |acquisition baskets. |acquisition baskets. | | |It |It |refactors and centralizes |refactors and centralises |the code used to add fields |the code used to add fields |to subscriptions as well. |to subscriptions as well. | | |Users can name additional |Users can name additional |fields, tie them to |fields, tie them to |authorized values, and |authorised values, and |specify whether the fields |specify whether the fields |can be searched in the |can be searched in the |acquisitions module. |acquisitions module. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This new feature adds the |This new feature adds the release notes|ability to define |ability to define |additional fields to store |additional fields to store |information about |information about |acquisition baskets. |acquisition baskets. | | |It |It |refactors and centralises |refactors and centralises |the code used to add fields |the code used to add fields |to subscriptions as well. |to subscriptions as well. | |There is a new 'Additional |Users can name additional |fields' page in the |fields, tie them to |adminsitration module to |authorised values, and |configure the fields. |specify whether the fields | |can be searched in the |Users can name additional |acquisitions module. |fields, tie them to | |authorised values, and | |specify whether the fields | |can be searched in the | |acquisitions module. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21329 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 MichaelaSieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 MichaelaSieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31115 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org