[Bug 33178] New: Use template wrapper for authority and bibliographic subfield entry form tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33178 Bug ID: 33178 Summary: Use template wrapper for authority and bibliographic subfield entry form tabs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, testopia@bugs.koha-community.org Depends on: 33177, 32571 Continuing the work of Bug 32571, the authority and bibliographic subfield entry form tabs should be updated to use the new WRAPPER for tabs. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 [Bug 32571] Use template wrapper to build tabbed components https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33177 [Bug 33177] Use include file for subfield constraints in both authority and bibliographic frameworks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33178 Bug 33178 depends on bug 32571, which changed state. Bug 32571 Summary: Use template wrapper to build tabbed components https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33178 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|33177 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33177 [Bug 33177] Use include file for subfield constraints in both authority and bibliographic frameworks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33178 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33178 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 167552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167552&action=edit Bug 33178: Use template wrapper for authority and bibliographic subfield entry form tabs This patch updates the authority and bibliographic subfield entry forms to replace tab markup with the use of WRAPPERs. Some JS has been modified in order to adapt to the changed Bootstrap tab markup. The patch also updates the WRAPPER code so that a unique ID can be added to individual tabs. This is necessary as a hook for the Sortable JavaScript. To test, apply the patch and go to Administration. - Go to MARC bibliographic frameworks -> Actions -> MARC structure. - Click Actions -> View subfields for a tag with more than one subfield. - Click the "Edit" button for one of the subfields, not the first one in the list. - The tab for the subfield you chose should be active. - Confirm that all the tabs look correct and work correctly. - Try dragging one of the tabs into a new position. Save your changes and confirm that the subfield was saved in that new position. - Go to Administration -> Authority types -> Actions -> MARC structure and repeat the same steps above with the authority record subfields. Sponsored-By: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33178 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167552|0 |1 is obsolete| | --- Comment #2 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 167576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167576&action=edit Bug 33178: Use template wrapper for authority and bibliographic subfield entry form tabs This patch updates the authority and bibliographic subfield entry forms to replace tab markup with the use of WRAPPERs. Some JS has been modified in order to adapt to the changed Bootstrap tab markup. The patch also updates the WRAPPER code so that a unique ID can be added to individual tabs. This is necessary as a hook for the Sortable JavaScript. To test, apply the patch and go to Administration. - Go to MARC bibliographic frameworks -> Actions -> MARC structure. - Click Actions -> View subfields for a tag with more than one subfield. - Click the "Edit" button for one of the subfields, not the first one in the list. - The tab for the subfield you chose should be active. - Confirm that all the tabs look correct and work correctly. - Try dragging one of the tabs into a new position. Save your changes and confirm that the subfield was saved in that new position. - Go to Administration -> Authority types -> Actions -> MARC structure and repeat the same steps above with the authority record subfields. Sponsored-By: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33178 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33178 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167576|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 170658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170658&action=edit Bug 33178: Use template wrapper for authority and bibliographic subfield entry form tabs This patch updates the authority and bibliographic subfield entry forms to replace tab markup with the use of WRAPPERs. Some JS has been modified in order to adapt to the changed Bootstrap tab markup. The patch also updates the WRAPPER code so that a unique ID can be added to individual tabs. This is necessary as a hook for the Sortable JavaScript. To test, apply the patch and go to Administration. - Go to MARC bibliographic frameworks -> Actions -> MARC structure. - Click Actions -> View subfields for a tag with more than one subfield. - Click the "Edit" button for one of the subfields, not the first one in the list. - The tab for the subfield you chose should be active. - Confirm that all the tabs look correct and work correctly. - Try dragging one of the tabs into a new position. Save your changes and confirm that the subfield was saved in that new position. - Go to Administration -> Authority types -> Actions -> MARC structure and repeat the same steps above with the authority record subfields. Sponsored-By: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33178 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen, this no longer applies cleanly, can you please rebase? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33178 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33178 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170658|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 171021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171021&action=edit Bug 33178: Use template wrapper for authority and bibliographic subfield entry form tabs This patch updates the authority and bibliographic subfield entry forms to replace tab markup with the use of WRAPPERs. Some JS has been modified in order to adapt to the changed Bootstrap tab markup. The patch also updates the WRAPPER code so that a unique ID can be added to individual tabs. This is necessary as a hook for the Sortable JavaScript. To test, apply the patch and go to Administration. - Go to MARC bibliographic frameworks -> Actions -> MARC structure. - Click Actions -> View subfields for a tag with more than one subfield. - Click the "Edit" button for one of the subfields, not the first one in the list. - The tab for the subfield you chose should be active. - Confirm that all the tabs look correct and work correctly. - Try dragging one of the tabs into a new position. Save your changes and confirm that the subfield was saved in that new position. - Go to Administration -> Authority types -> Actions -> MARC structure and repeat the same steps above with the authority record subfields. Sponsored-By: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33178 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33178 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171021|0 |1 is obsolete| | --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 173540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173540&action=edit Bug 33178: Use template wrapper for authority and bibliographic subfield entry form tabs This patch updates the authority and bibliographic subfield entry forms to replace tab markup with the use of WRAPPERs. Some JS has been modified in order to adapt to the changed Bootstrap tab markup. The patch also updates the WRAPPER code so that a unique ID can be added to individual tabs. This is necessary as a hook for the Sortable JavaScript. To test, apply the patch and go to Administration. - Go to MARC bibliographic frameworks -> Actions -> MARC structure. - Click Actions -> View subfields for a tag with more than one subfield. - Click the "Edit" button for one of the subfields, not the first one in the list. - The tab for the subfield you chose should be active. - Confirm that all the tabs look correct and work correctly. - Try dragging one of the tabs into a new position. Save your changes and confirm that the subfield was saved in that new position. - Go to Administration -> Authority types -> Actions -> MARC structure and repeat the same steps above with the authority record subfields. Sponsored-By: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33178 --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 173541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173541&action=edit Bug 33178: (QA follow-up) Reformat js changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33178 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de QA Contact|testopia@bugs.koha-communit |paul.derscheid@lmscloud.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33178 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33178 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33178 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Doesn't apply clean to 24.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33178 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39300 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39300 [Bug 39300] Quick edit a subfield not selecting the correct tab -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33178 Bug 33178 depends on bug 32571, which changed state. Bug 32571 Summary: Use template wrapper to build tabbed components https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org