[Bug 9075] New: Show material type and item type on staff detail (with xslt)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 Priority: P5 - low Change sponsored?: --- Bug ID: 9075 CC: gmcharlt@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: Show material type and item type on staff detail (with xslt) Severity: enhancement Classification: Unclassified OS: All Reporter: m.de.rooy@rijksmuseum.nl Hardware: All Status: NEW Version: master Component: Staff Client Product: Koha If pref item_level_itypes is set to biblio, the item type is not shown on staff detail (in the items table) while XSLT is enabled. Why not, since it still is useful information? The proposed patch is very simple: The item type with icon from the intranetDetail XSLT is renamed to Material type. That's what it is or at least comes closer. The table below does always show item type for each item. The setting of the pref does no longer matter in that sense. Note that the normal view without xslt on staff does show item type under the title. I remove it there since it is in the table below now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 13448 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13448&action=edit Patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Patch complexity|--- |Small patch --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Are you showing the biblio level item type (942$c) even if the item_level_itypes pref is set to item? If so that's against what the preference says. The preference says pull the item type from the biblio (942$c) or the item (952$y) - many libraries don't bother setting the 942$c right ... it's a shame, but it's the case, so we might want to talk about this before we make this change - we might need different preference options - something that let's people basically say - I don't edit my 942$c and I don't want that icon showing. If this patch (which I did not apply) uses the item level item type icon then ignore the rant above :) Nicole PS. I couldn't comment without setting a patch complexity, but I don't know how complex this patch is - so please update the complexity if I guessed wrong. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #2)
Are you showing the biblio level item type (942$c) even if the item_level_itypes pref is set to item? If so that's against what the preference says. The preference says pull the item type from the biblio (942$c) or the item (952$y) - many libraries don't bother setting the 942$c right ... it's a shame, but it's the case, so we might want to talk about this before we make this change - we might need different preference options - something that let's people basically say - I don't edit my 942$c and I don't want that icon showing.
If item_level_itypes==item, it shows the icons for 952y. Actually, it always uses 952y. Note that 942c is just a default item type. When using item_level_itypes==biblio, you can still change the item type of your item. The 942c just determines the default value when adding an item. If you use item_level_itypes==biblio, the items will normally not be different and so 942c==952y. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 --- Comment #4 from Nicole C. Engard <nengard@gmail.com> --- I'm not sure I was being clear. My question to you is if I have this preference set to biblio what icon is it going to use? If it's still going to show the icon from the 952y then which item will it pick the icon from - I could have 8 items with 4 different item types - how does Koha know which icon to use? This preference implies that it's going to use the item type assigned at the biblio level (942c) if set to 'biblio' and many libraries don't actually set that right. Make sense? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #4)
I'm not sure I was being clear. My question to you is if I have this preference set to biblio what icon is it going to use? If it's still going to show the icon from the 952y then which item will it pick the icon from - I could have 8 items with 4 different item types - how does Koha know which icon to use? This preference implies that it's going to use the item type assigned at the biblio level (942c) if set to 'biblio' and many libraries don't actually set that right.
Sorry for the delay in answering: The icon for itemtype is shown in the table below now. So for each item you see an icon. The 8 items with 4 different types are handled correctly independent of the item_level_itypes pref setting. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Confusion about what this patch does would be helped by adding a description of the problem, a description of the solution, and a clear test plan to the patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13448|0 |1 is obsolete| | --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 14447 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14447&action=edit Patch Rebased on 3.11.0.14 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 --- Comment #8 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #6)
Confusion about what this patch does would be helped by adding a description of the problem, a description of the solution, and a clear test plan to the patch.
Description of the "problem": see initial description. This patch does the following: Shows label "material type" on staff detail xslt (under title). This type is dependent on the MARC leader. Shows itemtype per item in the holdings table below. (No longer dependent of the setting of item_level_itypes.) Also removes item type (under title) from normal view without xslt in staff since it is shown in the holdings table below. Test plan: Check the above points in the staff detail view with XSLT enabled and without. Also toggle the setting of item_level_itypes and check again. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- If the goal is to show the item type on detail pages when item_level_itypes is set to biblio, why not simply add that information to the part of the page which displays biblio-level information? I don't like that this patch puts itemtype information into the display of holdings. If item_level_itypes is set to biblio then itemtype should not be displayed with item-specific data. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #9)
If the goal is to show the item type on detail pages when item_level_itypes is set to biblio, why not simply add that information to the part of the page which displays biblio-level information? I don't like that this patch puts itemtype information into the display of holdings. If item_level_itypes is set to biblio then itemtype should not be displayed with item-specific data. Can understand your point of view. But note that as mentioned earlier, the 942c at biblio level does not prevent items from having a different value in 952y. So the information is item-specific as holding information is as well.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- In our union catalog setting we use a standard value for the 942$c and don't want that to show up somewhere as it does not give any information about the record. I think as the value currently has not a lot of meaning/importance if you use item level itypes it might be similar for other institutions. Could this be something that can be controlled by a pref? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14447|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show material type and item |Rename type to material |type on staff detail (with |type on staff detail (with |xslt) |xslt) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 --- Comment #12 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 26787 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26787&action=edit Bug 9075: Rename type to material type on staff detail (with XSLT) The label Material type better describes what the icon presents. It is based on leader values of the MARC record. Test plan: Enable XSLT on staff detail. Check if you see the new label on catalogue detail. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |String patch Severity|enhancement |trivial --- Comment #13 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- I decided to simplify the approach of this report. Instead of discussing whether we should have the item type icon or not in the items table for the different settings of item_level_itypes, I now just rename Type to what is really is: Material type. That makes this patch a trivial string patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- If "Material type" is correct should it not be changed in all views? The term "type" appears in OPAC search results, OPAC detail page, staff client search results, and staff client detail page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #15 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Owen Leonard from comment #14)
If "Material type" is correct should it not be changed in all views? The term "type" appears in OPAC search results, OPAC detail page, staff client search results, and staff client detail page.
Hm. I agree that it is at least inconsistent to not apply the same change to staff client results. I will resend this patch. Note that the non-XSLT view in staff does not include this same Type-line (in results and detail). As for OPAC, it might be different. Here we come into the discussion if a more precise wording in staff is still appropriate for the general public of the opac. (Similar example: should you say authority search in opac). Before doing that change, I would like some feedback. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think material type would work for me in OPAC too. It's more specific than type and easier to translate for that. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Rename type to material |Rename type to material |type on staff detail (with |type |xslt) | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26787|0 |1 is obsolete| | --- Comment #17 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 26823 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26823&action=edit Bug 9075: Rename type to material type on staff XSLT detail and results The label Material type better describes what the icon presents. It is based on leader values of the MARC record. Test plan: Enable XSLT on staff detail/results. Check if you see the new label on catalogue detail/results. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 --- Comment #18 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 26824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26824&action=edit Bug 9075: Rename type to material type on OPAC XSLT detail and results The label Material type better describes what the icon presents. It is based on leader values of the MARC record. Test plan: Enable XSLT on OPAC detail/results. Check if you see the new label on OPAC detail/results (bootstrap, prog). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 --- Comment #19 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Note that both patches only deal with xslt views; the non-xslt views do not have a similar Type-display. Also note that the code in the various xslt files for determining material type should probably be moved into a shared function. I might open up a new report for that one.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26823|0 |1 is obsolete| | --- Comment #20 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 26825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26825&action=edit [SIGNED OFF] Bug 9075: Rename type to material type on staff XSLT detail and results The label Material type better describes what the icon presents. It is based on leader values of the MARC record. Revised Test Plan ----------------- 1) Set the Staff system preference XSLTDetailsDisplay to 'default' and save. 2) Set the Staff system preference XSLTResultsDisplay to 'default' and save. 3) Click 'Search the catalog' tab in the search area. 4) Search for something 5) Look for a biblio that has 942$c set to some type. -- It should display "Type:" Or take a result and modify it to have a 942$c. 6) Look at the biblio details -- It should also display "Type:" 7) Apply the patch 8) Search for the same biblio again. -- It should display "Material type:" this time. 9) Look at the biblio details -- It should display "Material type:" this time. 10) Run the koha qa test tool. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Note: This is a simple string substitution. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26824|0 |1 is obsolete| | --- Comment #21 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 26826 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26826&action=edit [SIGNED OFF] Bug 9075: Rename type to material type on OPAC XSLT detail and results The label Material type better describes what the icon presents. It is based on leader values of the MARC record. Revised Test Plan ----------------- 1) In the staff client, set the OPAC system preference OPACXSLTDetailsDisplay to 'default' and save. 2) In the staff client, set the OPAC system preference OPACXSLTResultsDisplay to 'default' and save. 3) In the staff client, set the OPAC system preference opacthemes to 'bootstrap' and save. 4) In the OPAC, search for biblio used in previous patch testing. -- It should display "Type:" 6) Look at the biblio details -- It should also display "Type:" 7) In the staff client, set the OPAC system preference opacthemes to 'prog' and save. 8) In the OPAC, search for biblio used in previous patch testing. -- It should display "Type:" 9) Look at the biblio details -- It should also display "Type:" 10) Apply the patch 11) In the staff client, set the OPAC system preference opacthemes to 'bootstrap' and save. 12) In the OPAC, search for biblio used in previous patch testing. -- It should display "Material type:" this time. 13) Look at the biblio details -- It should display "Material type:" this time. 14) In the staff client, set the OPAC system preference opacthemes to 'prog' and save. 15) In the OPAC, search for biblio used in previous patch testing. -- It should display "Material type:" this time. 16) Look at the biblio details -- It should display "Material type:" this time. 17) Run the koha qa test tool. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Note: Just a simple string change. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26825|0 |1 is obsolete| | Attachment #26826|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26886&action=edit [PASSED QA] Bug 9075: Rename type to material type on staff XSLT detail and results The label Material type better describes what the icon presents. It is based on leader values of the MARC record. Revised Test Plan ----------------- 1) Set the Staff system preference XSLTDetailsDisplay to 'default' and save. 2) Set the Staff system preference XSLTResultsDisplay to 'default' and save. 3) Click 'Search the catalog' tab in the search area. 4) Search for something 5) Look for a biblio that has 942$c set to some type. -- It should display "Type:" Or take a result and modify it to have a 942$c. 6) Look at the biblio details -- It should also display "Type:" 7) Apply the patch 8) Search for the same biblio again. -- It should display "Material type:" this time. 9) Look at the biblio details -- It should display "Material type:" this time. 10) Run the koha qa test tool. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Note: This is a simple string substitution. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26887 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26887&action=edit [PASSED QA] Bug 9075: Rename type to material type on OPAC XSLT detail and results The label Material type better describes what the icon presents. It is based on leader values of the MARC record. Revised Test Plan ----------------- 1) In the staff client, set the OPAC system preference OPACXSLTDetailsDisplay to 'default' and save. 2) In the staff client, set the OPAC system preference OPACXSLTResultsDisplay to 'default' and save. 3) In the staff client, set the OPAC system preference opacthemes to 'bootstrap' and save. 4) In the OPAC, search for biblio used in previous patch testing. -- It should display "Type:" 6) Look at the biblio details -- It should also display "Type:" 7) In the staff client, set the OPAC system preference opacthemes to 'prog' and save. 8) In the OPAC, search for biblio used in previous patch testing. -- It should display "Type:" 9) Look at the biblio details -- It should also display "Type:" 10) Apply the patch 11) In the staff client, set the OPAC system preference opacthemes to 'bootstrap' and save. 12) In the OPAC, search for biblio used in previous patch testing. -- It should display "Material type:" this time. 13) Look at the biblio details -- It should display "Material type:" this time. 14) In the staff client, set the OPAC system preference opacthemes to 'prog' and save. 15) In the OPAC, search for biblio used in previous patch testing. -- It should display "Material type:" this time. 16) Look at the biblio details -- It should display "Material type:" this time. 17) Run the koha qa test tool. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Note: Just a simple string change. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> String change, works as advertised in staff, prog and bootstrap OPAC. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #24 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. I note that "material type" is library jargon, not patron jargon, but the distinction expressed is valid. Thanks, Marcel! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #25 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.10 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 3.12.x, will be in 3.12.15! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org