[Bug 39051] New: Cash register statistics form submit button styled incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39051 Bug ID: 39051 Summary: Cash register statistics form submit button styled incorrectly Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 32091 Submit buttons should have the "btn-primary" class instead of "btn-default" Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32091 [Bug 32091] Consistent classes for primary buttons: Reports -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39051 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39051 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177572&action=edit Bug 39051: Fix submit button class on cash register statistics page This patch corrects the class of the submit button on the cash register statistics page. Bug 32091 added the "btn btn-default" class but it should have been "btn-default." To test, apply the patch and go to Reports -> Cash register statistics. The submit button should have the yellow "primary" button color. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39051 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39051 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177572|0 |1 is obsolete| | --- Comment #2 from Magnus Enger <magnus@libriotech.no> --- Created attachment 177610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177610&action=edit Bug 39051: Fix submit button class on cash register statistics page This patch corrects the class of the submit button on the cash register statistics page. Bug 32091 added the "btn btn-default" class but it should have been "btn-default." To test, apply the patch and go to Reports -> Cash register statistics. The submit button should have the yellow "primary" button color. Sponsored-by: Athens County Public Libraries Signed-off-by: Magnus Enger <magnus@libriotech.no> Button is now yellow. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39051 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39051 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177610|0 |1 is obsolete| | --- Comment #3 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 177632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177632&action=edit Bug 39051: Fix submit button class on cash register statistics page This patch corrects the class of the submit button on the cash register statistics page. Bug 32091 added the "btn btn-default" class but it should have been "btn-default." To test, apply the patch and go to Reports -> Cash register statistics. The submit button should have the yellow "primary" button color. Sponsored-by: Athens County Public Libraries Signed-off-by: Magnus Enger <magnus@libriotech.no> Button is now yellow. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39051 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177632|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177951&action=edit Bug 39051: Fix submit button class on cash register statistics page This patch corrects the class of the submit button on the cash register statistics page. Bug 32091 added the "btn btn-default" class but it should have been "btn-default." To test, apply the patch and go to Reports -> Cash register statistics. The submit button should have the yellow "primary" button color. Sponsored-by: Athens County Public Libraries Signed-off-by: Magnus Enger <magnus@libriotech.no> Button is now yellow. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39051 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39051 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39051 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39051 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.08 released in| | CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #6 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 24.11.x for 24.11.08 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39051 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39051 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org