https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20737 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 75204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75204&action=edit Bug 20737: Use https for baker and taylor cover images Easy change, should be able to verify with code review or testing with dummy values To test: 1 - Put some values in baker and taylor prefs (don't need to be valid) 2 - Do a search on the opac (and have some items with isbns) 3 - Inspect the cover images links to ensure they are formed correctly 4 - prove -v t/External/BakerTaylor.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20737 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20737 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Hmm, hardcoded URLs like http://contentcafe2.btol.com in various scripts. I do not object to pushing this fix, but it would be better to remove them from the code and put them somewhere else (pref, koha-conf, etc.) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20737 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75230|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 75250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75250&action=edit Bug 20737: Use https for baker and taylor cover images Easy change, should be able to verify with code review or testing with dummy values To test: 1 - Put some values in baker and taylor prefs (don't need to be valid) 2 - Do a search on the opac (and have some items with isbns) 3 - Inspect the cover images links to ensure they are formed correctly 4 - prove -v t/External/BakerTaylor.t Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20737 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20737 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.