[Bug 27876] New: Accessibility: OPAC - Reduce heading redundancy and correct error/alert headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 Bug ID: 27876 Summary: Accessibility: OPAC - Reduce heading redundancy and correct error/alert headings Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: wainuiwitikapark@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org Bug 27610 created <h1> headings on each page of the OPAC, then Bug 27740 fixed the hierarchy of the other headings in each page to ensure there was no skipping of heading levels, and that items that appeared as headings of some sort, had an <h> tag. There are now a few headings that are redundant (e.g. Purchase suggestions https://snipboard.io/SCFALO.jpg) so this bug will deal with issues like this. Many of the alerts and errors are also tagged as headings, which for many cases is not correct. Therefore, this bug will also deal with these issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |wainuiwitikapark@catalyst.n | |et.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27610 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27610 [Bug 27610] Accessibility: OPAC - <h1> on each page is Logo but should be page description/title -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27740 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740 [Bug 27740] Accessibility: OPAC - Headings should have correct tags and hierarchy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Accessibility: OPAC - |Accessibility: OPAC - |Reduce heading redundancy |Reduce heading redundancy |and correct error/alert | |headings | Henry Bolshaw <bolshawh@parliament.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |accessibility --- Comment #1 from wainuiwitikapark@catalyst.net.nz --- I don't think this bug needs to address error alerts anymore -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Do you think you could provide a patch soon? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 Henry Bolshaw <bolshawh@parliament.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bolshawh@parliament.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Ooh.. I fixed the purchase suggestsions one as a followup in bug 27740.. I felt it was a QA fail otherwise. As for the alerts and errors.. I think that also ties into my followup questions on bug 27740.. such content area's likely need some sort of 'title' but without necessarily interfering with the header hierarchy.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 --- Comment #4 from wainuiwitikapark@catalyst.net.nz --- Hi all, yeah I'm working on this now so will hopefully be able to provide a patch soon. Please feel free to point out any pages in particular that you think need addressing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 --- Comment #5 from wainuiwitikapark@catalyst.net.nz --- Created attachment 120148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120148&action=edit Bug 27876: added sr-only to caption of table in Charges page Made the "Your charges" caption of the table in the Charges page of the OPAC hidden and for screen-readers only so that it takes out redundancy. To test: 1) Apply patch 2) Go to OPAC 3) Go to Charges page 4) Ensure that there is no visible caption above the table that says "Your charges" 5) Check that the code has the caption still with sr-only class Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 --- Comment #6 from wainuiwitikapark@catalyst.net.nz --- Created attachment 120149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120149&action=edit Bug 27876: took away redundant heading in OPAC full serial issues Changed <h2> to <h1> and deleted current <h1> to eliminate redundancy. To test: 1) Apply patch 2) Go to OPAC 3) Go to opac-serial-issues.pl 4) Check there is only one main heading and it is <h1> Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 --- Comment #7 from wainuiwitikapark@catalyst.net.nz --- Created attachment 120150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120150&action=edit Bug 27876: changed Your tags title to caption in OPAC On the tags page, changed the <h2> "Your tags" to a <caption> to reduce heading redundancy but keep the information available. To test: 1) Apply patch 2) Go to OPAC 3) Go to opac-tags.pl 4) Ensure that there is a caption above the table that says "Your tags" and that it is not a heading tag Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120148|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120148|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 --- Comment #8 from wainuiwitikapark@catalyst.net.nz --- Created attachment 120151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120151&action=edit Bug 27876: Added caption to checkout history table Added a sr-only caption to the checkout history table but made it hidden and for screen-readers only. This is to keep it consistent with the Charges page and table but is also the best practice for tables. This ensures there is still no visible redundancy but is better for accessible. To test: 1) Apply patch 2) Go to OPAC 3) Go to checkout history page 4) Check that the page looks the same 5) Check that the code has a caption "Your checkout history" that has the class "sr-only" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120151|0 |1 is obsolete| | --- Comment #9 from wainuiwitikapark@catalyst.net.nz --- Created attachment 120152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120152&action=edit Bug 27876: Added caption to checkout history table Added a sr-only caption to the checkout history table but made it hidden and for screen-readers only. This is to keep it consistent with the Charges page and table but is also the best practice for tables. This ensures there is still no visible redundancy but is better for accessibility. To test: 1) Apply patch 2) Go to OPAC 3) Go to checkout history page 4) Check that the page looks the same 5) Check that the code has a caption "Your checkout history" that has the class "sr-only" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 --- Comment #10 from wainuiwitikapark@catalyst.net.nz --- Created attachment 120153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120153&action=edit Bug 27876: Added caption to holds history table Added a sr-only caption to the holds history table but made it hidden and for screen-readers only. This is to keep it consistent with the Charges and checkout histories pages and tables but is also the best practice for tables. This ensures there is still no visible redundancy but is better for accessibility. To test: 1) Apply patch 2) Go to OPAC 3) Go to holds history page 4) Check that the page looks the same 5) Check that the code has a caption "Your holds history" that has the class "sr-only" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120148|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120152|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120153|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120148|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 --- Comment #11 from wainuiwitikapark@catalyst.net.nz --- Apologies for the confusing patches making them obsolete etc. I have decided that adding captions to tables and making them sr-only should be a separate bug. Except the charges page I left the caption there but with sr-only as I it already had a caption. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 Henry Bolshaw <bolshawh@parliament.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 Henry Bolshaw <bolshawh@parliament.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120148|0 |1 is obsolete| | --- Comment #12 from Henry Bolshaw <bolshawh@parliament.uk> --- Created attachment 120199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120199&action=edit Bug 27876: added sr-only to caption of table in Charges page Made the "Your charges" caption of the table in the Charges page of the OPAC hidden and for screen-readers only so that it takes out redundancy. To test: 1) Apply patch 2) Go to OPAC 3) Go to Charges page 4) Ensure that there is no visible caption above the table that says "Your charges" 5) Check that the code has the caption still with sr-only class Sponsored-by: Catalyst IT Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 Henry Bolshaw <bolshawh@parliament.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120149|0 |1 is obsolete| | --- Comment #13 from Henry Bolshaw <bolshawh@parliament.uk> --- Created attachment 120200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120200&action=edit Bug 27876: took away redundant heading in OPAC full serial issues Changed <h2> to <h1> and deleted current <h1> to eliminate redundancy. To test: 1) Apply patch 2) Go to OPAC 3) Go to opac-serial-issues.pl 4) Check there is only one main heading and it is <h1> Sponsored-by: Catalyst IT Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 Henry Bolshaw <bolshawh@parliament.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120150|0 |1 is obsolete| | --- Comment #14 from Henry Bolshaw <bolshawh@parliament.uk> --- Created attachment 120201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120201&action=edit Bug 27876: changed Your tags title to caption in OPAC On the tags page, changed the <h2> "Your tags" to a <caption> to reduce heading redundancy but keep the information available. To test: 1) Apply patch 2) Go to OPAC 3) Go to opac-tags.pl 4) Ensure that there is a caption above the table that says "Your tags" and that it is not a heading tag Sponsored-by: Catalyst IT Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 --- Comment #15 from Henry Bolshaw <bolshawh@parliament.uk> --- This is great. I have followed the test plans and signed off. I also checked the pages using the NVDA screenreader: the change on the tags page makes the table much easier to understand! Wainui, are you going to create a separate bug for table captions? Let me know if you weren't and I'll submit one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 --- Comment #16 from wainuiwitikapark@catalyst.net.nz --- (In reply to Henry Bolshaw from comment #15)
This is great. I have followed the test plans and signed off. I also checked the pages using the NVDA screenreader: the change on the tags page makes the table much easier to understand!
Wainui, are you going to create a separate bug for table captions? Let me know if you weren't and I'll submit one.
Hi Henry, thanks so much! Yeah I can submit a bug for that :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 --- Comment #17 from wainuiwitikapark@catalyst.net.nz --- (In reply to Henry Bolshaw from comment #15)
Wainui, are you going to create a separate bug for table captions? Let me know if you weren't and I'll submit one.
Please see Bug 28242 and Bug 28243 for dealing with table captions as well as other elements that need labels/legends. It will be useful for many of these to be "sr-only" so that they don't interfere with other headings and don't create redundancy. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28242 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242 [Bug 28242] Accessibility: OPAC - add captions/legends/labels to elements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120199|0 |1 is obsolete| | Attachment #120200|0 |1 is obsolete| | Attachment #120201|0 |1 is obsolete| | --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 120716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120716&action=edit Bug 27876: added sr-only to caption of table in Charges page Made the "Your charges" caption of the table in the Charges page of the OPAC hidden and for screen-readers only so that it takes out redundancy. To test: 1) Apply patch 2) Go to OPAC 3) Go to Charges page 4) Ensure that there is no visible caption above the table that says "Your charges" 5) Check that the code has the caption still with sr-only class Sponsored-by: Catalyst IT Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 120717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120717&action=edit Bug 27876: took away redundant heading in OPAC full serial issues Changed <h2> to <h1> and deleted current <h1> to eliminate redundancy. To test: 1) Apply patch 2) Go to OPAC 3) Go to opac-serial-issues.pl 4) Check there is only one main heading and it is <h1> Sponsored-by: Catalyst IT Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 120718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120718&action=edit Bug 27876: changed Your tags title to caption in OPAC On the tags page, changed the <h2> "Your tags" to a <caption> to reduce heading redundancy but keep the information available. To test: 1) Apply patch 2) Go to OPAC 3) Go to opac-tags.pl 4) Ensure that there is a caption above the table that says "Your tags" and that it is not a heading tag Sponsored-by: Catalyst IT Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 --- Comment #21 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #22 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 27610 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org