[Bug 11497] New: i18n toolchain fails to pick up TT code in the format 'SomeVariable or "Some Text"' for translation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11497 Bug ID: 11497 Summary: i18n toolchain fails to pick up TT code in the format 'SomeVariable or "Some Text"' for translation Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kallinen@pttk.fi QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Some templates use the following or similar code: [% LibraryNameTitle or "Koha online" %] The translation toolchain fails to pick up the hard-coded string for translation: # grep -E '^#. %[0-9]+\$s: +.* or \"[^"]+".*$' po/de-DE-*.po po/de-DE-i-opac-t-prog-v-3006000.po:#. %4$s: LibraryNameTitle or "Koha online" po/de-DE-i-opac-t-prog-v-3006000.po:#. %3$s: LibraryNameTitle or "Koha online" po/de-DE-i-opac-t-prog-v-3006000.po:#. %3$s: LibraryNameTitle or "Koha online" po/de-DE-i-opac-t-prog-v-3006000.po:#. %2$s: LibraryNameTitle or "Koha online" po/de-DE-i-opac-t-prog-v-3006000.po:#. %2$s: LibraryNameTitle or "Koha online" po/de-DE-i-staff-t-prog-v-3006000.po:#. %1$s: frameworkcode or "Default" po/de-DE-i-staff-t-prog-v-3006000.po:#. %1$s: update.old_branch or "?" po/de-DE-i-staff-t-prog-v-3006000.po:#. %2$s: update.LoginBranchcode or "?" po/de-DE-opac-bootstrap.po:#. %4$s: LibraryNameTitle or "Koha online" po/de-DE-opac-bootstrap.po:#. %3$s: LibraryNameTitle or "Koha online" po/de-DE-opac-bootstrap.po:#. %3$s: LibraryNameTitle or "Koha online" po/de-DE-opac-bootstrap.po:#. %3$s: LibraryNameTitle or "Koha online" po/de-DE-opac-bootstrap.po:#. %2$s: LibraryNameTitle or "Koha online" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11497 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 26801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26801&action=edit Bug 11497 - i18n toolchain fails to pick up TT code in the format 'SomeVariable or "Some Text"' for translation i18n toolchain fails to pick text defined inside [% ... %] This patch fixes all the cases I could find To test: 1. Update your preferred language (cd misc/translator; perl translate update fi-FI) 2. Count headers for example egrep "^msgid.*Koha online" misc/translator/po/fi-FI-* | wc -l 3. Apply the patch 4. Repeat 1 and 2, now there are more lines Or translate to som lang and visit every touched page and look the title -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11497 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |bgkriegel@gmail.com Assignee|koha-bugs@lists.koha-commun |bgkriegel@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11497 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11497 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11497 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26801|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 27549 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27549&action=edit Bug 11497 - i18n toolchain fails to pick up TT code in the format 'SomeVariable or "Some Text"' for translation i18n toolchain fails to pick text defined inside [% ... %] This patch fixes all the cases I could find To test: 1. Update your preferred language (cd misc/translator; perl translate update fi-FI) 2. Count headers for example egrep "^msgid.*Koha online" misc/translator/po/fi-FI-* | wc -l 3. Apply the patch 4. Repeat 1 and 2, now there are more lines Or translate to some lang and visit every touched page and look the title Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11497 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11497 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27549|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27663 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27663&action=edit [PASSED QA] Bug 11497 - i18n toolchain fails to pick up TT code in the format 'SomeVariable or "Some Text"' for translation i18n toolchain fails to pick text defined inside [% ... %] This patch fixes all the cases I could find To test: 1. Update your preferred language (cd misc/translator; perl translate update fi-FI) 2. Count headers for example egrep "^msgid.*Koha online" misc/translator/po/fi-FI-* | wc -l 3. Apply the patch 4. Repeat 1 and 2, now there are more lines Or translate to some lang and visit every touched page and look the title Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described. Template changes only. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11497 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Maybe we should add this to the coding guidelines? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11497 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Bernardo! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11497 --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to Katrin Fischer from comment #4)
Maybe we should add this to the coding guidelines?
Although I pushed the patch, the construct that it replaces seems useful on the face of it, and it's certainly less verbose. I'd rather see the translation code be taught how to deal with it. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org