[Bug 33408] New: Fetch sysprefs from svc/config/systempreferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Bug ID: 33408 Summary: Fetch sysprefs from svc/config/systempreferences Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com CC: jonathan.druart+koha@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, pedro.amorim@ptfs-europe.com We are retrieving the syspref from the template, we could retrieve them from a route. It will be easier to mock/set them from cypress tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33289, 33402 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33289 [Bug 33289] Vue - Add API client class to interact with svc/config/systempreferences https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 [Bug 33402] ERM Cypress tests needs to be moved to their own directory -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149131&action=edit Bug 33408: Fetch sysprefs from svc/config/systempreferences It will be easier to mock/set them from cypress tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149132&action=edit Bug 33408: Mock ERM sysprefs from cypress tests Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149131|0 |1 is obsolete| | Attachment #149132|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149133&action=edit Bug 33408: Fetch sysprefs from svc/config/systempreferences It will be easier to mock/set them from cypress tests. Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149134&action=edit Bug 33408: Mock ERM sysprefs from cypress tests Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149133|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149184&action=edit Bug 33408: Fetch sysprefs from svc/config/systempreferences It will be easier to mock/set them from cypress tests. Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149134|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149185&action=edit Bug 33408: Mock ERM sysprefs from cypress tests Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- *** Bug 33370 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149186&action=edit Bug 33408: Extend defaultCommandTimeout for cypress Sometimes the initial page load takes more than 4 seconds. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33416 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416 [Bug 33416] Agreements.ts is failing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 --- Comment #9 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 149196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149196&action=edit Bug 33408: Remove obsolete template sys pref code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 --- Comment #10 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 149197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149197&action=edit Bug 33408: Prevent access to erm module by URL if sys pref is disabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149196|0 |1 is obsolete| | --- Comment #11 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 149198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149198&action=edit Bug 33408: Remove obsolete tests and template sys pref code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149200&action=edit Bug 33408: We need only one this.loaded call -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149184|0 |1 is obsolete| | --- Comment #13 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 149204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149204&action=edit Bug 33408: Fetch sysprefs from svc/config/systempreferences It will be easier to mock/set them from cypress tests. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149185|0 |1 is obsolete| | --- Comment #14 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 149205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149205&action=edit Bug 33408: Mock ERM sysprefs from cypress tests Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149186|0 |1 is obsolete| | --- Comment #15 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 149206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149206&action=edit Bug 33408: Extend defaultCommandTimeout for cypress Sometimes the initial page load takes more than 4 seconds. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149197|0 |1 is obsolete| | --- Comment #16 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 149207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149207&action=edit Bug 33408: Prevent access to erm module by URL if sys pref is disabled Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149198|0 |1 is obsolete| | --- Comment #17 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 149208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149208&action=edit Bug 33408: Remove obsolete tests and template sys pref code Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149200|0 |1 is obsolete| | --- Comment #18 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 149209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149209&action=edit Bug 33408: We need only one this.loaded call Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149254&action=edit Bug 33408: Store sysprefs in a new ERM store We need the sysprefs' values to be shared between the components -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #20 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- There were 2 components using the erm_providers js variable from the .tt We need to store the values to make them reusable from other components. I am not 100% happy with this patch, there is certainly something to improve, for instance we should not need two variables here: + this.ERMStore.providers = providers.value.split(",") + this.providers = this.ERMStore.providers But here is a quick fix to restore the feature. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33443 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33443 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 --- Comment #21 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Last patch doesn't apply after bug 33066 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149254|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149438&action=edit Bug 33408: Store sysprefs in a new ERM store We need the sysprefs' values to be shared between the components -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149438|0 |1 is obsolete| | --- Comment #23 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 149516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149516&action=edit Bug 33408: Store sysprefs in a new ERM store We need the sysprefs' values to be shared between the components Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 --- Comment #24 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 149517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149517&action=edit Bug 33408: Add storeToRefs to ERMStore It makes it so that any changes to the local property is also reflected in the store and other components are made aware of the new value. No need to explicitly change both local property and store property values. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 --- Comment #25 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 149518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149518&action=edit Bug 33408: Move providers into syspref array ERMProviders is a sys pref, place it in sysprefs Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149204|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 149535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149535&action=edit Bug 33408: Fetch sysprefs from svc/config/systempreferences It will be easier to mock/set them from cypress tests. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149205|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 149536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149536&action=edit Bug 33408: Mock ERM sysprefs from cypress tests Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149206|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 149537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149537&action=edit Bug 33408: Extend defaultCommandTimeout for cypress Sometimes the initial page load takes more than 4 seconds. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149207|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 149538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149538&action=edit Bug 33408: Prevent access to erm module by URL if sys pref is disabled Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149208|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 149539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149539&action=edit Bug 33408: Remove obsolete tests and template sys pref code Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149209|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 149540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149540&action=edit Bug 33408: We need only one this.loaded call Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149516|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 149541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149541&action=edit Bug 33408: Store sysprefs in a new ERM store We need the sysprefs' values to be shared between the components Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149517|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 149542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149542&action=edit Bug 33408: Add storeToRefs to ERMStore It makes it so that any changes to the local property is also reflected in the store and other components are made aware of the new value. No need to explicitly change both local property and store property values. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149518|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 149543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149543&action=edit Bug 33408: Move providers into syspref array ERMProviders is a sys pref, place it in sysprefs Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This is a nice clear improvement.. QA script squeeks about template literals in ktd, but I thought we'd decided those were OK now? Happy to PQA is someone is happy to verify that template literals are OK now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 --- Comment #36 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Comment on attachment 149535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149535 Bug 33408: Fetch sysprefs from svc/config/systempreferences Review of attachment 149535: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=33408&attachment=149535) ----------------------------------------------------------------- Can you review this? Thanks ::: koha-tmpl/intranet-tmpl/prog/js/vue/fetch/system-preferences-api-client.js @@ +10,5 @@
get sysprefs() { return { + get: (variable) => + this.get({ + endpoint: `/?pref=${variable}`,
FAIL koha-tmpl/intranet-tmpl/prog/js/vue/fetch/system-preferences-api-client.js FAIL ES template literals ES template literals found ( endpoint: `/?pref=${variable}`,) - See bug 24725 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 --- Comment #37 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 149570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149570&action=edit Bug 33408: Fix template literal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 --- Comment #38 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- I think there's something wrong in this patch: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149535 With it applied, if you access http://localhost:8081/cgi-bin/koha/erm/agreements on a new window, it never gets past "Loading", but clicking on the different menu items and going back to agreements, all works fine. It's only with agreements too. This doesn't happen with licenses or any of the others. I'm looking into this but ask if someone else can confirm if they can also reproduce this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #39 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- The behaviour I'm experiencing is fixed by bug 33483, more specifically this patch: https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=33483&attachment=149564 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 --- Comment #40 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |jacob.omara@ptfs-europe.com --- Comment #41 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33606 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 [Bug 33606] Access to ERM requires parameters => 'manage_sysprefs' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Bug 33408 depends on bug 33289, which changed state. Bug 33289 Summary: Vue - Add API client class to interact with svc/config/systempreferences https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33289 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Bug 33408 depends on bug 33402, which changed state. Bug 33402 Summary: ERM Cypress tests needs to be moved to their own directory https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #42 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Jacob O'Mara from comment #41)
Enhancement - not backporting to 22.11.x
Nice work everyone!
It appears like this was backported to 22.11. Can you check? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org