[Bug 30418] New: Add permission and setting for public lists to allow staff with permission to edit contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Bug ID: 30418 Summary: Add permission and setting for public lists to allow staff with permission to edit contents Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Bug 26346 added an option for all staff to be able to manage contents of a public list, and a permission to allow staff to edit the configuration of public lists. It would be nice to go more granular and add a permission that allow users with this permission to edit list contents, and a setting to follow this permission for a list -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26346 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 [Bug 26346] Add option to make a public list editable by library staff only -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Nick, I have read it several times, but I am not sure I understand yet what the new permissions would look like. Maybe you could write them up? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Bug 30418 depends on bug 26346, which changed state. Bug 26346 Summary: Add option to make a public list editable by library staff only https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk --- Comment #2 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- +1 Really interested in this development. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |alexbuckley@catalyst.net.nz |ity.org | CC| |alexbuckley@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #3 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 139696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139696&action=edit Bug 30418: Database changes Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #4 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 139697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139697&action=edit Bug 30418: Updated schema file Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #5 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 139698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139698&action=edit Bug 30418: Template and JavaScript changes Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #6 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 139699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139699&action=edit Bug 30418: Add ability for permitted staff to edit list contents Public lists with 'Allow changes to contents from' = 'Permitted staff only' can have their contents managed by Koha patrons with either of the permissions below: - superlibrarian permission - catalogue permission + 'edit_public_list_contents' sub-permission Test plan: 1. Apply patches, update database, restart services 2. In the staff client go to: Lists > New List 3. Create a list, choose 'Allow changes to contents from' => 'Permitted staff only' 4. Log into the OPAC as a patron with no permissions. 5. Confirm you CANNOT add a biblio to the list from the OPAC search result page and OPAC biblio detail pages 6. Log into the OPAC as a patron with only the 'catalogue' permissions enabled 7. Confirm you CANNOT add a biblio to the list from OPAC search result or biblio detail pages 8. Log into the OPAC as a patron with the 'catalogue' and 'edit_public_list_contents' permissions enabled 9. Confirm you CAN add/remove biblios from the OPAC search result and biblio detail pages 10. Log into the OPAC as a patron with superlibrarian permissions 11. Confirm you CAN add a biblio to the list from the OPAC search result page and OPAC biblio detail pages 12. Log into the staff client as a patron with only the 'catalogue' permission and confirm you CANNOT add/remove records from the list 13. Log into the staff client as a patron with the 'catalogue' and 'edit_public_list_contents' sub-permission (found under 'Lists' parent permission) 14. Confirm you CAN add/remove records from the list 15. Login into thestaff client as a patron with 'superlibrarian' permissions and confirm you CAN add/remove records from the list Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #7 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 139700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139700&action=edit Bug 30418: Unit tests Test plan: 1. Run unit tests sudo koha-shell <instance> prove t/db_dependent/Koha/Patron.t prove t/db_dependent/Virtualshelves.t Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #8 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 139701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139701&action=edit Bug 30418: Re-order options of who can edit list contents The 'Allow changes to contents from' dropdown when creating/edit lists should be most locked down to least locked down: 1. Nobody 2. Owner only 3. Permitted staff only 4. Staff only 5. Anyone seeing this list Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Add a new 'Permitted staff release notes| |only' option to public | |lists, allowing only | |permitted staff users to | |manage the list contents | |from the staff client and | |OPAC. | | | |The 'Permitted staff | |only' option differs from | |the 'Staff only' option | |because permitted staff are | |Koha patrons with the | |'catalogue' permission | |enabled and the new | |'edit_public_list_contents' | |sub-permission enabled. Change sponsored?|--- |Sponsored Status|ASSIGNED |Needs Signoff --- Comment #9 from Alex Buckley <alexbuckley@catalyst.net.nz> --- This is now ready to test. I have named the new 'Allow changes to contents from' dropdown option 'Permitted staff only'. I'm happy to change this naming to 'Staff with permissions' or other variations if you think it might clarify what it does. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |hammat.wele@inlibro.com --- Comment #10 from Hammat wele <hammat.wele@inlibro.com> --- CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc error: Failed to merge in the changes.Patch failed at 0001 Bug 30418: Template and JavaScript changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139701|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139700|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139699|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139698|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139697|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139696|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #11 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 146363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146363&action=edit Bug 30418: Database changes Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #12 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 146364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146364&action=edit Bug 30418: Updated schema file Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #13 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 146365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146365&action=edit Bug 30418: Template and JavaScript changes Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #14 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 146366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146366&action=edit Bug 30418: Add ability for permitted staff to edit list contents Public lists with 'Allow changes to contents from' = 'Permitted staff only' can have their contents managed by Koha patrons with either of the permissions below: - superlibrarian permission - catalogue permission + 'edit_public_list_contents' sub-permission Test plan: 1. Apply patches, update database, restart services 2. In the staff client go to: Lists > New List 3. Create a list, choose 'Allow changes to contents from' => 'Permitted staff only' 4. Log into the OPAC as a patron with no permissions. 5. Confirm you CANNOT add a biblio to the list from the OPAC search result page and OPAC biblio detail pages 6. Log into the OPAC as a patron with only the 'catalogue' permissions enabled 7. Confirm you CANNOT add a biblio to the list from OPAC search result or biblio detail pages 8. Log into the OPAC as a patron with the 'catalogue' and 'edit_public_list_contents' permissions enabled 9. Confirm you CAN add/remove biblios from the OPAC search result and biblio detail pages 10. Log into the OPAC as a patron with superlibrarian permissions 11. Confirm you CAN add a biblio to the list from the OPAC search result page and OPAC biblio detail pages 12. Log into the staff client as a patron with only the 'catalogue' permission and confirm you CANNOT add/remove records from the list 13. Log into the staff client as a patron with the 'catalogue' and 'edit_public_list_contents' sub-permission (found under 'Lists' parent permission) 14. Confirm you CAN add/remove records from the list 15. Login into thestaff client as a patron with 'superlibrarian' permissions and confirm you CAN add/remove records from the list Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #15 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 146367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146367&action=edit Bug 30418: Unit tests Test plan: 1. Run unit tests sudo koha-shell <instance> prove t/db_dependent/Koha/Patron.t prove t/db_dependent/Virtualshelves.t Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #16 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 146368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146368&action=edit Bug 30418: Re-order options of who can edit list contents The 'Allow changes to contents from' dropdown when creating/edit lists should be most locked down to least locked down: 1. Nobody 2. Owner only 3. Permitted staff only 4. Staff only 5. Anyone seeing this list Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #17 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Rebased against master. Ready for testing again -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #18 from Lucas Gass <lucas@bywatersolutions.com> --- Works as describe and tests pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146363|0 |1 is obsolete| | --- Comment #19 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 146374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146374&action=edit Bug 30418: Database changes Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146364|0 |1 is obsolete| | --- Comment #20 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 146375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146375&action=edit Bug 30418: Updated schema file Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146365|0 |1 is obsolete| | --- Comment #21 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 146376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146376&action=edit Bug 30418: Template and JavaScript changes Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146366|0 |1 is obsolete| | --- Comment #22 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 146377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146377&action=edit Bug 30418: Add ability for permitted staff to edit list contents Public lists with 'Allow changes to contents from' = 'Permitted staff only' can have their contents managed by Koha patrons with either of the permissions below: - superlibrarian permission - catalogue permission + 'edit_public_list_contents' sub-permission Test plan: 1. Apply patches, update database, restart services 2. In the staff client go to: Lists > New List 3. Create a list, choose 'Allow changes to contents from' => 'Permitted staff only' 4. Log into the OPAC as a patron with no permissions. 5. Confirm you CANNOT add a biblio to the list from the OPAC search result page and OPAC biblio detail pages 6. Log into the OPAC as a patron with only the 'catalogue' permissions enabled 7. Confirm you CANNOT add a biblio to the list from OPAC search result or biblio detail pages 8. Log into the OPAC as a patron with the 'catalogue' and 'edit_public_list_contents' permissions enabled 9. Confirm you CAN add/remove biblios from the OPAC search result and biblio detail pages 10. Log into the OPAC as a patron with superlibrarian permissions 11. Confirm you CAN add a biblio to the list from the OPAC search result page and OPAC biblio detail pages 12. Log into the staff client as a patron with only the 'catalogue' permission and confirm you CANNOT add/remove records from the list 13. Log into the staff client as a patron with the 'catalogue' and 'edit_public_list_contents' sub-permission (found under 'Lists' parent permission) 14. Confirm you CAN add/remove records from the list 15. Login into thestaff client as a patron with 'superlibrarian' permissions and confirm you CAN add/remove records from the list Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146367|0 |1 is obsolete| | --- Comment #23 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 146378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146378&action=edit Bug 30418: Unit tests Test plan: 1. Run unit tests sudo koha-shell <instance> prove t/db_dependent/Koha/Patron.t prove t/db_dependent/Virtualshelves.t Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146368|0 |1 is obsolete| | --- Comment #24 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 146379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146379&action=edit Bug 30418: Re-order options of who can edit list contents The 'Allow changes to contents from' dropdown when creating/edit lists should be most locked down to least locked down: 1. Nobody 2. Owner only 3. Permitted staff only 4. Staff only 5. Anyone seeing this list Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #25 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 146609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146609&action=edit Bug 30418: (follow-up) Fixes for QA test tools Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146374|0 |1 is obsolete| | Attachment #146375|0 |1 is obsolete| | Attachment #146376|0 |1 is obsolete| | Attachment #146377|0 |1 is obsolete| | Attachment #146378|0 |1 is obsolete| | Attachment #146379|0 |1 is obsolete| | Attachment #146609|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 148645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148645&action=edit Bug 30418: Database changes Sponsored-by: Catalyst IT, New Zealand Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 148646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148646&action=edit Bug 30418: Updated schema file Sponsored-by: Catalyst IT, New Zealand Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 148647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148647&action=edit Bug 30418: Template and JavaScript changes Sponsored-by: Catalyst IT, New Zealand Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 148648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148648&action=edit Bug 30418: Add ability for permitted staff to edit list contents Public lists with 'Allow changes to contents from' = 'Permitted staff only' can have their contents managed by Koha patrons with either of the permissions below: - superlibrarian permission - catalogue permission + 'edit_public_list_contents' sub-permission Test plan: 1. Apply patches, update database, restart services 2. In the staff client go to: Lists > New List 3. Create a list, choose 'Allow changes to contents from' => 'Permitted staff only' 4. Log into the OPAC as a patron with no permissions. 5. Confirm you CANNOT add a biblio to the list from the OPAC search result page and OPAC biblio detail pages 6. Log into the OPAC as a patron with only the 'catalogue' permissions enabled 7. Confirm you CANNOT add a biblio to the list from OPAC search result or biblio detail pages 8. Log into the OPAC as a patron with the 'catalogue' and 'edit_public_list_contents' permissions enabled 9. Confirm you CAN add/remove biblios from the OPAC search result and biblio detail pages 10. Log into the OPAC as a patron with superlibrarian permissions 11. Confirm you CAN add a biblio to the list from the OPAC search result page and OPAC biblio detail pages 12. Log into the staff client as a patron with only the 'catalogue' permission and confirm you CANNOT add/remove records from the list 13. Log into the staff client as a patron with the 'catalogue' and 'edit_public_list_contents' sub-permission (found under 'Lists' parent permission) 14. Confirm you CAN add/remove records from the list 15. Login into thestaff client as a patron with 'superlibrarian' permissions and confirm you CAN add/remove records from the list Sponsored-by: Catalyst IT, New Zealand Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 148649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148649&action=edit Bug 30418: Unit tests Test plan: 1. Run unit tests sudo koha-shell <instance> prove t/db_dependent/Koha/Patron.t prove t/db_dependent/Virtualshelves.t Sponsored-by: Catalyst IT, New Zealand Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 148650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148650&action=edit Bug 30418: Re-order options of who can edit list contents The 'Allow changes to contents from' dropdown when creating/edit lists should be most locked down to least locked down: 1. Nobody 2. Owner only 3. Permitted staff only 4. Staff only 5. Anyone seeing this list Sponsored-by: Catalyst IT, New Zealand Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 148651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148651&action=edit Bug 30418: (follow-up) Fixes for QA test tools Sponsored-by: Catalyst IT, New Zealand Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 148652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148652&action=edit Bug 30418: (QA follow-up): Fix unit test count Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #34 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #35 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 151249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151249&action=edit Bug 30418: Fix t/Koha/Auth/Permissions.t koha_1 | # Failed test 'Expected permissions generated for superlibrarian' koha_1 | # at t/Koha/Auth/Permissions.t line 283. koha_1 | # Structures begin differing at: koha_1 | # $got->{CAN_user_lists_edit_public_list_contents} = '1' koha_1 | # $expected->{CAN_user_lists_edit_public_list_contents} = Does not exist koha_1 | # Looks like you failed 1 test of 1. koha_1 | koha_1 | # Failed test 'superlibrarian tests' koha_1 | # at t/Koha/Auth/Permissions.t line 284. koha_1 | # Looks like you failed 1 test of 3. koha_1 | [23:34:42] t/Koha/Auth/Permissions.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #36 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #35)
Created attachment 151249 [details] [review] Bug 30418: Fix t/Koha/Auth/Permissions.t
koha_1 | # Failed test 'Expected permissions generated for superlibrarian' koha_1 | # at t/Koha/Auth/Permissions.t line 283. koha_1 | # Structures begin differing at: koha_1 | # $got->{CAN_user_lists_edit_public_list_contents} = '1' koha_1 | # $expected->{CAN_user_lists_edit_public_list_contents} = Does not exist koha_1 | # Looks like you failed 1 test of 1. koha_1 | koha_1 | # Failed test 'superlibrarian tests' koha_1 | # at t/Koha/Auth/Permissions.t line 284. koha_1 | # Looks like you failed 1 test of 3. koha_1 | [23:34:42] t/Koha/Auth/Permissions.t
Pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #37 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Hmm We have problems with permissions now. Could this one be the cause? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33722 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #38 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #37)
Hmm We have problems with permissions now. Could this one be the cause?
Still looking btw -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #39 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Marcel, According to comment #36 this enhancement (bug 30418) was pushed to master around 2023-05-16 09:28:06 UTC, however, the list permission problems in bug 33722 were reported earlier at 2023-05-11 23:16:42 UTC Also, noting that if you checkout 2928c1cf634c97041ea3b1268dcc27a550feb2ca 'Bug 32775: (QA follow-up) remove useless empty line' (the commit in log before bug 30418 was pushed) the problem reported in bug 33722 can be replicated then. Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #40 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Alex Buckley from comment #39)
Hi Marcel,
According to comment #36 this enhancement (bug 30418) was pushed to master around 2023-05-16 09:28:06 UTC, however, the list permission problems in bug 33722 were reported earlier at 2023-05-11 23:16:42 UTC
Also, noting that if you checkout 2928c1cf634c97041ea3b1268dcc27a550feb2ca 'Bug 32775: (QA follow-up) remove useless empty line' (the commit in log before bug 30418 was pushed) the problem reported in bug 33722 can be replicated then.
Alex
Might be false alarm indeed. Sorry for the confusion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/691 CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #41 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to Marcel de Rooy from comment #40)
(In reply to Alex Buckley from comment #39)
Hi Marcel,
According to comment #36 this enhancement (bug 30418) was pushed to master around 2023-05-16 09:28:06 UTC, however, the list permission problems in bug 33722 were reported earlier at 2023-05-11 23:16:42 UTC
Also, noting that if you checkout 2928c1cf634c97041ea3b1268dcc27a550feb2ca 'Bug 32775: (QA follow-up) remove useless empty line' (the commit in log before bug 30418 was pushed) the problem reported in bug 33722 can be replicated then.
Alex
Might be false alarm indeed. Sorry for the confusion.
No worries, thanks Marcel -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |matt.blenkinsop@ptfs-europe | |.com Status|Pushed to master |RESOLVED --- Comment #42 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Enhancement - not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13888 CC| |martin.renvoize@ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13888 [Bug 13888] 'Lists' permission should allow/disallow using the lists module in staff -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org