https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 118461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118461&action=edit Bug 27981: Add option to automatically set 001 to the biblionumber This patch adds a new system preference: autoControlNumber The option "biblionumber" will set field 001 to the biblionumber when you create a new record or edit an existing record If set to 'OFF' the 001 field wil not be touched To test: 1 - Apply patches and updatedatabase 2 - Create a new record with no 001 field 3 - Save and view the MAC, confirm there is no 001 4 - Set the system preference to 'biblionumber' 5 - Edit the record you created previously 6 - Note the 001 is prepopulated with the biblionumber 7 - Delete the field 8 - Save the record 9 - View the MARC, the 001 is filled with biblionumber 10 - Edit the record 11 - Set the 001 to a different value "Not the biblionumber" 12 - Save 13 - View the marc and confirm the value you entered is retained 14 - Edit a record with an existing 001 that is not the biblionumber 15 - Save and confirm 001 is not updated -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- # Subtest: AddBiblio 1..4 not ok 1 - expected warnings when adding too long LCCN # Failed test 'expected warnings when adding too long LCCN' # at t/db_dependent/Biblio.t line 61. # found warning: Use of uninitialized value in string eq at /usr/share/koha/C4/Biblio.pm line 2630. # expected to find warning: (?^u:Data too long for column 'lccn') # expected to find warning: (?^u:Data too long for column 'lccn') not ok 2 - AddBiblio returns undef for biblionumber if something went wrong # Failed test 'AddBiblio returns undef for biblionumber if something went wrong' # at t/db_dependent/Biblio.t line 63. # got: '1572' # expected: undef not ok 3 - AddBiblio returns undef for biblioitemnumber if something went wrong # Failed test 'AddBiblio returns undef for biblioitemnumber if something went wrong' # at t/db_dependent/Biblio.t line 65. # got: '1508' # expected: undef not ok 4 - No biblio should have been added if something went wrong # Failed test 'No biblio should have been added if something went wrong' # at t/db_dependent/Biblio.t line 68. # got: '1031' # expected: '1030' # Looks like you failed 4 tests of 4. not ok 2 - AddBiblio # Failed test 'AddBiblio' # at t/db_dependent/Biblio.t line 70. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 118513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118513&action=edit Bug 27981: (follow-up) Set pref off for existing tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Frank Hansen <frank.hansen@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frank.hansen@ub.lu.se Status|Needs Signoff |Patch doesn't apply --- Comment #6 from Frank Hansen <frank.hansen@ub.lu.se> --- The patch doesn't apply: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 27981: Add option to automatically set 001 to the biblionumber Applying: Bug 27981: (follow-up) Set pref off for existing tests error: sha1 information is lacking or useless (members/memberentry.pl). error: could not build fake ancestor Patch failed at 0001 Bug 27981: (follow-up) Set pref off for existing tests Needs to be rebased? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118461|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 119704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119704&action=edit Bug 27981: Add option to automatically set 001 to the biblionumber This patch adds a new system preference: autoControlNumber The option "biblionumber" will set field 001 to the biblionumber when you create a new record or edit an existing record If set to 'OFF' the 001 field wil not be touched To test: 1 - Apply patches and updatedatabase 2 - Create a new record with no 001 field 3 - Save and view the MAC, confirm there is no 001 4 - Set the system preference to 'biblionumber' 5 - Edit the record you created previously 6 - Note the 001 is prepopulated with the biblionumber 7 - Delete the field 8 - Save the record 9 - View the MARC, the 001 is filled with biblionumber 10 - Edit the record 11 - Set the 001 to a different value "Not the biblionumber" 12 - Save 13 - View the marc and confirm the value you entered is retained 14 - Edit a record with an existing 001 that is not the biblionumber 15 - Save and confirm 001 is not updated -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Frank Hansen <frank.hansen@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Salman Ali <salman.ali@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119717|0 |1 is obsolete| | --- Comment #10 from Salman Ali <salman.ali@inLibro.com> --- Created attachment 121805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121805&action=edit Bug 27981: (follow-up) Set pref off for existing tests The patches applies now. I have tested it and can confirm that it works as intended. Signed-off-by: Frank Hansen <frank.hansen@ub.lu.se> Signed-off-by: Salman Ali <salman@outaouais> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- FAIL members/memberentry.pl OK critic FAIL forbidden patterns forbidden pattern: Data::Dumper::Dumper (line 112) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Note that the Biblio.t test already fails without this patch.. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Nick Clemens from comment #15)

(In reply to Marcel de Rooy from comment #14)

...

+ unless($record->field('001')){ + $record->insert_fields_ordered(MARC::Field->new('001', $biblionumber)); + }elsif($record->field('001')->data() eq 'biblionumber'){ + $record->field('001')->update($biblionumber); + }

Please explain. Why do you test eq 'biblionumber' ?? Why not always overwrite 001 with $biblionumber if the pref is set ?

Similar to autobarcode or automembernum - we will default, but if you force a new value we let it stand - I think allowing the librarian to force a different number allows for collections that fall outside the norm.

It could be useful for an OAI set for instance

Maybe you do not understand my point? Read this line:

...

+ }elsif($record->field('001')->data() eq 'biblionumber'){

You are comparing with the string biblionumber ! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- The problem with leaving a number might be when you are cloning records with Edit as new. When you do not modify that 001, it is probably wrong. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- + }elsif($record->field('001')->data() eq 'biblionumber'){ How and when will the 001 ever be string biblionumber ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 122280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122280&action=edit Bug 27981: (follow-up) Handle duplciation and remove debug There were some additional lines in the commits on accident I add a 'duplication' option to svc/bib and pass the parameter from rancor to remove the 001 if autoControlNumber is set I add code to addbiblio.pl to remove 001 in standard editor To test: 1 - Follow above test plan 2 - Edit a record as duplicate when using the advanced editor 3 - Confirm the 001 does not load, but record saves correctly 4 - Edit the record 5 - Switch to 'basic editor' 6 - Save, then view record 7 - Edit as duplicate in basic editor 8 - Confirm the 001 is removed 9 - Confirm the 001 is added on save -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #18)

The problem with leaving a number might be when you are cloning records with Edit as new. When you do not modify that 001, it is probably wrong.

New patch, back to NSO -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Hakam, should this be switched to signed off? I notice you only reattached the last patch. Usually we will add sign-off lines to all patches and then reattach them all with them. If you need help on how to do so, please let us know. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #25)

Hi Hakam, should this be switched to signed off?

I notice you only reattached the last patch. Usually we will add sign-off lines to all patches and then reattach them all with them. If you need help on how to do so, please let us know.

Oops it is somebody else :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #29 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- # Subtest: AddBiblio 1..5 not ok 1 - expected warnings when adding too long LCCN # Failed test 'expected warnings when adding too long LCCN' # at t/db_dependent/Biblio.t line 61. # found warning: Use of uninitialized value in string eq at /usr/share/koha/C4/Biblio.pm line 2632. # expected to find warning: (?^u:Data too long for column 'lccn') # expected to find warning: (?^u:Data too long for column 'lccn') not ok 2 - AddBiblio returns undef for biblionumber if something went wrong # Failed test 'AddBiblio returns undef for biblionumber if something went wrong' # at t/db_dependent/Biblio.t line 63. # got: '129' # expected: undef not ok 3 - AddBiblio returns undef for biblioitemnumber if something went wrong # Failed test 'AddBiblio returns undef for biblioitemnumber if something went wrong' # at t/db_dependent/Biblio.t line 65. # got: '129' # expected: undef not ok 4 - No biblio should have been added if something went wrong # Failed test 'No biblio should have been added if something went wrong' # at t/db_dependent/Biblio.t line 68. # got: '3' # expected: '2' not ok 5 - The biblionumber is correctly passed to BiblioAutoLink # Failed test 'The biblionumber is correctly passed to BiblioAutoLink' # at t/db_dependent/Biblio.t line 81. # found warning: Use of uninitialized value in string eq at /usr/share/koha/C4/Biblio.pm line 2632. # found warning: My biblionumber is 130 and my frameworkcode is at t/db_dependent/Biblio.t line 78. # expected to find warning: (?^u:My biblionumber is \d+ and my frameworkcode is ) # Looks like you failed 5 tests of 5. not ok 2 - AddBiblio -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #32 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #30)

Please cleanup your patches! Please amend the first patch where you delete the buggy lines too ;)

Patches squashed, back to NSO (In reply to Marcel de Rooy from comment #29)

# found warning: Use of uninitialized value in string eq at /usr/share/koha/C4/Biblio.pm line 2632. # found warning: My biblionumber is 130 and my frameworkcode is at t/db_dependent/Biblio.t line 78. # expected to find warning: (?^u:My biblionumber is \d+ and my frameworkcode is ) # Looks like you failed 5 tests of 5. not ok 2 - AddBiblio

I get the extra warning if i run the test before the DB update, but all is good after -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #34 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Nick Clemens from comment #32)

I get the extra warning if i run the test before the DB update, but all is good after

Still have it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #36 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #34)

(In reply to Nick Clemens from comment #32)

...

I get the extra warning if i run the test before the DB update, but all is good after

Still have it.

Forget this one: strict sql mode stuff.. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #38 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Nick: There is also another point still. If we update 001, we should update the orgcode too in 003. See also bug 28491 for authority counterpart. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122344|0 |1 is obsolete| | --- Comment #39 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 122672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122672&action=edit Bug 27981: Add option to automatically set 001 to the biblionumber This patch adds a new system preference: autoControlNumber The option "biblionumber" will set field 001 to the biblionumber when you create a new record or edit an existing record If set to 'OFF' the 001 field wil not be touched When duplicating a record the 001 will be removed if autoControlNumber is set To test: 1 - Apply patches and updatedatabase 2 - Create a new record with no 001 field 3 - Save and view the MAC, confirm there is no 001 4 - Set the system preference to 'biblionumber' 5 - Edit the record you created previously 6 - Note the 001 is prepopulated with the biblionumber 7 - Delete the field 8 - Save the record 9 - View the MARC, the 001 is filled with biblionumber 10 - Edit the record 11 - Set the 001 to a different value "Not the biblionumber" 12 - Save 13 - View the marc and confirm the value you entered is retained 14 - Edit a record with an existing 001 that is not the biblionumber 15 - Save and confirm 001 is not updated To test duplication: 1 - Edit a record as duplicate when using the advanced editor 2 - Confirm the 001 does not load, but record saves correctly 3 - Edit the record 4 - Switch to 'basic editor' 5 - Save, then view record 6 - Edit as duplicate in basic editor 7 - Confirm the 001 is removed 8 - Confirm the 001 is added on save -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28685 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #42 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Commit promises: The option "biblionumber" will set field 001 to the biblionumber when you create a new record or edit an existing record Create works, modify does not. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122672|0 |1 is obsolete| | --- Comment #44 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122675&action=edit Bug 27981: Add option to automatically set 001 to the biblionumber This patch adds a new system preference: autoControlNumber The option "biblionumber" will set field 001 to the biblionumber when you create a new record or edit an existing record If set to 'OFF' the 001 field wil not be touched When duplicating a record the 001 will be removed if autoControlNumber is set To test: 1 - Apply patches and updatedatabase 2 - Create a new record with no 001 field 3 - Save and view the MAC, confirm there is no 001 4 - Set the system preference to 'biblionumber' 5 - Edit the record you created previously 6 - Note the 001 is prepopulated with the biblionumber 7 - Delete the field 8 - Save the record 9 - View the MARC, the 001 is filled with biblionumber 10 - Edit the record 11 - Set the 001 to a different value "Not the biblionumber" 12 - Save 13 - View the marc and confirm the value you entered is retained 14 - Edit a record with an existing 001 that is not the biblionumber 15 - Save and confirm 001 is not updated To test duplication: 1 - Edit a record as duplicate when using the advanced editor 2 - Confirm the 001 does not load, but record saves correctly 3 - Edit the record 4 - Switch to 'basic editor' 5 - Save, then view record 6 - Edit as duplicate in basic editor 7 - Confirm the 001 is removed 8 - Confirm the 001 is added on save Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122674|0 |1 is obsolete| | Attachment #122675|0 |1 is obsolete| | --- Comment #47 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124279&action=edit Bug 27981: (QA follow-up) Adjust atomic update [1] Insert ignore. [2] Remove references to bug 9921. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #49 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124281&action=edit Bug 27981: Adjust imported records, svc/import_bibs, records from Z3950 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #51 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to David Cook from comment #46)

Thanks for working on this, Nick. This is a feature I've long wanted in Koha.

I've just taken a quick peek at the code, so just going to ask for some clarification.

At a glance, it looks like a 001 will be assigned for original cataloguing or copy cataloguing using the Cataloguing UI (even if it already has a 001), is that right? That sounds good to me.

I wonder about Staged MARC Imports though. At a glance, I think those will retain their original 001 and won't get updated. I think that might be problematic.

Same goes for the APIs.

Updated importing and svc/import_bibs -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124279|0 |1 is obsolete| | Attachment #124280|0 |1 is obsolete| | Attachment #124281|0 |1 is obsolete| | --- Comment #54 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 128223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128223&action=edit Bug 27981: DB update Current status: Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #56 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 128225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128225&action=edit Bug 27981: Adjust imported records, svc/import_bibs, records from Z3950 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #58 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132035&action=edit Bug 27981: Add option to automatically set 001 to the biblionumber This patch adds a new system preference: autoControlNumber The option "biblionumber" will set field 001 to the biblionumber when you create a new record or edit an existing record and clear the 001 field. If a value is present in 001 when saving the record it will be preserved. If set to 'OFF' the 001 field wil not be touched When duplicating a record the 001 will be removed if autoControlNumber is set To test: 1 - Apply patches and updatedatabase 2 - Create a new record with no 001 field 3 - Save and view the MAC, confirm there is no 001 4 - Set the system preference to 'biblionumber' 5 - Edit the record you created previously 6 - Note the 001 is prepopulated with the biblionumber 7 - Delete the field 8 - Save the record 9 - View the MARC, the 001 is filled with biblionumber 10 - Edit the record 11 - Set the 001 to a different value "Not the biblionumber" 12 - Save 13 - View the marc and confirm the value you entered is retained 14 - Edit a record with an existing 001 that is not the biblionumber 15 - Save and confirm 001 is not updated To test duplication: 1 - Edit a record as duplicate when using the advanced editor 2 - Confirm the 001 does not load, but record saves correctly 3 - Edit the record 4 - Switch to 'basic editor' 5 - Save, then view record 6 - Edit as duplicate in basic editor 7 - Confirm the 001 is removed 8 - Confirm the 001 is added on save Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |domm@plix.at --- Comment #60 from Thomas Klausner <domm@plix.at> --- I tested this feature, everything works as expected / documented, but I (currently) don't have time to set up a proper sign-off workflow ... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132034|0 |1 is obsolete| | --- Comment #61 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 134536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134536&action=edit Bug 27981: DB update Signed-off-by: Thomas Klausner <domm@plix.at> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132036|0 |1 is obsolete| | --- Comment #63 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 134538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134538&action=edit Bug 27981: Adjust imported records, svc/import_bibs, records from Z3950 Signed-off-by: Thomas Klausner <domm@plix.at> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #65 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Nick for adding the sign-off lines :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud@orex.es --- Comment #68 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 23832 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134536|0 |1 is obsolete| | Attachment #134537|0 |1 is obsolete| | Attachment #134538|0 |1 is obsolete| | Attachment #134539|0 |1 is obsolete| | Attachment #136022|0 |1 is obsolete| | --- Comment #69 from Andrew Nugged <nugged@gmail.com> --- Created attachment 140092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140092&action=edit Bug 27981: DB update Signed-off-by: Thomas Klausner <domm@plix.at> Signed-off-by: Andrew Nugged <nugged@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #71 from Andrew Nugged <nugged@gmail.com> --- Created attachment 140094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140094&action=edit Bug 27981: Adjust imported records, svc/import_bibs, records from Z3950 Signed-off-by: Thomas Klausner <domm@plix.at> Signed-off-by: Andrew Nugged <nugged@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #73 from Andrew Nugged <nugged@gmail.com> --- Created attachment 140096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140096&action=edit Bug 27981: (follow-up) Fix tests Signed-off-by: Andrew Nugged <nugged@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #75 from Andrew Nugged <nugged@gmail.com> --- Did QA & Rebased to the latest master. Also added 1 final patch (small polishing step) to use true/false everywhere to unify JS because, KohaBackend.GetRecord( id, remove_control_num, callback ); called in one place with remove_control_num to be 0 or 1, and in another place: KohaBackend.GetRecord( id, "", callback ); let's have it true/false, so the next developer will get from the context that this variable is only boolean. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #77 from Andrew Nugged <nugged@gmail.com> --- Future development note, but this is not in the scope of the CURRENT TICKET: Our librarians also noted that there's a 003 field which might also be auto-filled with some hardcoded value for this autofilled 001. They also noted that "However, it should be the case that the combination of 001 and 003 is always unique."). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |Needs documenting -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs documenting |RESOLVED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/665 Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes.