[Bug 44062] New: "From:" and "To:" in the patron notices delivery note need a translation context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44062 Bug ID: 44062 Summary: "From:" and "To:" in the patron notices delivery note need a translation context Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: paul.derscheid@lmscloud.de QA Contact: testopia@bugs.koha-community.org CC: caroline.cyr-la-rose@inlibro.com, f.demians@tamil.fr, jonathan.druart@gmail.com, julian.maurice@biblibre.com Target Milestone: --- The "Delivery note" column on the patron notices tab shows the sender and recipient of each sent message as "From:" and "To:". The same strings are used as date range labels across the staff interface (serials, invoices, parcels, overdues, ...), and translations follow that meaning. In German, the recipient is labelled "Bis:" (until) instead of "An:". To reproduce: 1. Install and enable a translation (e.g. de-DE) 2. Switch the staff interface to it 3. Go to a patron with at least one sent email notice > Notices 4. The delivery note shows "Bis:" before the recipient address members/notices.tt shares the msgids "From:" and "To:" with the date filters, so translators can only give each one meaning. Affects 24.05 and later (since Bug 18397). Main is affected. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44062 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18397, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=44059 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44062 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |paul.derscheid@lmscloud.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44062 --- Comment #1 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 211458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=211458&action=edit Bug 44062: Add translation context to notices From/To labels - The delivery note on the patron notices tab labels sender and recipient with "From:" and "To:", which are shared with the date range filters, so the recipient gets the date translation (de-DE: "Bis:") - Use tp('Message sender', 'From:') and tp('Message recipient', 'To:') so they get their own msgids Test plan: 1. Install a translation in KTD: koha-translate --install de-DE --dev kohadev 2. Enable it in the language system preferences and switch the staff interface to German 3. Go to a patron with an email address > Add message, choose "Email", enter a subject and body, save 4. Mark the message as sent: koha-mysql kohadev -e "UPDATE message_queue SET status='sent', from_address='library@example.org', to_address='patron@example.org' ORDER BY message_id DESC LIMIT 1" 5. Go to the patron's Notices tab 6. Without this patch, the delivery note shows "Bis:" before the recipient address 7. Apply the patch and update the strings: gulp po:update --lang de-DE 8. In misc/translator/po/de-DE-staff-prog.po, find msgctxt "Message recipient" / msgid "To:", set msgstr "An:", and msgctxt "Message sender" / msgid "From:", set msgstr "Von:"; remove the fuzzy flags if present 9. Install the translation: koha-translate --update de-DE --dev kohadev 10. Reload the Notices tab: the delivery note shows "Von:" and "An:" 11. Go to Circulation > Overdues: the date filter label is still "Bis:" Assisted-by: Opus 5.5 (Anthropic) Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44062 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- The patch no longer applies. I think this is related to Bug 33260 - Show message queue on staff interface and make notices printable, which was just pushed to main "today". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44062 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #211458|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44062 --- Comment #3 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 211593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=211593&action=edit Bug 44062: Add translation context to notices From/To labels - The delivery note on the patron notices tab labels sender and recipient with "From:" and "To:", which are shared with the date range filters, so the recipient gets the date translation (de-DE: "Bis:") - Use tp('Message sender', 'From:') and tp('Message recipient', 'To:') so they get their own msgids Test plan: 1. In a KTD root shell (ktd --root --shell), install a translation: koha-translate --install de-DE --dev kohadev 2. Enable it in the language system preferences and switch the staff interface to German 3. Go to a patron with an email address > Add message, choose "Email", enter a subject and body, save 4. In the KTD root shell, mark the message as sent: koha-mysql kohadev -e "UPDATE message_queue SET status='sent', from_address='library@example.org', to_address='patron@example.org' ORDER BY message_id DESC LIMIT 1" 5. Go to the patron's Notices tab 6. Without this patch, the delivery note shows "Bis:" before the recipient address 7. Apply the patch and update the strings: gulp po:update --lang de-DE 8. In misc/translator/po/de-DE-messages.po, find msgctxt "Message recipient" / msgid "To:", set msgstr "An:", and msgctxt "Message sender" / msgid "From:", set msgstr "Von:"; remove the fuzzy flags if present 9. In the KTD root shell, install the translation and restart Plack: koha-translate --update de-DE --dev kohadev koha-plack --restart kohadev 10. Reload the Notices tab: the delivery note shows "Von:" and "An:" 11. Go to Circulation > Overdues: the date filter label is still "Bis:" Assisted-by: Opus 5.5 (Anthropic) Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44062 --- Comment #4 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Hi David, thanks, you're right. Rebasing.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44062 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #211593|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44062 --- Comment #5 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 211594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=211594&action=edit Bug 44062: Add translation context to notices From/To labels - The delivery note on the patron notices tab and on Tools > Notices management labels sender and recipient with "From:" and "To:", which are shared with the date range filters, so the recipient gets the date translation (de-DE: "Bis:") - Use tp('Message sender', 'From:') and tp('Message recipient', 'To:') in members/notices.tt and tools/notices.tt, so they get their own msgids Test plan: 1. In a KTD root shell (ktd --root --shell), install a translation: koha-translate --install de-DE --dev kohadev 2. Enable it in the language system preferences and switch the staff interface to German 3. Go to a patron with an email address > Add message, choose "Email", enter a subject and body, save 4. In the KTD root shell, mark the message as sent: koha-mysql kohadev -e "UPDATE message_queue SET status='sent', from_address='library@example.org', to_address='patron@example.org' ORDER BY message_id DESC LIMIT 1" 5. Go to the patron's Notices tab 6. Without this patch, the delivery note shows "Bis:" before the recipient address 7. Apply the patch and update the strings: gulp po:update --lang de-DE 8. In misc/translator/po/de-DE-messages.po, find msgctxt "Message recipient" / msgid "To:", set msgstr "An:", and msgctxt "Message sender" / msgid "From:", set msgstr "Von:"; remove the fuzzy flags if present 9. In the KTD root shell, install the translation and restart Plack: koha-translate --update de-DE --dev kohadev koha-plack --restart kohadev 10. Reload the Notices tab: the delivery note shows "Von:" and "An:" 11. Go to Tools > Notices management and find the sent message: the delivery note shows "Von:" and "An:" 12. Go to Circulation > Overdues: the date filter label is still "Bis:" Assisted-by: Opus 5.5 (Anthropic) Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44062 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Rebased onto main after Bug 33260, which restructured members/notices.tt. Bug 33260 also added Tools > Notices management (tools/notices.tt), which has the same "From:"/"To:" delivery note labels. The patch now gives those the same contexts too, and the test plan has a step for that page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44062 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44062 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44062 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #211594|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44062 --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 211670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=211670&action=edit Bug 44062: Add translation context to notices From/To labels - The delivery note on the patron notices tab and on Tools > Notices management labels sender and recipient with "From:" and "To:", which are shared with the date range filters, so the recipient gets the date translation (de-DE: "Bis:") - Use tp('Message sender', 'From:') and tp('Message recipient', 'To:') in members/notices.tt and tools/notices.tt, so they get their own msgids Test plan: 1. In a KTD root shell (ktd --root --shell), install a translation: koha-translate --install de-DE --dev kohadev 2. Enable it in the language system preferences and switch the staff interface to German 3. Go to a patron with an email address > Add message, choose "Email", enter a subject and body, save 4. In the KTD root shell, mark the message as sent: koha-mysql kohadev -e "UPDATE message_queue SET status='sent', from_address='library@example.org', to_address='patron@example.org' ORDER BY message_id DESC LIMIT 1" 5. Go to the patron's Notices tab 6. Without this patch, the delivery note shows "Bis:" before the recipient address 7. Apply the patch and update the strings: gulp po:update --lang de-DE 8. In misc/translator/po/de-DE-messages.po, find msgctxt "Message recipient" / msgid "To:", set msgstr "An:", and msgctxt "Message sender" / msgid "From:", set msgstr "Von:"; remove the fuzzy flags if present 9. In the KTD root shell, install the translation and restart Plack: koha-translate --update de-DE --dev kohadev koha-plack --restart kohadev 10. Reload the Notices tab: the delivery note shows "Von:" and "An:" 11. Go to Tools > Notices management and find the sent message: the delivery note shows "Von:" and "An:" 12. Go to Circulation > Overdues: the date filter label is still "Bis:" Assisted-by: Opus 5.5 (Anthropic) Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44062 --- Comment #8 from David Nind <david@davidnind.com> --- Thanks Paul! Now signed off. Testing notes (using KTD): 1. For step 11: Enable the new system preference NoticesManagement. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org