https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #1 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 134716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134716&action=edit [En] Preservation module - Main principles -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134715|0 |1 is obsolete| | --- Comment #3 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 134732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134732&action=edit [Fr] Module Conservation - Note générale -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #5 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 134734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134734&action=edit [Fr] Module Conservation - Annexe 2 Specs 'Utilisateur' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134736|0 |1 is obsolete| | --- Comment #7 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 134737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134737&action=edit [Fr] Module Conservation - Annexe 3 Specs 'Architecture' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #10 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 134783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134783&action=edit [En] Preservation module - 2 'Users' specifications -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #12 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 134785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134785&action=edit [En] Preservation module - 4 Appendix -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Cécile Gobbo <cecile.gobbo@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cecile.gobbo@bulac.fr -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 mathilde.marechal@bulac.fr changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathilde.marechal@bulac.fr Saïra Munir Qureshi <saira.munir-qureshi@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |saira.munir-qureshi@bulac.f | |r -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jonathan.druart+koha@gmail. | |com Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com Change sponsored?|Seeking sponsor |Sponsored --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Progress on this new feature can be found at https://tree.taiga.io/project/joubu-koha-preservation-module/kanban The current state of the code is at https://gitlab.com/joubu/Koha/-/commits/bug_30708 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amaury.gau@bulac.fr -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34054 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34054 [Bug 34054] Allow to embed biblio on GET /items -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 152939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152939&action=edit Bug 30708: Add REST API controllers Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 152941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152941&action=edit Bug 30708: Add Koha Objects Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 152943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152943&action=edit Bug 30708: REST API specs Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #20 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 152945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152945&action=edit Bug 30708: DB changes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #22 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 152947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152947&action=edit Bug 30708: Koha controller script and template changes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #24 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 152949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152949&action=edit Bug 30708: Do not allow edition of 'status for item added to train' It does not seem useful to enforce it at lower level, it is not a condition that will break the feature, but it does not feel correct to allow the modification of this value Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #26 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 152951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152951&action=edit Bug 30708: Show the copy button right after the train is received Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #28 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 152953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152953&action=edit Bug 30708: Do not allow deletion of processings that are used Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #30 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 152955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152955&action=edit Bug 30708: Do not allow adding new items to a closed train Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #32 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 152957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152957&action=edit Bug 30708: DBIC specific Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #34 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 152959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152959&action=edit Bug 30708: DO NOT PUSH - ONLY FOR DB UPDATE DURING TESTING STAGE Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #36 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 152961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152961&action=edit Bug 30708: Allow modifying attribute linked with AV to another value If a value is not in the AV list, or if it differs slightly, they would like to force the modification of the value, without creating a new authorised value. Note that this could be a candidate for an option at the attribute level if there are different needs (ie. for some attributes we don't want to allow an other value). Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #38 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 152963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152963&action=edit Bug 30708: (follow-up) Add user_train_item_id Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #40 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 152965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152965&action=edit Bug 30708: Add spacing for buttons Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #42 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 152967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152967&action=edit Bug 30708: Add a default sort for trains We want opened, closed, sent, then finally received trains. But ordering by desc for opened, and asc for the others. Which means the last opened will be first, but the closed, send and received will display oldest first. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #44 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 152969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152969&action=edit Bug 30708: Deal with deleted authorised value categories If a AV category is renamed or deleted, the app will freeze with "TypeError: av_match is undefined" To prevent that we add an check to prevent the freeze and a warning in the settings. We could eventually add a FK on option_source, but the idea was to let it flexible in case we want to add another source. This bug can be considered a configuration error anyway. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #46 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This patchset has been deeply tested and approve by the sponsor. Keeping the "Needs signoff" status to get an independent signoff. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Heather <heather_hernandez@nps.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez@nps.gov --- Comment #49 from Heather <heather_hernandez@nps.gov> --- I just came across this--I want it SO much!! Unfortunately I don't have the expertise to do a sign off (I don't know how to do all the steps), but I hope someone who does know how to do it signs off on it!!!! --h2 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #51 from Heather <heather_hernandez@nps.gov> --- Hi! Thank you!! I am aware of that wiki page (it's SO helpful!) and have tested before, but I do have lots of questions (e.g., I don't see anyway to "reset all...") so I will send you an email! Cheerio! --h2 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #53 from Heather <heather_hernandez@nps.gov> --- Thank you again for your help & your email! I have some questions: Around step 7, I'm not sure I'm seeing everything I should when looking at a "Train"--I attached a screenshot. I'm not sure I saw all this: "Notice that the attributes linked with a database column are automatically pre filled. Notice that attributes linked with an authorised value are displayed with a dropdown list but that a different value can be set..." So maybe this is why the columns are empty? I followed the test plan exactly, and when I added items to the train, boxes were empty, and therefore the boxes in this column were empty. I was able to change the processing and get the different "non-column" display. Is this looking the way it should? I had a problem at step 9--it wouldn't allow me to add items to a train directly. I got an error saying I had to add items through the waiting list. Otherwise, everything worked! Let me know if the screenshot is looking the way it should. And let me know if I'm misunderstanding step 9. If these are OK, I can sign off! It looks like a great enhancement!!! Cheerio! h2 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #55 from Heather <heather_hernandez@nps.gov> --- Hi, Amaury-- Today I'm getting a different problem--there is no "PreservationModule" syspref--no sysprefs with *preservation* in them anywhere. When I try to apply this patch, I get this text: ---Begin quote: Bug 30708 Depends on bug 34054 (Signed Off) Follow? [(y)es, (n)o] Bug 34054 - Allow to embed biblio on GET /items 153819 - Bug 34054: Add tests 153820 - Bug 34054: Allow to embed biblio on GET /items Apply? [(y)es, (n)o, (i)nteractive] fatal: previous rebase directory .git/rebase-apply still exists but mbox given. Patch left in /tmp/Bug-34054-Add-tests-eehavq7y.patch Cannot apply cleanly patches from bug 34054. Everything will be left dirty. git bz apply --continue will not continue the process if patches from other bug reports need to be applied. {UNKNOWN}: Version control conflict marker at /kohadevbox/koha/Koha/Schema/Result/Item.pm line 961, near "<<<<<<<" Version control conflict marker at /kohadevbox/koha/Koha/Schema/Result/Item.pm line 964, near "=======" Version control conflict marker at /kohadevbox/koha/Koha/Schema/Result/Item.pm line 967, near ">>>>>>>" BEGIN not safe after errors--compilation aborted at /kohadevbox/koha/Koha/Schema/Result/Item.pm line 1015. Compilation failed in require at /usr/share/perl5/Class/C3/Componentised.pm line 146. at /usr/share/perl5/Class/C3/Componentised.pm line 151 Compilation failed in require at /kohadevbox/koha/C4/Installer.pm line 30. BEGIN failed--compilation aborted at /kohadevbox/koha/C4/Installer.pm line 30. Compilation failed in require at koha/installer/data/mysql/updatedatabase.pl line 40. BEGIN failed--compilation aborted at koha/installer/data/mysql/updatedatabase.pl line 40. ---End quote So perhaps there's a problem applying the patch to my sandbox? (My sandbox is here, http://sandboxes.ptfs-europe.co.uk/ ) Thank you for your help! --h2 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Laurence Rault <laurence.rault@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laurence.rault@biblibre.com --- Comment #57 from Laurence Rault <laurence.rault@biblibre.com> --- Tested on https://staff-preservatio.sandboxes.biblibre.eu 1. ok 2. ok 3. ok 4. ok Once a processing added, it can be removed (only if it is not used in a train), or edited 5. ok Possible to add items from waiting list. Also possible to update items from the catalog (or by batch item modification) with the status defined in PreservationNotForLoanWaitingListIn, they'll appear in the waiting list. 6. ok 7. ok Note : when adding manually a value not in the AV list for an attribute linked to an AV list, it does not update the AV list (and it is the feature). The content of attributes linked to db fields can also be changed : example, change in the title 8. ok 9. ok ? You can now add several items to a train, directly (for instance if you don't really need to pass through the waiting list) : I did not see that. From the train, you can only add one barcode at once. Possible only from the "Add last X items to a train" in the witing list. Values can be set for the batch, but attributes linked with a database column are not editable (they will be prefilled automatically) : ok 10. ok 11. ok 12. ok 13. ok In a closed ,sent, or received train, you cannot add new items, but you can edit them, and delete them : could deletion be a problem here ? 14. ok More : 1) in waiting items and train list, tables can be exported : the Actions column is exported with the data, should it be ? 2) Add items to a train : would it be possible, from a train, to check items in the waiting list to add them by batch ? (but maybe it has no sense because librarians have books in hand when filling a train) 3) It is not possible to re-open a train, would it be interesting ? 4) Item status does not change automatically at reception, may be useful to do that 5) In the train list, display the number of items in the train would be great 6) In the train the default processing is displayed, even if items have different processings. Maybe a processing different from the default should be displayed near its item ? 7) For a User not superlibrarian, with only Catalog and Preservation permission When going to Preservation module : Something went wrong : error 400 : KO 8) My impression is that pages display slowly, with message "Loading" displayed, even with very few data (waiting list, train, train creation...) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #59 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Laurence Rault from comment #57) Thanks!

9. ok ? You can now add several items to a train, directly (for instance if you don't really need to pass through the waiting list) : I did not see that. From the train, you can only add one barcode at once. Possible only from the "Add last X items to a train" in the witing list.

Yes, that's what I meant. Maybe the test plan was not clear. You cannot add (for now) more than one item to a train if you are not using the "Add last X items" link.

In a closed ,sent, or received train, you cannot add new items, but you can edit them, and delete them : could deletion be a problem here ?

Could be, I don't remember. Amaury?

More :

1) in waiting items and train list, tables can be exported : the Actions column is exported with the data, should it be ?

No, I will fix later.

2) Add items to a train : would it be possible, from a train, to check items in the waiting list to add them by batch ? (but maybe it has no sense because librarians have books in hand when filling a train)

Everything is possible ;) It's reported already on https://tree.taiga.io/project/joubu-koha-preservation-module/us/31

3) It is not possible to re-open a train, would it be interesting ?

We decided to keep it as simple as possible for a first version. Could be adjusted later.

4) Item status does not change automatically at reception, may be useful to do that

See https://tree.taiga.io/project/joubu-koha-preservation-module/us/10

5) In the train list, display the number of items in the train would be great

Good idea, I've created a new card https://tree.taiga.io/project/joubu-koha-preservation-module/us/40

6) In the train the default processing is displayed, even if items have different processings. Maybe a processing different from the default should be displayed near its item ?

Same, https://tree.taiga.io/project/joubu-koha-preservation-module/us/41

7) For a User not superlibrarian, with only Catalog and Preservation permission When going to Preservation module : Something went wrong : error 400 : KO

Ok, will fix later.

8) My impression is that pages display slowly, with message "Loading" displayed, even with very few data (waiting list, train, train creation...)

That's the sandboxes server, it is slow (and actually overloaded by a broken elastic box currently). (In reply to Heather from comment #58)

Hi! Hi :) Thanks, Heather!

So, how can I sign off...?

Just add a comment here, and switch the status to "Signed Off", I will deal with the rest of the signoff process myself. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34418, 34215 --- Comment #61 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #59)

(In reply to Laurence Rault from comment #57)

...

1) in waiting items and train list, tables can be exported : the Actions column is exported with the data, should it be ?

No, I will fix later.

See bug 34447, it's a global bugfix (will fix tables in the ERM module as well).

...

7) For a User not superlibrarian, with only Catalog and Preservation permission When going to Preservation module : Something went wrong : error 400 : KO

Ok, will fix later.

Good catch. I had to provide the same fix we wrote for bug ERM on bug 33606. Done in commit "Bug 30708: Rebase - Use a dedicated 'config' endpoint" However there is still a problem when the logged in user tries to set the settings without having the necessary permissions. I've adjusted the remote branch and the sandbox. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34215 [Bug 34215] Vue Toolbar component should be more flexible https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 [Bug 34418] Allow empty nodes in breadcrumb's elements -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #63 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #61)

However there is still a problem when the logged in user tries to set the settings without having the necessary permissions.

Fixed in a new patch "Bug 30708: Do not allow non-authorised users to edit the settings" I've adjusted the remote branch and the sandbox. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152940|0 |1 is obsolete| | Attachment #152941|0 |1 is obsolete| | Attachment #152942|0 |1 is obsolete| | Attachment #152943|0 |1 is obsolete| | Attachment #152944|0 |1 is obsolete| | Attachment #152945|0 |1 is obsolete| | Attachment #152946|0 |1 is obsolete| | Attachment #152947|0 |1 is obsolete| | Attachment #152948|0 |1 is obsolete| | Attachment #152949|0 |1 is obsolete| | Attachment #152950|0 |1 is obsolete| | Attachment #152951|0 |1 is obsolete| | Attachment #152952|0 |1 is obsolete| | Attachment #152953|0 |1 is obsolete| | Attachment #152954|0 |1 is obsolete| | Attachment #152955|0 |1 is obsolete| | Attachment #152956|0 |1 is obsolete| | Attachment #152957|0 |1 is obsolete| | Attachment #152958|0 |1 is obsolete| | Attachment #152959|0 |1 is obsolete| | Attachment #152960|0 |1 is obsolete| | Attachment #152961|0 |1 is obsolete| | Attachment #152962|0 |1 is obsolete| | Attachment #152963|0 |1 is obsolete| | Attachment #152964|0 |1 is obsolete| | Attachment #152965|0 |1 is obsolete| | Attachment #152966|0 |1 is obsolete| | Attachment #152967|0 |1 is obsolete| | Attachment #152968|0 |1 is obsolete| | Attachment #152969|0 |1 is obsolete| | Attachment #152970|0 |1 is obsolete| | Attachment #153102|0 |1 is obsolete| | --- Comment #65 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 154167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154167&action=edit Bug 30708: Add REST API controllers Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #67 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 154169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154169&action=edit Bug 30708: Add tests Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #69 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 154171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154171&action=edit Bug 30708: Vue app This commit contains the main commit message The description of the original need is described in documents attached by the sponsor on the bug report specifically "[En] Preservation module - Main principles". The idea is to develop a whole new module to track the status of the documents that are sent for processings/treatments in order to preserve them (eg. covering). This is a first step, more are certainly coming later. The author and sponsors have worked for several months before providing this MVP version. The different discussion and needs can be found at https://tree.taiga.io/project/joubu-koha-preservation-module/kanban Some ideas of the next steps are also listed. The first iterations have been done using the classic .pl/.tt Koha style but we finally switched to a new Vue module, for more fun. These patches made the following main changes: New files * Koha objects under Koha/Preservation * REST API controllers under Koha/REST/V1/Preservation * preservation/home.pl and preservation/home.tt * Vue components under js/vue/components/Preservation * tests under t/db_dependent/Koha/Preservation and t/db_dependent/api/v1/preservation_* * Cypress tests under t/cypress/integration/Preservation DB: * 3 new sysprefs PreservationModule, PreservationNotForLoanWaitingListIn, PreservationNotForLoanDefaultTrainIn * 1 new permission "preservation" (will be split into subpermissions later) * 5 new tables: - preservation_processings - preservation_trains - preservation_processing_attributes - preservation_trains_items - preservation_processing_attributes_items Terminology and workflow: *Processings* are the different treatments an item can receive during its stay in the preservation module A *processing* is defined by a list of *attributes*. To make the module as easy to use for the librarians in charge of the preservation area a list of processings will be defined when the module will be set up. An *attribute* is a name and a value. That's it. However it also has a type, to define what the value is coming from: *free text*, *authorised value* or *database column*. For instance if you are defining a processing that will handling the book cover you could have 3 *attributes*: - first named "Barcode" that will be automatically filled with "items.barcode" (type *database column*" - second attribute named "color" linked with a new PRES_COLOR authorised value category you would have previously defined with "red", "blue", "green", etc. (type *authorised value*) - third attribute named "notes", because librarians like notes (type *free text*) Important: Even if the attribute is linked with a DB column or AV category, the value will be automatically pre filled but will stay editable (could be a config option to restrict the edition, later, if needed). The *status* of an item will change during the preservation process. First it will arrive in the preservation area and be on a *waiting list*. It is not processed already but is not available anymore for the patrons of the library. That's why we are going to use the "not for loan" (items.notforloan) value for this. This *waiting list* is a fictional concept, it simply lists all the items in the library with a specific *status*. A *train* is... how they call that at the BULAC, a train (same in French!). And we quite like the word so we kept it. It is what it is: a list of items/waggons, one after each other. We could have picked "cart", "list", but the concepts were already used in different places. We are not strongly attached to the term and it can be modified (but it's spread all over the code already and will be tedious to modify!) if you have a very good suggestion :) So, a *train* is where items are going after they have been sent to the waiting list. It's a stack of items that will be sent to a provider. When you create a new train you will be asked for the "Status for item added to this train", that will be the "not for loan" value to set to the items added to this train, and a "Default processing" that will be the processing used. But keep in mind that a train can have items that have different processings (specific case, will see later). When all items have been added to a *train*, you can *close* it. You cannot add items anymore to it! Then you can *send* it, and finally *receive* it. They are just statuses to keep track of the dates, and filter trains by status. However when a train is received you can *copy* an item to another (opened) train. It means that you have the item on hand but something went wrong, you are not happy with the work done by the supplier and want to send it back, so you create a new train (that can have different items, and it is the case where you will have items in a train that don't all have the same processing!). Test plan: A. Prerequisites 0. Just `reset_all` and jump to B, or: 1. Apache configuration You will need to edit /etc/koha/apache-shared-intranet-git.conf and add the following lines after the RewriteRule for erm (line.24?) RewriteCond %{REQUEST_URI} !^/cgi-bin/koha/preservation/.*.pl$ RewriteRule ^/cgi-bin/koha/preservation/.*$ /cgi-bin/koha/preservation/home.pl [PT] The RewriteCond is only useful if you are testing the "print slips" bugs as well, but it cannot hurt to have it! 2. `yarn js:build` to regenerate the Vue app for the preservation module 3. `updatedatabase` 4. `restart_all` B. Settings 0. Create 2 different values for NOTLOAN, eg. 'In preservation' and 'In preservation external' Create different authorised values for a new category, eg. PRES_COLORS: RED, BLUE, GREEN. Feel free to create more categories. 1. You can turn on the "PreservationModule" syspref and go to the Koha homepage to see a new "Preservation" link 2. You landed on the empty home page of the preservation, no worry! We need to fill this page with useful information! (see #2 on the kanban) 3. Go to settings 4. Set "Status for item added to waiting list" to "In preservation" and "Default status for item added to train": "In preservation external" Create a new processing and define some attributes. Ideally at least one of each type. 5. Go to "Waiting list" and add some items 6. Go to "Trains" and create several trains (at least 2). Notice that the "Status for item added to this train" value is set to the value defined in the settings, but can be modified. Notice that this status can be set when a train is created but it won't be possible to edit later. 7. Add items to a train. You can only add items that are already in the waiting list. Add values for the attributes. Notice that the attributes linked with a database column are automatically pre filled. Notice that attributes linked with an authorised value are displayed with a dropdown list but that a different value can be set (remember, this is a feature!). Notice that attributes can be multivalued. 8. Add other items to the waiting list, notice the "Add last X items to a train" link at the top of the waiting list table, click it 9. You can now add several items to a train, directly (for instance if you don't really need to pass through the waiting list). Values can be set for the batch, but attributes linked with a database column are not editable (they will be prefilled automatically) 10. Once you have a train with several items, look at the "show train" view and notice the item list. If all of them are using the same processing then a table is displayed, one column per attribute. However if at least one item of the train has a different processing then the items are not listed in a table. 11. Edit items and confirm that the values are correctly saved. 12. Close, send and receive a train 13. Once a train is closed you can no longer add items to it 14. Once a train is received notice that you can "copy" an item to another (opened) train QA notes: The patch is huge! New enhancements and improvements have been moved to separate bug reports but this cannot be split. We need a ground base to build on top. The size is mainly coming from Vue components, Koha::Objects, REST API controllers and specs, and tests. Nothing hard ;) More to come: - See the kanban! - Print slips (bug 33547 and bug 34030) - Put something on the landing page! - Link with the acquisition module (suppliers, funds, etc.) Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #71 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 154173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154173&action=edit Bug 30708: Add apache RewriteRule Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #73 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 154175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154175&action=edit Bug 30708: Add user_train_item_id Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #75 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 154177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154177&action=edit Bug 30708: Keep item attributes when editing a new processing Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #77 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 154179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154179&action=edit Bug 30708: Duplicate/copy items to an opened train Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #79 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 154181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154181&action=edit Bug 30708: Do not allow copy item to a train if the item already exists in a non-received train Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #81 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 154183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154183&action=edit Bug 30708: DBIC schema changes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #83 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 154185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154185&action=edit Bug 30708: Allow attributes to be multivalued This is not working as it, but we are going to fix the problem when working on the "Set default values for items added in batch to a train" Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #85 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 154187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154187&action=edit Bug 30708: DBIC Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #87 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 154189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154189&action=edit Bug 30708: Set default values for items added in batch to a train Technical notes: Ideally we would have split TrainsFormAddItem to make some part reusable, but it turned out into a complicated component that would have been hard to maintain. It seems easier to have two different components. Ideas to improve this area are welcome! Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #89 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 154191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154191&action=edit Bug 30708: Add spacing for buttons Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #91 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 154193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154193&action=edit Bug 30708: Add a default sort for trains We want opened, closed, sent, then finally received trains. But ordering by desc for opened, and asc for the others. Which means the last opened will be first, but the closed, send and received will display oldest first. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #93 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 154195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154195&action=edit Bug 30708: Deal with deleted authorised value categories If a AV category is renamed or deleted, the app will freeze with "TypeError: av_match is undefined" To prevent that we add an check to prevent the freeze and a warning in the settings. We could eventually add a FK on option_source, but the idea was to let it flexible in case we want to add another source. This bug can be considered a configuration error anyway. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #95 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 154197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154197&action=edit Bug 30708: Remove q_header from specs It broke the REST API routes. Adjustement for bug 33971. Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #97 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 154199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154199&action=edit Bug 30708: Rebase - Rewrite toolbar Bug 33417 has changed how we handle the toolbars in Vue apps, this patch is adjusting the 'Preservation' module code on top of it, but also adds to make it more flexible (see bug 34215). Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #99 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 154201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154201&action=edit Bug 30708: Rebase - Adjust breadcrumbs To match what has been done on bug 33169 and bug 34418. Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #101 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 154203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154203&action=edit Bug 30708: Do not allow non-authorised users to edit the settings In case the logged in user does not have manage_sysprefs we should no display the form in the settings. Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #103 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #47)

Amaury (from BULAC) presented this development during a French conference (Symposium Kohala), here are the slides: https://drive.google.com/file/d/12IclGOcVrwivCNIg0KW1mBmaiukgpdp7/ view?usp=sharing

It contains some screenshots.

French text :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #105 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Seeing things like this in qa tools: DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'bundle_items' is trying to create a utility method called set_bundle_items. This will completely overwrite one such already existing method on class Koha::Schema::Result::Item. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #107 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- $c->validation errors too in qa tools -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #110 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 156596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156596&action=edit Bug 30708: Fix conflict with 34055 and 34219 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #112 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #105)

Seeing things like this in qa tools:

DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'bundle_items' is trying to create a utility method called set_bundle_items. This will completely overwrite one such already existing method on class Koha::Schema::Result::Item.

"bundle_items", that's not related to this development. It happens between the "before" and "after" the patch, we reload the different module (and so the schema file), that's why you see the warnings. (In reply to Marcel de Rooy from comment #106)

* Signed-off-by line 'Signed-off-by: BULAC - http://www.bulac.fr/' seems invalid

We could add the whole team, but I think is what they want here. (In reply to Marcel de Rooy from comment #107)

$c->validation errors too in qa tools

Fixed. Also fixed another bug. (In reply to Marcel de Rooy from comment #109)

And a few (innocent) notes during the process:

But keep in mind that a train can have items that have different processings (specific case, will see later).

Hum?

RewriteRule ^/cgi-bin/koha/preservation/.*$ /cgi-bin/koha/preservation/home.pl [PT]

Yes?

ASK Shouldnt we have a few default NFL statuses added now ?

I don't think so. It really depends on how the library will use the module. We could however add sample data in misc4dev.

POST /api/v1/preservation/waiting-list/items: unhandled exception (Koha::Exceptions::Preservation::MissingSettings)<<The following parameter settings is required: PreservationNotForLoanWaitingListIn>> POST /intranet/svc/config/systempreferences Did not work at the start without warns or alerts.. Related to CSRF bug. Now solved, but error checking could be improved.

I don't think so. Discussed already in PM: this was a programming error, and a programmer/reviewer must have the JS console opened (especially if something wrong happened). It's a whole global Koha question anyway, absolutely nothing directly related to this bug.

Home page Kind of weird to land at an empty page constantly.

Please see the kanban, still lot of things in mind. https://tree.taiga.io/project/joubu-koha-preservation-module/us/2 Note that we have the same for ERM.

user_train_item_id => $max + 1, Looking further, I wonder what is the exact use of this column? Cant really see when git grepping on it.

For display/info purpose. We want the items inside a given train to be numbered. This is the "ID" column displayed on the item table of the "show train" view.

If a value is not in the AV list, or if it differs slightly, they would like to force the modification of the value, without creating a new authorised value. - value: "Paraguay", => Not very clear.

(This is referring to bug 30708: Allow modifying attribute linked with AV to another value) Before this patch it was not possible de force the value of a dropdown list, you had to select a value from the AV list. With this patch it's possible to enter another value. AV list is only there as suggestions, but not to force a choice. Hence the rest of the commit message: """ Note that this could be a candidate for an option at the attribute level if there are different needs (ie. for some attributes we don't want to allow an other value). """ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154167|0 |1 is obsolete| | --- Comment #113 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 156636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156636&action=edit Bug 30708: Add REST API controllers Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154169|0 |1 is obsolete| | --- Comment #115 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 156638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156638&action=edit Bug 30708: Add tests Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154171|0 |1 is obsolete| | --- Comment #117 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 156640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156640&action=edit Bug 30708: Vue app This commit contains the main commit message The description of the original need is described in documents attached by the sponsor on the bug report specifically "[En] Preservation module - Main principles". The idea is to develop a whole new module to track the status of the documents that are sent for processings/treatments in order to preserve them (eg. covering). This is a first step, more are certainly coming later. The author and sponsors have worked for several months before providing this MVP version. The different discussion and needs can be found at https://tree.taiga.io/project/joubu-koha-preservation-module/kanban Some ideas of the next steps are also listed. The first iterations have been done using the classic .pl/.tt Koha style but we finally switched to a new Vue module, for more fun. These patches made the following main changes: New files * Koha objects under Koha/Preservation * REST API controllers under Koha/REST/V1/Preservation * preservation/home.pl and preservation/home.tt * Vue components under js/vue/components/Preservation * tests under t/db_dependent/Koha/Preservation and t/db_dependent/api/v1/preservation_* * Cypress tests under t/cypress/integration/Preservation DB: * 3 new sysprefs PreservationModule, PreservationNotForLoanWaitingListIn, PreservationNotForLoanDefaultTrainIn * 1 new permission "preservation" (will be split into subpermissions later) * 5 new tables: - preservation_processings - preservation_trains - preservation_processing_attributes - preservation_trains_items - preservation_processing_attributes_items Terminology and workflow: *Processings* are the different treatments an item can receive during its stay in the preservation module A *processing* is defined by a list of *attributes*. To make the module as easy to use for the librarians in charge of the preservation area a list of processings will be defined when the module will be set up. An *attribute* is a name and a value. That's it. However it also has a type, to define what the value is coming from: *free text*, *authorised value* or *database column*. For instance if you are defining a processing that will handling the book cover you could have 3 *attributes*: - first named "Barcode" that will be automatically filled with "items.barcode" (type *database column*" - second attribute named "color" linked with a new PRES_COLOR authorised value category you would have previously defined with "red", "blue", "green", etc. (type *authorised value*) - third attribute named "notes", because librarians like notes (type *free text*) Important: Even if the attribute is linked with a DB column or AV category, the value will be automatically pre filled but will stay editable (could be a config option to restrict the edition, later, if needed). The *status* of an item will change during the preservation process. First it will arrive in the preservation area and be on a *waiting list*. It is not processed already but is not available anymore for the patrons of the library. That's why we are going to use the "not for loan" (items.notforloan) value for this. This *waiting list* is a fictional concept, it simply lists all the items in the library with a specific *status*. A *train* is... how they call that at the BULAC, a train (same in French!). And we quite like the word so we kept it. It is what it is: a list of items/waggons, one after each other. We could have picked "cart", "list", but the concepts were already used in different places. We are not strongly attached to the term and it can be modified (but it's spread all over the code already and will be tedious to modify!) if you have a very good suggestion :) So, a *train* is where items are going after they have been sent to the waiting list. It's a stack of items that will be sent to a provider. When you create a new train you will be asked for the "Status for item added to this train", that will be the "not for loan" value to set to the items added to this train, and a "Default processing" that will be the processing used. But keep in mind that a train can have items that have different processings (specific case, will see later). When all items have been added to a *train*, you can *close* it. You cannot add items anymore to it! Then you can *send* it, and finally *receive* it. They are just statuses to keep track of the dates, and filter trains by status. However when a train is received you can *copy* an item to another (opened) train. It means that you have the item on hand but something went wrong, you are not happy with the work done by the supplier and want to send it back, so you create a new train (that can have different items, and it is the case where you will have items in a train that don't all have the same processing!). Test plan: A. Prerequisites 0. Just `reset_all` and jump to B, or: 1. Apache configuration You will need to edit /etc/koha/apache-shared-intranet-git.conf and add the following lines after the RewriteRule for erm (line.24?) RewriteCond %{REQUEST_URI} !^/cgi-bin/koha/preservation/.*.pl$ RewriteRule ^/cgi-bin/koha/preservation/.*$ /cgi-bin/koha/preservation/home.pl [PT] The RewriteCond is only useful if you are testing the "print slips" bugs as well, but it cannot hurt to have it! 2. `yarn js:build` to regenerate the Vue app for the preservation module 3. `updatedatabase` 4. `restart_all` B. Settings 0. Create 2 different values for NOTLOAN, eg. 'In preservation' and 'In preservation external' Create different authorised values for a new category, eg. PRES_COLORS: RED, BLUE, GREEN. Feel free to create more categories. 1. You can turn on the "PreservationModule" syspref and go to the Koha homepage to see a new "Preservation" link 2. You landed on the empty home page of the preservation, no worry! We need to fill this page with useful information! (see #2 on the kanban) 3. Go to settings 4. Set "Status for item added to waiting list" to "In preservation" and "Default status for item added to train": "In preservation external" Create a new processing and define some attributes. Ideally at least one of each type. 5. Go to "Waiting list" and add some items 6. Go to "Trains" and create several trains (at least 2). Notice that the "Status for item added to this train" value is set to the value defined in the settings, but can be modified. Notice that this status can be set when a train is created but it won't be possible to edit later. 7. Add items to a train. You can only add items that are already in the waiting list. Add values for the attributes. Notice that the attributes linked with a database column are automatically pre filled. Notice that attributes linked with an authorised value are displayed with a dropdown list but that a different value can be set (remember, this is a feature!). Notice that attributes can be multivalued. 8. Add other items to the waiting list, notice the "Add last X items to a train" link at the top of the waiting list table, click it 9. You can now add several items to a train, directly (for instance if you don't really need to pass through the waiting list). Values can be set for the batch, but attributes linked with a database column are not editable (they will be prefilled automatically) 10. Once you have a train with several items, look at the "show train" view and notice the item list. If all of them are using the same processing then a table is displayed, one column per attribute. However if at least one item of the train has a different processing then the items are not listed in a table. 11. Edit items and confirm that the values are correctly saved. 12. Close, send and receive a train 13. Once a train is closed you can no longer add items to it 14. Once a train is received notice that you can "copy" an item to another (opened) train QA notes: The patch is huge! New enhancements and improvements have been moved to separate bug reports but this cannot be split. We need a ground base to build on top. The size is mainly coming from Vue components, Koha::Objects, REST API controllers and specs, and tests. Nothing hard ;) More to come: - See the kanban! - Print slips (bug 33547 and bug 34030) - Put something on the landing page! - Link with the acquisition module (suppliers, funds, etc.) Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154173|0 |1 is obsolete| | --- Comment #119 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 156642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156642&action=edit Bug 30708: Add apache RewriteRule Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154175|0 |1 is obsolete| | --- Comment #121 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 156644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156644&action=edit Bug 30708: Add user_train_item_id Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154177|0 |1 is obsolete| | --- Comment #123 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 156646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156646&action=edit Bug 30708: Keep item attributes when editing a new processing Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154179|0 |1 is obsolete| | --- Comment #125 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 156648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156648&action=edit Bug 30708: Duplicate/copy items to an opened train Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154181|0 |1 is obsolete| | --- Comment #127 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 156650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156650&action=edit Bug 30708: Do not allow copy item to a train if the item already exists in a non-received train Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154183|0 |1 is obsolete| | --- Comment #129 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 156652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156652&action=edit Bug 30708: DBIC schema changes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154185|0 |1 is obsolete| | --- Comment #131 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 156654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156654&action=edit Bug 30708: Allow attributes to be multivalued This is not working as it, but we are going to fix the problem when working on the "Set default values for items added in batch to a train" Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154187|0 |1 is obsolete| | --- Comment #133 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 156656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156656&action=edit Bug 30708: DBIC Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154189|0 |1 is obsolete| | --- Comment #135 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 156658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156658&action=edit Bug 30708: Set default values for items added in batch to a train Technical notes: Ideally we would have split TrainsFormAddItem to make some part reusable, but it turned out into a complicated component that would have been hard to maintain. It seems easier to have two different components. Ideas to improve this area are welcome! Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154191|0 |1 is obsolete| | --- Comment #137 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 156660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156660&action=edit Bug 30708: Add spacing for buttons Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154193|0 |1 is obsolete| | --- Comment #139 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 156662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156662&action=edit Bug 30708: Add a default sort for trains We want opened, closed, sent, then finally received trains. But ordering by desc for opened, and asc for the others. Which means the last opened will be first, but the closed, send and received will display oldest first. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154195|0 |1 is obsolete| | --- Comment #141 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 156664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156664&action=edit Bug 30708: Deal with deleted authorised value categories If a AV category is renamed or deleted, the app will freeze with "TypeError: av_match is undefined" To prevent that we add an check to prevent the freeze and a warning in the settings. We could eventually add a FK on option_source, but the idea was to let it flexible in case we want to add another source. This bug can be considered a configuration error anyway. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154197|0 |1 is obsolete| | --- Comment #143 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 156666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156666&action=edit Bug 30708: Remove q_header from specs It broke the REST API routes. Adjustement for bug 33971. Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154199|0 |1 is obsolete| | --- Comment #145 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 156668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156668&action=edit Bug 30708: Rebase - Rewrite toolbar Bug 33417 has changed how we handle the toolbars in Vue apps, this patch is adjusting the 'Preservation' module code on top of it, but also adds to make it more flexible (see bug 34215). Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154201|0 |1 is obsolete| | --- Comment #147 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 156670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156670&action=edit Bug 30708: Rebase - Adjust breadcrumbs To match what has been done on bug 33169 and bug 34418. Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154203|0 |1 is obsolete| | --- Comment #149 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 156672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156672&action=edit Bug 30708: Do not allow non-authorised users to edit the settings In case the logged in user does not have manage_sysprefs we should no display the form in the settings. Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156596|0 |1 is obsolete| | --- Comment #151 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 156674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156674&action=edit Bug 30708: Fix conflict with 34055 and 34219 Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #153 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- See former comments. Looks good to me. Another set of QA eyes would not hurt but I do not feel that it is a must. Feel free to change status back and have another QA round if so. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #154 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #153)

See former comments. Looks good to me. Another set of QA eyes would not hurt but I do not feel that it is a must. Feel free to change status back and have another QA round if so.

I didn't read the code, but I ran through the test plan to QA the notice slips, things work as expected and seems like a cool new workflow -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Bug 30708 depends on bug 34055, which changed state. Bug 34055 Summary: Add API client class to get items https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34055 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #155 from David Cook <dcook@prosentient.com.au> --- Apologies for coming in this late, but I'm a bit concerned about the use of the term "train" here. Jonathan has explained the term at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708#c19 and I've briefly read through the "Utilisateurs"/"Users" specifications. The French PDF uses the term "Train" while the English PDF uses the term "Batch", which is a more common term in English and in Koha. I took a preservation course during my librarian degree and I'd never heard the term "train" used in the context of preservation, so I think librarians with previous preservation experience might be confused/confronted by preservation in Koha. I imagine that this might also cause some issues for translators? I've briefly moved the status from "Passed QA" to "In Discussion" as I'd like to gather some more feedback about this term... ...but at the same time I don't necessarily want to hold up this development. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #157 from Heather <heather_hernandez@nps.gov> --- Hi! I think the fact that the term "train" is a cognate in English and French, two widely used languages worldwide, is a strong argument in its favor. Although https://wiki.koha-community.org/wiki/Documentation_-_Content_Development_Gui... states, "Language - US English (Simplified)," the word "train" is very common. Moreover, a "truck train" is a commonly understood term for a bunch of trailers attached to one cab--and a preservation "train" is a similar thing, with a bunch of items needing preservation treatments all going off together! Yes--"batch" is more commonly used in US English preservation work. And, yes, we are preferring US English in the Koha English interface (e.g., the button says "Cataloging" not "Cataloguing"), but, to me, that doesn't mean that one necessarily needs to select a more common term in a non-automated workflow when automating the workflow. I think the Preservation Module in Koha will be automating workflows in A LOT of libraries that have not had the opportunity to incorporate automated preservation workflows into their ILS, and so it will be easy to adapt to saying, e.g., "This batch that we used to represent on a spreadsheet will be represented in a Koha Train." (We all call "developments" "bugs" and got used to that, too!) (And am I the only one hearing the song, "C'mon N' Ride It (The Train)" every time I think about this bug? "It's the choo choo! It's the choo choo!!") A Koha Train. Makes sense to me! But I also would happily stand aside on the issue if others feel strongly about changing the language to "batch"--it's not a big deal for me. --USian Cataloger Who Also Does Preservation, h2:) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #159 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Heather, I admit, I also stumbled on the train terminology - for translators I think it might be easier to use batch. I remember someone abbreviated category with 'cat' in the GUI once, and you can imagine how well that ended ;) *meow* But: I would not insist on changing it, knowing it's a term used in preservation. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #161 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am ok with keeping it as Heather confirmed as a native speaker that it makes sense to her. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35071 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35071 [Bug 35071] Disambiguate "train" for translators -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #164 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- So with the amount of testing we got here - Nick also said he ran through the test plan I think - are we ready to push? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #165 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #167 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 157503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157503&action=edit Bug 30708: Some spec fixes Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #169 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 157508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157508&action=edit Bug 30708: Fix API specs -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #171 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 157514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157514&action=edit Bug 30708: Adjust spec for train_item -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35230 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35230 [Bug 35230] `catalogue_item` missing description -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Angela Berrett <angela.berrett@familysearch.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |angela.berrett@familysearch | |.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35377 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35377 [Bug 35377] Terminology: Callnumber shoudl be call number -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35376 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35376 [Bug 35376] Rephrase: Be careful removing attribute to this processing, the items using it will be impacted as well! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Component|Tools |Preservation -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35476 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35476 [Bug 35476] Submit button for adding new processings is not translatable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36565 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565 [Bug 36565] Fix API docs inconsistencies -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Angela Berrett <angela.berrett@familysearch.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36286 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36286 [Bug 36286] Add ability to upload files/images in Preservation Module -- You are receiving this mail because: You are watching all bug changes.