[Bug 20515] New: "ILL Request" menu options displayed when user has no ILL permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 Bug ID: 20515 Summary: "ILL Request" menu options displayed when user has no ILL permissions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: andrew.isherwood@ptfs-europe.com When the Interlibrary Loans module is enabled the menu option "ILL Requests" is added to the main intranet screen and the "More" dropdown menu. These options are displayed regardless of whether the logged in user has any permissions on this module. They should only be displayed if the user has permissions to work with ILL. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 --- Comment #1 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 73615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73615&action=edit Bug 20515 - "ILL Request" menu options displayed when user has no ILL This patch adds the following additional conditions to the display of both the ILL Requests drop down "More" menu option and the "ILL Requests" option on the intranet front page: Before: [% IF Koha.Preference('ILLModule') %] After: [% IF Koha.Preference('ILLModule') && (CAN_user_ill || CAN_user_superlibrarian) %] This prevents the options being displayed to users who have no permissions to work with ILL. Test plan: View both the intranet front page and "More" dropdown while logged in as a user without ILL permissions, ensure the options do not display. Then do the same with a user with ILL permissions, ensure the options do display. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7317 CC| |martin.renvoize@ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73615|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 73643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73643&action=edit Bug 20515 - "ILL Request" menu options displayed when user has no ILL This patch adds the following additional conditions to the display of both the ILL Requests drop down "More" menu option and the "ILL Requests" option on the intranet front page: Before: [% IF Koha.Preference('ILLModule') %] After: [% IF Koha.Preference('ILLModule') && (CAN_user_ill || CAN_user_superlibrarian) %] This prevents the options being displayed to users who have no permissions to work with ILL. Test plan: View both the intranet front page and "More" dropdown while logged in as a user without ILL permissions, ensure the options do not display. Then do the same with a user with ILL permissions, ensure the options do display. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Andrew, all good, but you don't need the superlibrarian bit - can you please remove those in a little follow up and set back to signed off? Thx! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20536 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536 [Bug 20536] ILL: authnotrequired not explicitly unset -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|20536 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536 [Bug 20536] ILL: authnotrequired not explicitly unset -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 --- Comment #4 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 73875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73875&action=edit Bug [20515] - [Follow up] Removed the test for CAN_user_superlibrarian as requested -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer@bsz-bw.de Assignee|koha-bugs@lists.koha-commun |andrew.isherwood@ptfs-europ |ity.org |e.com --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Andrew, please remember to set the Assignee field! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73643|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74065&action=edit Bug 20515 - "ILL Request" menu options displayed when user has no ILL This patch adds the following additional conditions to the display of both the ILL Requests drop down "More" menu option and the "ILL Requests" option on the intranet front page: Before: [% IF Koha.Preference('ILLModule') %] After: [% IF Koha.Preference('ILLModule') && (CAN_user_ill || CAN_user_superlibrarian) %] This prevents the options being displayed to users who have no permissions to work with ILL. Test plan: View both the intranet front page and "More" dropdown while logged in as a user without ILL permissions, ensure the options do not display. Then do the same with a user with ILL permissions, ensure the options do display. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73875|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74066&action=edit Bug [20515] - [Follow up] Removed the test for CAN_user_superlibrarian as requested Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74067&action=edit Bug 20515: Fix permission check on "ILL request" menu options This patch adds the following additional conditions to the display of both the ILL Requests drop down "More" menu option and the "ILL Requests" option on the intranet front page: Before: [% IF Koha.Preference('ILLModule') %] After: [% IF Koha.Preference('ILLModule') && (CAN_user_ill || CAN_user_superlibrarian) %] This prevents the options being displayed to users who have no permissions to work with ILL. Test plan: View both the intranet front page and "More" dropdown while logged in as a user without ILL permissions, ensure the options do not display. Then do the same with a user with ILL permissions, ensure the options do display. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74068&action=edit Bug 20515: (QA follow-up) Remove specific superlibrarian check Removed the test for CAN_user_superlibrarian as requested Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74065|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74066|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've also fixed the commit messages (free this time ;) ), but please take a look at https://wiki.koha-community.org/wiki/Commit_messages for your next patches! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What about this one too? 121 [% IF Koha.Preference('ILLModule') %] 122 <li><a href="/cgi-bin/koha/ill/ill-requests.pl?borrowernumber=[% patron.borrowernumber %]">Interlibrary loans</a></li> 123 [% END %] koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 --- Comment #12 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 74154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74154&action=edit Bug 20515: (follow-up) Add missing CAN_user_ill This follow up patch adds two missing CAN_user_ill tests in templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74154|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74194&action=edit Bug 20515: (follow-up) Add missing CAN_user_ill This follow up patch adds two missing CAN_user_ill tests in templates Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74195&action=edit Bug 20515: (QA follow-up) Fix capitalization on 'Ill Requests' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Took the chance to fix a tiny capitalization error pointed out by the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Patches pushed to master for 18.05 Congratulations Andrew for your first patches in! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20646 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20646 [Bug 20646] "ILL Request" menu options not displayed when user has superlibrarian permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think we miss a change in Auth.pm: 297 if ( $flags && $flags->{superlibrarian} == 1 ) { 298 $template->param( CAN_user_circulate => 1 ); And that should probably use IsSuperLibrarian()for the check (see bug 20649) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 Joe McGlynn <joe.mcglynn@educampus.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joe.mcglynn@educampus.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 Bug 20515 depends on bug 7317, which changed state. Bug 7317 Summary: Add an Interlibrary Loan Module to Circulation and OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|20646 | --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- *** Bug 20646 has been marked as a duplicate of this bug. *** Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20646 [Bug 20646] "ILL Request" menu options not displayed when user has superlibrarian permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org