[Bug 43319] New: Remove event attribute from library_groups.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43319 Bug ID: 43319 Summary: Remove event attribute from library_groups.tt Initiative type: --- Sponsorship Sponsored status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, testopia@bugs.koha-community.org Blocks: 38407 Target Milestone: --- There is an event attribute in library_groups.tt which can be dropped in favor of some restructuring of the pop-up menu markup. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 [Bug 38407] Eliminate event handler attributes in the staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43319 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Comma delimited| |Athens County Public list of Sponsors| |Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43319 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 203686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203686&action=edit Bug 43319: Remove event attribute from library_groups.tt This patch updates the library groups administration page so that an event attribute is not necessary. We don't need an onclick event handler to submit the form--we can just use a submit button as the menu item. To test, apply the patch and go to Administration -> Library groups. - If necessary, create a new library group. - From the list of groups, click an "Add library" menu button and then click one of the libraries which appear as menu items. - The page should reload and the library you selected should now show up as being part of that library group. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43319 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43319 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43319 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43319 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203686|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43319 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 204346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204346&action=edit Bug 43319: Remove event attribute from library_groups.tt This patch updates the library groups administration page so that an event attribute is not necessary. We don't need an onclick event handler to submit the form--we can just use a submit button as the menu item. To test, apply the patch and go to Administration -> Library groups. - If necessary, create a new library group. - From the list of groups, click an "Add library" menu button and then click one of the libraries which appear as menu items. - The page should reload and the library you selected should now show up as being part of that library group. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43319 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43319 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204346|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43319 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 204878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204878&action=edit Bug 43319: Remove event attribute from library_groups.tt This patch updates the library groups administration page so that an event attribute is not necessary. We don't need an onclick event handler to submit the form--we can just use a submit button as the menu item. To test, apply the patch and go to Administration -> Library groups. - If necessary, create a new library group. - From the list of groups, click an "Add library" menu button and then click one of the libraries which appear as menu items. - The page should reload and the library you selected should now show up as being part of that library group. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43319 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43319 --- Comment #4 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org