https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40807 Chloé Zermatten <chloe.zermatten@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |chloe.zermatten@openfifth.c |ity.org |o.uk --- Comment #1 from Chloé Zermatten <chloe.zermatten@openfifth.co.uk> --- The issue seems to be that the <input type="text" disabled="disabled" style="display:none" /> dummy input added "avoid Firefox from using userid/password saved for authentication" as per the code comment does not play ball with the change introduced by Bug 38459, which modifies the origin_input_id check to ensure that we check the value of the last child. The simplest (though maybe slightly hack-y?) solution appears to be to just invert the order of the input fields in the template, so the last child is the true input. Patch coming up. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40807 Chloé Zermatten <chloe.zermatten@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40807 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186400|0 |1 is obsolete| | --- Comment #3 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 186591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186591&action=edit Bug 40807: fix: username field in quick add form The username field would not appear in the quick add form despite being marked as required in BorrowerMandatoryField. This was due the interaction between a change introduced by Bug 38459 and the dummy input for the username field. This patch moves the dummy input so that the true input is the last child that the change in Bug 38459 targets. This allows the username field to appear when added to BorrowerMandatoryField. Test plan: 0. (Before applying the patch, follow the replication tests as in the comment above.) 1. Login to the Koha staff interface 2. Search system preferences for BorrowerMandatoryField 3. Toggle on Username (userid) so it is added to the list of fields and save your changes. 4. Navigate to /cgi-bin/koha/members/memberentry.pl?op=add_form&categorycode=PT, notice that username still shows and is marked as required 5. Navigate to /cgi-bin/koha/members/memberentry.pl?op=add_form&categorycode=PT&quickadd=true, notice that the username field does show. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40807 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186591|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 186601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186601&action=edit Bug 40807: fix: username field in quick add form The username field would not appear in the quick add form despite being marked as required in BorrowerMandatoryField. This was due the interaction between a change introduced by Bug 38459 and the dummy input for the username field. This patch moves the dummy input so that the true input is the last child that the change in Bug 38459 targets. This allows the username field to appear when added to BorrowerMandatoryField. Test plan: 0. (Before applying the patch, follow the replication tests as in the comment above.) 1. Login to the Koha staff interface 2. Search system preferences for BorrowerMandatoryField 3. Toggle on Username (userid) so it is added to the list of fields and save your changes. 4. Navigate to /cgi-bin/koha/members/memberentry.pl?op=add_form&categorycode=PT, notice that username still shows and is marked as required 5. Navigate to /cgi-bin/koha/members/memberentry.pl?op=add_form&categorycode=PT&quickadd=true, notice that the username field does show. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40807 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40807 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.04 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40807 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable Version(s)|25.11.00,25.05.04 |25.11.00,25.05.04,24.11.10 released in| | --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes.