[Bug 20781] New: 0 months is not a valid enrollment period and causes errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20781 Bug ID: 20781 Summary: 0 months is not a valid enrollment period and causes errors Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com To recreate: 1 - Browse to Admin->Patron Categories 2 - Click '+ New category' 3 - Enter data as required, however, enter 0 in 'Enrolment period' -> 'in months' 4 - Save 5 - View the list of categories, the new category has 'Enrolment period' = 'until' 6 - Create a patron in this category 7 - Search for them 8 - internal server error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20781 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20781 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20781 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 75433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75433&action=edit Bug 20781: Set a minimum enrollemnt period 'in months' of 1 To test: 1 - Browse to Admin->Patron Categories 2 - Click '+ New category' 3 - Enter data as required, however, enter 0 in 'Enrolment period' -> 'in months' 4 - Save 5 - View the list of categories, the new category has 'Enrolment period' = 'until' 6 - Create a patron in this category, note their dateexipry is '0000-00-00' 7 - Search for them 8 - internal server error 9 - Delete that patron 10 - Apply patch 11 - Edit the category, note you cannot save with 0 months 12 - Set 1 month and save 13 - Create a patron in this cateogry 14 - Note they have a valid dateexpiry 15 - Search for them 16 - All works 17 - Create a new category and verify you cannot add with 0 months -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20781 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20781 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75433|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 75437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75437&action=edit Bug 20781: Set a minimum enrollemnt period 'in months' of 1 To test: 1 - Browse to Admin->Patron Categories 2 - Click '+ New category' 3 - Enter data as required, however, enter 0 in 'Enrolment period' -> 'in months' 4 - Save 5 - View the list of categories, the new category has 'Enrolment period' = 'until' 6 - Create a patron in this category, note their dateexipry is '0000-00-00' 7 - Search for them 8 - internal server error 9 - Delete that patron 10 - Apply patch 11 - Edit the category, note you cannot save with 0 months 12 - Set 1 month and save 13 - Create a patron in this cateogry 14 - Note they have a valid dateexpiry 15 - Search for them 16 - All works 17 - Create a new category and verify you cannot add with 0 months Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20781 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20781 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75437|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 75553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75553&action=edit Bug 20781: Set a minimum enrollemnt period 'in months' of 1 To test: 1 - Browse to Admin->Patron Categories 2 - Click '+ New category' 3 - Enter data as required, however, enter 0 in 'Enrolment period' -> 'in months' 4 - Save 5 - View the list of categories, the new category has 'Enrolment period' = 'until' 6 - Create a patron in this category, note their dateexipry is '0000-00-00' 7 - Search for them 8 - internal server error 9 - Delete that patron 10 - Apply patch 11 - Edit the category, note you cannot save with 0 months 12 - Set 1 month and save 13 - Create a patron in this cateogry 14 - Note they have a valid dateexpiry 15 - Search for them 16 - All works 17 - Create a new category and verify you cannot add with 0 months Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20781 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 75554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75554&action=edit Bug 20781: (QA follow-up) Remove unneeded rules These rules do not have any meaning. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20781 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20781 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #4)
Created attachment 75554 [details] [review] Bug 20781: (QA follow-up) Remove unneeded rules
These rules do not have any meaning.
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Hmm...without these rules we can enter a value in both fields - going to skip this patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20781 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Pushed to master for 18.11. Awesome work all, thank you. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20781 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This patch has been pushed to 18.05.x and will be in 18.05.01 Also skipped the second patch here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20781 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20781 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org