[Bug 26403] New: "Issue refund" is not fully translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Bug ID: 26403 Summary: "Issue refund" is not fully translatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Depends on: 23442 The new "issue refund" that is available for payments is not fully translatable. This is a big issue. To test: - Make sure a language with a complete translation is installed - Switch to the language - Go to any user account - Add a manual invoice - Pay it off fully or partially - Click on "issue refund" - Verify the list of "Transaction types" is not translated - Check the information in the patron account. It will show: Payment from library to patron A refund applied to a patrons fine - Check in the OPAC - same issue there. There is no option to edit the hardcoded credit and debit type descriptions? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 [Bug 23442] Add a 'refund' process to accounts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #0)
The new "issue refund" that is available for payments is not fully translatable. This is a big issue.
To test: - Make sure a language with a complete translation is installed - Switch to the language - Go to any user account - Add a manual invoice - Pay it off fully or partially - Click on "issue refund" - Verify the list of "Transaction types" is not translated - Check the information in the patron account. It will show:
Payment from library to patron A refund applied to a patrons fine
- Check in the OPAC - same issue there.
There is no option to edit the hardcoded credit and debit type descriptions?
The reason one cannot edit the descriptions for these hardcoded types is precisely for translation reasons. If it's a system code it should appear in the translation template and thus the description in the DB will never get called. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26398 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26398 [Bug 26398] Credit type on creating a manual credit is not translatable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- These are not credit types, but rather the 'payment_type' authorized values... as such to be translatable we need translatable AV's first.... or to merge payment_types into credit_types.. but I'm still not entirely sure about that one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|26398 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26398 [Bug 26398] Credit and Debit types on creating a manual credits and manual invoices are not translatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20307 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 [Bug 20307] Language overlay for authorized values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #2)
These are not credit types, but rather the 'payment_type' authorized values... as such to be translatable we need translatable AV's first.... or to merge payment_types into credit_types.. but I'm still not entirely sure about that one.
Hm, it was labelled credit types - so maybe the label is wrong then? But what you are saying is good for the descriptions in the "history" - we "just" need to add them to the templates. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure why this is BLOCKED? We can at least fix a part of this now and we should - translations for authorised values doesn't apply to all points here and it's not around the corner. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 109816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109816&action=edit Account summary showing English descriptions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26418 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26418 [Bug 26418] The "description" for REFUND accountlines is not translatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|26418 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26418 [Bug 26418] The "description" for REFUND accountlines is not translatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26418 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26418 [Bug 26418] The "description" for REFUND accountlines is not translatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've split this bug in two.. one for the description which is fixable and leaving this one here for the transaction type which is blocked by AV translations. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23442 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 [Bug 23442] Add a 'refund' process to accounts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Is this the bug for account_credit_types and account_debit_types being installed in English only? I have to go into every one of my installations and manually change the database descriptions... My problem is specifically when installing in another language, not switching between languages. My hypothesis is that those values are in installer/data/mysql/mandatory rather than installer/data/mysql/en/mandatory If they were in /en/, they would show up in the translation files. Does that make sense? Could we consider moving them? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 --- Comment #8 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 148940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148940&action=edit YAML file for credit types I tried to transfer the credit types into a yaml file to put into the /en/ directory. Didn't have time to do the rest (CASH payment type, which is also untranslated, and account debit types, and remove the sql files). Let me know if this is OK and I'll be able to continue another day -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 149104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149104&action=edit Bug 26403: "Issue refund" is not fully translatable This patch moves account debit and credit types, as well as the CASH payment type, into YAML files under installer/data/en/mandatory. This should make the debit and credit types translatable (for new installations only). To test: 1. Apply patch 2. Update po files ./misc/translator/translate update xx-XX 3. View the xx-XX-installer.po file -->The default account debit and credit types (and cash payment type) should be available to be translated 4. Translate the strings 5. Apply the translations ./misc/translator/translate install xx-XX 6. Load the new translated YAML files (with a fresh install, or by deleting the values in the db and using ./misc/load_yaml.pl to load the files) 7. In the staff interface, go to Administration > Credit types --> They should be translated 8. Go to Administration > Debit types --> They should be translated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 --- Comment #10 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 149105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149105&action=edit Bug 26403: (follow-up) Deleted old SQL files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #11 from Magnus Enger <magnus@libriotech.no> --- Trying to apply the patches, I get this: $ git bz apply 26403 Bug 26403 Depends on bug 20307 (BLOCKED) As far as I can tell "Bug 20307 - Language overlay for authorized values" is for getting translateable authorised values in the interface, which would be another solution to this problem? Or is there a connection between these two bugs that I am not seeing? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149104|0 |1 is obsolete| | --- Comment #12 from Magnus Enger <magnus@libriotech.no> --- Created attachment 150744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150744&action=edit Bug 26403: "Issue refund" is not fully translatable This patch moves account debit and credit types, as well as the CASH payment type, into YAML files under installer/data/en/mandatory. This should make the debit and credit types translatable (for new installations only). To test: 1. Apply patch 2. Update po files ./misc/translator/translate update xx-XX 3. View the xx-XX-installer.po file -->The default account debit and credit types (and cash payment type) should be available to be translated 4. Translate the strings 5. Apply the translations ./misc/translator/translate install xx-XX 6. Load the new translated YAML files (with a fresh install, or by deleting the values in the db and using ./misc/load_yaml.pl to load the files) 7. In the staff interface, go to Administration > Credit types --> They should be translated 8. Go to Administration > Debit types --> They should be translated Signed-off-by: Magnus Enger <magnus@libriotech.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149105|0 |1 is obsolete| | --- Comment #13 from Magnus Enger <magnus@libriotech.no> --- Created attachment 150745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150745&action=edit Bug 26403: (follow-up) Deleted old SQL files Signed-off-by: Magnus Enger <magnus@libriotech.no> Followed the test plan. Works as advertised. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20307 Depends on|20307 | --- Comment #14 from Magnus Enger <magnus@libriotech.no> --- Worked nicely without 20307 for me, so I am taking the liberty of changing that to a "see also". Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 [Bug 20307] Language overlay for authorized values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|"Issue refund" is not fully |Move debit and credit types |translatable |to YAML files to make them | |translatable for use in | |reports --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The templates use .inc files to make the system internal debit and credit types multi-lingual. So this will only affect reports or places where the description is pulled from the database directly (which we shouldn't do... but...) My initial bug was about things missing from the include files, this might be still something to investigate, but repurposing this one now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150912&action=edit Bug 26403: Move credit and debit types into translatable YAML files This patch moves account debit and credit types, as well as the CASH payment type, into YAML files under installer/data/en/mandatory. This should make the debit and credit types translatable (for new installations only). To test: 1. Apply patch 2. Update po files ./misc/translator/translate update xx-XX 3. View the xx-XX-installer.po file -->The default account debit and credit types (and cash payment type) should be available to be translated 4. Translate the strings 5. Apply the translations ./misc/translator/translate install xx-XX 6. Load the new translated YAML files (with a fresh install, or by deleting the values in the db and using ./misc/load_yaml.pl to load the files) 7. In the staff interface, go to Administration > Credit types --> They should be translated 8. Go to Administration > Debit types --> They should be translated Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> 150744 - Bug 26403: "Issue refund" is not fully translatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150745|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150913&action=edit Bug 26403: (follow-up) Deleted old SQL files Signed-off-by: Magnus Enger <magnus@libriotech.no> Followed the test plan. Works as advertised. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- The first two patches look like duplicates to me and I don't understand how the first one fixes the issue refund issue initially reported. Also, this encourages bad practice in so much as the DB level descriptions are not meant it be used. Has someone broken the use of the include somewhere to make this work.. the DB fields should ONLY be getting used for reports.. nowhere else -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Your just introducing double translation here. The "correct" patch would change the .description calls in the two tables to use the include as intended. I have a feeling that got undone during QA of the original patchsets that added these management pages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150925&action=edit Bug 26403: Use accounts include in account management pages This patch updates the credit and debit types management pages to use the proper includes for handling system type translations. This is how it should have been done in the first place on the original bugs that introduced the management of these types but for some reason I think it got dropped during the QA process leading to confusion around these system types with their fixed descriptions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Please try the final patch as an alternative. With this version you do not need to translate the strings again, they should already all be in appearance in the po files so we're no longer doubling up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- You can also keep the original patches if you want.. but the test plan should be altered to: To test: 1. Apply patch 2. Update po files ./misc/translator/translate update xx-XX 3. View the xx-XX-installer.po file -->The default account debit and credit types (and cash payment type) should be available to be translated 4. Translate the strings 5. Apply the translations ./misc/translator/translate install xx-XX 6. Load the new translated YAML files (with a fresh install, or by deleting the values in the db and using ./misc/load_yaml.pl to load the files) 7. In the staff interface, go to Reports 8. Create a report that includes credit_type.description and debit_type.description 9. Run the report and note the translated values For ALL other occurrences of credit type or debit type in the UI and notices, you should find translations are already applied using the template based translations. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150744|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150925|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150932&action=edit Bug 26403: Use accounts include in account management pages This patch updates the credit and debit types management pages to use the proper includes for handling system type translations. This is how it should have been done in the first place on the original bugs that introduced the management of these types but for some reason I think it got dropped during the QA process leading to confusion around these system types with their fixed descriptions. To test: 1. Apply patch 2. Apply the translations ./misc/translator/translate install xx-XX 3. In the staff interface, go to Administration > Credit types --> They should be translated 4. Go to Administration > Debit types --> They should be translated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think we should do both. 1) Web installer: It will help with SQL reporting where you can't use the includes. I have translated ours in the database for this reason and it has no bad side effects. 2) Template fixes: These are great, because they fix what I initially had reported. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Actually, I think we might need some more template fixes, but are on a good road here. Looking at my original test plan: To test: - Make sure a language with a complete translation is installed - Switch to the language - Go to any user account - Add a manual invoice - Pay it off fully or partially - Click on "issue refund" - Verify the list of "Transaction types" is not translated - Check the information in the patron account. It will show: I'll try to test this now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #25)
Actually, I think we might need some more template fixes, but are on a good road here.
Looking at my original test plan:
To test: - Make sure a language with a complete translation is installed - Switch to the language - Go to any user account - Add a manual invoice - Pay it off fully or partially - Click on "issue refund" - Verify the list of "Transaction types" is not translated
Only Cash stands out there, the other entries are translated now. This will be fixed by Caroline's adding Cash to the web installer files, because this list is part hard coded and part coming from AV: [% FOREACH pt IN payment_types %] <option value="[% pt.authorised_value | html %]">[% pt.lib | html %]</option> [% END %]
- Check the information in the patron account. It will show:
Some debit and credit types are missing from the includes. I'll provide a follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150912|0 |1 is obsolete| | --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150941&action=edit Bug 26403: Move credit and debit types into translatable YAML files This patch moves account debit and credit types, as well as the CASH payment type, into YAML files under installer/data/en/mandatory. This should make the debit and credit types translatable (for new installations only). To test: 1. Apply patch 2. Update po files ./misc/translator/translate update xx-XX 3. View the xx-XX-installer.po file -->The default account debit and credit types (and cash payment type) should be available to be translated 4. Translate the strings 5. Apply the translations ./misc/translator/translate install xx-XX 6. Load the new translated YAML files (with a fresh install, or by deleting the values in the db and using ./misc/load_yaml.pl to load the files) 7. In the staff interface, go to Administration > Credit types --> They should be translated 8. Go to Administration > Debit types --> They should be translated Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150913|0 |1 is obsolete| | --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150942&action=edit Bug 26403: (follow-up) Deleted old SQL files Signed-off-by: Magnus Enger <magnus@libriotech.no> Followed the test plan. Works as advertised. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150932|0 |1 is obsolete| | --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150943&action=edit Bug 26403: Use accounts include in account management pages This patch updates the credit and debit types management pages to use the proper includes for handling system type translations. This is how it should have been done in the first place on the original bugs that introduced the management of these types but for some reason I think it got dropped during the QA process leading to confusion around these system types with their fixed descriptions. To test: 1. Apply patch 2. Apply the translations ./misc/translator/translate install xx-XX 3. In the staff interface, go to Administration > Credit types --> They should be translated 4. Go to Administration > Debit types --> They should be translated Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150944&action=edit Bug 26403: (QA follow-up) Add missing debit and credit types to includes This adds the missing debit and credit types to the includes, namely: DISCOUNT, PURCHASE, PAYOUT, and VOID. I sorted them as they appear in the GUI (alphabetically) so it's a little easier to spot missing ones. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move debit and credit types |Move debit and credit types |to YAML files to make them |to YAML files and fix other |translatable for use in |related translation issues |reports | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150944|0 |1 is obsolete| | --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150946&action=edit Bug 26403: (QA follow-up) Add missing debit and credit types to includes This adds the missing debit and credit types to the includes, namely: DISCOUNT, PURCHASE, PAYOUT, and VOID. I sorted them as they appear in the GUI (alphabetically) so it's a little easier to spot missing ones. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |With this patch the release notes| |descriptions of system | |internal credit and debit | |types will be translated | |into the selected language | |at installation time. This | |will only affect new | |installations and SQL | |reporting. If you are | |building your own SQL | |reports, you'll be able to | |pull the descriptions from | |the tables. | | | |It also makes | |sure, that all system | |internal debit and credit | |types appear translated in | |the GUI. This now also | |includes the administration | |pages for managing credit | |and debit types. Some | |descriptions for discount, | |payout, purchase, and void | |were missing. These have | |now also been added. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 --- Comment #32 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice one everyone, thanks for the further follow-up Katrin :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 --- Comment #34 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #35 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Nobody tried the installer process? There are issues reported on the mailing list. There are still occurrences of the sql files! % git grep account_credit_types.sql -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 --- Comment #36 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #35)
Nobody tried the installer process? There are issues reported on the mailing list.
There are still occurrences of the sql files! % git grep account_credit_types.sql
See 33935. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33935 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33935 [Bug 33935] installer list deleted files which stops the process -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org