[Bug 38669] New: ILL - Staff: Automatic backend screen should provide option to go back to form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38669 Bug ID: 38669 Summary: ILL - Staff: Automatic backend screen should provide option to go back to form Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: pedro.amorim@ptfs-europe.com Reporter: pedro.amorim@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: pedro.amorim@ptfs-europe.com, tomascohen@gmail.com Depends on: 35604 On the automatic backend screen, each backend may provide different reasons to why the availability check has failed, and sometimes this can be "fixed" by updating the form metadata. Because of this, there should be the possibility of going back to the form from this screen. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604 [Bug 35604] ILL - Allow for automatic backend selection -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38669 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38669 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 175360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175360&action=edit Bug 38669: Add 'Return to form' button at top of auto backend screen Follow test plan from bug 35604, but notice you now have the possibility to return to the form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38669 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38669 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175360|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 175473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175473&action=edit Bug 38669: Add 'Return to form' button at top of auto backend screen Follow test plan from bug 35604, but notice you now have the possibility to return to the form Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38669 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA Text to go in the| |This enhancement adds a release notes| |"Return to form" link on | |the confirm backend page, | |so that the request details | |can be updated (for | |example, to fix a failure | |reason in the backend | |availability check). CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. One of the tests no longer passes after applying the patch for this bug (it passed with bug 35604 applied): prove t/db_dependent/Koha/ILL/Backends.t t/db_dependent/Koha/ILL/Backends.t .. 1/4 # Failed test 'Only one backend installed, happens to be a plugin' # at t/db_dependent/Koha/ILL/Backends.t line 59. # Structures begin differing at: # $got->[0] = 'PluginBackend' # $expected->[0] = 'Test Plugin' # Failed test 'Two backends are installed, one plugin and one directory backend' # at t/db_dependent/Koha/ILL/Backends.t line 75. # Structures begin differing at: # $got->[1] = 'PluginBackend' # $expected->[1] = 'Test Plugin' # Looks like you failed 2 tests of 2. # Failed test 'installed_backends() tests' # at t/db_dependent/Koha/ILL/Backends.t line 84. # Looks like you failed 1 test of 4. t/db_dependent/Koha/ILL/Backends.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/4 subtests Test Summary Report ------------------- t/db_dependent/Koha/ILL/Backends.t (Wstat: 256 (exited 1) Tests: 4 Failed: 1) Failed test: 4 Non-zero exit status: 1 Files=1, Tests=4, 1 wallclock secs ( 0.02 usr 0.00 sys + 1.05 cusr 0.19 csys = 1.26 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38669 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to David Nind from comment #3)
Testing notes (using KTD):
1. One of the tests no longer passes after applying the patch for this bug (it passed with bug 35604 applied):
prove t/db_dependent/Koha/ILL/Backends.t t/db_dependent/Koha/ILL/Backends.t .. 1/4 # Failed test 'Only one backend installed, happens to be a plugin' # at t/db_dependent/Koha/ILL/Backends.t line 59. # Structures begin differing at: # $got->[0] = 'PluginBackend' # $expected->[0] = 'Test Plugin'
# Failed test 'Two backends are installed, one plugin and one directory backend' # at t/db_dependent/Koha/ILL/Backends.t line 75. # Structures begin differing at: # $got->[1] = 'PluginBackend' # $expected->[1] = 'Test Plugin' # Looks like you failed 2 tests of 2.
# Failed test 'installed_backends() tests' # at t/db_dependent/Koha/ILL/Backends.t line 84. # Looks like you failed 1 test of 4. t/db_dependent/Koha/ILL/Backends.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/4 subtests
Test Summary Report ------------------- t/db_dependent/Koha/ILL/Backends.t (Wstat: 256 (exited 1) Tests: 4 Failed: 1) Failed test: 4 Non-zero exit status: 1 Files=1, Tests=4, 1 wallclock secs ( 0.02 usr 0.00 sys + 1.05 cusr 0.19 csys = 1.26 CPU) Result: FAIL
Hi David, sorry I wasn't clear in my test plan. It appears you're running this after following the test plan of 35604 and you still have the "PluginBackend" plugin installed. You can't have any plugins installed when running tests else they'll very likely fail. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38669 --- Comment #5 from David Nind <david@davidnind.com> --- (In reply to Pedro Amorim from comment #4)
Hi David, sorry I wasn't clear in my test plan. It appears you're running this after following the test plan of 35604 and you still have the "PluginBackend" plugin installed. You can't have any plugins installed when running tests else they'll very likely fail.
No worries. Thanks Pedro! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38669 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38819 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 [Bug 38819] ILL - 'Switch provider' should use AutoILLBackendPriority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38669 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175473|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176277&action=edit Bug 38669: Add 'Return to form' button at top of auto backend screen Follow test plan from bug 35604, but notice you now have the possibility to return to the form Sponsored-by: UKHSA - UK Health Security Agency Sponsored-by: PTFS Europe Ltd <https://ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38669 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38669 --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 176571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176571&action=edit Bug 38669: (QA follow-up): Fix find-missing-op-in-forms.t prove xt/find-missing-op-in-forms.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38669 --- Comment #8 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 176812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176812&action=edit Bug 38669: (QA follow-up): Prevent multiple occurrences of 'op' in the form This may happen if getting to the ILL auto screen from the type disclaimer screen for example Which causes the 'return to request'm form submission to have 2 'op's, causing error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38669 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176277|0 |1 is obsolete| | --- Comment #9 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 179730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179730&action=edit Bug 38669: Add 'Return to form' button at top of auto backend screen Follow test plan from bug 35604, but notice you now have the possibility to return to the form Sponsored-by: UKHSA - UK Health Security Agency Sponsored-by: PTFS Europe Ltd <https://ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38669 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176571|0 |1 is obsolete| | --- Comment #10 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 179731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179731&action=edit Bug 38669: (QA follow-up): Fix find-missing-op-in-forms.t prove xt/find-missing-op-in-forms.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38669 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176812|0 |1 is obsolete| | --- Comment #11 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 179732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179732&action=edit Bug 38669: (QA follow-up): Prevent multiple occurrences of 'op' in the form This may happen if getting to the ILL auto screen from the type disclaimer screen for example Which causes the 'return to request'm form submission to have 2 'op's, causing error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38669 --- Comment #12 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Rebased for main (on top of tidied bug 35604) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38669 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179730|0 |1 is obsolete| | --- Comment #13 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 179737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179737&action=edit Bug 38669: Add 'Return to form' button at top of auto backend screen Follow test plan from bug 35604, but notice you now have the possibility to return to the form Sponsored-by: UKHSA - UK Health Security Agency Sponsored-by: PTFS Europe Ltd <https://ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38669 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179731|0 |1 is obsolete| | --- Comment #14 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 179738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179738&action=edit Bug 38669: (QA follow-up): Fix find-missing-op-in-forms.t prove xt/find-missing-op-in-forms.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38669 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179732|0 |1 is obsolete| | --- Comment #15 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 179739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179739&action=edit Bug 38669: (QA follow-up): Prevent multiple occurrences of 'op' in the form This may happen if getting to the ILL auto screen from the type disclaimer screen for example Which causes the 'return to request'm form submission to have 2 'op's, causing error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38669 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179737|0 |1 is obsolete| | --- Comment #16 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180394&action=edit Bug 38669: Add 'Return to form' button at top of auto backend screen Follow test plan from bug 35604, but notice you now have the possibility to return to the form Sponsored-by: UKHSA - UK Health Security Agency Sponsored-by: PTFS Europe Ltd <https://ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38669 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179738|0 |1 is obsolete| | --- Comment #17 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180395&action=edit Bug 38669: (QA follow-up): Fix find-missing-op-in-forms.t prove xt/find-missing-op-in-forms.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38669 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179739|0 |1 is obsolete| | --- Comment #18 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180396&action=edit Bug 38669: (QA follow-up): Prevent multiple occurrences of 'op' in the form This may happen if getting to the ILL auto screen from the type disclaimer screen for example Which causes the 'return to request'm form submission to have 2 'op's, causing error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38669 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38669 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180394|0 |1 is obsolete| | Attachment #180395|0 |1 is obsolete| | Attachment #180396|0 |1 is obsolete| | --- Comment #19 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 180466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180466&action=edit Bug 38669: Add 'Return to form' button at top of auto backend screen Follow test plan from bug 35604, but notice you now have the possibility to return to the form Sponsored-by: UKHSA - UK Health Security Agency Sponsored-by: PTFS Europe Ltd <https://ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38669 --- Comment #20 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 180467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180467&action=edit Bug 38669: (QA follow-up): Fix find-missing-op-in-forms.t prove xt/find-missing-op-in-forms.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38669 --- Comment #21 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 180468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180468&action=edit Bug 38669: (QA follow-up): Prevent multiple occurrences of 'op' in the form This may happen if getting to the ILL auto screen from the type disclaimer screen for example Which causes the 'return to request'm form submission to have 2 'op's, causing error. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38669 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize@openfifth.c |tomascohen@gmail.com |o.uk | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38669 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ILL - Staff: Automatic |Staff interface: Automatic |backend screen should |backend screen should |provide option to go back |provide option to go back |to form |to form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38669 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38669 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38669 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #23 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 35604 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org