[Bug 16034] New: Integration with OverDrive Patron API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Bug ID: 16034 Summary: Integration with OverDrive Patron API Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: srdjan@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org Enable patrons to access their OverDrive account from Koha. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #1 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Requires WebService::ILS library from CPAN -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #2 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 48919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48919&action=edit bug_16034 Koha::ExternalContent::OverDrive - a wrapper around WebService::ILS::Overdrive::Patron * Using the upstream module for all the heavy lifting * opac/external/overdrive/auth.pl - 3-legged authentication handler -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #3 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 48920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48920&action=edit bug_16034 Adding a new syspref - OverDriveCirculation If set to true, Opac will integrate OverDrive patron services -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #4 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 48921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48921&action=edit bug_16034 Add overdrive info to the users page in the public interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #5 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- I have not included a test plan for this. It cannot be tested without * an OverDrive account * return url of http(s)://your/opac/host/cgi-bin/koha/external/overdrive/auth.pl being registered with OverDrive In terms of regression testing, opac-user.tt has an additional tab that is visible only when OverDriveCirculation syspref is set to yes, so it should possibly be given just a quick check. If someone with an OverDrive account wants to have a go, please let me know and I will either email instructions or add them here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |srdjan@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |dependency CC| |gmcharlt@gmail.com, | |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jweaver@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48919|0 |1 is obsolete| | --- Comment #6 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 49929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49929&action=edit bug_16034 Koha::ExternalContent::OverDrive - a wrapper around WebService::ILS::Overdrive::Patron * Using the upstream module for all the heavy lifting * opac/external/overdrive/auth.pl - 3-legged authentication handler Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48920|0 |1 is obsolete| | --- Comment #7 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 49930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49930&action=edit bug_16034 Adding a new syspref - OverDriveCirculation If set to true, Opac will integrate OverDrive patron services Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48921|0 |1 is obsolete| | --- Comment #8 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 49931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49931&action=edit bug_16034 Add overdrive info to the users page in the public interface Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Agnes Rivers-Moore <arm@hanover.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm@hanover.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Some preliminary questions: Did Jesse test with an OverDrive account? Noting such info in the signoff line could be helpful. You seem to be adding an optional dependency. I am missing PerlDependencies? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #10 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Yes, you must have an OverDrive account to use this, and even set up the return url with them. It's a process. I apologise, I did not update PerlDependencies, I thought it was only for mandatory deps. Do you want me to add it to the first patch, or write a follow-up? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Srdjan Jankovic from comment #10)
Yes, you must have an OverDrive account to use this, and even set up the return url with them. It's a process. I assumed so. But my question was: Did the signoffer (Jesse) actually test with an Overdrive account?
I apologise, I did not update PerlDependencies, I thought it was only for mandatory deps. Do you want me to add it to the first patch, or write a follow-up? Since you already have a SO, you'd better write a follow-up. No need to change status for that.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #12 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 53793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53793&action=edit Bug 16034 follow-up: added WebService::ILS to PerlDependencies -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #13 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- I will confirm on Jesse's behalf, I believe they even implemented it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53793|0 |1 is obsolete| | --- Comment #14 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 55594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55594&action=edit Bug 16034 follow-up: added WebService::ILS to PerlDependencies -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patch doesn't apply, please rebase. Would it be possible to get a test account in order to test this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49929|0 |1 is obsolete| | --- Comment #16 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 55675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55675&action=edit bug_16034 Koha::ExternalContent::OverDrive - a wrapper around WebService::ILS::Overdrive::Patron * Using the upstream module for all the heavy lifting * opac/external/overdrive/auth.pl - 3-legged authentication handler Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49930|0 |1 is obsolete| | --- Comment #17 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 55676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55676&action=edit bug_16034 Adding a new syspref - OverDriveCirculation If set to true, Opac will integrate OverDrive patron services Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49931|0 |1 is obsolete| | --- Comment #18 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 55677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55677&action=edit bug_16034 Add overdrive info to the users page in the public interface Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55594|0 |1 is obsolete| | --- Comment #19 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 55678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55678&action=edit Bug 16034 follow-up: added WebService::ILS to PerlDependencies -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- If the rebase was not too complicated, putting back to "Signed off" is ok. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #21 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- The rebase was easy, but the fourth patch (follow-up) was not signed-off earlier. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55675|0 |1 is obsolete| | --- Comment #22 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 55763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55763&action=edit bug_16034 Koha::ExternalContent::OverDrive - a wrapper around WebService::ILS::Overdrive::Patron * Using the upstream module for all the heavy lifting * opac/external/overdrive/auth.pl - 3-legged authentication handler Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55676|0 |1 is obsolete| | --- Comment #23 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 55764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55764&action=edit bug_16034 Adding a new syspref - OverDriveCirculation If set to true, Opac will integrate OverDrive patron services Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55677|0 |1 is obsolete| | --- Comment #24 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 55765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55765&action=edit bug_16034 Add overdrive info to the users page in the public interface Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55678|0 |1 is obsolete| | --- Comment #25 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 55766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55766&action=edit Bug 16034 follow-up: added WebService::ILS to PerlDependencies -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55765|0 |1 is obsolete| | --- Comment #26 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 55815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55815&action=edit bug_16034 Add overdrive info to the users page in the public interface Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55766|0 |1 is obsolete| | --- Comment #27 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 55816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55816&action=edit Bug 16034 follow-up: added WebService::ILS to PerlDependencies -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17602 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 [Bug 17602] Integrate support for ONeclickDigital/Recorded Books API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55763|0 |1 is obsolete| | --- Comment #28 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 57398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57398&action=edit bug_16034 Koha::ExternalContent::OverDrive - a wrapper around WebService::ILS::Overdrive::Patron * Using the upstream module for all the heavy lifting * opac/external/overdrive/auth.pl - 3-legged authentication handler Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55764|0 |1 is obsolete| | --- Comment #29 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 57399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57399&action=edit bug_16034 Adding a new syspref - OverDriveCirculation If set to true, Opac will integrate OverDrive patron services Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55815|0 |1 is obsolete| | --- Comment #30 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 57400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57400&action=edit bug_16034 Add overdrive info to the users page in the public interface Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55816|0 |1 is obsolete| | --- Comment #31 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 57401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57401&action=edit Bug 16034 follow-up: added WebService::ILS to PerlDependencies -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #32 from Nick Clemens <nick@bywatersolutions.com> --- couple things: POD fails QA tools opac/external/overdrive/auth.pl has wrong description (copy/paste error) When attempting to cancel a hold from results or patron details error is displayed at top of page: The title is not checked out. at /usr/local/share/perl/5.14.2/WebService/ILS/OverDrive/Patron.pm line 571. This is awesome overall though! Nice addition of ability to checkout/download/hold titles. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57398|0 |1 is obsolete| | --- Comment #33 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 58518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58518&action=edit bug_16034 Koha::ExternalContent::OverDrive - a wrapper around WebService::ILS::Overdrive::Patron * Using the upstream module for all the heavy lifting * opac/external/overdrive/auth.pl - 3-legged authentication handler Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57399|0 |1 is obsolete| | --- Comment #34 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 58519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58519&action=edit bug_16034 Adding a new syspref - OverDriveCirculation If set to true, Opac will integrate OverDrive patron services Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57400|0 |1 is obsolete| | --- Comment #35 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 58520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58520&action=edit bug_16034 Add overdrive info to the users page in the public interface Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57401|0 |1 is obsolete| | --- Comment #36 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 58521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58521&action=edit Bug 16034 follow-up: added WebService::ILS to PerlDependencies -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #37 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 58522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58522&action=edit bug_16034 follow-up: Protect from unreliable OverDrive return API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #38 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- I've fixed wrong descriptions in handlers. Unfortunately, I could not find a title that I could place a hold on. I've made a "blind"-ish change for returns, works for checked out items, so I'd imagine it would work with hold returns (cancellations). Can you please try it with this patch. Also, can you please let me know which title could be placed on hold so I can play with it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #39 from Nick Clemens <nick@bywatersolutions.com> --- I no longer get an error when cancelling a hold, but the hold is not cancelled either. 'Safe in his arms' is a title in the bywater library which can be placed on hold (In reply to Srdjan Jankovic from comment #38)
I've fixed wrong descriptions in handlers.
Unfortunately, I could not find a title that I could place a hold on. I've made a "blind"-ish change for returns, works for checked out items, so I'd imagine it would work with hold returns (cancellations). Can you please try it with this patch. Also, can you please let me know which title could be placed on hold so I can play with it.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58520|0 |1 is obsolete| | Attachment #58522|0 |1 is obsolete| | --- Comment #40 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 58790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58790&action=edit bug_16034 Add overdrive info to the users page in the public interface Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58521|0 |1 is obsolete| | --- Comment #41 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 58791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58791&action=edit Bug 16034 follow-up: added WebService::ILS to PerlDependencies -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #42 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Sorry Nick, was a bug. Fixed it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #43 from Nick Clemens <nick@bywatersolutions.com> --- Awesome, checking out and in and placing/cancelling a hold all work well now. When I click 'Logout from OverDrive account' the response seems to always be "Internal server error" can you check on that? POD still fails QA Additionally - two things would be nice: 1 - When you click to Sign In to OverDrive - this link should open in a new tab/window 2 - It would be nice to have a link to your overdrive account from the account page so that you can view the overdrive site if you wish to. (In reply to Srdjan Jankovic from comment #42)
Sorry Nick, was a bug. Fixed it.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58518|0 |1 is obsolete| | --- Comment #44 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 59055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59055&action=edit bug_16034 Koha::ExternalContent::OverDrive - a wrapper around WebService::ILS::Overdrive::Patron * Using the upstream module for all the heavy lifting * opac/external/overdrive/auth.pl - 3-legged authentication handler Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58519|0 |1 is obsolete| | --- Comment #45 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 59056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59056&action=edit bug_16034 Adding a new syspref - OverDriveCirculation If set to true, Opac will integrate OverDrive patron services Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58790|0 |1 is obsolete| | --- Comment #46 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 59057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59057&action=edit bug_16034 Add overdrive info to the users page in the public interface Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58791|0 |1 is obsolete| | --- Comment #47 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 59058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59058&action=edit Bug 16034 follow-up: added WebService::ILS to PerlDependencies -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59055|0 |1 is obsolete| | --- Comment #48 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 59392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59392&action=edit bug_16034 Koha::ExternalContent::OverDrive - a wrapper around WebService::ILS::Overdrive::Patron * Using the upstream module for all the heavy lifting * opac/external/overdrive/auth.pl - 3-legged authentication handler Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59056|0 |1 is obsolete| | --- Comment #49 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 59393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59393&action=edit bug_16034 Adding a new syspref - OverDriveCirculation If set to true, Opac will integrate OverDrive patron services Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59057|0 |1 is obsolete| | --- Comment #50 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 59394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59394&action=edit bug_16034 Add overdrive info to the users page in the public interface Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59058|0 |1 is obsolete| | --- Comment #51 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 59395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59395&action=edit Bug 16034 follow-up: added WebService::ILS to PerlDependencies -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #52 from Nick Clemens <nick@bywatersolutions.com> --- This is looking very good - the one issue I see remaining is the content in the OverDrive tab has a lot of html tags showing <i> <b> etc - can that be processed correctly? -Nick -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59394|0 |1 is obsolete| | --- Comment #53 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 59713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59713&action=edit bug_16034 Add overdrive info to the users page in the public interface Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59395|0 |1 is obsolete| | --- Comment #54 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 59714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59714&action=edit Bug 16034 follow-up: added WebService::ILS to PerlDependencies -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59392|0 |1 is obsolete| | Attachment #59393|0 |1 is obsolete| | Attachment #59713|0 |1 is obsolete| | Attachment #59714|0 |1 is obsolete| | --- Comment #55 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 59743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59743&action=edit bug_16034 Koha::ExternalContent::OverDrive - a wrapper around WebService::ILS::Overdrive::Patron * Using the upstream module for all the heavy lifting * opac/external/overdrive/auth.pl - 3-legged authentication handler Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #56 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 59744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59744&action=edit bug_16034 Adding a new syspref - OverDriveCirculation If set to true, Opac will integrate OverDrive patron services Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #57 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 59745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59745&action=edit bug_16034 Add overdrive info to the users page in the public interface Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #58 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 59746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59746&action=edit Bug 16034 follow-up: added WebService::ILS to PerlDependencies Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #59 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Srdjan, Chris! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #60 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18160 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18160 [Bug 18160] Error when OverDriveCirculation not enabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #61 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 59743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59743 bug_16034 Koha::ExternalContent::OverDrive - a wrapper around WebService::ILS::Overdrive::Patron Review of attachment 59743: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=16034&attachment=59743) ----------------------------------------------------------------- ::: Koha/Schema/Result/Borrower.pm @@ +616,5 @@
datetime_undef_if_invalid => 1, is_nullable => 1, }, + "overdrive_auth_token", + { data_type => "text", is_nullable => 1 },
This is terrible wrong, you have to commit the file generated by misc/devel/update_dbix_class_files.pl, with the sum updated! Now we are not able to regenerate the schema. DBIx::Class::Schema::Loader::make_schema_at(): Checksum mismatch in './/Koha/Schema/Result/Borrower.pm', the auto-generated part of the file has been modified outside of this loader. Aborting. Please fix ASAP -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #62 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 60626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60626&action=edit Bug 16034 follow-up: generated Borrower resultset -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #63 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Apologies, didn't know that. Now the patch contains much more than my field, hope it's fine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #64 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Guys, another QA lesson :) if you add to borrowers, dont forget deletedborrowers DBIx::Class::Row::store_column(): No such column 'overdrive_auth_token' on Koha::Schema::Result::Deletedborrower at /usr/share/koha/masterclone/Koha/Patron.pm line 416 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #65 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ee should have a test for that... it's gone wrong so many times now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #66 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #65)
Ee should have a test for that... it's gone wrong so many times now.
We have it already: % prove t/db_dependent/db_structure.t t/db_dependent/db_structure.t .. 1/? # Failed test 'tables related to Borrower and Deletedborrower should not differ on overdrive_auth_token.is_nullable' # at t/db_dependent/db_structure.t line 53. # got: '1' # expected: undef # Failed test 'tables related to Borrower and Deletedborrower should not differ on overdrive_auth_token.data_type' # at t/db_dependent/db_structure.t line 53. # got: 'text' # expected: undef # Looks like you failed 2 tests of 423. t/db_dependent/db_structure.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/423 subtests Test Summary Report ------------------- t/db_dependent/db_structure.t (Wstat: 512 Tests: 423 Failed: 2) Failed tests: 164-165 Non-zero exit status: 2 Files=1, Tests=423, 2 wallclock secs ( 0.06 usr 0.01 sys + 0.84 cusr 0.40 csys = 1.31 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60626|0 |1 is obsolete| | --- Comment #67 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 60626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60626 Bug 16034 follow-up: generated Borrower resultset Too many wrong things in this patch, @RM do no push it and regenerate it yourself. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #68 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 60654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60654&action=edit Bug 16034: (followup) Fix DB update and schema files Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #69 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- (In reply to Marcel de Rooy from comment #64)
Guys, another QA lesson :) if you add to borrowers, dont forget deletedborrowers
DBIx::Class::Row::store_column(): No such column 'overdrive_auth_token' on Koha::Schema::Result::Deletedborrower at /usr/share/koha/masterclone/Koha/Patron.pm line 416
In which case maybe a check in misc/devel/update_dbix_class_files.pl would be in order? --- Comment #70 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Srdjan Jankovic from comment #69)
(In reply to Marcel de Rooy from comment #64)
Guys, another QA lesson :) if you add to borrowers, dont forget deletedborrowers
DBIx::Class::Row::store_column(): No such column 'overdrive_auth_token' on Koha::Schema::Result::Deletedborrower at /usr/share/koha/masterclone/Koha/Patron.pm line 416
In which case maybe a check in misc/devel/update_dbix_class_files.pl would be in order?
There is a check in qa-tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #71 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #70)
(In reply to Srdjan Jankovic from comment #69)
(In reply to Marcel de Rooy from comment #64)
Guys, another QA lesson :) if you add to borrowers, dont forget deletedborrowers
DBIx::Class::Row::store_column(): No such column 'overdrive_auth_token' on Koha::Schema::Result::Deletedborrower at /usr/share/koha/masterclone/Koha/Patron.pm line 416
In which case maybe a check in misc/devel/update_dbix_class_files.pl would be in order?
There is a check in qa-tools
Nope, but we have a test, see comment 66. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net --- Comment #72 from Mirko Tietgen <mirko@abunchofthings.net> --- This breaks master packages. There is no Debian package available. There is an ITP bug from Chris at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=838609 I think this is optional, so maybe the test should be skippable (if that is a word)? # Failed test 'use Koha::ExternalContent::OverDrive;' # at t/00-load.t line 65. # Tried to use 'Koha::ExternalContent::OverDrive'. # Error: Can't locate WebService/ILS/OverDrive/Patron.pm in @INC (you may need to install the WebService::ILS::OverDrive::Patron module) (@INC contains: /tmp/buildd/koha-16.12.01~git+20170226133406.b5b4b708/blib/PERL_MODULE_DIR /tmp/buildd/koha-16.12.01~git+20170226133406.b5b4b708/blib/arch /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2 /usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20 /usr/local/lib/site_perl . /var/lib/koha/plugins /var/lib/koha/plugins) at /tmp/buildd/koha-16.12.01~git+20170226133406.b5b4b708/blib/PERL_MODULE_DIR/Koha/ExternalContent/OverDrive.pm line 24. # BEGIN failed--compilation aborted at /tmp/buildd/koha-16.12.01~git+20170226133406.b5b4b708/blib/PERL_MODULE_DIR/Koha/ExternalContent/OverDrive.pm line 24. # Compilation failed in require at t/00-load.t line 65. # BEGIN failed--compilation aborted at t/00-load.t line 65. Bailout called. Further testing stopped: ***** PROBLEMS LOADING FILE 'Koha::ExternalContent::OverDrive' # Tests were run but no plan was declared and done_testing() was not seen. # Looks like your test exited with 255 just after 245. FAILED--Further testing stopped: ***** PROBLEMS LOADING FILE 'Koha::ExternalContent::OverDrive' Makefile:22097: recipe for target 'test_dynamic' failed make[1]: *** [test_dynamic] Error 255 make[1]: Leaving directory '/tmp/buildd/koha-16.12.01~git+20170226133406.b5b4b708' dh_auto_test: make -j1 test returned exit code 2 debian/rules:9: recipe for target 'build' failed make: *** [build] Error 2 dpkg-buildpackage: error: debian/rules build gave error exit status 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #73 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Is there a standard way we skip that kind of tests? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #74 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Srdjan Jankovic from comment #73)
Is there a standard way we skip that kind of tests?
We already kind of the same thing in C4::Members for the Norvegian specific ft. I guess thing like: use Module::Load::Conditional qw( can_load ); if ( ! can_load( modules => { 'WebService::ILS::OverDrive::Patron' => undef } ) ) { warn "Unable to load WebService::ILS::OverDrive::Patron"; } in place of the use statement would do the trick. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #75 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 60789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60789&action=edit Bug 16034 follow-up: better handling of absence of WebService::ILS::OverDrive::Patron at testing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #76 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- =head1 L<WebService::ILS::OverDrive::Patron> METHODS =item C<return($id)> sub return { Definitely a fine name for a method ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #77 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- (In reply to Marcel de Rooy from comment #76)
=head1 L<WebService::ILS::OverDrive::Patron> METHODS =item C<return($id)>
sub return {
Definitely a fine name for a method ;)
Oh why cannot life be simple... I think it is safe, there are some rules and Perl knows which one's which. However, if it is making you uneasy, I can rename it to return_checkout() or something. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #78 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Srdjan Jankovic from comment #77)
(In reply to Marcel de Rooy from comment #76)
=head1 L<WebService::ILS::OverDrive::Patron> METHODS =item C<return($id)>
sub return {
Definitely a fine name for a method ;)
Oh why cannot life be simple... I think it is safe, there are some rules and Perl knows which one's which. However, if it is making you uneasy, I can rename it to return_checkout() or something.
No worries. But we should not use reserved words for methods, columns, etc. In another report we just removed a 'return' column from issues.. As you will understand, git grepping on return is laborious. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #79 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- (In reply to Marcel de Rooy from comment #78)
In another report we just removed a 'return' column from issues.. As you will understand, git grepping on return is laborious.
Ah right, of course, I had to do it myself when figuring out how difficult it would be to replace it. To my defence, I was grepping for "sub return" and "\->return". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #80 from Mirko Tietgen <mirko@abunchofthings.net> --- I rolled a package and installed it. $ locate WebService/ILS/OverDrive/Patron.pm /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm Test fails anyway. # Failed test 'use Koha::ExternalContent::OverDrive;' # at t/00-load.t line 65. # Tried to use 'Koha::ExternalContent::OverDrive'. # Error: Can't locate WebService/ILS/OverDrive/Patron.pm in @INC (you may need to install the WebService::ILS::OverDrive::Patron module) (@INC contains: /tmp/buildd/koha-16.12+17311~git+20170309145207.123dfb1c/blib/PERL_MODULE_DIR /tmp/buildd/koha-16.12+17311~git+20170309145207.123dfb1c/blib/arch /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2 /usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20 /usr/local/lib/site_perl . /var/lib/koha/plugins /var/lib/koha/plugins) at /tmp/buildd/koha-16.12+17311~git+20170309145207.123dfb1c/blib/PERL_MODULE_DIR/Koha/ExternalContent/OverDrive.pm line 24. # BEGIN failed--compilation aborted at /tmp/buildd/koha-16.12+17311~git+20170309145207.123dfb1c/blib/PERL_MODULE_DIR/Koha/ExternalContent/OverDrive.pm line 24. # Compilation failed in require at t/00-load.t line 65. # BEGIN failed--compilation aborted at t/00-load.t line 65. Bailout called. Further testing stopped: ***** PROBLEMS LOADING FILE 'Koha::ExternalContent::OverDrive' # Tests were run but no plan was declared and done_testing() was not seen. # Looks like your test exited with 255 just after 255. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #81 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Patch on comment 75 has not been pushed and package building fail, please open a new bug report and fix these issues ASAP. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #82 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 Should we close this one then? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60789|0 |1 is obsolete| | --- Comment #83 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Comment on attachment 60789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60789 Bug 16034 follow-up: better handling of absence of WebService::ILS::OverDrive::Patron at testing Attached to bug 18243 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18243 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 [Bug 18243] Bug 16034 follow-up: better handling of absence of WebService::ILS::OverDrive::Patron at testing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #84 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Srdjan Jankovic from comment #82)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243
Should we close this one then?
At least "pushed to master", not sure resolved is appropriate when there are known bugs. Did you also fix comment 80? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #85 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #86 from Srdjan Jankovic <srdjan@catalyst.net.nz> ---
Did you also fix comment 80?
Not sure. I was not getting it in the first place. But 18234 should address that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #87 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Srdjan Jankovic from comment #86)
Did you also fix comment 80?
Not sure. I was not getting it in the first place. But 18234 should address that.
It's bug 18243 I guess. And no, it does not: % git bz apply 18243 % prove t/00-load.t # Failed test 'use Koha::ExternalContent::OverDrive;' # at t/00-load.t line 65. # Tried to use 'Koha::ExternalContent::OverDrive'. # Error: Can't locate WebService/ILS/OverDrive/Patron.pm in @INC (you may need to install the WebService::ILS::OverDrive::Patron module) (@INC contains: /home/vagrant/kohaclone /home/vagrant/qa-test-tools /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2 /usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20 /usr/local/lib/site_perl . /var/lib/koha/kohadev/plugins /var/lib/koha/kohadev/plugins) at /home/vagrant/kohaclone/Koha/ExternalContent/OverDrive.pm line 24. # BEGIN failed--compilation aborted at /home/vagrant/kohaclone/Koha/ExternalContent/OverDrive.pm line 24. # Compilation failed in require at t/00-load.t line 65. # BEGIN failed--compilation aborted at t/00-load.t line 65. Bailout called. Further testing stopped: ***** PROBLEMS LOADING FILE 'Koha::ExternalContent::OverDrive' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #88 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- (In reply to Jonathan Druart from comment #87)
(In reply to Srdjan Jankovic from comment #86)
Did you also fix comment 80?
Not sure. I was not getting it in the first place. But 18234 should address that.
It's bug 18243 I guess.
And no, it does not:
Omg, must have had it in my PERL5LIB. Submitted to 18243. Sorry. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Blocks| |18172 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18172 [Bug 18172] Logged in user page shows internal server error if OverDriveCirculation is disabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18514 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18514 [Bug 18514] Allow library to search their Koha and Overdrive collections using ElasticSearch -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org