[Bug 22627] New: Rephrase 'your fines' tab in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627 Bug ID: 22627 Summary: Rephrase 'your fines' tab in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Target Milestone: --- See also discussion on bug 21578: In the OPAC the tab for accessing the account balance is labelled 'your fines', as dicussed on bug 21579 fines is not always a fitting term. The page itself is then labelled: 'fines and charges'. I think it would make sense to at least change the tab label to match the patch title. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627 --- Comment #1 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 90101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90101&action=edit Bug 22627: Renames OPAC fines tab to 'your charges' to be more inclusive Brought up on Bug 21578, the 'your fines' tab in the OPAC would be better named as 'your charges' as not all charges are fines, some are credits etc. To test: 1) In the OPAC, click on the user's name and note that the tab that was called your fines is now called your charges. 2) When you click on the tab, the title says Your charges, the breadcrumb says Your charges, and the table title remains Fines and charges. Please let me know if you think the table title should change too. Sponsored-by: Catalyst IT. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |hayleymapley@catalyst.net.n |ity.org |z CC| |hayleymapley@catalyst.net.n | |z -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627 Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie-luce.laflamme@inlibro | |.com Status|Needs Signoff |In Discussion --- Comment #2 from Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> --- The patch apply correctly. However, I do believe it will better to use the same term in both place: the access tab and the page itself. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627 --- Comment #3 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 90286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90286&action=edit Bug 22627: (follow-up) Changed accountlines and sco to match OPAC Test plan: Same as previous patch Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627 --- Comment #4 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 90287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90287&action=edit Bug 22627: Renames OPAC fines tab to 'your charges' to be more inclusive Brought up on Bug 21578, the 'your fines' tab in the OPAC would be better named as 'your charges' as not all charges are fines, some are credits etc. To test: 1) In the OPAC, click on the user's name and note that the tab that was called your fines is now called your charges. 2) When you click on the tab, the title says Your charges, the breadcrumb says Your charges, and the table title is Your charges. Sponsored-by: Catalyst IT. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90101|0 |1 is obsolete| | Attachment #90286|0 |1 is obsolete| | Attachment #90287|0 |1 is obsolete| | --- Comment #5 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 90288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90288&action=edit Bug 22627: Renames OPAC fines tab to 'your charges' to be more inclusive Brought up on Bug 21578, the 'your fines' tab in the OPAC would be better named as 'your charges' as not all charges are fines, some are credits etc. To test: 1) In the OPAC, click on the user's name and note that the tab that was called your fines is now called your charges. 2) When you click on the tab, the title says Your charges, the breadcrumb says Your charges, and the table title is Your charges. Sponsored-by: Catalyst IT. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- This looks nice. But when I try to sign-off I get: Found multiple bug references specified commits: https://bugs.koha-community.org/show_bug.cgi?id=22627 https://bugs.koha-community.org/show_bug.cgi?id=21578 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lucas Gass from comment #6)
This looks nice. But when I try to sign-off I get:
Found multiple bug references specified commits: https://bugs.koha-community.org/show_bug.cgi?id=22627 https://bugs.koha-community.org/show_bug.cgi?id=21578
Hi Lucas, works ok for me - maybe your branch was not clean? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90288|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 92141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92141&action=edit Bug 22627: Renames OPAC fines tab to 'your charges' to be more inclusive Brought up on Bug 21578, the 'your fines' tab in the OPAC would be better named as 'your charges' as not all charges are fines, some are credits etc. To test: 1) In the OPAC, click on the user's name and note that the tab that was called your fines is now called your charges. 2) When you click on the tab, the title says Your charges, the breadcrumb says Your charges, and the table title is Your charges. Sponsored-by: Catalyst IT. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 92142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92142&action=edit Bug 22627: Rename tab on my summary page This completes the first patch by also changing the tab on the OPAC summary page from "Fines" to "Charges". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92141|0 |1 is obsolete| | --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 92577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92577&action=edit Bug 22627: Renames OPAC fines tab to 'your charges' to be more inclusive Brought up on Bug 21578, the 'your fines' tab in the OPAC would be better named as 'your charges' as not all charges are fines, some are credits etc. To test: 1) In the OPAC, click on the user's name and note that the tab that was called your fines is now called your charges. 2) When you click on the tab, the title says Your charges, the breadcrumb says Your charges, and the table title is Your charges. Sponsored-by: Catalyst IT. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92142|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 92578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92578&action=edit Bug 22627: Rename tab on my summary page This completes the first patch by also changing the tab on the OPAC summary page from "Fines" to "Charges". Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #13 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 19.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Rephrase 'your fines' tab |Rephrase 'your fines and |in OPAC |charges' tab in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org