https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andrew.isherwood@ptfs-europ |ity.org |e.com Status|NEW |ASSIGNED Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 --- Comment #1 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Work on this bug is being submitted as distinct patches rather than one large patch. Each patch is related to a specific area of work, e.g. database schema changes, API changes, ILLrequest object changes, staff template changes & OPAC changes. Although these patches are distinct, they are all required for the end result to work. As such, I am adding QA test scenarios here rather than attaching them to the individual patches. Test custom status creation: 1) Apply this bug's patches 2) Apply database updates 3) Ensure you have at least one ILL backend available: https://wiki.koha-community.org/wiki/ILL_backends 4) Ensure you have the "ILLModule" preference enabled 5) Log in as a user with the ability to add authorised values. 6) Depending on whether you opted to accept the "Default ILL request status authorised value category name" data population during install, you may or may not have an authorised values category ILLSTATUS, if not, create it. 7) Add some authorised values to the ILLSTATUS category, these can be custom request statuses of your choice Test custom status usage: 8) From the staff interface, create an ILL request from a backend of your choice 9) On the resulting "Request details" page, observe that the request's status is "New request" 10) Click the "Edit request" button 11) In the "Request details" pane, observe that the request's status is now available in a drop down box, it should contain the current status PLUS your custom statuses. 12) Select a custom status and Submit the form 13) In the resulting "View ILL requests" page, observe that your request is now displaying your custom status. 14) Click the "Manage request" button for your new request 15) In the "Request details" page, observe that the request's status is displaying as your custom status Test custom status is overridden when request progresses through workflow: 16) Click "Confirm request", then the "Confirm request" confirmation 17) Observe that in the resulting "Request details" page, the request's status is now no longer displaying your custom status but has switched to "Requested" Test custom status is removed when authorised value is removed: 18) Observe that the request has the status "Requested", we are going to override that with a custom status, then remove that custom status authorised value 19) Click "Edit request" 20) Select a custom status and Submit the form 21) In the resulting "View ILL requests" page, observe that your request is now displaying your custom status. 22) Go to the authorised values management page 23) Delete the custom status you previously selected in step 19 24) Return to the list of ILL requests 25) Observe that the request that previously had the custom status now has it's former status of "Requested" Test API response for View ILL requests view: 26) Modify an existing request and set a custom status as discussed above 27) Navigate to the "View ILL requests" page 28) Examine the response to the API call made to the /api/v1/illrequests?embed=metadata,patron,capabilities,library,status_alias route 28) Observe that for requests with a custom status, the status_alias property contains an object for the request's authorised value containing the custom status 29) Observe that for requests without a custom status, status_alias is null Test OPAC view: 30) Modify an existing request and set a custom status as discussed above 31) In the OPAC, navigate to "your interlibrary loan requests" 32) In the "Interlibrary loan requests" view, observe that the request's status is displaying your custom value 33) Click "View" on the request with a custom value 34) In the "View Interlibrary loan request" view, observe that the request's status is displaying your custom value -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 --- Comment #2 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 74323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74323&action=edit Bug 20581: Modifications to database schema - This patch provides an illrequests.status_alias column that is a foreign key to authorised_values.id. This provides the ability for an ILL request to have an optional status alias that is defined as an authorised valued. - A new ILLSTATUS authorised value category is also made available during install. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 --- Comment #4 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 74325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74325&action=edit Bug 20581: API provide status_alias embed - This patch provides the illrequests API route with an additional embed, called 'status_alias'. Requesting this embed returns an object for the request's status_alias authorised value, or null if one is not set. - This patch also adds the new status_alias as a default embed on the API call made by the illlist view -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 --- Comment #6 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 74327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74327&action=edit Bug 20581: Add support for status_alias to OPAC view - This patch adds the abililty for the OPAC to display a set status_alias value in preference to a request's status value. During ILL request listing or individual ILL request view, the status_alias value, if set, will be displayed in favour of the status -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 --- Comment #9 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Hi Mark. That's a very good point. My knowledge of how to add multi language support to authorised values is, unfortunately, non existent. Are you aware of any "good practice" examples for this kind of thing? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 --- Comment #11 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Hi Katrin Thanks for the suggestions. I'm wary about cooking up a home baked way of doing it as, at the moment, I'm using a well established method of providing an authorised list of values, which is exactly what the custom statuses need. I think I'd rather keep to a correct "Koha" way of providing this functionality than try to work around the lack of translations with a bespoke solution. It's tricky when in a transitional phase with anything, but I think having devs coming up with bespoke solutions will likely cause more pain down the line when a standard way of doing it is established and it's necessary to migrate to it. So I think, for now, it feels more "correct" to use authorised values and accept that they cannot be translated. Cheers Andrew -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 C Hofstede <chloe.hofstede@educampus.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chloe.hofstede@educampus.ie -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74323|0 |1 is obsolete| | --- Comment #12 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 75333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75333&action=edit Bug 20581: Modifications to database schema - This patch provides an illrequests.status_alias column that is a foreign key to authorised_values.id. This provides the ability for an ILL request to have an optional status alias that is defined as an authorised valued. - A new ILLSTATUS authorised value category is also made available during install. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 --- Comment #14 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 75334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75334&action=edit Bug 20581: DO NOT PUSH: Updated Schema Files. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Bug 20581 depends on bug 7317, which changed state. Bug 7317 Summary: Add an Interlibrary Loan Module to Circulation and OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75333|0 |1 is obsolete| | --- Comment #16 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 77819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77819&action=edit Bug 20581: Modifications to database schema - This patch provides an illrequests.status_alias column that is a foreign key to authorised_values.id. This provides the ability for an ILL request to have an optional status alias that is defined as an authorised valued. - A new ILLSTATUS authorised value category is also made available during install. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74325|0 |1 is obsolete| | --- Comment #18 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 77821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77821&action=edit Bug 20581: API provide status_alias embed - This patch provides the illrequests API route with an additional embed, called 'status_alias'. Requesting this embed returns an object for the request's status_alias authorised value, or null if one is not set. - This patch also adds the new status_alias as a default embed on the API call made by the illlist view -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74327|0 |1 is obsolete| | --- Comment #20 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 77823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77823&action=edit Bug 20581: Add support for status_alias to OPAC view - This patch adds the abililty for the OPAC to display a set status_alias value in preference to a request's status value. During ILL request listing or individual ILL request view, the status_alias value, if set, will be displayed in favour of the status -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75334|0 |1 is obsolete| | --- Comment #22 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 77825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77825&action=edit Bug 20581: DO NOT PUSH: Updated Schema Files. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 --- Comment #24 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Rebased against current master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77820|0 |1 is obsolete| | --- Comment #26 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 78377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78377&action=edit Bug 20581: Provide status_alias on IllRequest This patch provides status_alias support for the Koha::Illrequest object. - New 'statusalias' getter method, returns the request's status_alias authorised value object if set, otherwise undef - Overloads existing 'status' method, getter/setter accessors intact, but setting the request's status now implicitly removes any status_alias that has been set -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77822|0 |1 is obsolete| | --- Comment #28 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 78379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78379&action=edit Bug 20581: Add display of status_alias to staff vw - This patch adds display of the new status_alias value, when set, in favour of the request's status value. - It also allows the user to set a status_alias for an existing request. When set, this value will be displayed in preference to the status. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77824|0 |1 is obsolete| | --- Comment #30 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 78381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78381&action=edit Bug 20581: Unit tests for status_alias This patch adds unit tests for the specific status_alias functionality added in this bug - Creation of the ILLSTATUS authorised value - Illrequest->statusalias accessor - Illrequest->status overloading to reset status_alias To test: 1) Apply this patch 2) prove t/db_dependent/Illrequests.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77826|0 |1 is obsolete| | --- Comment #32 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 78383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78383&action=edit Bug 20581: (follow-up) Display status name Rather than display the status code for custom statuses, we should be displaying the name -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 --- Comment #34 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Rebased on current master and provided an additional fix. Test custom status creation: 1) Apply this bug's patches 2) Apply database updates 3) Ensure you have at least one ILL backend available: https://wiki.koha-community.org/wiki/ILL_backends 4) Ensure you have the "ILLModule" preference enabled 5) Log in as a user with the ability to add authorised values. 6) Depending on whether you opted to accept the "Default ILL request status authorised value category name" data population during install, you may or may not have an authorised values category ILLSTATUS, if not, create it. 7) Add some authorised values to the ILLSTATUS category, these can be custom request statuses of your choice Test custom status usage: 8) From the staff interface, create an ILL request from a backend of your choice 9) On the resulting "Request details" page, observe that the request's status is "New request" 10) Click the "Edit request" button 11) In the "Request details" pane, observe that the request's status is now available in a drop down box, it should contain the current status PLUS your custom statuses. 12) Select a custom status and Submit the form 13) In the resulting "View ILL requests" page, observe that your request is now displaying your custom status. 14) Click the "Manage request" button for your new request 15) In the "Request details" page, observe that the request's status is displaying as your custom status Test custom status is overridden when request progresses through workflow: 16) Click "Confirm request", then the "Confirm request" confirmation 17) Observe that in the resulting "Request details" page, the request's status is now no longer displaying your custom status but has switched to "Requested" Test custom status is removed when authorised value is removed: 18) Observe that the request has the status "Requested", we are going to override that with a custom status, then remove that custom status authorised value 19) Click "Edit request" 20) Select a custom status and Submit the form 21) In the resulting "View ILL requests" page, observe that your request is now displaying your custom status. 22) Go to the authorised values management page 23) Delete the custom status you previously selected in step 19 24) Return to the list of ILL requests 25) Observe that the request that previously had the custom status now has it's former status of "Requested" Test API response for View ILL requests view: 26) Modify an existing request and set a custom status as discussed above 27) Navigate to the "View ILL requests" page 28) Examine the response to the API call made to the /api/v1/illrequests?embed=metadata,patron,capabilities,library,status_alias route 28) Observe that for requests with a custom status, the status_alias property contains an object for the request's authorised value containing the custom status 29) Observe that for requests without a custom status, status_alias is null Test OPAC view: 30) Modify an existing request and set a custom status as discussed above 31) In the OPAC, navigate to "your interlibrary loan requests" 32) In the "Interlibrary loan requests" view, observe that the request's status is displaying your custom value 33) Click "View" on the request with a custom value 34) In the "View Interlibrary loan request" view, observe that the request's status is displaying your custom value -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78384|0 |1 is obsolete| | --- Comment #36 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 78431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78431&action=edit Bug 20581: Fix display of status alias in OPAC Fix for status alias display in OPAC, we should be displaying the status name, not the status code. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78377|0 |1 is obsolete| | --- Comment #38 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 78516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78516&action=edit Bug 20581: Provide status_alias on IllRequest This patch provides status_alias support for the Koha::Illrequest object. - New 'statusalias' getter method, returns the request's status_alias authorised value object if set, otherwise undef - Overloads existing 'status' method, getter/setter accessors intact, but setting the request's status now implicitly removes any status_alias that has been set Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78379|0 |1 is obsolete| | --- Comment #40 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 78518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78518&action=edit Bug 20581: Add display of status_alias to staff vw - This patch adds display of the new status_alias value, when set, in favour of the request's status value. - It also allows the user to set a status_alias for an existing request. When set, this value will be displayed in preference to the status. Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78381|0 |1 is obsolete| | --- Comment #42 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 78520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78520&action=edit Bug 20581: Unit tests for status_alias This patch adds unit tests for the specific status_alias functionality added in this bug - Creation of the ILLSTATUS authorised value - Illrequest->statusalias accessor - Illrequest->status overloading to reset status_alias To test: 1) Apply this patch 2) prove t/db_dependent/Illrequests.t Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78383|0 |1 is obsolete| | --- Comment #44 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 78522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78522&action=edit Bug 20581: (follow-up) Display status name Rather than display the status code for custom statuses, we should be displaying the name Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78515|0 |1 is obsolete| | --- Comment #47 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 80279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80279&action=edit Bug 20581: Modifications to database schema - This patch provides an illrequests.status_alias column that is a foreign key to authorised_values.id. This provides the ability for an ILL request to have an optional status alias that is defined as an authorised valued. - A new ILLSTATUS authorised value category is also made available during install. Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78517|0 |1 is obsolete| | --- Comment #49 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 80281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80281&action=edit Bug 20581: API provide status_alias embed - This patch provides the illrequests API route with an additional embed, called 'status_alias'. Requesting this embed returns an object for the request's status_alias authorised value, or null if one is not set. - This patch also adds the new status_alias as a default embed on the API call made by the illlist view Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78519|0 |1 is obsolete| | --- Comment #51 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 80283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80283&action=edit Bug 20581: Add support for status_alias to OPAC view - This patch adds the abililty for the OPAC to display a set status_alias value in preference to a request's status value. During ILL request listing or individual ILL request view, the status_alias value, if set, will be displayed in favour of the status Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78522|0 |1 is obsolete| | --- Comment #53 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 80285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80285&action=edit Bug 20581: (follow-up) Display status name Rather than display the status code for custom statuses, we should be displaying the name Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #55 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Done, thanks Josef! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 --- Comment #61 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 80474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80474&action=edit Bug 20581: (follow-up) Modify DB updgrade As per https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c56 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80475|0 |1 is obsolete| | --- Comment #67 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 80505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80505&action=edit Bug 20581: (follow-up) Fix statusalias return As per https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c57 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 --- Comment #71 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 80598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80598&action=edit Bug 20581: (follow-up) Fix fallback status_alias As per: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c68 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 --- Comment #73 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 80600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80600&action=edit Bug 20581: (follow-up) Fix AV population As per: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c72 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20600 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 [Bug 20600] Provide the ability for users to filter ILL requests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|7317 | CC| |martin.renvoize@ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80279|0 |1 is obsolete| | --- Comment #74 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82063&action=edit Bug 20581: Modifications to database schema - This patch provides an illrequests.status_alias column that is a foreign key to authorised_values.id. This provides the ability for an ILL request to have an optional status alias that is defined as an authorised valued. - A new ILLSTATUS authorised value category is also made available during install. Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80280|0 |1 is obsolete| | --- Comment #76 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82065&action=edit Bug 20581: Provide status_alias on IllRequest This patch provides status_alias support for the Koha::Illrequest object. - New 'statusalias' getter method, returns the request's status_alias authorised value object if set, otherwise undef - Overloads existing 'status' method, getter/setter accessors intact, but setting the request's status now implicitly removes any status_alias that has been set Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80282|0 |1 is obsolete| | --- Comment #78 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82067&action=edit Bug 20581: Add display of status_alias to staff vw - This patch adds display of the new status_alias value, when set, in favour of the request's status value. - It also allows the user to set a status_alias for an existing request. When set, this value will be displayed in preference to the status. Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80285|0 |1 is obsolete| | --- Comment #80 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82069&action=edit Bug 20581: (follow-up) Display status name Rather than display the status code for custom statuses, we should be displaying the name Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80501|0 |1 is obsolete| | --- Comment #82 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82071&action=edit Bug 20581: (follow-up) Allow for undefined lib As per: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c59 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80598|0 |1 is obsolete| | --- Comment #84 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82073&action=edit Bug 20581: (follow-up) Fix fallback status_alias As per: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c68 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80600|0 |1 is obsolete| | --- Comment #86 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82075&action=edit Bug 20581: (follow-up) Fix AV population As per: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c72 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80283|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82063|0 |1 is obsolete| | --- Comment #89 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82443&action=edit Bug 20581: Modifications to database schema - This patch provides an illrequests.status_alias column that is a foreign key to authorised_values.id. This provides the ability for an ILL request to have an optional status alias that is defined as an authorised valued. - A new ILLSTATUS authorised value category is also made available during install. Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82065|0 |1 is obsolete| | --- Comment #91 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82445&action=edit Bug 20581: Provide status_alias on IllRequest This patch provides status_alias support for the Koha::Illrequest object. - New 'statusalias' getter method, returns the request's status_alias authorised value object if set, otherwise undef - Overloads existing 'status' method, getter/setter accessors intact, but setting the request's status now implicitly removes any status_alias that has been set Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82067|0 |1 is obsolete| | --- Comment #93 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82447&action=edit Bug 20581: Add display of status_alias to staff vw - This patch adds display of the new status_alias value, when set, in favour of the request's status value. - It also allows the user to set a status_alias for an existing request. When set, this value will be displayed in preference to the status. Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82069|0 |1 is obsolete| | --- Comment #95 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82449&action=edit Bug 20581: (follow-up) Display status name Rather than display the status code for custom statuses, we should be displaying the name Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82071|0 |1 is obsolete| | --- Comment #97 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82451&action=edit Bug 20581: (follow-up) Allow for undefined lib As per: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c59 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82073|0 |1 is obsolete| | --- Comment #99 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82453&action=edit Bug 20581: (follow-up) Fix fallback status_alias As per: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c68 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82075|0 |1 is obsolete| | --- Comment #101 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82455&action=edit Bug 20581: (follow-up) Fix AV population As per: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c72 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82443|0 |1 is obsolete| | --- Comment #103 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82457&action=edit Bug 20581: Modifications to database schema - This patch provides an illrequests.status_alias column that is a foreign key to authorised_values.id. This provides the ability for an ILL request to have an optional status alias that is defined as an authorised valued. - A new ILLSTATUS authorised value category is also made available during install. Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82445|0 |1 is obsolete| | --- Comment #105 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82459&action=edit Bug 20581: Provide status_alias on IllRequest This patch provides status_alias support for the Koha::Illrequest object. - New 'statusalias' getter method, returns the request's status_alias authorised value object if set, otherwise undef - Overloads existing 'status' method, getter/setter accessors intact, but setting the request's status now implicitly removes any status_alias that has been set Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82447|0 |1 is obsolete| | --- Comment #107 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82461&action=edit Bug 20581: Add display of status_alias to staff vw - This patch adds display of the new status_alias value, when set, in favour of the request's status value. - It also allows the user to set a status_alias for an existing request. When set, this value will be displayed in preference to the status. Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82449|0 |1 is obsolete| | --- Comment #109 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82463&action=edit Bug 20581: (follow-up) Display status name Rather than display the status code for custom statuses, we should be displaying the name Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82451|0 |1 is obsolete| | --- Comment #111 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82465&action=edit Bug 20581: (follow-up) Allow for undefined lib As per: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c59 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82453|0 |1 is obsolete| | --- Comment #113 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82467&action=edit Bug 20581: (follow-up) Fix fallback status_alias As per: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c68 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82461|0 |1 is obsolete| | --- Comment #115 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82472&action=edit Bug 20581: Add display of status_alias to staff vw - This patch adds display of the new status_alias value, when set, in favour of the request's status value. - It also allows the user to set a status_alias for an existing request. When set, this value will be displayed in preference to the status. Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82459|0 |1 is obsolete| | --- Comment #117 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82484&action=edit Bug 20581: Provide status_alias on IllRequest This patch provides status_alias support for the Koha::Illrequest object. - New 'statusalias' getter method, returns the request's status_alias authorised value object if set, otherwise undef - Overloads existing 'status' method, getter/setter accessors intact, but setting the request's status now implicitly removes any status_alias that has been set Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82472|0 |1 is obsolete| | --- Comment #119 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82486&action=edit Bug 20581: Add display of status_alias to staff vw - This patch adds display of the new status_alias value, when set, in favour of the request's status value. - It also allows the user to set a status_alias for an existing request. When set, this value will be displayed in preference to the status. Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82462|0 |1 is obsolete| | --- Comment #121 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82488&action=edit Bug 20581: Unit tests for status_alias This patch adds unit tests for the specific status_alias functionality added in this bug - Creation of the ILLSTATUS authorised value - Illrequest->statusalias accessor - Illrequest->status overloading to reset status_alias To test: 1) Apply this patch 2) prove t/db_dependent/Illrequests.t Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82458|0 |1 is obsolete| | --- Comment #123 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82490&action=edit Bug 20581: (follow-up) Modify DB updgrade As per https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c56 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82465|0 |1 is obsolete| | --- Comment #125 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82492&action=edit Bug 20581: (follow-up) Allow for undefined lib As per: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c59 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82467|0 |1 is obsolete| | --- Comment #127 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82494&action=edit Bug 20581: (follow-up) Fix fallback status_alias As per: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c68 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82468|0 |1 is obsolete| | --- Comment #129 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82496&action=edit Bug 20581: (follow-up) Modify POD As per: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c69 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 --- Comment #131 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 84202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84202&action=edit Bug 20581: (follow-up) Fix QA errors This patch fixes the "missing_filter" errors on ill-requests.tt -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |tomascohen@gmail.com --- Comment #133 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have an issue here with the data structures: In Koha we ususally store the code (authorised_value) for referencing, this patch uses the authorised_values.id which is the numerical PK of the table. I can see where this is coming from, but as it would be the only place in Koha working like that. It will make it impossible to use our TT plugins for dealing with the descriptions etc.

From the QA script:

Maybe we could improve that with a bit of squashing: FAIL installer/data/mysql/en/optional/ill_auth_cat.sql FAIL git manipulation The file has been added and deleted in the same patchset FAIL installer/data/mysql/en/optional/ill_auth_cat.txt FAIL git manipulation The file has been added and deleted in the same patchset -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82483|0 |1 is obsolete| | --- Comment #135 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 84770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84770&action=edit Bug 20581: Modifications to database schema - This patch provides an illrequests.status_alias column that is a foreign key to authorised_values.id. This provides the ability for an ILL request to have an optional status alias that is defined as an authorised valued. - A new ILLSTATUS authorised value category is also made available during install. Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie Following commit was squashed into this one: Bug 20581: (follow-up) Modify DB updgrade As per https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c56 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82485|0 |1 is obsolete| | --- Comment #137 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 84772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84772&action=edit Bug 20581: API provide status_alias embed - This patch provides the illrequests API route with an additional embed, called 'status_alias'. Requesting this embed returns an object for the request's status_alias authorised value, or null if one is not set. - This patch also adds the new status_alias as a default embed on the API call made by the illlist view Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82487|0 |1 is obsolete| | --- Comment #139 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 84774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84774&action=edit Bug 20581: Fix display of status alias in OPAC Fix for status alias display in OPAC, we should be displaying the status name, not the status code. Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82491|0 |1 is obsolete| | --- Comment #141 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 84776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84776&action=edit Bug 20581: (follow-up) Display status name Rather than display the status code for custom statuses, we should be displaying the name Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82493|0 |1 is obsolete| | --- Comment #143 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 84778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84778&action=edit Bug 20581: (follow-up) Fix statusalias return As per https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c57 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82495|0 |1 is obsolete| | --- Comment #145 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 84780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84780&action=edit Bug 20581: (follow-up) Fix AV population As per: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c72 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82733|0 |1 is obsolete| | --- Comment #147 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 84782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84782&action=edit Bug 20581: (follow-up) Fix typo in kohastructure Fix the missing comma -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84404|0 |1 is obsolete| | --- Comment #149 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 84784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84784&action=edit Bug 20581: (follow-up) Fix dependency requirement Since this bug is now dependent on Bug 20600 (Provide the ability for users to filter ILL requests) we need to make the status filtering aware of the custom statuses. This patch does that. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 --- Comment #151 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Hi Katrin Thanks for that. I've now switched from using authorised_values.id to authorised_values.authorised_value. I've also squashed the commits that were causing that QA error. All should be well now. Cheers Andrew -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #152 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Moving back to signed off. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82489|0 |1 is obsolete| | --- Comment #154 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 82489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82489 Bug 20581: DO NOT PUSH: Updated Schema Files. This is too big, including more than the expected changed files. I am obsoleting it using 'dbic' on kohadevbox. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 --- Comment #156 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Hi Katrin, rant incoming, though it's not aimed at you! To be honest, this is actually a problem that is caused by using a foreign key that does not contain unique values. I was originally using authorised_values.id (which *is* unique) as the foreign key from illrequests.status_alias, but after you said this is the non-standard way of doing things, I changed it to use authorised_values.authorised_value, which has no unique constraint on it, as you have demonstrated. Thinking around the problem, I suspect this issue will affect any part of Koha that uses authorised values. The DBIx relationship makes the reasonable assumption that the column used as a foreign key contains unique values, so it just returns the first value it finds, which in this case is incorrect. As far as addressing it in this case. Whatever I do is going to be hackery, since it's patching over a fundamental DB design problem. Since we're using the Koha objects/DBIx::Class accessors to get the request's status, I'm going to have to provide an overloaded method that only gets the authorised values in the correct category. I do think it's worth considering in the context of the DB design error. This is a fairly nasty problem, I suspect it's just not very commonly seen since creating two authorised values with the same "Authorised value" value is probably quite rare. I'll create a bug to start a discussion on it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 --- Comment #158 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- A first idea I had was to add prefixes... CATEGORY_AUTHVALUE, but the numerical ones are a problem there. The datatypes won't make it possible without more changes. Having a new table for each of those is also not the right way. Would a combined primary key not solve the issue? (category, authorised_value) - those ARE unique and enforced. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 --- Comment #160 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Andrew Isherwood from comment #159)

Hmmm, prefixes feels like a hack.

Using a composite primary key as you suggest might be a step in the right direction. However, as I understand it, to then use that as a foreign key in other tables would require each table to have a corresponding column for each of the authorised_values columns that comprise the key.

As an aside, I'm not convinced the category and authorised_value columns do currently have any unique constraint on them. Looking at the schema, it looks like category, authorised_value and lib are defined as keys, but I can only think that was does to create indexes on them as there appears to be no unique constraints on them.

Definitely worth a discussion I think...

It might only be enforced on GUI side. Jonathan worked on some of this as part of the move to Koha introducing the authorised_value_category table as a first step to improve the data structures. Looking at some of this code might be helpful? Note: In order to translate the code to a description you can use TT plugins. No needs to pass the descriptions usually - so that might avoid some of the issue? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 --- Comment #162 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 84818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84818&action=edit Bug 20581: (follow-up) Fix status_alias comparison status_alias will arrive in the Koha object as a string, so when we special case it, we should also pass a string -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 --- Comment #164 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Andrew, can this be switched back to Signed off = ready for more QA? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #165 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry Andrew, I wish I had better news: - Correct descriptions now show But: When I edit one of the ILL requests I set to "Internal processing" and change it back to "New request" it doesn't take on saving. I stays at the custom status and I can't change it. There is no error in the plack logs, just: [Mon Feb 4 19:33:12 2019] [debug] GET "/api/v1/illrequests" [Mon Feb 4 19:33:12 2019] [debug] Routing to controller "Koha::REST::V1::Auth" and action "under" [Mon Feb 4 19:33:12 2019] [debug] Routing to controller "Koha::REST::V1::Illrequests" and action "list" [Mon Feb 4 19:33:12 2019] [debug] 200 OK (0.0728s, 13.736/s) This happens for both my FreeForm and BLDSS requests. If I confirm the request, setting "Requested" seems to work ok, But in the datbase I see -1 for alias_status. I'd say this should be NULL or "", as -1 seems unusual and a bit dangerous (considering the 'on order' authorised value is -1 for example) Not sure if this is related to the patch, but noting just in case: I can't confirm the request either, but get an error instead. This is a BLDSS request - might just be related to that as my FreeForm one behaves nicely. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 --- Comment #167 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Hi Katrin Thanks very much for the info. A bit of context might be in order. An ILL request has, at any given time, a single "status". The workflow the request passes through is dictated by those statuses. The ILL module has the idea of a "status graph", which essentially says "if you're at this status, you can have come from this/these status(es) and you can go to this/these status(es)." This is how we can determine what actions the user can take on any given request. This bug adds the concept of status aliases, which are user defined as authorised values. These have no bearing on any of the above, the request's status is still used in the same way. The status alias is purely used for display. The display logic says "if a request has a status alias, display that, otherwise display the request's status". This enables the user to select one of their user defined status aliases, which will be displayed in favour of the request's "actual" status. This allows the user to assign a more locally meaningful status to a request, rather than rely on those provided by ILL. I mentioned above that the status alias has no bearing on the actual status. The request's status is still there, and still determines, say, which action buttons are displayed for a request, but it is not displayed if an alias is also assigned to that request. However, if a request that has a status alias is moved forward through the workflow by clicking one of the action buttons (e.g. Confirm request), we assume that the status alias is no longer applicable and nullify it in the request, causing the request's actual status to now display, until such a time as the user selects a new status alias. So, to address what you're seeing above with -1 being assigned. In the "Edit request" screen, the status dropdown contains all of the status aliases PLUS an option for the request's actual status, which effectively allows the user to nullify the request's status alias and revert the request to the actual status. You said you selected "New request", which will have been the request's actual status. But it sounds like, rather than nullifying the status alias, it set it to -1. Which is odd. I'll investigate and get back to you. Thanks again for your ongoing efforts on getting this one through! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #169 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #165)

When I edit one of the ILL requests I set to "Internal processing" and change it back to "New request" it doesn't take on saving. I stays at the custom status and I can't change it.

This is now fixed. The hackery I had to introduce into Illrequest.pm requires a special casing for when we want to nullify status_alias, I had forgotten to introduce that here.

If I confirm the request, setting "Requested" seems to work ok, But in the datbase I see -1 for alias_status.

See above

Not sure if this is related to the patch, but noting just in case: I can't confirm the request either, but get an error instead. This is a BLDSS request - might just be related to that as my FreeForm one behaves nicely.

This is unrelated, it does actually appear that the BLDSS API is suddenly returning an error for the confirm call :( I'll investigate... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84770|0 |1 is obsolete| | --- Comment #170 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84911&action=edit Bug 20581: Modifications to database schema - This patch provides an illrequests.status_alias column that is a foreign key to authorised_values.id. This provides the ability for an ILL request to have an optional status alias that is defined as an authorised valued. - A new ILLSTATUS authorised value category is also made available during install. Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie Following commit was squashed into this one: Bug 20581: (follow-up) Modify DB updgrade As per https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c56 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84772|0 |1 is obsolete| | --- Comment #172 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84913&action=edit Bug 20581: API provide status_alias embed - This patch provides the illrequests API route with an additional embed, called 'status_alias'. Requesting this embed returns an object for the request's status_alias authorised value, or null if one is not set. - This patch also adds the new status_alias as a default embed on the API call made by the illlist view Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84774|0 |1 is obsolete| | --- Comment #174 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84915&action=edit Bug 20581: Fix display of status alias in OPAC Fix for status alias display in OPAC, we should be displaying the status name, not the status code. Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84776|0 |1 is obsolete| | --- Comment #176 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84917&action=edit Bug 20581: (follow-up) Display status name Rather than display the status code for custom statuses, we should be displaying the name Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84778|0 |1 is obsolete| | --- Comment #178 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84919&action=edit Bug 20581: (follow-up) Fix statusalias return As per https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c57 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84780|0 |1 is obsolete| | --- Comment #180 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84921&action=edit Bug 20581: (follow-up) Fix AV population As per: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c72 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84782|0 |1 is obsolete| | --- Comment #182 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84923&action=edit Bug 20581: (follow-up) Fix typo in kohastructure Fix the missing comma Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84784|0 |1 is obsolete| | --- Comment #184 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84925&action=edit Bug 20581: (follow-up) Fix dependency requirement Since this bug is now dependent on Bug 20600 (Provide the ability for users to filter ILL requests) we need to make the status filtering aware of the custom statuses. This patch does that. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84791|0 |1 is obsolete| | --- Comment #186 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84927&action=edit Bug 20581: (follow-up) Fix typo in DB upgrade IN -> ON Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84818|0 |1 is obsolete| | --- Comment #188 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84929&action=edit Bug 20581: (follow-up) Fix status_alias comparison status_alias will arrive in the Koha object as a string, so when we special case it, we should also pass a string Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84844|0 |1 is obsolete| | --- Comment #190 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84931&action=edit Bug 20581: (follow-up) Passed value to status_alias Now we have overloaded status_alias, we can no longer pass it undef (as it uses that to determine if it's being used as a getter or setter). So we now pass it -1 to indicate it should actually be setting undef (a hack, I know, but what are you going to do...) This patch makes sure ill-request.pl conforms to that. It also fixes the testing of the passed parameter, which was wrong. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #192 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #191)

I don't like -1 in illrequests.status_alias meaning 'no status set'. I'd be much happier with NULL.

That's a bug, it should not be recording -1 for no status_alias, it should indeed be NULL. If it's saving -1 that's potentially very problematic. Is it definitely still doing that? The fix I did the other day should have resolved that. I'll set this to Failed QA and investigate tomorrow. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84912|0 |1 is obsolete| | --- Comment #196 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 85076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85076&action=edit Bug 20581: Provide status_alias on IllRequest This patch provides status_alias support for the Koha::Illrequest object. - New 'statusalias' getter method, returns the request's status_alias authorised value object if set, otherwise undef - Overloads existing 'status' method, getter/setter accessors intact, but setting the request's status now implicitly removes any status_alias that has been set Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.