Discussion of account types / labels
The accounts system uses the following codes to show what kind of fee or credit has been issued: A = Account management fee C = Credit F = Overdue fine FOR = Forgiven FU = Overdue, still accruing L = Lost item LR = Lost item returned/refunded M = Sundry N = New card PAY = Payment W = Writeoff The labels, such as 'Account management fee' and 'Overdue fine' are hard coded in various template toolkit files. This is problematic for a number of reasons: 1) It's not obvious where these are defined -- most other constants in Koha are in authorized values. https://koha-community.org/manual/18.05/en/html/faq.html#fines-table is the only place where a koha user can find them all in one place. 2) Because they're not in the database, they can't be used in reports (at least without kludgy case statements). 3) They're not available outside the web interface, so SIP2 and any API endpoints must show the raw codes. 4) 'FU' is a common abbreviation for an obscenity in English, and this has a tendency to show in up in a lot of places where it really shouldn't.
Hi, On 19-02-22 21:00, Barton Chittenden wrote:
The accounts system uses the following codes to show what kind of fee or credit has been issued:
[...]
The labels, such as 'Account management fee' and 'Overdue fine' are hard coded in various template toolkit files. This is problematic for a number of reasons:
1) It's not obvious where these are defined -- most other constants in Koha are in authorized values. https://koha-community.org/manual/18.05/en/html/faq.html#fines-table is the only place where a koha user can find them all in one place. 2) Because they're not in the database, they can't be used in reports (at least without kludgy case statements). 3) They're not available outside the web interface, so SIP2 and any API endpoints must show the raw codes. 4) 'FU' is a common abbreviation for an obscenity in English, and this has a tendency to show in up in a lot of places where it really shouldn't.
Thanks for bringing that up. Indeed, and the codes doesn't really speak for themselves so having very minimal doc doesn't help I don't even know how FU relates it's description. Maybe it's the actual obscenity. To express discontent with the accruing overdue 😱 Joking aside, is there one obvious clean way that this would have been done today? Authorized values? Would there be downsides of the clean alternative(s) compared to now? (hopefully it was like that because of "historical reasons") À++ -- Victor Grousset, dev support/maintenance BibLibre, Services en logiciels libres pour les bibliothèques BibLibre, Libre/Open Source software and services for libraries
It's Fine Unreturned Whatever they are changed to needs to be translatable. Chris On 25 February 2019 11:50:17 PM NZDT, Victor Grousset <victor.grousset@biblibre.com> wrote:
Hi,
On 19-02-22 21:00, Barton Chittenden wrote:
The accounts system uses the following codes to show what kind of fee or credit has been issued:
[...]
The labels, such as 'Account management fee' and 'Overdue fine' are hard coded in various template toolkit files. This is problematic for a number of reasons:
1) It's not obvious where these are defined -- most other constants in Koha are in authorized values. https://koha-community.org/manual/18.05/en/html/faq.html#fines-table is the only place where a koha user can find them all in one place. 2) Because they're not in the database, they can't be used in reports
(at least without kludgy case statements). 3) They're not available outside the web interface, so SIP2 and any API endpoints must show the raw codes. 4) 'FU' is a common abbreviation for an obscenity in English, and this has a tendency to show in up in a lot of places where it really shouldn't.
Thanks for bringing that up. Indeed, and the codes doesn't really speak for themselves so having very minimal doc doesn't help I don't even know how FU relates it's description. Maybe it's the actual obscenity. To express discontent with the accruing overdue 😱
Joking aside, is there one obvious clean way that this would have been done today? Authorized values?
Would there be downsides of the clean alternative(s) compared to now? (hopefully it was like that because of "historical reasons")
À++
-- Victor Grousset, dev support/maintenance BibLibre, Services en logiciels libres pour les bibliothèques BibLibre, Libre/Open Source software and services for libraries _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
-- Sent from my Android device with K-9 Mail. Please excuse my brevity.
On Mon, Feb 25, 2019 at 6:51 AM Chris Cormack <chrisc@catalyst.net.nz> wrote:
Whatever they are changed to needs to be translatable.
Agreed. I suspect that the trade-offs between 'We would like this to be translatable' and 'we need these values to be un-editable' (I.e. not authorized values) are probably what's kept things as they are.
I was pondering this yesterday as well. I figure a lookup table in the database that contains the code and a description (for reporting and administration purposes), but use translatable strings in templates using the code as hooks. David Cook Systems Librarian Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 0899 Direct: 02 8005 0595 From: koha-devel-bounces@lists.koha-community.org [mailto:koha-devel-bounces@lists.koha-community.org] On Behalf Of Barton Chittenden Sent: Tuesday, 26 February 2019 12:58 AM To: Chris Cormack <chrisc@catalyst.net.nz> Cc: Koha-devel <koha-devel@lists.koha-community.org> Subject: Re: [Koha-devel] Discussion of account types / labels On Mon, Feb 25, 2019 at 6:51 AM Chris Cormack <chrisc@catalyst.net.nz <mailto:chrisc@catalyst.net.nz> > wrote: Whatever they are changed to needs to be translatable. Agreed. I suspect that the trade-offs between 'We would like this to be translatable' and 'we need these values to be un-editable' (I.e. not authorized values) are probably what's kept things as they are.
Hi all, please keep in mind that 'translated' doesn't mean into one language, but should allow for supporting different languages at the same time, especially if those descriptions were to be used for APIs as well. Katrin On 26.02.19 00:11, David Cook wrote:
I was pondering this yesterday as well.
I figure a lookup table in the database that contains the code and a description (for reporting and administration purposes), but use translatable strings in templates using the code as hooks.
David Cook
Systems Librarian
Prosentient Systems
72/330 Wattle St
Ultimo, NSW 2007
Australia
Office: 02 9212 0899
Direct: 02 8005 0595
*From:*koha-devel-bounces@lists.koha-community.org [mailto:koha-devel-bounces@lists.koha-community.org] *On Behalf Of *Barton Chittenden *Sent:* Tuesday, 26 February 2019 12:58 AM *To:* Chris Cormack <chrisc@catalyst.net.nz> *Cc:* Koha-devel <koha-devel@lists.koha-community.org> *Subject:* Re: [Koha-devel] Discussion of account types / labels
On Mon, Feb 25, 2019 at 6:51 AM Chris Cormack <chrisc@catalyst.net.nz <mailto:chrisc@catalyst.net.nz>> wrote:
Whatever they are changed to needs to be translatable.
Agreed. I suspect that the trade-offs between 'We would like this to be translatable' and 'we need these values to be un-editable' (I.e. not authorized values) are probably what's kept things as they are.
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
Hi Katrin, I don’t understand your email. My suggestion would yield support for different languages (for anything using Template Toolkit templates). As far as I understand, that’s how we currently provide internationalization support in Koha. Am I missing something? Admittedly, I haven’t done much with the REST API yet, but I assume that the API would just deal with codes? And if we were calling the API from the OPAC, we’d just use templates that rely on the codes. David Cook Systems Librarian Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 0899 Direct: 02 8005 0595 From: koha-devel-bounces@lists.koha-community.org [mailto:koha-devel-bounces@lists.koha-community.org] On Behalf Of Katrin Fischer Sent: Tuesday, 26 February 2019 5:28 PM To: koha-devel@lists.koha-community.org Subject: Re: [Koha-devel] Discussion of account types / labels Hi all, please keep in mind that 'translated' doesn't mean into one language, but should allow for supporting different languages at the same time, especially if those descriptions were to be used for APIs as well. Katrin On 26.02.19 00:11, David Cook wrote: I was pondering this yesterday as well. I figure a lookup table in the database that contains the code and a description (for reporting and administration purposes), but use translatable strings in templates using the code as hooks. David Cook Systems Librarian Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 0899 Direct: 02 8005 0595 From: koha-devel-bounces@lists.koha-community.org <mailto:koha-devel-bounces@lists.koha-community.org> [mailto:koha-devel-bounces@lists.koha-community.org] On Behalf Of Barton Chittenden Sent: Tuesday, 26 February 2019 12:58 AM To: Chris Cormack <mailto:chrisc@catalyst.net.nz> <chrisc@catalyst.net.nz> Cc: Koha-devel <mailto:koha-devel@lists.koha-community.org> <koha-devel@lists.koha-community.org> Subject: Re: [Koha-devel] Discussion of account types / labels On Mon, Feb 25, 2019 at 6:51 AM Chris Cormack <chrisc@catalyst.net.nz <mailto:chrisc@catalyst.net.nz> > wrote: Whatever they are changed to needs to be translatable. Agreed. I suspect that the trade-offs between 'We would like this to be translatable' and 'we need these values to be un-editable' (I.e. not authorized values) are probably what's kept things as they are. _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org <mailto:Koha-devel@lists.koha-community.org> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
I've been working on cleaning up these codes as a first step towards other improvements in this area.. There are a few bugs still in the NSO stages and I think it would be really beneficial to keep that tree moving forward as we're now in a half and half state in master (and thus 19.05 if we don't push these through).. Any help with the following bugs would be gratefully received. Bug 22563 <https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563> - Convert lost handling to use 'status' instead of multiple accounttypes Bug 11573 <https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573> - Fine descriptions related to Rentals are untranslatable Bug 6759 <https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6759> - Use a different account type for account renewals than for new accounts Bug 22610 <https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610> - SIP Payment Types should be moved out of accountype My hope is to get these one's in now to clear the way for working on resurrecting "Bug 17702 <https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702> - Create configuration for account types" during the next cycle Many thanks, *Martin Renvoize* <https://www.ptfs-europe.com> Development Team Manager *Phone:* +44 (0) 1483 378728 *Mobile:* +44 (0) 7725 985 636 *Email:* martin.renvoize@ptfs-europe.com *Fax:* +44 (0) 800 756 6384 www.ptfs-europe.com Registered in the United Kingdom No. 06416372 VAT Reg No. 925 7211 30 The information contained in this email message may be privileged, confidential and protected from disclosure. If you are not the intended recipient, any dissemination, distribution or copying is strictly prohibited. If you think that you have received this email message in error, please email the sender at info@ptfs-europe.com On Wed, 27 Feb 2019 at 05:25, David Cook <dcook@prosentient.com.au> wrote:
Hi Katrin,
I don’t understand your email. My suggestion would yield support for different languages (for anything using Template Toolkit templates). As far as I understand, that’s how we currently provide internationalization support in Koha. Am I missing something?
Admittedly, I haven’t done much with the REST API yet, but I assume that the API would just deal with codes? And if we were calling the API from the OPAC, we’d just use templates that rely on the codes.
David Cook
Systems Librarian
Prosentient Systems
72/330 Wattle St
Ultimo, NSW 2007
Australia
Office: 02 9212 0899
Direct: 02 8005 0595
*From:* koha-devel-bounces@lists.koha-community.org [mailto: koha-devel-bounces@lists.koha-community.org] *On Behalf Of *Katrin Fischer *Sent:* Tuesday, 26 February 2019 5:28 PM *To:* koha-devel@lists.koha-community.org *Subject:* Re: [Koha-devel] Discussion of account types / labels
Hi all,
please keep in mind that 'translated' doesn't mean into one language, but should allow for supporting different languages at the same time, especially if those descriptions were to be used for APIs as well.
Katrin
On 26.02.19 00:11, David Cook wrote:
I was pondering this yesterday as well.
I figure a lookup table in the database that contains the code and a description (for reporting and administration purposes), but use translatable strings in templates using the code as hooks.
David Cook
Systems Librarian
Prosentient Systems
72/330 Wattle St
Ultimo, NSW 2007
Australia
Office: 02 9212 0899
Direct: 02 8005 0595
*From:* koha-devel-bounces@lists.koha-community.org [ mailto:koha-devel-bounces@lists.koha-community.org <koha-devel-bounces@lists.koha-community.org>] *On Behalf Of *Barton Chittenden *Sent:* Tuesday, 26 February 2019 12:58 AM *To:* Chris Cormack <chrisc@catalyst.net.nz> <chrisc@catalyst.net.nz> *Cc:* Koha-devel <koha-devel@lists.koha-community.org> <koha-devel@lists.koha-community.org> *Subject:* Re: [Koha-devel] Discussion of account types / labels
On Mon, Feb 25, 2019 at 6:51 AM Chris Cormack <chrisc@catalyst.net.nz> wrote:
Whatever they are changed to needs to be translatable.
Agreed. I suspect that the trade-offs between 'We would like this to be translatable' and 'we need these values to be un-editable' (I.e. not authorized values) are probably what's kept things as they are.
_______________________________________________
Koha-devel mailing list
Koha-devel@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
participants (6)
-
Barton Chittenden -
Chris Cormack -
David Cook -
Katrin Fischer -
Renvoize, Martin -
Victor Grousset