Broken url in arabic facets.. and fix
Hi, Karam made an interesting discovery for Bug 10176 [1], putting "use utf8;" on Search.pm fixes URL of facets (not display well for me, but url works). Digging a little I found that on line 574 of master Search.pm there is a strange symbol (last between []). Seems to be an inverted question mark. Karam saids that is Arabic one. 572:# Sanitize the link value : parenthesis, question and exclamation mark will cause errors with CCL 573- my $facet_link_value = $one_facet; 574- $facet_link_value =~ s/[()!?¡¿؟]/ /g; 575- Question: this char is a typo? Was introduced on Bug 9183 [2] 'use utf8;' fixes the substitute, and the URLs. Also removing that char gives the same effect (without 'use utf8:' Patch is from jcamins Regards, bernardo [1] http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10176 [2] http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9183 -- Bernardo Gonzalez Kriegel bgkriegel@gmail.com
Bernardo, Karam made an interesting discovery for Bug 10176 [1],
putting "use utf8;" on Search.pm fixes URL of facets (not display well for me, but url works).
Digging a little I found that on line 574 of master Search.pm there is a strange symbol (last between []). Seems to be an inverted question mark. Karam saids that is Arabic one.
572:# Sanitize the link value : parenthesis, question and exclamation mark will cause errors with CCL 573- my $facet_link_value = $one_facet; 574- $facet_link_value =~ s/[()!?¡¿؟]/ /g; 575-
Question: this char is a typo? Was introduced on Bug 9183 [2]
'use utf8;' fixes the substitute, and the URLs. Also removing that char gives the same effect (without 'use utf8:'
All I did with that line was reindent it. The question mark was added in patch 0e8e6e71332b3f47a9d131b35ee42ead9e8e5702 for bug 8888. Regards, Jared -- Jared Camins-Esakov Bibliographer, C & P Bibliography Services, LLC (phone) +1 (917) 727-3445 (e-mail) jcamins@cpbibliography.com (web) http://www.cpbibliography.com/
Sorry, I need to remember 'git blame -w' B -- Bernardo Gonzalez Kriegel bgkriegel@gmail.com On Sat, May 4, 2013 at 10:39 PM, Jared Camins-Esakov < jcamins@cpbibliography.com> wrote:
Bernardo,
Karam made an interesting discovery for Bug 10176 [1],
putting "use utf8;" on Search.pm fixes URL of facets (not display well for me, but url works).
Digging a little I found that on line 574 of master Search.pm there is a strange symbol (last between []). Seems to be an inverted question mark. Karam saids that is Arabic one.
572:# Sanitize the link value : parenthesis, question and exclamation mark will cause errors with CCL 573- my $facet_link_value = $one_facet; 574- $facet_link_value =~ s/[()!?¡¿؟]/ /g; 575-
Question: this char is a typo? Was introduced on Bug 9183 [2]
'use utf8;' fixes the substitute, and the URLs. Also removing that char gives the same effect (without 'use utf8:'
All I did with that line was reindent it. The question mark was added in patch 0e8e6e71332b3f47a9d131b35ee42ead9e8e5702 for bug 8888.
Regards, Jared
-- Jared Camins-Esakov Bibliographer, C & P Bibliography Services, LLC (phone) +1 (917) 727-3445 (e-mail) jcamins@cpbibliography.com (web) http://www.cpbibliography.com/
Very interesting. I think this charaters are escaped to not beak CCL syntaxe. But in this syntaxe, there is no ؟ Will you create a patch for this or do you think it may fix Bug 9579 ? Regards, Le 05/05/2013 03:33, Bernardo Gonzalez Kriegel a écrit :
Hi, Karam made an interesting discovery for Bug 10176 [1], putting "use utf8;" on Search.pm fixes URL of facets (not display well for me, but url works).
Digging a little I found that on line 574 of master Search.pm there is a strange symbol (last between []). Seems to be an inverted question mark. Karam saids that is Arabic one.
572:# Sanitize the link value : parenthesis, question and exclamation mark will cause errors with CCL 573- my $facet_link_value = $one_facet; 574- $facet_link_value =~ s/[()!?¡¿؟]/ /g; 575-
Question: this char is a typo? Was introduced on Bug 9183 [2]
'use utf8;' fixes the substitute, and the URLs. Also removing that char gives the same effect (without 'use utf8:'
Patch is from jcamins
Regards, bernardo
[1] http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10176 [2] http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9183
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
-- Fridolyn SOMERS Biblibre - Pôle support fridolyn.somers@biblibre.com
I did some tests, and for me Bug 9579 is fixed by Bug 10176, and now arabic facets are working, I will put a comment on the bug. That symbol was explicitly added on Bug 8888 ( http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12849&action=diff ), I don't have the faintest idea about the reason. Regards -- Bernardo Gonzalez Kriegel bgkriegel@gmail.com On Wed, Jun 5, 2013 at 5:55 AM, Fridolyn SOMERS < fridolyn.somers@biblibre.com> wrote:
Very interesting. I think this charaters are escaped to not beak CCL syntaxe. But in this syntaxe, there is no ؟ Will you create a patch for this or do you think it may fix Bug 9579 ?
Regards,
Le 05/05/2013 03:33, Bernardo Gonzalez Kriegel a écrit :
Hi, Karam made an interesting discovery for Bug 10176 [1], putting "use utf8;" on Search.pm fixes URL of facets (not display well for me, but url works).
Digging a little I found that on line 574 of master Search.pm there is a strange symbol (last between []). Seems to be an inverted question mark. Karam saids that is Arabic one.
572:# Sanitize the link value : parenthesis, question and exclamation mark will cause errors with CCL 573- my $facet_link_value = $one_facet; 574- $facet_link_value =~ s/[()!?¡¿؟]/ /g; 575-
Question: this char is a typo? Was introduced on Bug 9183 [2]
'use utf8;' fixes the substitute, and the URLs. Also removing that char gives the same effect (without 'use utf8:'
Patch is from jcamins
Regards, bernardo
[1] http://bugs.koha-community.**org/bugzilla3/show_bug.cgi?id=**10176<http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10176> [2] http://bugs.koha-community.**org/bugzilla3/show_bug.cgi?id=**9183<http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9183>
______________________________**_________________ Koha-devel mailing list Koha-devel@lists.koha-**community.org<Koha-devel@lists.koha-community.org> http://lists.koha-community.**org/cgi-bin/mailman/listinfo/**koha-devel<http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel> website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.**org/<http://bugs.koha-community.org/>
-- Fridolyn SOMERS Biblibre - Pôle support fridolyn.somers@biblibre.com ______________________________**_________________ Koha-devel mailing list Koha-devel@lists.koha-**community.org<Koha-devel@lists.koha-community.org> http://lists.koha-community.**org/cgi-bin/mailman/listinfo/**koha-devel<http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel> website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.**org/ <http://bugs.koha-community.org/>
Hi, On Wed, Jun 5, 2013 at 3:57 AM, Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> wrote:
That symbol was explicitly added on Bug 8888 (http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12849&action=diff), I don't have the faintest idea about the reason.
My guess would be over-thoroughness. Our Zebra configuration uses '?' and '!' as operators, and on the face of it only those two characters need special handling. However, the patch submitter might have assumed that *all* question mark and exclamation mark characters were problematic. Regards, Galen -- Galen Charlton Manager of Implementation Equinox Software, Inc. / The Open Source Experts email: gmc@esilibrary.com direct: +1 770-709-5581 cell: +1 404-984-4366 skype: gmcharlt web: http://www.esilibrary.com/ Supporting Koha and Evergreen: http://koha-community.org & http://evergreen-ils.org
Le 05/06/2013 18:42, Galen Charlton a écrit :
Hi,
On Wed, Jun 5, 2013 at 3:57 AM, Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> wrote:
That symbol was explicitly added on Bug 8888 (http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12849&action=diff), I don't have the faintest idea about the reason.
My guess would be over-thoroughness. Our Zebra configuration uses '?' and '!' as operators, and on the face of it only those two characters need special handling. However, the patch submitter might have assumed that *all* question mark and exclamation mark characters were problematic.
Regards,
Galen -- Galen Charlton Manager of Implementation Equinox Software, Inc. / The Open Source Experts email: gmc@esilibrary.com direct: +1 770-709-5581 cell: +1 404-984-4366 skype: gmcharlt web: http://www.esilibrary.com/ Supporting Koha and Evergreen: http://koha-community.org & http://evergreen-ils.org _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
I think that also. -- Fridolyn SOMERS Biblibre - Pôle support fridolyn.somers@biblibre.com
participants (4)
-
Bernardo Gonzalez Kriegel -
Fridolyn SOMERS -
Galen Charlton -
Jared Camins-Esakov