[koha-commits] main Koha release repository branch master updated. v3.16.00-387-g27eccf4

Git repo owner gitmaster at git.koha-community.org
Mon Aug 11 14:39:44 CEST 2014


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  27eccf412217c18f282ae9e97e94885209a9ba69 (commit)
      from  80a1225bb732fb957af483cfa64face8631165bf (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 27eccf412217c18f282ae9e97e94885209a9ba69
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Fri Aug 8 14:48:59 2014 -0300

    Bug 12647: PQF QueryParser driver and unit tests fixes
    
    Due to Perl 5.18, QueryParser the default search class is no longer
    'keyword' (see bug 12738), and needs to be set manually. This patch
    adds a line that does that. The problem that gets fixed is with test
    'super simple keyword query'.
    
    The rest of the non-deterministically failing tests are due to the same
    problem, keys returning differently sorted keys from hashes.
    
    So this patch sorts keys in the step that concatenates attributes when building
    the PQF queries (and tests get adjusted to match the now deterministic result).
    
    I did that (sorting there) under Jared's recommendation. Hopefuly he will step
    in and comment/fix any mistake I made. My main concern was a possible loss
    in performance. That we agreed it is almost void, because of the tiny size
    of the hash.
    
    Sponsored-by: Universidad Nacional de Cordoba
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    All tests are passing now again :)
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/QueryParser/Driver/PQF/Util.pm |    5 +--
 t/QueryParser.t                     |   70 ++++++++++++++++++++++++++++-------
 2 files changed, 58 insertions(+), 17 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list