[Koha-devel] Moving system preference serialization into the database

[Chris Nighswonger]

On Mon, Jul 12, 2010 at 5:28 PM, Frederic Demians <frederic at tamil.fr> wrote:
>
>> Ok. Here is a quick fix which seems to be what everyone is headed toward.
>> Please abuse it a bit and see if it meets the present criteria.
>
> I try it. It works.

Thanks.

But the way you identify local syspref is not the good
> one, as I understand it. You have in systemprefernces.pl (that you
> reactivate) a hash of 'official' sysprefs. Then you select all syspref
> defined in DB which are no in this hash. But it means that if tomorrow I had
> a new preference in a .pref file I also will have to add it in
> systempreferences.pl file otherwise it will appear as local.

I think this is an unfortunate side-effect of the "quick and dirty"
part of this fix. Perhaps it might be good to open a bug against 3.4
to do at least some major cleanup of this code. There is a lot of it
which should be removed.

Kind Regards,
Chris