[Koha-devel] [QA] Description of some patches waiting for QA.

[Jonathan Druart]

Hello QA team (and others)!

I realize some of my patches are big and maybe need some explanation.

Below is a description of my main patches in the QA queue.

=== Bug fixes ===

== Bug 11549: Acquisition module ==
A major one: Data loss possible!
If an order is transferred and you receive/undo the receive, the order
is deleted!
This patch fixes the issue and add a regression test.

=== Features/enhancements ===

== Search history ==
I provided a lot of patches to improve the search history.
The idea is to have a search history at the OPAC and the staff interface.
Moreover an authority search history is added.
A refactoring has been made and unit tests written.
On my side, I have an other pending patch: the ability to merge
selected searches.

One patch is already passed QA, two need to be signed off and an other
one is in the QA queue:

Bug 10807 (NQA): OPAC: There is no authority search history
This patch adds the authority search history for the OPAC.

Bug 10862 (PQA): Add the search history for the staff interface
This patch adds the search history for the staff interface (catalogue
and authority).

Bug 10933 (NSO): PurgeSearchHistory should be merged into the
C4::Search::History module
=> This is a technical one, and I think a developer should do the signoff.

These 3 patches should be pushed at the same time I think.

Bug 11430 (NSO): Search history: Delete selected lines
At this point, it was only possible to delete previous or current
search history, not a specific search.
This one is a small feature and can be pushed later.

== Bug 10212: Columns configuration for tables ==
This patch was really fun to write and, I think, is a big improvement.
It is more than a POC, but it should be validated and pushed to go further.
The goal is to provide an admin page to configure all tables into
Koha. By configure I mean: "display/hide these columns by default" or
"this column could be shown/hidden (or not)".
Extending the concept to others tables will be quite easy.

== Multi transport types for notices ==
Hold on to your chair!
The goal of these patches is to add the ability to choose the
transport type a library want to use for notices.
Don't be afraid, it is easy.
The entry point is bug 9016: a new field letter.message_transport_type
is created. This way it becomes possible to defined several
"templates" for a letter_code. It will avoid to have letter codes like
HOLD_PRINT, HOLD_PHONE, etc.
This patch series adds the first step: the modifications into the DB
structure and the interface.
The multi transport types support for overdues is added too (interface
changes only).
A patron could be notified by email and/or sms for a given overdue level.
The templates being different, the sent message could be adapted to
the transport type.

The 3 other patches are based on top of bug 9016.

Bug 10832 - Multi transport types for overdue notices
Changes for the cronjob script misc/cronjobs/overdue_notices.pl.

Bug 10833 - Multi transport types for advanced notices
Changes for the cronjob script misc/cronjobs/advance_notices.pl.

Bug 10845 - Multi transport types for holds
Changes for holds.

All these patches are needing QA.

== Bug 10363: New package for authorised values ==
This one needs QA too.
I just refactored the authorised values code, put it in a new module
and provide unit tests.
Even if it does not use DBIC, I think it is useful and with this
refactoring, it will be easy to use DBIC later.

== Bug 11023: How to manage the newness of items? ==
This patch allows to manage various use cases for new items (see the
commit message for examples).
It offers an easy and flexible way to follow news items.
It adds a cronjob which automatically remove the new status for items
depending from some rules.
These rules can be defined easily into a configuration page in the tools area.

== Batch modification for records ==
There are two bugs waiting to be signed off:
Bug 11319 - Marc modification templates improvements
Bug 11395 - Batch modifications for records
The first one fixes some issues with the marc modification templates
features (bug 8015).
The second one adds an interface to modify records (catalogues or
authorities) in a batch using a template previously defined.
It is waited for a long time by librarians (see bug 5725 for the history).

Extra: bug 11562 (sysprefs.sql is not correctly sorted) should be
integrated quickly, if we don't have a sysprefs file sorted, the qa
script does not manage to catch non sorted new line (fix is welcomed
on the qa tools repo. I don't find how to fix that).

Please note that I am still waiting for other feedbacks on bug 8007.

I hope this email will be useful to you and make easier the QA step on
these patches!

Regards,
Jonathan