[Koha-devel] Coding guidelines question
Mark Tompsett
mtompset at hotmail.com
Wed Oct 29 05:38:51 CET 2014
Greetings,
<span style="block" title="[% SEARCH_RESULT.biblionumber |url %]" class="[%
IF ( SEARCH_RESULT.normalized_ean ) %][% SEARCH_RESULT.normalized_ean %][%
ELSE %][% SEARCH_RESULT.normalized_isbn %][% END %]" id="coce-thumbnail[%
loop.count %]"></span>
This fails to meet coding guidelines
(http://wiki.koha-community.org/wiki/Coding_Guidelines#HTML1:_Template_Toolkit_markup_inside_HTML)
The question is does the following fail too?
<span style="block" title="[% SEARCH_RESULT.biblionumber |url %]" class="[%
SEARCH_RESULT.normalized_ean || SEARCH_RESULT.normalized_isbn %]"
id="coce-thumbnail[% loop.count %]"></span>
Because I really like it compared to the length IF/ELSE split.
GPML,
Mark Tompsett
More information about the Koha-devel
mailing list