[Koha-devel] viewlog bug

[long_sam.tw]

 Dear tomas, 
http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=tools/viewlog.pl;h=a13ec5faf27e8692f11684e8c7b0075590d7595d;hb=HEAD

 80     if ( C4::Context->preference('ExtendedPatronAttributes') ) { 81         my $attributes = GetBorrowerAttributes( $data->{'borrowernumber'} ); 82         $template->param( 83             ExtendedPatronAttributes => 1, 84             extendedattributes       => $attributes 85         ); 86     }
If you turn on [ExtendedPatronAttributes] options, 
then it call GetBorrowerAttributes function. 
You use C4::Members::Attributes module, but there isn't the module in front ofin front of viewlog.pl . 
http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Members/Attributes.pm;h=a56a6273a5716390726eb81480a5864b3acf43dd;hb=HEAD
  Reproduce the error , you can turn on [ExtendedPatronAttributes] options in the system preferencehttp://your koha ip :8080/cgi-bin/koha/admin/preferences.pl
, and view 
http://your koha ip:8080/cgi-bin/koha/tools/viewlog.pl?do_it=1&modules=MEMBERS&modules=circulation&object=1&src=circ

Version affected 3.16.x,

Version 3.18, 3.20 are ok
line 74 they have add "use C4::Members::Attributes qw(GetBorrowerAttributes)"  
 74     use C4::Members::Attributes qw(GetBorrowerAttributes); 75     my $borrowernumber = $object;
,so there no error. 
Thanks a lot,
龍山 
     Tomas Cohen Arazi <tomascohen at gmail.com> 於 2015/6/11 (週四) 10:14 PM 寫道﹕
   
 

 You should definitely fill a bug on http://bugs.koha-community.org about it.
A side note: I couldn't reproduce the error on my test site. So please explain in detail things like if the patron has or hasn't extended attributes, etc.
2015-06-11 0:53 GMT-03:00 long_sam.tw <long_sam.tw at yahoo.com.tw>:

Dear koha floks, 
I found viewlog bugs. If you turn on [ExtendedPatronAttributes], then view Home › Patrons › Modification log
Software error:
Undefined subroutine &main::GetBorrowerAttributes called at /usr/share/koha/intranet/cgi-bin/tools/viewlog.pl line 82.
Bug fix 
modify viewlog.pl 
line 82
change
my $attributes = GetBorrowerAttributes( $data->{'borrowernumber'} ); 

to 
my $attributes = C4::Members::Attributes::GetBorrowerAttributes( $data->{'borrowernumber'} );


Koha version : 3.16.11, 3.18.7, 3.20
Help me patch viewlogs next release version.

Thanks a lot
龍山
_______________________________________________
Koha-devel mailing list
Koha-devel at lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/




-- 
Tomás Cohen AraziProsecretaría de InformáticaUniversidad Nacional de Córdoba✆ +54 351 5353750 ext 13168GPG: B76C 6E7C 2D80 551A C765  E225 0A27 2EA1 B2F3 C15F
_______________________________________________
Koha-devel mailing list
Koha-devel at lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

 
  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20150611/dde4d64a/attachment-0001.html>