[Koha-devel] kohastructure.sql : columns with COLLATE

[Renvoize, Martin]

I happened to spot the same only yesterday and wondered about doing such a
tidy up too..

I'd agree with Tomas, where the collate matches the table I'd drop it from
the column.. I didn't go ahead and do it yet as I didn't want to introduce
any pain for RMaints without discussing it first.


*Martin Renvoize*

<https://www.ptfs-europe.com>

Development Team Manager





*Phone:* +44 (0) 1483 378728

*Mobile:* +44 (0) 7725 985 636

*Email:* martin.renvoize at ptfs-europe.com

*Fax:* +44 (0) 800 756 6384


www.ptfs-europe.com







Registered in the United Kingdom No. 06416372   VAT Reg No. 925 7211 30

The information contained in this email message may be privileged,
confidential and protected from disclosure. If you are not the intended
recipient, any dissemination, distribution or copying is strictly
prohibited. If you think that you have received this email message in
error, please email the sender at info at ptfs-europe.com



On Fri, 27 Sep 2019 at 18:06, Tomas Cohen Arazi <tomascohen at gmail.com>
wrote:

> I think it doesn't really make sense. There are cases in which the general
> table collation is utf8mb4_unicode_ci and some columns need utf8mb4_binary.
> I think those are the only meaningful ones.
>
> El vie., 27 sept. 2019 a las 11:27, Fridolin SOMERS (<
> fridolin.somers at biblibre.com>) escribió:
>
>> Hi
>>
>> I'm working on DB structure compare.
>> I note that in installer/data/mysql/kohastructure.sql, a few columns
>> define CHARACTER SET and/or COLLATE, with same values as table.
>>
>> Is this usefull or should we remove it ?
>>
>> $ grep  'COLLATE' installer/data/mysql/kohastructure.sql  | grep -v
>> ENGIN | grep 'utf8mb4_unicode_ci'
>>    `category_name` varchar(32) COLLATE utf8mb4_unicode_ci NOT NULL
>> DEFAULT '',
>>    `font` char(10) CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci NOT
>> NULL DEFAULT 'TR',
>>    `text_justify` char(1) CHARACTER SET utf8mb4 COLLATE
>> utf8mb4_unicode_ci NOT NULL DEFAULT 'L',
>>    `auto_renew_error` varchar(32) COLLATE utf8mb4_unicode_ci DEFAULT
>> NULL, -- automatic renewal error
>>    `auto_renew_error` varchar(32) COLLATE utf8mb4_unicode_ci DEFAULT
>> NULL, -- automatic renewal error
>>    `suppliers_report` MEDIUMTEXT COLLATE utf8mb4_unicode_ci, -- reports
>> received from suppliers
>>        entity varchar(16) COLLATE utf8mb4_unicode_ci NOT NULL,
>>        code varchar(64) COLLATE utf8mb4_unicode_ci NOT NULL,
>>        lang varchar(25) COLLATE utf8mb4_unicode_ci NOT NULL, -- could be
>> a foreign key
>>        translation MEDIUMTEXT COLLATE utf8mb4_unicode_ci,
>>    `branchcode` varchar(10) CHARACTER SET utf8mb4 COLLATE
>> utf8mb4_unicode_ci DEFAULT NULL,
>>
>> --
>> Fridolin SOMERS <fridolin.somers at biblibre.com>
>> BibLibre, France - software and system maintainer
>> _______________________________________________
>> Koha-devel mailing list
>> Koha-devel at lists.koha-community.org
>> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
>> website : http://www.koha-community.org/
>> git : http://git.koha-community.org/
>> bugs : http://bugs.koha-community.org/
>>
>
>
> --
> Tomás Cohen Arazi
> Theke Solutions (http://theke.io)
> ✆ +54 9351 3513384
> GPG: B2F3C15F
> _______________________________________________
> Koha-devel mailing list
> Koha-devel at lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : http://www.koha-community.org/
> git : http://git.koha-community.org/
> bugs : http://bugs.koha-community.org/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20190927/e08eda7f/attachment-0001.html>