https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148419&action=edit Bib record for testing -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org --- Comment #4 from Phil Ringnalda <phil@chetcolibrary.org> --- Not sure how many other cases it would enable, but the bug 33159 comment 28 thing of searching for Heading-use-main-or-added-entry = 'a' while linking 1xx/7xx would work for LCSH plus FAST, since the FAST name authority records correctly have 008/14 set to b. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148493&action=edit Bug 33277: Support custom thesaurus authority with no 040 specified -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148495&action=edit Bug 33277: Don't search thesaurus when heading 'notspecified' -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Phil Ringnalda from comment #4)

Not sure how many other cases it would enable, but the bug 33159 comment 28 thing of searching for Heading-use-main-or-added-entry = 'a' while linking 1xx/7xx would work for LCSH plus FAST, since the FAST name authority records correctly have 008/14 set to b.

Please file as a new bug :-) dependent on this one -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #10 from Janusz Kaczmarek <januszop@gmail.com> --- (In reply to Nick Clemens from comment #8)

Created attachment 148495 [details] [review] Bug 33277: Don't search thesaurus when heading 'notspecified'

Nick, in this case (i.e. 2nd ind == 4), according to my knowledge and experience, if we want to be strict (and we want, I suppose) we should look for an authority record with 008/11 = '|', and non simply 'not n' For 6XX we read (e.g. https://www.loc.gov/marc/bibliographic/bd650.html): 2nd ind == "4 - Source not specified Subject added entry conforms to a controlled list that cannot be identified by second indicator values 0-3, 5-6 or by a code in subfield $2." So it does not mean "I, the librarian, do not care, take anything you can find", It means rather "there is no appropriate thesaurus identification", so, I would interpret it as "not coded" == '|'. It is not straightforward to do a search for '|', but it is possible, both in Zebra and ES. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #12 from Janusz Kaczmarek <januszop@gmail.com> --- I can confirm -- it does not work with Zebra for the case of 008/11 = 'z' and no 040 $f. The second attempt is made, but without modification of zebra auth index definition there will be 'notdefined' in the index instead of 'z' (authority-zebra-indexdefs.xsl): <xslo:when test="$thesaurus_code1 = 'z'"> <xslo:choose> <xslo:when test="//marc:datafield[@tag='040']/marc:subfield[@code='f']"> <xslo:value-of select="//marc:datafield[@tag='040']/marc:subfield[@code='f']"/> </xslo:when> <xslo:otherwise> <xslo:text>notdefined</xslo:text> </xslo:otherwise> </xslo:choose> </xslo:when> With ES it seems OK. The only doubt that I still have is putting nothing in the query for 6XX 2nd ind == '4'. As the consequence, if we had more than one auth records with the same 1XX, we would get more than one from the query, which is bad. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148500&action=edit Bug 33277: (follow-up) Fix notdefined search for Zebra and ES -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #16 from Phil Ringnalda <phil@chetcolibrary.org> --- I've never seen an authority record for a heading intended to be coded with ind2=4, so I don't have a practical opinion. If someone ordered me to create one, I would have used 008/11=z and an empty 040$f to say "this is an Other thesaurus, but I cannot speak its name." But if Janusz has experience with ones using 008/11=| I'm quite happy to defer to experience, and wait to see if someone using z objects later. (Because I think horrible thoughts, a WhatSubjectThesaurusCodeIsUnknown preference came to mind to solve disagreements, but anyone who feels we need that really ought to either be forced to write it, or be forced to pay someone handsomely for writing it.) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148528&action=edit Bug 33277: Support custom thesaurus authority with no 040 specified -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148530&action=edit Bug 33277: Search thesaurus for 'notspecified' -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #22 from Frank Hansen <frank.hansen@ub.lu.se> --- (In reply to Phil Ringnalda from comment #16)

I've never seen an authority record for a heading intended to be coded with ind2=4, so I don't have a practical opinion. If someone ordered me to create one, I would have used 008/11=z and an empty 040$f to say "this is an Other thesaurus, but I cannot speak its name." But if Janusz has experience with ones using 008/11=| I'm quite happy to defer to experience, and wait to see if someone using z objects later.

(Because I think horrible thoughts, a WhatSubjectThesaurusCodeIsUnknown preference came to mind to solve disagreements, but anyone who feels we need that really ought to either be forced to write it, or be forced to pay someone handsomely for writing it.)

I understand that different countries may have different interpretations of Library of Congress MARC specifications. And the Library of Congress allows free interpretation. I'm pretty sure that in Sweden we have our interpretation, which is also available here: https://katalogverk.kb.se/katalogisering/Formathandboken/index.html (only in Swedish). And Sweden are not to decide the format of course. And different countries may also have different needs. I would still like to comment on ind2=4. As for us, we treat them as local subject headings only and they are not included in any thesaurus. Therefore, I would prefer not to see any authority records for either 008/11=| (or 008/11=n) in our catalog, even if the format allows it. Here in Sweden, a kind of transition is made from field 653 for uncontrolled subject headings to using 650 with ind2=4 instead. That's another reason why I don't want to see any authority records with 008/11=| in our catalog. We are don't autocreate any authority records in our catalog. Almost all is imported from Netional Library (Libris). I also want to comment on 040$f. According to the Swedish cataloguing guidelines here https://katalogverk.kb.se/katalogisering/Formathandboken/kallorsystem/index.... (only in Swedish) 040$f must be filled in if 008/11=z. We in Sweden use many different thesauruses. In Library of Congress list here, https://www.loc.gov/standards/sourcelist/subject.html both the Swedish and Polish are listed. As I understand, 040 is a required field in Koha. However, 040$f is optional. Even though Library of Congress allows for the omission of 040$f, I can't see why it should be omitted, except for convenience. So I question about allowing to omit 040$f when 008/11=z. What causes the most trouble for me is, as mentioned earlier, that non-6XX fields are hardcoded to LCSH. This creates problems for libraries outside the US, as we typically do not use LCSH names. I wish we could skip thesaurus search for those fields. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #24 from Frank Hansen <frank.hansen@ub.lu.se> --- (In reply to Nick Clemens from comment #23)

(In reply to Frank Hansen from comment #22)

...

I would still like to comment on ind2=4. As for us, we treat them as local subject headings only and they are not included in any thesaurus. Therefore, I would prefer not to see any authority records for either 008/11=| (or 008/11=n) in our catalog, even if the format allows it.

Are you saying you won't import those records - or you want those records to be ignored when linking? The former sounds easy enough, the second seems it would require a syspref to not link those

Sorry if I was unclear. Records with ind2=4 is not exported from National Library catalogue at first. So they will not be imported to our local catalogue. We are not planning to create any either manually or automatically.

...

I also want to comment on 040$f. According to the Swedish cataloguing guidelines here ... So I question about allowing to omit 040$f when 008/11=z.

This sounds like a comment on cataloging standards, and maybe something that can be set in frameworks. But I don't think we need code for this?

Maybe not. We will use 040$f to specify system/thesaurus conventions in any case. I just want to make sure that it not have a negative impact on filtering on thesauruses if we omit 040$f.

...

What causes the most trouble for me is, as mentioned earlier, that non-6XX fields are hardcoded to LCSH. This creates problems for libraries outside the US, as we typically do not use LCSH names. I wish we could skip thesaurus search for those fields.

These patches do now skip searching thesaurus when linking non-subject fields

I'm testing bug33277 and what I have seen so far looks good. (both ES and Zebra) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #26 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Janusz Kaczmarek from comment #25)

Nick, I have looked into the corrected version. I see one problem: with Zebra, for:

655 7 $a Literatura angielska $2 DBN

you search first for: "Literatura angielska + DBN" and, since there is no 040 $f, there is the second query for: "Literatura angielska + undefined'

The second query passes "notdefined" - not undef

But having two auth records:

00116nz a2200049n 4500 008 230210 n anznnbabn a ana d 155 $a Literatura angielska

This is stored as thesaurus "notdefined"

00116nz a2200049n 4500 008 230210 n an|nnbabn a ana d 155 $a Literatura angielska

This is stored as thesaurus "notspecified"

you will get both as response, while only one of them is appropriate (the first one) [note 008/11].

Here is what the searches look like in Zebra 11:09:06-23/03 zebrasrv(1) [request] Search authorities OK 0 1 1+0 RPN @attrset Bib-1 @or @attr 1=Local-Number @attr 4=109 @attr 7=1 0 @and @and @attr 5=100 @attr 1=authtype GENRE/FORM @attr 6=3 @attr 5=100 @attr 4=1 @attr 1=Match-heading "Literatura angielska" @attr 5=100 @attr 4=1 @attr 1=Subject-heading-thesaurus DBN 11:09:06-23/03 zebrasrv(1) [request] Search authorities OK 1 1 1+0 RPN @attrset Bib-1 @or @attr 1=Local-Number @attr 4=109 @attr 7=1 0 @and @and @attr 5=100 @attr 1=authtype GENRE/FORM @attr 6=3 @attr 5=100 @attr 4=1 @attr 1=Match-heading "Literatura angielska" @attr 5=100 @attr 4=1 @attr 1=Subject-heading-thesaurus notdefined It should only return the second

Why not to index, in Zebra, directly 008/11 and 040 $f into the same index, without the 'index_subject_thesaurus' help-template which inserts 'undefined' for lacking 040 $f?

Note that in ES in this case you are adding subject-heading-thesaurus == 'z' to the query, not '|'.

In ES we are storing both the code and the 040f, so one with 040f will match on that - then when searching without the z will match

Also, it is not clear for me why do you hardcoded subject-heading-thesaurus in Koha/SearchEngine/Elasticsearch.pm, instead of putting it in mapping.yaml as:

The thesaurus search is used only internally for linking - this should not be customised or updated by the user. We do the same for 'Match-heading' to ensure consistent linking -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #28 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Phil Ringnalda from comment #27)

I just followed the test plan in a sandbox, first with Zebra and then with ElasticSearch, and in neither case was the Literatura angielska genre heading linked.

Did you reindex after applying the patches? While I tried to avoid it, it is required -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #30 from Phil Ringnalda <phil@chetcolibrary.org> --- On https://sandboxes.biblibre.eu/ if you want to poke at it, see where I might have gone wrong. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148418|0 |1 is obsolete| | --- Comment #32 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148734&action=edit Updated authority records for testing Replaces an 'n' in the 008 for '|' -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #34 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Janusz Kaczmarek from comment #31)

(In reply to Nick Clemens from comment #26) I understand your explanation about hardcoding Subject-heading-thesaurus but, to be sincere, I do not share this argument. Firstly, in Zebra also we have the definitions in the configuration file--if somebody changes there something he/she shouldn't, its his/her fault. And secondly, which is IMHO more important, shall we than, in the next step, hardcode also Heading-use-main-or-added-entry for 008/14, Heading-use-series-added-entry for 008/16, Heading-use-subject-added-entry for 008/15 when we will be wanting to narrow the search for linking even more specifically (which should definitely be done at some point)? So, I am still not convinced if it is the right idea...

I would suggest we hardcode the new fields if needed for linking. Linking is an internal process that shouldn't be adjusted by the user. Rather than allow them to break the system, let us save them :-) Zebra can technically be adjusted by the end user, however, ES allows direct updating via the interface. The intention of allowing the user access, IMHO, is to allow them to adjust searching for their needs. Adjusting internal processes isn't something we need to provide access to. The same MARC fields can be indexed into another field if the user needs them for searching. Authority searching doesn't use or provide these fields either, so allowing to be user adjusted only allows linking to break. Happy to continue that discussion, but I think we can address it wholesale on another bug. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #36 from Phil Ringnalda <phil@chetcolibrary.org> --- Finally got my hands on a working sandbox again, and with the updated test authorities and the current patches, while the Literatura angielska‡2DBN genre now links, the ind2=4 Literatura światowa one now does not link (with either '|' or going back to 'n' in 008/11). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #38 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Phil Ringnalda from comment #36)

Finally got my hands on a working sandbox again, and with the updated test authorities and the current patches, while the Literatura angielska‡2DBN genre now links, the ind2=4 Literatura światowa one now does not link (with either '|' or going back to 'n' in 008/11).

This one actually cannot be tested on a sandbox - it requires copying the updated zebra files for indexing -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #41 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Frank Hansen from comment #40)

(In reply to Katrin Fischer from comment #39)

...

Can someone help to get this tested?

I have now tested the patch on my testing docker. I get different results depending on whether I choose the ES or the Zebra engine. I am following the test plan in comment #17

ES works flawlessly. All headings are linked after the patch is applied.

But when doing the same using Zebra, without the patch installed only field 100 is linked. After applying the patch and restarted not all headings are linked. Only field 100, 655 (Literature English), 700 and 830 fields are linked after saving the record again.

Have I missed something.

The test plan is missing the steps for Zebra as the index files need to be copied and then a full reindex: sudo cp /kohadevbox/koha/etc/zebradb/marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl /etc/koha/zebradb/marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl restart_all sudo koha-rebuild-zebra -v -f kohadev -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Frank Hansen <frank.hansen@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #42 from Frank Hansen <frank.hansen@ub.lu.se> --- (In reply to Nick Clemens from comment #41)

(In reply to Frank Hansen from comment #40)

...

(In reply to Katrin Fischer from comment #39)

...

Can someone help to get this tested?

I have now tested the patch on my testing docker. I get different results depending on whether I choose the ES or the Zebra engine. I am following the test plan in comment #17

ES works flawlessly. All headings are linked after the patch is applied.

But when doing the same using Zebra, without the patch installed only field 100 is linked. After applying the patch and restarted not all headings are linked. Only field 100, 655 (Literature English), 700 and 830 fields are linked after saving the record again.

Have I missed something.

The test plan is missing the steps for Zebra as the index files need to be copied and then a full reindex: sudo cp /kohadevbox/koha/etc/zebradb/marc_defs/marc21/authorities/authority-zebra- indexdefs.xsl /etc/koha/zebradb/marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl restart_all sudo koha-rebuild-zebra -v -f kohadev

Yes! It works for me. I'm signing off. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Frank Hansen <frank.hansen@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148527|0 |1 is obsolete| | --- Comment #44 from Frank Hansen <frank.hansen@ub.lu.se> --- Created attachment 149837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149837&action=edit Bug 33277: Do not search using thesaurus when linking non 6XX fields This patch sets thesaurus as undefined when linking any field except 6XX This fixes the case where authrotiy records don't have the thesaurus defined Consequently - this means that Koha does not support multiple thesaurus records for authorities outside of subjects i.e. Using the default linker, and having both an LCSH and Sears record for 'Shakespeare,William' A 100 entry will find two results and the heading won't be linked. Previously we always linked to the LCSH To test: 1 - Import the attached auths and biblio (from bug 33159 comment 24) 2 - Set system preferences: RequireChoosingExistingAuthority - don't require AutoCreateAuthorities - don't generate CatalogModuleRelink - Do LinkerKeepStale - Don't LinkerModule - default LinkerRelink - do 3 - Edit the imported bib 4 - Save it 5 - Headings are not linked except 600 6 - Apply patch 7 - Restart all 8 - Edit and save record 9 - Headings are successfully linked Signed-off-by: Frank Hansen <frank.hansen@ub.lu.se> Current status: Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Frank Hansen <frank.hansen@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148529|0 |1 is obsolete| | --- Comment #46 from Frank Hansen <frank.hansen@ub.lu.se> --- Created attachment 149839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149839&action=edit Bug 33277: Add comments and missing thesauri Signed-off-by: Frank Hansen <frank.hansen@ub.lu.se> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Frank Hansen <frank.hansen@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148531|0 |1 is obsolete| | --- Comment #48 from Frank Hansen <frank.hansen@ub.lu.se> --- Created attachment 149841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149841&action=edit Bug 33277: (follow-up) Fix notdefined search for Zebra and ES Signed-off-by: Frank Hansen <frank.hansen@ub.lu.se> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |blocker CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #50 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I think this doesn't apply anymore. Bug 33277 - Correctly handle linking subfields with no defined thesaurus 148530 - Bug 33277: Search thesaurus for 'notspecified' 149837 - Bug 33277: Do not search using thesaurus when linking non 6XX fields 149838 - Bug 33277: Support custom thesaurus authority with no 040 specified 149839 - Bug 33277: Add comments and missing thesauri 149840 - Bug 33277: Search thesaurus for 'notspecified' 149841 - Bug 33277: (follow-up) Fix notdefined search for Zebra and ES 149842 - Bug 33277: Adjust source file for zebra mappings Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 33277: Search thesaurus for 'notspecified' error: sha1 information is lacking or useless (Koha/SearchEngine/Elasticsearch/QueryBuilder.pm). error: could not build fake ancestor Patch failed at 0001 Bug 33277: Search thesaurus for 'notspecified' hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-33277-Search-thesaurus-for-notspecified-1Gg31H.patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #52 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Janusz, do you think you could add your stamp to this (bug 33277) and bug 33557? If you do we can consider they Passed QA I think. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #54 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looking here now -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #55 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Tested this with Zebra. Copied cp etc/zebradb/marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl /etc/koha/zebradb/marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl Rebuilt index, restarted Zebra. Conform test plan, opened record and saved it again. Checked sysprefs. The links are not relinked to the correct authids. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #56 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> ---

! grep /$thesaurus/,('lcsh','lcac','mesh','nal','notspecified','cash','rvm','sears','aat') This regex might not always do what you want. Probably we could better do something like: none { $_ eq $thesaurus } etc

etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl <xslo:when> <xsl:attribute name="test"><xsl:value-of select="$alt_select"/></xsl:attribute> <xslo:value-of> <xsl:attribute name="select"><xsl:value-of select="$alt_select"/></xsl:attribute> </xslo:value-of> </xslo:when> <xslo:otherwise><xslo:text>notdefined</xslo:text></xslo:otherwise> This could be done much simpler. Funny construction here. Out of scope. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148957|0 |1 is obsolete| | --- Comment #57 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 150890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150890&action=edit Updated authority records for testing -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #58 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 150891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150891&action=edit Bug 33277: (follow-up) Don't use regex, tidy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #60 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Nick Clemens from comment #59)

(In reply to Marcel de Rooy from comment #55) None of them? Or some of them?

None.

Restart zebra (restart_all) then reindex Will try that again.

Make sure AutoLinkBiblios is set to 'Do' Yes, I verified all prefs with the test plan.

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #62 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Note: there was also a space in the bib side: <subfield code="a">Hamlet </subfield> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149837|0 |1 is obsolete| | --- Comment #63 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 150977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150977&action=edit Bug 33277: Do not search using thesaurus when linking non 6XX fields This patch sets thesaurus as undefined when linking any field except 6XX This fixes the case where authrotiy records don't have the thesaurus defined Consequently - this means that Koha does not support multiple thesaurus records for authorities outside of subjects i.e. Using the default linker, and having both an LCSH and Sears record for 'Shakespeare,William' A 100 entry will find two results and the heading won't be linked. Previously we always linked to the LCSH To test: 1 - Import the attached auths and biblio (from bug 33159 comment 24) 2 - Set system preferences: RequireChoosingExistingAuthority - don't require AutoCreateAuthorities - don't generate CatalogModuleRelink - Do LinkerKeepStale - Don't LinkerModule - default LinkerRelink - do 3 - Edit the imported bib 4 - Save it 5 - Headings are not linked except 600 6 - Apply patch 7 - Restart all 8 - Edit and save record 9 - Headings are successfully linked Signed-off-by: Frank Hansen <frank.hansen@ub.lu.se> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149839|0 |1 is obsolete| | --- Comment #65 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 150979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150979&action=edit Bug 33277: Add comments and missing thesauri Signed-off-by: Frank Hansen <frank.hansen@ub.lu.se> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149841|0 |1 is obsolete| | --- Comment #67 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 150981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150981&action=edit Bug 33277: (follow-up) Fix notdefined search for Zebra and ES Signed-off-by: Frank Hansen <frank.hansen@ub.lu.se> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150891|0 |1 is obsolete| | --- Comment #69 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 150983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150983&action=edit Bug 33277: (follow-up) Don't use regex, tidy Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33718 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_23_05_candidate | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Bug 33277 depends on bug 33159, which changed state. Bug 33159 Summary: Thesaurus is not defined by second indicator for controlled fields outside of 6XX https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33159 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.