[Bug 17509] New: Notify patrons to return items requested on hold by another person
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Bug ID: 17509 Summary: Notify patrons to return items requested on hold by another person Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: rbit@rbit.cz QA Contact: testopia@bugs.koha-community.org Create a new notification allowing to ask patrons to return a book which has just been put on hold by somebody else. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |rbit@rbit.cz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #1 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- Created attachment 57143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57143&action=edit Bug 17509: Added NotifyToReturnItemWhenHoldIsPlaced syspref This system preference will allow to ask patrons to return items whenever a new hold is placed on them Test plan: 1) Open System preferences / Circulation / Holds Policy 2) Change value from Enable to Don't enable and vice versa 3) Check NotifyToReturnItemWhenHoldIsPlaced is changed in database -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #2 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- Created attachment 57144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57144&action=edit Bug 17509: Added system preference to restrict recipients based on library Test plan: 1) apply patch 2) go to System preferences / Circulation / Holds Policy 3) change which patrons will be contacted 4) compare your change against database value NotifyToReturnItemFromLibrary -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #3 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- Created attachment 57145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57145&action=edit Bug 17509: Improved system preferences for item return notification Test plan: 1) apply patch 2) go to System preferences / Circulation / Holds Policy 3) change NotifyToReturn* variables as you wish 4) verify your changes in database -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #4 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- Created attachment 57146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57146&action=edit Bug 17509: renamed atomic file to suit conventions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #5 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- Created attachment 57147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57147&action=edit Bug 17509: Removed old name of atomic update file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #6 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- Created attachment 57148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57148&action=edit Bug 17509: Added notification letter HOLDPLACED_CONTACT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #7 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- Created attachment 57149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57149&action=edit Bug 17509: notify patrons to return an item whenever a hold is placed on it Test plan: 1) apply patch 2) run database update 3) enable sending an email to the patrons to return an item whenever a hold request is placed on it 4) place a hold 5) patrons having checked-out the item on hold are notified by email (see HOLDPLACED_CONTACT letter) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #8 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- Created attachment 57150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57150&action=edit Bug 17509: Fixed invalid patterns -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57143|0 |1 is obsolete| | --- Comment #9 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57157&action=edit [SIGNED-OFF] Bug 17509: Added NotifyToReturnItemWhenHoldIsPlaced syspref This system preference will allow to ask patrons to return items whenever a new hold is placed on them Test plan: 1) Open System preferences / Circulation / Holds Policy 2) Change value from Enable to Don't enable and vice versa 3) Check NotifyToReturnItemWhenHoldIsPlaced is changed in database Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57144|0 |1 is obsolete| | Attachment #57145|0 |1 is obsolete| | Attachment #57146|0 |1 is obsolete| | Attachment #57147|0 |1 is obsolete| | Attachment #57148|0 |1 is obsolete| | Attachment #57149|0 |1 is obsolete| | Attachment #57150|0 |1 is obsolete| | --- Comment #10 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57159&action=edit [SIGNED-OFF] Bug 17509: Added system preference to restrict recipients based on library Test plan: 1) apply patch 2) go to System preferences / Circulation / Holds Policy 3) change which patrons will be contacted 4) compare your change against database value NotifyToReturnItemFromLibrary Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #11 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57160&action=edit [SIGNED-OFF] Bug 17509: Improved system preferences for item return notification Test plan: 1) apply patch 2) go to System preferences / Circulation / Holds Policy 3) change NotifyToReturn* variables as you wish 4) verify your changes in database Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #12 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57161&action=edit [SIGNED-OFF] Bug 17509: renamed atomic file to suit conventions Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #13 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57162&action=edit [SIGNED-OFF] Bug 17509: Removed old name of atomic update file Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #14 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57163&action=edit [SIGNED-OFF] Bug 17509: Added notification letter HOLDPLACED_CONTACT Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #15 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57164&action=edit [SIGNED-OFF] Bug 17509: notify patrons to return an item whenever a hold is placed on it Test plan: 1) apply patch 2) run database update 3) enable sending an email to the patrons to return an item whenever a hold request is placed on it 4) place a hold 5) patrons having checked-out the item on hold are notified by email (see HOLDPLACED_CONTACT letter) Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #16 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57165&action=edit [SIGNED-OFF] Bug 17509: Fixed invalid patterns Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.05 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 2 quick comments: 1/ Maybe it would be better to have only 1 syspref, or at least squash them into the same syspref block (in the .pref file) 2/ It would be great to move GetBorrowersToSatisfyHold to the Koha namespace and return objects instead. I don't think they are blocker, but recommended. I am failing it because you do not provide tests for the changes you made in subroutines. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #18 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- Jonathan, could you please tell me more regarding your syspref suggestion? I thought it's been already squashed into one single section having 2 sysprefs. Have you meant to do it another way? This is current layout: http://prntscr.com/djd0f0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Radek Šiman (R-Bit Technology, s.r.o.) from comment #18)
Jonathan, could you please tell me more regarding your syspref suggestion? I thought it's been already squashed into one single section having 2 sysprefs. Have you meant to do it another way? This is current layout: http://prntscr.com/djd0f0
Indeed, I wrongly wrote the diff. You can forget this point. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 13846 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 pierre.genty02@univ-paris8.fr changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre.genty02@univ-paris8. | |fr --- Comment #21 from pierre.genty02@univ-paris8.fr --- Hi, We are really interested in this new feature. Is someone still working on it ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #22 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- Hi, yes, it's still in development, but I'm currently working on another important issue within payments, so this one has to wait a bit. We need this kind of notification too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #23 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- Created attachment 63258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63258&action=edit Bug 17509: Added tests prove t/db_dependent/Reserves/Notification.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57157|0 |1 is obsolete| | --- Comment #24 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63269&action=edit [SIGNED-OFF] Bug 17509: Added NotifyToReturnItemWhenHoldIsPlaced syspref This system preference will allow to ask patrons to return items whenever a new hold is placed on them Test plan: 1) Open System preferences / Circulation / Holds Policy 2) Change value from Enable to Don't enable and vice versa 3) Check NotifyToReturnItemWhenHoldIsPlaced is changed in database Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57159|0 |1 is obsolete| | --- Comment #25 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63270&action=edit [SIGNED-OFF] Bug 17509: Added system preference to restrict recipients based on library Test plan: 1) apply patch 2) go to System preferences / Circulation / Holds Policy 3) change which patrons will be contacted 4) compare your change against database value NotifyToReturnItemFromLibrary Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57160|0 |1 is obsolete| | --- Comment #26 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63271&action=edit [SIGNED-OFF] Bug 17509: Improved system preferences for item return notification Test plan: 1) apply patch 2) go to System preferences / Circulation / Holds Policy 3) change NotifyToReturn* variables as you wish 4) verify your changes in database Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57161|0 |1 is obsolete| | --- Comment #27 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63272&action=edit [SIGNED-OFF] Bug 17509: renamed atomic file to suit conventions Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57162|0 |1 is obsolete| | --- Comment #28 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63273&action=edit [SIGNED-OFF] Bug 17509: Removed old name of atomic update file Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57163|0 |1 is obsolete| | --- Comment #29 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63274&action=edit [SIGNED-OFF] Bug 17509: Added notification letter HOLDPLACED_CONTACT Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57164|0 |1 is obsolete| | --- Comment #30 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63275&action=edit [SIGNED-OFF] Bug 17509: notify patrons to return an item whenever a hold is placed on it Test plan: 1) apply patch 2) run database update 3) enable sending an email to the patrons to return an item whenever a hold request is placed on it 4) place a hold 5) patrons having checked-out the item on hold are notified by email (see HOLDPLACED_CONTACT letter) Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57165|0 |1 is obsolete| | --- Comment #31 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63276&action=edit [SIGNED-OFF] Bug 17509: Fixed invalid patterns Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #32 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63277&action=edit [SIGNED-OFF] Bug 17509: Added tests prove t/db_dependent/Reserves/Notification.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Test pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63258|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #33 from Josef Moravec <josef.moravec@gmail.com> --- I tested the last patch and rebased the whole patchset on master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #34 from David Cook <dcook@prosentient.com.au> --- In other systems, I think they refer to this as "recalling" an item. We might want to use similar terminology for the sake of users. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think a recall goes usually further than this, possibly shortening the due date and removing the option to renew etc. - I think this is just a friendly email so not quite a recall yet. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #36 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- This feature is meant exactly as Katrin said: it kindly asks the user to return the item ASAP only. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #37 from Liz Rea <liz@catalyst.net.nz> --- Let's start here with recalls, and build the other stuff in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #38 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- I'd like to see this patch to be published as is. The other stuff should be developed in a separately filed bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #39 from Liz Rea <liz@catalyst.net.nz> --- That's what I mean, let's get this in and build the rest of recalls off of it somewhere else. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #40 from Nick Clemens <nick@bywatersolutions.com> --- I like this one a lot, but a few issues: 1 - GetMember has been removed should use Koha::Patrons 2 - The sub should not go into C4:Reserves but should be a class method in Koha::Holds you can get patrons with something like (adding conditions per the pref) Koha::Patrons->search({'item.biblionumber'=>$hold->biblionumber,issue_id=>{'!=' => undef} },{ join => {'issues' => 'item'} }) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Sally Healey <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #41 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- Created attachment 67982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67982&action=edit Bug 17509: (followup) Logic moved from C4 to Koha namespace This patch simplifies logic by using Koha objects. Automated test has been moved from t/db_dependent/Reserves to t/db_dependent/Holds. Test plan: 1) apply patch 2) run database update 3) enable sending an email to the patrons to return an item whenever a hold request is placed on it (NotifyToReturnItemFromLibrary) 4) place a hold 5) patrons having checked-out the item on hold are notified by email (see HOLDPLACED_CONTACT letter) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz Status|Needs Signoff |Patch doesn't apply --- Comment #42 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Can you please rebase against master, a conflict is thrown when applying these patches on a clean, up to date branch. Specifically the patch causing the issue is '[SIGNED-OFF] Bug 17509: Added notification letter HOLDPLACED_CONTACT' and the file with the conflict is in installer/data/mysql/uk-UA/mandatory/sample_notices.sql Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 17509: Added NotifyToReturnItemWhenHoldIsPlaced syspref Applying: Bug 17509: Added system preference to restrict recipients based on library Applying: Bug 17509: Improved system preferences for item return notification Applying: Bug 17509: renamed atomic file to suit conventions Applying: Bug 17509: Removed old name of atomic update file Applying: Bug 17509: Added notification letter HOLDPLACED_CONTACT Using index info to reconstruct a base tree... M installer/data/mysql/uk-UA/mandatory/sample_notices.sql Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/uk-UA/mandatory/sample_notices.sql CONFLICT (content): Merge conflict in installer/data/mysql/uk-UA/mandatory/sample_notices.sql Failed to merge in the changes. Patch failed at 0001 Bug 17509: Added notification letter HOLDPLACED_CONTACT The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/SIGNED-OFF-Bug-17509-Added-notification-letter-HOL-iFsWW_.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19532 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Niamh <niamh.walker-headon@it-tallaght.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon@it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63269|0 |1 is obsolete| | Attachment #63270|0 |1 is obsolete| | Attachment #63271|0 |1 is obsolete| | Attachment #63272|0 |1 is obsolete| | Attachment #63273|0 |1 is obsolete| | Attachment #63274|0 |1 is obsolete| | Attachment #63275|0 |1 is obsolete| | Attachment #63276|0 |1 is obsolete| | Attachment #63277|0 |1 is obsolete| | Attachment #67982|0 |1 is obsolete| | --- Comment #43 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 80452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80452&action=edit Bug 17509: Added NotifyToReturnItemWhenHoldIsPlaced syspref This system preference will allow to ask patrons to return items whenever a new hold is placed on them Test plan: 1) Open System preferences / Circulation / Holds Policy 2) Change value from Enable to Don't enable and vice versa 3) Check NotifyToReturnItemWhenHoldIsPlaced is changed in database Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #44 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 80453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80453&action=edit Bug 17509: Added system preference to restrict recipients based on library Test plan: 1) apply patch 2) go to System preferences / Circulation / Holds Policy 3) change which patrons will be contacted 4) compare your change against database value NotifyToReturnItemFromLibrary Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #45 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 80454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80454&action=edit Bug 17509: Improved system preferences for item return notification Test plan: 1) apply patch 2) go to System preferences / Circulation / Holds Policy 3) change NotifyToReturn* variables as you wish 4) verify your changes in database Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #46 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 80455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80455&action=edit Bug 17509: renamed atomic file to suit conventions Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #47 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 80456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80456&action=edit Bug 17509: Removed old name of atomic update file Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #48 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 80457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80457&action=edit Bug 17509: Added notification letter HOLDPLACED_CONTACT Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #49 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 80458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80458&action=edit Bug 17509: notify patrons to return an item whenever a hold is placed on it Test plan: 1) apply patch 2) run database update 3) enable sending an email to the patrons to return an item whenever a hold request is placed on it 4) place a hold 5) patrons having checked-out the item on hold are notified by email (see HOLDPLACED_CONTACT letter) Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #50 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 80459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80459&action=edit Bug 17509: Fixed invalid patterns Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #51 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 80460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80460&action=edit Bug 17509: Added tests prove t/db_dependent/Reserves/Notification.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Test pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #52 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 80461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80461&action=edit Bug 17509: (follow-up) Logic moved from C4 to Koha namespace This patch simplifies logic by using Koha objects. Automated test has been moved from t/db_dependent/Reserves to t/db_dependent/Holds. Test plan: 1) apply patch 2) run database update 3) enable sending an email to the patrons to return an item whenever a hold request is placed on it (NotifyToReturnItemFromLibrary) 4) place a hold 5) patrons having checked-out the item on hold are notified by email (see HOLDPLACED_CONTACT letter) Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #53 from Josef Moravec <josef.moravec@gmail.com> --- Patchset rebased on master, still works as advertised. Setting back to signed off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #54 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Quick code review: 1. + my $library = Koha::Libraries->find($borrower->branchcode)->unblessed; can be replaced by $patron->library 2. "lang" param must be passed to GetPreparedLetter to make the notice translatable 3. Use "patron" instead of "borrower", especially for Koha:: 4. + to_address => $borrower->email, To not enqueue with to_address, it must depend on AutoEmailPrimaryAddress. It is correctly handled when sent. 5. We will need native English speaker for "NotifyToReturnItemFromLibrary" (name, description, options) 6. Code in borrowers_to_satisfy could be simplify (no blocker, I can have a look later) 7. New template notices must use the TT syntax (I would recommend to provide the notice for 'en' only and wait for the QA stamp to provide the changes to other files) 8. Changes to AddReserve is not covered by tests. Maybe it should be moved to Koha::Hold? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19014 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80452|0 |1 is obsolete| | Attachment #80453|0 |1 is obsolete| | Attachment #80454|0 |1 is obsolete| | Attachment #80455|0 |1 is obsolete| | Attachment #80456|0 |1 is obsolete| | Attachment #80457|0 |1 is obsolete| | Attachment #80458|0 |1 is obsolete| | Attachment #80459|0 |1 is obsolete| | Attachment #80460|0 |1 is obsolete| | Attachment #80461|0 |1 is obsolete| | --- Comment #55 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86365&action=edit Bug 17509: Added NotifyToReturnItemWhenHoldIsPlaced syspref This system preference will allow to ask patrons to return items whenever a new hold is placed on them Test plan: 1) Open System preferences / Circulation / Holds Policy 2) Change value from Enable to Don't enable and vice versa 3) Check NotifyToReturnItemWhenHoldIsPlaced is changed in database 4) change which patrons will be contacted 5) compare your change against database value NotifyToReturnItemFromLibrary Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #56 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86366&action=edit Bug 17509: Added notification letter HOLDPLACED_CONTACT Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #57 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86367&action=edit Bug 17509: notify patrons to return an item whenever a hold is placed on it Test plan: 1) apply patch 2) run database update 3) enable sending an email to the patrons to return an item whenever a hold request is placed on it 4) place a hold 5) patrons having checked-out the item on hold are notified by email (see HOLDPLACED_CONTACT letter) Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #58 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86368&action=edit Bug 17509: Added tests prove t/db_dependent/Reserves/Notification.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Test pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #59 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86369&action=edit Bug 17509: (follow-up) Logic moved from C4 to Koha namespace This patch simplifies logic by using Koha objects. Automated test has been moved from t/db_dependent/Reserves to t/db_dependent/Holds. Test plan: 1) apply patch 2) run database update 3) enable sending an email to the patrons to return an item whenever a hold request is placed on it (NotifyToReturnItemFromLibrary) 4) place a hold 5) patrons having checked-out the item on hold are notified by email (see HOLDPLACED_CONTACT letter) Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Chris Slone <cslone@camdencountylibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone@camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #60 from Josef Moravec <josef.moravec@gmail.com> --- Comment on attachment 86369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86369 Bug 17509: (follow-up) Logic moved from C4 to Koha namespace Review of attachment 86369: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17509&attachment=86369) ----------------------------------------------------------------- ::: C4/Reserves.pm @@ +268,2 @@
foreach my $borrower (@borrowers) { + if ( !$borrower->email ) {
should be ->first_valid_email_address @@ +292,3 @@
message_transport_type => 'email', from_address => $admin_email_address, + to_address => $borrower->email,
should be ->first_valid_email_address ::: Koha/Hold.pm @@ +330,5 @@
+Returns Koha::Patron objects able to return item to satisfy this Hold + +=cut + +sub borrowers_to_satisfy {
Should be called "patrons_..." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #61 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
+sub borrowers_to_satisfy {
Should be called "patrons_..."
Maybe the naming should be changed to include something about holds? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #62 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Katrin Fischer from comment #61)
+sub borrowers_to_satisfy {
Should be called "patrons_..."
Maybe the naming should be changed to include something about holds?
I agree -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Patrick Robitaille <patrick.robitaille@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@collecto | |.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|19014 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 [Bug 19014] Patrons should not get an 'on_reserve' notification if the due date is far into the future -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #63 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Is this still relevant/needed now that recalls has been pushed? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #64 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think it's a different feature and would still be nice to have. With recalls you _have_ to return the item, this is more a 'nicely asking'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #65 from Michal Denar <black23@gmail.com> --- Hi, Aleisha and Katrin, The feature of alerting the reader that there is a reservation for a borrowed book is great. However, in practice, we have run into one detail that readers perceive negatively. If an email arrives every time someone makes a hold on a title/unit, that can be a lot of repeated notifications in some cases. Would it perhaps only send one, the first time a hold is made? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #66 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Michal, you make a good point. Just noting that neither Aleisha nor I are developers of this patch and it could be an abandoned development. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #67 from Michal Denar <black23@gmail.com> --- I asked Radek to comment on this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #68 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- (In reply to Michal Denar from comment #67)
I asked Radek to comment on this patch.
Hi girls and boys, the libraries we support like this feature, but until it notifies the user during the loan only once, it's kind of unusable. Thinking about use cases maybe I've found a way to solve this issue. We could try to find the last HOLDPLACED_CONTACT message's time_queued in the message_queue table between issuedate and recently created hold's reservedate. If there is a message, we shouldn't send another one. In the case of no results, new HOLDPLACED_CONTACT message will be queued. Is is good or bad idea? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #69 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Radek Šiman (R-Bit Technology, s.r.o.) from comment #68)
(In reply to Michal Denar from comment #67)
I asked Radek to comment on this patch.
Hi girls and boys, the libraries we support like this feature, but until it notifies the user during the loan only once, it's kind of unusable.
Thinking about use cases maybe I've found a way to solve this issue. We could try to find the last HOLDPLACED_CONTACT message's time_queued in the message_queue table between issuedate and recently created hold's reservedate. If there is a message, we shouldn't send another one. In the case of no results, new HOLDPLACED_CONTACT message will be queued.
Is is good or bad idea?
Sorry for not replying earlier to this. We just had another library asking about this feature. I think you are right that we don't want to email for every hold placed. If it's a high demand item, that could cause quite a bit of trouble. Maybe a different idea: What if we create a flag in the issues table that is set to the date the last HOLDPLACED_CONTACT was sent. This way we could also enhance the feature in the future to say another reminder is ok after X days or similar. And we don't have to rely on the message_queue, that might get cleaned or be otherwise unreliable. Another question would be to whom we send the email if there are multiple checked out copies. I'd say if it's an item level hold, we should only email the issuer of this item (thinking of items for serial issues etc) and if it's a record level hold we email all patrons that have items checked out? An alternative could be to email up to x users that had the item for the longest time at this point. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Koha collecto <koha@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@collecto.ca -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org