[Bug 42131] New: Terminology: Return in action logs should be Checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42131 Bug ID: 42131 Summary: Terminology: Return in action logs should be Checkin Initiative type: --- Sponsorship --- status: Product: Koha Version: 24.11 Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org This was found while translating: Return koha-tmpl/intranet-tmpl/prog/en/includes/action-logs.inc:67 Should be updated to be Check-in. The problem that arises here is that return meaning "return to previous page" as a verb and "Return" as a substantive require different translation, at least in German. The string also appears on course reserves: koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/batch_rm_items.tt:83 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42131 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|24.11 |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42131 --- Comment #1 from Lewis Clay <lewiswork98@gmail.com> --- Created attachment 198214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198214&action=edit Bug 42131: Terminology: Return in action logs should be Checkin The problem that arises here is that return meaning 'return to previous page' as a verb and 'Return' as a substantive require different translation, at least in German. Updated the display text 'Return' to 'Check-in' in: - action-logs.inc: The action log display for the RETURN case This resolves problems in the translation Test plan: 1. Navigate to a page displaying Action logs 2. Look for entries with the RETURN action 3. Confirm the display text now shows 'Check-in' instead of 'Return' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42131 Lewis Clay <lewiswork98@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lewiswork98@gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42131 Lewis Clay <lewiswork98@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42131 --- Comment #2 from Lewis Clay <lewiswork98@gmail.com> --- Just to be clear the original comment makes mention of "The string also appears on course reserves: koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/batch_rm_items.tt:83" however doesn't specify weather this also needs changing and with the title stating "Return in action logs should be Checkin" I decided not to make the additional change. If I was wrong in this decision please inform me and I will amend asap. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42131 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42131 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 198220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198220&action=edit Bug 42131: Terminology: Return in action logs should be Check-in The problem that arises here is that return meaning 'return to previous page' as a verb and 'Return' as a substantive require different translation, at least in German. Updated the display text 'Return' to 'Check-in' in: - action-logs.inc: The action log display for the RETURN case This resolves problems in the translation Test plan: 1. Navigate to a page displaying Action logs 2. Look for entries with the RETURN action 3. Confirm the display text now shows 'Check-in' instead of 'Return' Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42131 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Summary|Terminology: Return in |Terminology: Return in |action logs should be |action logs should be |Checkin |Check-in -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42131 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198214|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42131 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This changes the text for release notes| |the "Return" action in the | |log viewer (when checking | |in an item) to "Check-in", | |to help improve | |translation. --- Comment #4 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. To reproduce the issue: - Check out an item to a patron, then check it back in - Go to the log viewer (Tools > Additional tools > Log viewer) - Click Submit - Note that the log entry for checking in the item is shown as "Return" in the action column 2. Apply the patch. 3. Refresh the log viewer page. 4. The log entry should now show as "Check-in". (Check-in is the noun version and matches with the Check out action, see the terminology list https://wiki.koha-community.org/wiki/Terminology#C) Additional notes - "Return" for course reserves: 1. Go to course reserves (Course reserves). 2. Click the "- Batch remove reserves" button above the courses page title. 3. Enter an invalid barcode: for example, 1234 4. You are then prompted "Are you sure you want to remove these items from all courses?" 5. Click "OK". 6. You get a results page which has the "Return" button, which returns you to the list of course reserves page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42131 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lewiswork98@gmail.com Severity|enhancement |minor --- Comment #5 from David Nind <david@davidnind.com> --- I also: - changed the assignee - change the importance from "Enhancement" to "Minor" (to me it is a big, rather than an improvement) - updated the bug commit message title to "...Check-in" - updated the bug title as well -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42131 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com QA Contact|testopia@bugs.koha-communit |baptiste.wojtkowski@biblibr |y.org |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42131 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198220|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42131 --- Comment #6 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 198292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198292&action=edit Bug 42131: Terminology: Return in action logs should be Check-in The problem that arises here is that return meaning 'return to previous page' as a verb and 'Return' as a substantive require different translation, at least in German. Updated the display text 'Return' to 'Check-in' in: - action-logs.inc: The action log display for the RETURN case This resolves problems in the translation Test plan: 1. Navigate to a page displaying Action logs 2. Look for entries with the RETURN action 3. Confirm the display text now shows 'Check-in' instead of 'Return' Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42131 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42131 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42131 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42131 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42131 --- Comment #8 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42131 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org