[Bug 37054] New: Allow for custom branch colors in the staff interface header search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Bug ID: 37054 Summary: Allow for custom branch colors in the staff interface header search Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The staff interface includes a green bar at the top of almost every page, #header_search.toptab I have been writing custom JavaScript to color this bar differently per branch. It would be much nice if you could just do this in Koha without JS. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 167577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167577&action=edit Bug 37054: DBUpdate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 167578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167578&action=edit Bug 37054: DO NOT PUSH - Schema updates -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 167579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167579&action=edit Bug 37054: Add branch color to branches.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 167590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167590&action=edit Bug 37054: Adjust header colors if branches.branchcolor is used To test: 1. Apply patch, update database, restart services, yarn build 2. Go to Administration > Libraries 3. Edit or create a new branch. 4. You should now see a 'Branch color' option. 5. Set that to anything you want. 6. Log in as that branch. 7. Your header color should now relect that choice. 8. Log in to another branch without a set branch color. 9. The header should remain the default green. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167577|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 167595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167595&action=edit Bug 37054: DBUpdate Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167578|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 167596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167596&action=edit Bug 37054: DO NOT PUSH - Schema updates Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167579|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 167597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167597&action=edit Bug 37054: Add branch color to branches.tt Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167590|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 167598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167598&action=edit Bug 37054: Adjust header colors if branches.branchcolor is used To test: 1. Apply patch, update database, restart services, yarn build 2. Go to Administration > Libraries 3. Edit or create a new branch. 4. You should now see a 'Branch color' option. 5. Set that to anything you want. 6. Log in as that branch. 7. Your header color should now relect that choice. 8. Log in to another branch without a set branch color. 9. The header should remain the default green. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 167609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167609&action=edit Bug 37054: (follow-up) Simplify changes, add a way to clear the color field This patch cuts some of the CSS changes which I think were unnecessary and adds a way for the user to clear the color field. A text input now shows the selected hex colur value and the "Clear" button clears it. I've changed the way the patch handles the custom colors by making the color handling dependent on there being a branchcolor value. This way we don't have to alter the existing header CSS, just override it if a custom color has been chosen. To test, apply the patch and test that the color picker still works correctly and that the "Clear" button works to empty the field. Test the appearance of the search bar in a branch with a custom color and in a branch without. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167595|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 167612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167612&action=edit Bug 37054: DBUpdate Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167596|0 |1 is obsolete| | --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 167613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167613&action=edit Bug 37054: DO NOT PUSH - Schema updates Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167597|0 |1 is obsolete| | --- Comment #12 from David Nind <david@davidnind.com> --- Created attachment 167614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167614&action=edit Bug 37054: Add branch color to branches.tt Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167598|0 |1 is obsolete| | --- Comment #13 from David Nind <david@davidnind.com> --- Created attachment 167615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167615&action=edit Bug 37054: Adjust header colors if branches.branchcolor is used To test: 1. Apply patch, update database, restart services, yarn build 2. Go to Administration > Libraries 3. Edit or create a new branch. 4. You should now see a 'Branch color' option. 5. Set that to anything you want. 6. Log in as that branch. 7. Your header color should now relect that choice. 8. Log in to another branch without a set branch color. 9. The header should remain the default green. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167609|0 |1 is obsolete| | --- Comment #14 from David Nind <david@davidnind.com> --- Created attachment 167616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167616&action=edit Bug 37054: (follow-up) Simplify changes, add a way to clear the color field This patch cuts some of the CSS changes which I think were unnecessary and adds a way for the user to clear the color field. A text input now shows the selected hex colur value and the "Clear" button clears it. I've changed the way the patch handles the custom colors by making the color handling dependent on there being a branchcolor value. This way we don't have to alter the existing header CSS, just override it if a custom color has been chosen. To test, apply the patch and test that the color picker still works correctly and that the "Clear" button works to empty the field. Test the appearance of the search bar in a branch with a custom color and in a branch without. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- Thank you Owen! I am going to propose 2 changes: 1. I don't like that the background color of the links still changes to green when a custom color is set. In my opinion we don't need to set the background color on hover. I think that rule can be removed for the header.scss file. 2. Can we turn the filter brightness down just a bit on the '#header_search button[type="submit"]' btn? And then turn it up a bit when hovering on that element? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 167618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167618&action=edit Bug 37054: (follow-up) Remove some unneeded SCSS and ajust button brightness -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37067 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37067 [Bug 37067] Add a color contrast checker -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167618|0 |1 is obsolete| | --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 167625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167625&action=edit Bug 37054: (follow-up) Remove some unneeded SCSS and ajust button brightness Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This looks great! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow for custom branch |Allow for custom library |colors in the staff |colors in the staff |interface header search |interface header search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please rebase! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167612|0 |1 is obsolete| | --- Comment #20 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 171221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171221&action=edit Bug 37054: DBUpdate Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167613|0 |1 is obsolete| | --- Comment #21 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 171222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171222&action=edit Bug 37054: DO NOT PUSH - Schema updates Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167614|0 |1 is obsolete| | --- Comment #22 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 171223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171223&action=edit Bug 37054: Add branch color to branches.tt Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167615|0 |1 is obsolete| | --- Comment #23 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 171224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171224&action=edit Bug 37054: Adjust header colors if branches.branchcolor is used To test: 1. Apply patch, update database, restart services, yarn build 2. Go to Administration > Libraries 3. Edit or create a new branch. 4. You should now see a 'Branch color' option. 5. Set that to anything you want. 6. Log in as that branch. 7. Your header color should now relect that choice. 8. Log in to another branch without a set branch color. 9. The header should remain the default green. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167616|0 |1 is obsolete| | --- Comment #24 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 171225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171225&action=edit Bug 37054: (follow-up) Simplify changes, add a way to clear the color field This patch cuts some of the CSS changes which I think were unnecessary and adds a way for the user to clear the color field. A text input now shows the selected hex colur value and the "Clear" button clears it. I've changed the way the patch handles the custom colors by making the color handling dependent on there being a branchcolor value. This way we don't have to alter the existing header CSS, just override it if a custom color has been chosen. To test, apply the patch and test that the color picker still works correctly and that the "Clear" button works to empty the field. Test the appearance of the search bar in a branch with a custom color and in a branch without. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167625|0 |1 is obsolete| | --- Comment #25 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 171226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171226&action=edit Bug 37054: (follow-up) Remove some unneeded SCSS and ajust button brightness Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #26 from Lucas Gass <lucas@bywatersolutions.com> --- rebased for current main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171221|0 |1 is obsolete| | --- Comment #27 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 175991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175991&action=edit Bug 37054: DBUpdate Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171222|0 |1 is obsolete| | --- Comment #28 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 175992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175992&action=edit Bug 37054: DO NOT PUSH - Schema updates Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171223|0 |1 is obsolete| | --- Comment #29 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 175993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175993&action=edit Bug 37054: Add branch color to branches.tt Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171224|0 |1 is obsolete| | --- Comment #30 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 175994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175994&action=edit Bug 37054: Adjust header colors if branches.branchcolor is used To test: 1. Apply patch, update database, restart services, yarn build 2. Go to Administration > Libraries 3. Edit or create a new branch. 4. You should now see a 'Branch color' option. 5. Set that to anything you want. 6. Log in as that branch. 7. Your header color should now relect that choice. 8. Log in to another branch without a set branch color. 9. The header should remain the default green. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171225|0 |1 is obsolete| | --- Comment #31 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 175995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175995&action=edit Bug 37054: (follow-up) Simplify changes, add a way to clear the color field This patch cuts some of the CSS changes which I think were unnecessary and adds a way for the user to clear the color field. A text input now shows the selected hex colur value and the "Clear" button clears it. I've changed the way the patch handles the custom colors by making the color handling dependent on there being a branchcolor value. This way we don't have to alter the existing header CSS, just override it if a custom color has been chosen. To test, apply the patch and test that the color picker still works correctly and that the "Clear" button works to empty the field. Test the appearance of the search bar in a branch with a custom color and in a branch without. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171226|0 |1 is obsolete| | --- Comment #32 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 175996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175996&action=edit Bug 37054: (follow-up) Remove some unneeded SCSS and ajust button brightness Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com QA Contact|testopia@bugs.koha-communit |Laura.escamilla@bywatersolu |y.org |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #33 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Thank you for working on this, Lucas! I'm so excited to see this in Koha. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Laura Escamilla from comment #33)
Thank you for working on this, Lucas! I'm so excited to see this in Koha.
Hi Laura, thanks for QA! As we are just at the beginning of the cycle I'll be more strict about the guidelines for QA/SO being from people of different institutions. Sorry that this "hit you" first now :( I'd also like to get some notes on implementation. We now have opacusercss in the branches table. This is for adjusting the color in one specific spot, which could also have been achieved with a staffusercss. Is there a strong reason it was done this way? (I assume so, but always good to have it written down!) Some notes from looking at the code: 1) This uses "branch" a lot, but library should be used. https://wiki.koha-community.org/wiki/Terminology 2) I believe we are missing changes for the REST API since there are routes for library information. If this was named library_color in the db as well, we could save a mapping. 3) I think the method name should be snake case per PERL9: Subroutine naming conventions. https://wiki.koha-community.org/wiki/Coding_Guidelines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #35 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> ---
I'd also like to get some notes on implementation. We now have opacusercss in the branches table. This is for adjusting the color in one specific spot, which could also have been achieved with a staffusercss. Is there a strong reason it was done this way? (I assume so, but always good to have it written down!)
I wrote this patch to replace custom JS we have been using to show a different color header for each branch the user is logged in at. I suppose it could be done with something like `staffusercss`. But I don't see the reason for the pref, why not just use IntranetUserCSS if this is how we are going to do it? Maybe pass in a data-attribute for the logged in branch, that can be targeted with CSS. Then staff would still need to be able to write CSS, which was something I was hoping to avoid with this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lucas Gass (lukeg) from comment #35)
I'd also like to get some notes on implementation. We now have opacusercss in the branches table. This is for adjusting the color in one specific spot, which could also have been achieved with a staffusercss. Is there a strong reason it was done this way? (I assume so, but always good to have it written down!)
I wrote this patch to replace custom JS we have been using to show a different color header for each branch the user is logged in at. I suppose it could be done with something like `staffusercss`. But I don't see the reason for the pref, why not just use IntranetUserCSS if this is how we are going to do it? Maybe pass in a data-attribute for the logged in branch, that can be targeted with CSS.
Then staff would still need to be able to write CSS, which was something I was hoping to avoid with this patch.
Just to clarify: I didn't mean a pref, but something similar to the library specific CSS available now on the library administration page. I do see benefit in an easy to use color picker. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #37 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 176014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176014&action=edit Bug 37054: (follow-up) Rename branchcolor to library_color and use snake casing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #38 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 176015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176015&action=edit Bug 37054: DO NOT PUSH - More schema updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #39 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 176016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176016&action=edit Bug 37054: Add API support -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #40 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176615&action=edit Bug 37054: atomic update - display message only if column added -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #41 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176616&action=edit Bug 37054: Replace the TT plugin method with a more generic one Let's return the whole Koha::Library object so that it can be reusable for another attribute. Keeping the CamelCase to be consistent with the rest of the other methods in this file. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@gmail.com --- Comment #42 from Jonathan Druart <jonathan.druart@gmail.com> --- 1. API spec: "description: the library color" The... building? :D 2. Please provide tests 3. Color picker's default is "black". It looks like it will be black, not "default"/green. 4. IMO this should be CSS or a plugin, it's overkill to have this in Koha core. Personal opinion, not blocker. Also added 2 patches. FQA for 2, discussion for 4. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #43 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> ---
4. IMO this should be CSS or a plugin, it's overkill to have this in Koha core. Personal opinion, not blocker.
I've considered this as a plugin, and it would be fine IMO to go that route. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #44 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Lucas Gass (lukeg) from comment #43)
4. IMO this should be CSS or a plugin, it's overkill to have this in Koha core. Personal opinion, not blocker.
I've considered this as a plugin, and it would be fine IMO to go that route.
After thinking here, I am going to argue that this should still be in core. Currently, I have to use JS to do this. I don't like that. Could we make it where it would be easier to do this with custom CSS? Yes. It still requires CSS knowledge and I would really like to have something that is easy to setup without CSS knowledge. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #45 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #42)
1. API spec: "description: the library color" The... building? :D
What would be best here? header_bg_color? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #46 from David Cook <dcook@prosentient.com.au> --- It's an interesting idea... although I don't like the idea of adding more <style> elements, as they add more work when we implement Content-Security-Policy. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #47 from David Cook <dcook@prosentient.com.au> --- (In reply to Lucas Gass (lukeg) from comment #44)
After thinking here, I am going to argue that this should still be in core. Currently, I have to use JS to do this. I don't like that. Could we make it where it would be easier to do this with custom CSS? Yes. It still requires CSS knowledge and I would really like to have something that is easy to setup without CSS knowledge.
I was wondering why you wouldn't just use CSS and I thought that UX might be the reason. And if you start to pull that thread... I think that you actually have a really good point. Further, how cool would it be to have a colour palette that could be configured by a web administrator? In theory, using CSS variables would make it not too hard to define and re-define a palette. Honestly, "branchcolor/library_color" as a database column feels wrong to me, but... on the right track. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38550 --- Comment #48 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #47)
Further, how cool would it be to have a colour palette that could be configured by a web administrator?
That said, all the ideas here could conflict with bug 38550 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #49 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- staff_header_color maybe? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Pablo AB <pablo.bianchi@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pablo.bianchi@gmail.com --- Comment #50 from Pablo AB <pablo.bianchi@gmail.com> --- This bug could be named "Allow to pick an accent_color"? Right now I do this by changing on a set of CSS/JSON/SVG #408540 #006100 #418940 #418A40 #589D43 to a dark color (the difference on very similar colors seems another bug), and #6faf44 #71b443 #7cbb51 #dcefd0 to a light color, using HSL model. By default the color is around hsl(120, 40%, 40%). I would love to see a syspref to change that hue from 120 to any 0-255 value. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #51 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Pablo AB from comment #50)
This bug could be named "Allow to pick an accent_color"?
Right now I do this by changing on a set of CSS/JSON/SVG #408540 #006100 #418940 #418A40 #589D43 to a dark color (the difference on very similar colors seems another bug), and #6faf44 #71b443 #7cbb51 #dcefd0 to a light color, using HSL model.
By default the color is around hsl(120, 40%, 40%). I would love to see a syspref to change that hue from 120 to any 0-255 value.
Sounds good but out of scope for this, please file a new bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #52 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to David Cook from comment #48)
(In reply to David Cook from comment #47)
Further, how cool would it be to have a colour palette that could be configured by a web administrator?
That said, all the ideas here could conflict with bug 38550
I should state what the original purpose of this bug was. We have many consortium that want each individual branch to have a different color header, replacing the original green. This is a way for librarians and administrators to quickly differentiate which branch they are logged into. I was doing this with custom JS and I don't want to continue to use JS. I am also not keen on a CSS solution, not everyone wants to write CSS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #53 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> ---
Honestly, "branchcolor/library_color" as a database column feels wrong to me, but... on the right track.
Do you mean the name is wrong? Or the fact that it is a DB column? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #54 from David Cook <dcook@prosentient.com.au> --- (In reply to Lucas Gass (lukeg) from comment #52)
(In reply to David Cook from comment #48)
(In reply to David Cook from comment #47)
Further, how cool would it be to have a colour palette that could be configured by a web administrator?
That said, all the ideas here could conflict with bug 38550
I should state what the original purpose of this bug was. We have many consortium that want each individual branch to have a different color header, replacing the original green. This is a way for librarians and administrators to quickly differentiate which branch they are logged into.
I was doing this with custom JS and I don't want to continue to use JS. I am also not keen on a CSS solution, not everyone wants to write CSS.
(In reply to Lucas Gass (lukeg) from comment #53)
Honestly, "branchcolor/library_color" as a database column feels wrong to me, but... on the right track.
Do you mean the name is wrong? Or the fact that it is a DB column?
Yeah nah, I like your idea. It sounds useful and that it would make for a nice UX. But from a big picture perspective I think it's probably the beginning of something bigger. So yeah the name doesn't feel right, and also I'm not sure about it as a DB column in the "branches" table. It seems to me that there's a lot of room for this to grow, so that in the future "library_color" would need to be renamed (like Katrin's suggestion of staff_header_color). And then if we added things like "staff_font_color" or "staff_bg_color", I think the columns could grow a lot, and they're not really describing the "branch" entity/resource, right? So then I'm thinking of a DB table like "ui_staff" where these "staff_header_color" and "staff_bg_color" are either text columns OR they're object keys in a JSON column. -- But... I think you could argue that a new DB table might be premature since right now you're only proposing 1 new column. Fair enough. But yeah I think a rename to staff_header_color might be a good idea - unless you do see "library_color" being re-used for other sections as well, but... I suspect most libraries/orgs will have a palette of at least 3-5 different colours for a variety of different UI components. So making the DB column name more specific probably makes sense. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31327 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #55 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to David Cook from comment #54)
So then I'm thinking of a DB table like "ui_staff" where these "staff_header_color" and "staff_bg_color" are either text columns OR they're object keys in a JSON column.
--
But... I think you could argue that a new DB table might be premature since right now you're only proposing 1 new column. Fair enough.
I think this is the solution. We need a library.library_css that would be a JSON version of CSS rules specific to the library. We allow edition via a "css" form that could be on the edit library view, with some attributes and color picker. It will build a solid ground for future changes. Example: https://snipboard.io/WVSrnt.jpg It does not seem to be a lot of work, but allow for way more flexibility than introducing the "1 DB column per css rule/color" pattern. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #56 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> ---
We need a library.library_css that would be a JSON version of CSS rules specific to the library. We allow edition via a "css" form that could be on the edit library view, with some attributes and color picker.
It will build a solid ground for future changes.
Example: https://snipboard.io/WVSrnt.jpg
It does not seem to be a lot of work, but allow for way more flexibility than introducing the "1 DB column per css rule/color" pattern.
I agree with this, I see this as the first of many that would allow staff to customize the look of the staff client on a per branch basis. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #57 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #55)
We need a library.library_css that would be a JSON version of CSS rules specific to the library. We allow edition via a "css" form that could be on the edit library view, with some attributes and color picker.
+1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #58 from David Cook <dcook@prosentient.com.au> --- I know I keep saying this, but if we have these override CSS variables it would be very clean. (I suppose we could look too at the timing. Do we want these settings to be able to override OpacUserCSS or should OpacUserCSS override these?) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|Laura.escamilla@bywatersolu |testopia@bugs.koha-communit |tions.com |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 David Liddle <david.liddle@wycliff.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.liddle@wycliff.de --- Comment #59 from David Liddle <david.liddle@wycliff.de> --- (In reply to Jonathan Druart from comment #55)
(In reply to David Cook from comment #54)
So then I'm thinking of a DB table like "ui_staff" where these "staff_header_color" and "staff_bg_color" are either text columns OR they're object keys in a JSON column.
--
But... I think you could argue that a new DB table might be premature since right now you're only proposing 1 new column. Fair enough.
I think this is the solution.
We need a library.library_css that would be a JSON version of CSS rules specific to the library. We allow edition via a "css" form that could be on the edit library view, with some attributes and color picker.
It will build a solid ground for future changes.
Example: https://snipboard.io/WVSrnt.jpg
It does not seem to be a lot of work, but allow for way more flexibility than introducing the "1 DB column per css rule/color" pattern.
Hi there, all... I just want to bring something to your attention. The term "CSS" is being used here when only the color scheme is under discussion. Color scheming is but ONE function of CSS. If you create a table to manage ONLY the color scheme -- be it 'by way of' CSS or some other mechanism -- then I suggest that "css" not be part of the table name. That would be misleading. If, however, the proposed table would be used for all manner of stylings to be applied by CSS -- and ONLY by CSS -- then the suggested name would be appropriate. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #60 from David Liddle <david.liddle@wycliff.de> --- (In reply to David Cook from comment #58)
I know I keep saying this, but if we have these override CSS variables it would be very clean.
(I suppose we could look too at the timing. Do we want these settings to be able to override OpacUserCSS or should OpacUserCSS override these?)
Hi there... as I read your questions, it occurred to me as a system administrator that: 1. If you have UI color scheme settings override OpacUserCSS, then it might need to be an all-or-nothing, one-or-the-other approach. Allowing one to override some aspects of the other, but not all, could create headaches for people. 2. I'm only guessing here, but people who choose to modify the styling with the UI may be less likely to know that OpacUserCSS exists. If the latter overrides the former, then they're going to be left wondering why their settings didn't take effect. 3. A notice (or alert) in each location would aid staff and/or users with the above conditions. For example, if OpacUserCSS overrides UI, then a notice in the UI settings might state, "Your choice(s) here will not be applied because OpacUserCSS is populated." Or the choices may be grayed out and unavailable. If UI overrides OpacUserCSS, then the converse could be true. At OpacUserCSS, one might read, "This setting is unavailable because a color scheme other than the default has been selected." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m Keywords| |Hackfest -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow for custom library |Allow for custom library |colors in the staff |colors in the staff |interface header search |interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna@gmail.com --- Comment #61 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- *** Bug 25295 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39495 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39495 [Bug 39495] [OMNIBUS] Staff Interface Theming -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175992|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175993|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175995|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175994|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175996|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176014|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176016|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176015|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176615|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176616|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175991|0 |1 is obsolete| | --- Comment #62 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 180329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180329&action=edit Bug 37054: DBUpdate Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #63 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 180330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180330&action=edit Bug 37054: Amend DBUpdate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #64 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 180331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180331&action=edit Bug 37054: Add ability to adjust colors per branch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #65 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 180332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180332&action=edit Bug 37054: Schema updates DO NOT PUSH -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #66 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 180333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180333&action=edit Bug 37054: API support -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #67 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 180334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180334&action=edit Bug 37054: Convert primary green color variables from SCSS tp CSS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Laura O'Neil <laura@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laura@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Michael Adamyk <michael.adamyk@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michael.adamyk@bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180329|0 |1 is obsolete| | --- Comment #68 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 184825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184825&action=edit Bug 37054: DBUpdate Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180330|0 |1 is obsolete| | --- Comment #69 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 184826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184826&action=edit Bug 37054: Amend DBUpdate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180331|0 |1 is obsolete| | --- Comment #70 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 184827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184827&action=edit Bug 37054: Add ability to adjust colors per branch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180332|0 |1 is obsolete| | --- Comment #71 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 184828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184828&action=edit Bug 37054: Schema updates DO NOT PUSH -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180333|0 |1 is obsolete| | --- Comment #72 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 184829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184829&action=edit Bug 37054: API support -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180334|0 |1 is obsolete| | --- Comment #73 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 184830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184830&action=edit Bug 37054: Convert primary green color variables from SCSS tp CSS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #74 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 184831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184831&action=edit Bug 37054: Rename column as ui_staff_customization -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Hackfest | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #75 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 184838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184838&action=edit Bug 37054: Store and retrieve values in JSON -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #76 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 184903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184903&action=edit Bug 37054: USe try/catch when getting CSS rules or default to Koha green -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #77 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- I feel the need to express this — open to discussion and happy to be corrected. I’d like us to stop adding columns to core entities like `branches` for presentation or rules-related settings. * Mixing business data (branches) with presentation/styling data (like CSS) breaks the MVC principle. * Styling concerns belong in the front end (or a dedicated configuration layer), not in the core database model. It’s perfectly fine for styling data to live in the database — but why not use a dedicated table? ```sql CREATE TABLE library_ui_tweaks ( branchcode VARCHAR(10) PRIMARY KEY, tweaks JSON, updated_at TIMESTAMP DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP, FOREIGN KEY (branchcode) REFERENCES branches(branchcode) ); ``` Even in the API, putting style info directly on the branch object feels out of place. It should be returned as an embedded resource or sub-object, not part of the core representation. And you know what’s coming next: someone will want a global default that can be overridden at the library level. Boom — another syspref gets added. We’ve seen this pattern repeatedly: a quick fix becomes permanent and clutters our model. Y’all know I’ll eventually rant about the `configurations` table again, but seriously — this is exactly the kind of case where we should stop being pragmatic and start doing things the right way. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #78 from Lisette Scheer <lisette@bywatersolutions.com> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #77)
I feel the need to express this — open to discussion and happy to be corrected.
I’d like us to stop adding columns to core entities like `branches` for presentation or rules-related settings.
* Mixing business data (branches) with presentation/styling data (like CSS) breaks the MVC principle. * Styling concerns belong in the front end (or a dedicated configuration layer), not in the core database model.
It’s perfectly fine for styling data to live in the database — but why not use a dedicated table?
```sql CREATE TABLE library_ui_tweaks ( branchcode VARCHAR(10) PRIMARY KEY, tweaks JSON, updated_at TIMESTAMP DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP, FOREIGN KEY (branchcode) REFERENCES branches(branchcode) ); ```
Even in the API, putting style info directly on the branch object feels out of place. It should be returned as an embedded resource or sub-object, not part of the core representation.
And you know what’s coming next: someone will want a global default that can be overridden at the library level. Boom — another syspref gets added. We’ve seen this pattern repeatedly: a quick fix becomes permanent and clutters our model.
Y’all know I’ll eventually rant about the `configurations` table again, but seriously — this is exactly the kind of case where we should stop being pragmatic and start doing things the right way.
Bug 26129 is the configuration discussion in case someone hasn't seen it. I wonder some about if additional contents might be a better place than branches for this as it could be set per branch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #79 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Lisette Scheer from comment #78)
Bug 26129 is the configuration discussion in case someone hasn't seen it.
Thanks.
I wonder some about if additional contents might be a better place than branches for this as it could be set per branch?
I think the additional contents table has the right structure, and could be extended with a new 'category'. I'm not sure I like having the configuration page in the additional contents section 'just because they share the table', though. That was my idea for the `configurations` table: a well structured storage for settings that need to be defined at branch, category and itemtype level. And then we use then wherever we want, using the provided accessors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #80 from David Cook <dcook@prosentient.com.au> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #77)
I’d like us to stop adding columns to core entities like `branches` for presentation or rules-related settings.
Agreed. As I said on Comment 54 the `branches` table should just have attributes of the branch/library resource.
* Mixing business data (branches) with presentation/styling data (like CSS) breaks the MVC principle. * Styling concerns belong in the front end (or a dedicated configuration layer), not in the core database model.
Even in the API, putting style info directly on the branch object feels out of place. It should be returned as an embedded resource or sub-object, not part of the core representation.
I think that these are good points too. As Tomas says, the issue becomes clearer when designing/using the API. If we think of the staff interface and OPAC as "reference implementations" of Koha interfaces, a lot of the presentation logic is unique to those interfaces, and has nothing to do with the core library data that Koha manages. For instance, they wouldn't be relevant for a Discovery layer or a third-party interface.
It’s perfectly fine for styling data to live in the database — but why not use a dedicated table?
And you know what’s coming next: someone will want a global default that can be overridden at the library level. Boom — another syspref gets added. We’ve seen this pattern repeatedly: a quick fix becomes permanent and clutters our model.
Y’all know I’ll eventually rant about the `configurations` table again, but seriously — this is exactly the kind of case where we should stop being pragmatic and start doing things the right way.
I suppose we could all argue over what "doing things the right way" means, but I do like the idea of a separate table. Looking back over my latest comments on bug 26129, I can see that I think `configurations` table might be too generic. But... I'm open to the idea. The cool thing about the `configurations` table is that if we decided later it wasn't 100% to purpose it would be easy to migrate to something more specific as well. Personally, I think the idea of a `ui_branches_themes` or `ui_themes_branches` might be an idea. We could move "OPAC information", "Specific OPAC JS", and "Specific OPAC CSS" to that table. If we give each theme a file-system friendly name, we could potentially map this to the filesystem so that libraries could easily link in JS and CSS files as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 --- Comment #81 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #80)
Looking back over my latest comments on bug 26129, I can see that I think `configurations` table might be too generic. But... I'm open to the idea. The cool thing about the `configurations` table is that if we decided later it wasn't 100% to purpose it would be easy to migrate to something more specific as well.
Personally, I think the idea of a `ui_branches_themes` or `ui_themes_branches` might be an idea. We could move "OPAC information", "Specific OPAC JS", and "Specific OPAC CSS" to that table. If we give each theme a file-system friendly name, we could potentially map this to the filesystem so that libraries could easily link in JS and CSS files as well.
I'm not too fussed on the actual implementation, but yeah a separate table would be good. I have been thinking for a little while that having some ui_* specific tables could be good. Tables like `columns_settings` and `tables_settings` for instance would be better organised with a `ui_` prefix I suspect. Could be good to break out a lot of system preferences into ui_* table(s) instead of being in system_preferences as well... But anyway... -- Trying to say you've got my support, Tomas! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #82 from Victor Grousset/tuxayo <victor@tuxayo.net> --- A way to unblock this would be to use the proposed configurations table of bug 26129 . It's the easy part with existing patches compared to the rest of the ticket. UX wise, do we confirm it makes more sense to have the UI for the color in the library edition form? After Specific OPAC CSS. More details in bug 26129 comment 44 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|lucas@bywatersolutions.com |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37054 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39495 Depends on|39495 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39495 [Bug 39495] [OMNIBUS] Staff Interface Theming -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org