[Bug 36197] New: Allow for OPAC unauthenticated ILL request

newer
[Bug 39092] New: When loading an...

bugzilla-daemon＠bugs.koha-community.org

28 Feb 2024 28 Feb '24

4:44 p.m.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 Bug ID: 36197 Summary: Allow for OPAC unauthenticated ILL request Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@ptfs-europe.com CC: pedro.amorim@ptfs-europe.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

Show replies by date

bugzilla-daemon＠bugs.koha-community.org

28 Feb 28 Feb

4:45 p.m.

New subject: [Bug 36197] Allow for OPAC unauthenticated ILL request

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35570 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 [Bug 35570] Add a generic master form in ILL -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4 Mar 4 Mar

2:32 p.m.

New subject: [Bug 36197] Allow for OPAC unauthenticated ILL request

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|35570 |36221 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 [Bug 35570] Add a generic master form in ILL https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 [Bug 36221] Improve styling of Standard backend create form -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

bugzilla-daemon＠bugs.koha-community.org

5 Mar 5 Mar

5:33 p.m.

New subject: [Bug 36197] Allow for OPAC unauthenticated ILL request

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/PTFS-Eur | |ope/koha/commits/36197 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

5:34 p.m.

New subject: [Bug 36197] Allow for OPAC unauthenticated ILL request

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |martin.renvoize@ptfs-europe | |.com, nugged@gmail.com, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3 Apr 3 Apr

11:05 a.m.

New subject: [Bug 36197] Allow for OPAC unauthenticated ILL request

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35604 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604 [Bug 35604] ILL - Allow for automatic backend selection -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

18 Apr 18 Apr

12:50 p.m.

New subject: [Bug 36197] Allow for OPAC unauthenticated ILL request

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|https://github.com/PTFS-Eur |https://github.com/PTFS-Eur |ope/koha/commits/36197 |ope/koha/commits/b_36197 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

24 Apr 24 Apr

3:32 p.m.

New subject: [Bug 36197] Allow for OPAC unauthenticated ILL request

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.auld@ptfs-europe.com | |, magnus@libriotech.no, | |michaela.sieber@kit.edu Keywords| |Sandbox -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:34 p.m.

New subject: [Bug 36197] Allow for OPAC unauthenticated ILL request

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Status|NEW |Needs Signoff Patch complexity|--- |Medium patch Assignee|koha-bugs@lists.koha-commun |pedro.amorim@ptfs-europe.co |ity.org |m Severity|enhancement |new feature --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- This is ready for testing. Branch at: https://github.com/PTFS-Europe/koha/commits/b_36197 0) If k-t-d, run updatedatabase (ignore this if testing on a sandbox) 1) Enable ILLModule syspref: {staff_url}/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=ILLModule 2) No need to install a backend as 35570 is in the tree 3) On a different browser session, without being lgoged in, access the create ILL request OPAC page directly: {opac_url}/cgi-bin/koha/opac-illrequests.pl?method=create&backend=Standard 4) Notice you're presented with the login page, as expected 5) Enable ILLOpacUnauthenticatedRequest: {staff_url}/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=ILLOpacUnauthenticatedRequest 6) Repeat step 3) Notice you now get the create ILL request form, with some additional inputs at the top specific to an unauthenticated request (first name, last name, e-mail address) 6.5) (optional) Confirm the 'Make an Interlibrary loan request' link exists at the bottom of the search results page, while unauthenticated on OPAC: {opac_url}/cgi-bin/koha/opac-search.pl?idx=&q=music&weight_search=1 This should only show for authenticated OPAC users if ILLOpacUnauthenticatedRequest is off. 7) Test the form, try submitting with some blank fields, change type and library after and before inputing data in the input fields, etc. 8) Submit the form successfully. Notice you're presented with the unauthenticated request submission confirmation screen with a message and request details. 9) Go back to Staff UI, logged in, access ILL requests and confirm the unauthenticated request submitted through the OPAC is there: {staff_url}/cgi-bin/koha/ill/ill-requests.pl 10) Test that you can add a patron afterwards, if needed, by clicking 'Edit request' on the toolbar of the manage request page, and entering a patron ID 11) Test that you're able to 'confirm' the request by clicking 'Confirm request', as if it was a regular 'NEW' request. Additional testing: Make sure existing ILL functionality interacts with this new optional workflow behavior. For this, we're using ILLModuleDisclaimerByType. ILLCheckAvailability or AutoILLBackendPriority can also be used but require more setup (plugins, credentials, etc) 1) Configure ILLModuleDisclaimerByType, visit {staff_url}/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=ILLModuleDisclaimerByType 2) Click the 'edit' link at the bottom of the syspref and copy the example code from the description into the text box. Save. 3) Repeat the original test plan from above, but make sure the request type is not 'article' (as that type is bypassed). Use 'journal', for example. Submit the request making sure you fill in all mandatory fields. 4) Notice you're now presented with the ILL request disclaimer screen, hit Submit. Notice the request is created as before. 5) Return to Staff UI, logged in, confirm this 2nd unauthenticated request has been created and the type disclaimer info is stored and presented when viewing the request. Run tests (k-t-d only): prove t/db_dependent/Koha/ILL/Backends.t prove t/db_dependent/selenium/opac_ill_requests.t prove t/lib/plugins/Koha/Plugin/ILL/TestPlugin.pm Sponsored-by: NHS England (National Health Service England) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

17 May 17 May

3:09 p.m.

New subject: [Bug 36197] Allow for OPAC unauthenticated ILL request

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- This is ready for testing. Branch at: https://github.com/PTFS-Europe/koha/commits/b_36197 0) If k-t-d, run updatedatabase (ignore this if testing on a sandbox) 1) Enable ILLModule syspref: {staff_url}/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=ILLModule 2) No need to install a backend as 35570 is in the tree 3) On a different browser session, without being lgoged in, access the create ILL request OPAC page directly: {opac_url}/cgi-bin/koha/opac-illrequests.pl?method=create&backend=Standard 4) Notice you're presented with the login page, as expected 5) Enable ILLOpacUnauthenticatedRequest: {staff_url}/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=ILLOpacUnauthenticatedRequest 6) Repeat step 3) Notice you now get the create ILL request form, with some additional inputs at the top specific to an unauthenticated request (first name, last name, e-mail address) 6.5) (optional) Confirm the 'Make an Interlibrary loan request' link exists at the bottom of the search results page, while unauthenticated on OPAC: {opac_url}/cgi-bin/koha/opac-search.pl?idx=&q=music&weight_search=1 This should only show for authenticated OPAC users if ILLOpacUnauthenticatedRequest is off. 7) Test the form, try submitting with some blank fields, change type and library after and before inputing data in the input fields, etc. 8) Submit the form successfully. Notice you're presented with the unauthenticated request submission confirmation screen with a message and request details. 9) Go back to Staff UI, logged in, access ILL requests and confirm the unauthenticated request submitted through the OPAC is there: {staff_url}/cgi-bin/koha/ill/ill-requests.pl 10) Test that you can add a patron afterwards, if needed, by clicking 'Edit request' on the toolbar of the manage request page, and entering a patron ID 11) Test that you're able to 'confirm' the request by clicking 'Confirm request', as if it was a regular 'NEW' request. Additional testing: Make sure existing ILL functionality interacts with this new optional workflow behavior. For this, we're using ILLModuleDisclaimerByType. ILLCheckAvailability or AutoILLBackendPriority can also be used but require more setup (plugins, credentials, etc) 1) Configure ILLModuleDisclaimerByType, visit {staff_url}/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=ILLModuleDisclaimerByType 2) Click the 'edit' link at the bottom of the syspref and copy the example code from the description into the text box. Save. 3) Repeat the original test plan from above, but make sure the request type is not 'article' (as that type is bypassed). Use 'journal', for example. Submit the request making sure you fill in all mandatory fields. 4) Notice you're now presented with the ILL request disclaimer screen, hit Submit. Notice the request is created as before. 5) Return to Staff UI, logged in, confirm this 2nd unauthenticated request has been created and the type disclaimer info is stored and presented when viewing the request. Run tests (k-t-d only): prove t/db_dependent/Koha/ILL/Backends.t prove t/db_dependent/selenium/opac_ill_requests.t Sponsored-by: NHS England (National Health Service England) -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

20 May 20 May

5:08 a.m.

New subject: [Bug 36197] Allow for OPAC unauthenticated ILL request

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I had a go at testing. I haven't signed off yet, mainly because of the error noted in note 5. Notes from testing (using KTD): 1. Step 8: When you submit the request for type 'Book' (when unauthenticated) and visit the link, you go to a newly created record. This is discoverable by searching. None of the other types creates a record. 2. Additional testing - step 3: I only tested with ILLModuleDisclaimerByType. I don't get a type of 'article', but I think that is the code for 'Journal article'? I get Book, Chapter, Journal, Journal article, Thesis, Conference, DVD, Other, Generic resource. 3. On the input form, compulsory fields have an asterisk after the field label, but nothing to say that these are mandatory (that is, an explanation for the *). When you submit without completing a mandatory field, a plain text message appears at the top. This is different from the "normal" way of presenting forms in the OPAC, but I think you are aware of that 8-). 4. Before or after submitting the form when unauthenticated, the breadcrumb link ('Interlibrary loan requests') comes up with the 'Login to your account' form. 5. If request type is DVD, I get an error trace: Template process failed: file error - /kohadevbox/koha/Koha/ILL/Backend/shared-includes/forms/dvd.inc: not found at /kohadevbox/koha/C4/Templates.pm line 134 in C4::Templates::output at /kohadevbox/koha/C4/Templates.pm line 134 .... 6. If the request type is Other, there are no additional fields to complete (you can add custom fields). 7. Tests pass. Note: need to start up KTD with Selenium (ktd --selenium up). -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

21 May 21 May

9:41 a.m.

New subject: [Bug 36197] Allow for OPAC unauthenticated ILL request

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Hi David, great testing as usual thank you so much. 1) Good point. This is default behavior (for book type) that precedes this work. I'm open to suggestions but have kept this unchanged for now. 2) Correct, 'article' is the code for 'Journal article' 3) Fair points about the form / required fields. As before, I'm open to suggestions but this is default behavior that precedes this work so I've not addressed this here. 4) Thanks for this, will look for providing a follow-up for it. 5) The DVD error, I believe is unrelated to this development and comes from the original commit that added it: https://github.com/PTFS-Europe/koha-ill-freeform/commit/9d735a2dce267d67b439... I believe a required shared-includes/forms/dvd.inc is missing here. I've added Lucas in case he wishes/is available to provide a follow-up here. 6) For the 'other' request type, having no input fields is expected I believe as there's no way what 'other' would have as input hence only considering the custom fields. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

23 May 23 May

7:14 a.m.

New subject: [Bug 36197] Allow for OPAC unauthenticated ILL request

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 --- Comment #5 from David Nind <david@davidnind.com> --- (In reply to Pedro Amorim from comment #4)

...

Hi David, great testing as usual thank you so much. 1) Good point. This is default behavior (for book type) that precedes this work. I'm open to suggestions but have kept this unchanged for now. 2) Correct, 'article' is the code for 'Journal article' 3) Fair points about the form / required fields. As before, I'm open to suggestions but this is default behavior that precedes this work so I've not addressed this here. 4) Thanks for this, will look for providing a follow-up for it. 5) The DVD error, I believe is unrelated to this development and comes from the original commit that added it: https://github.com/PTFS-Europe/koha-ill-freeform/commit/ 9d735a2dce267d67b4396a0a33d7cb9521a1dfbe I believe a required shared-includes/forms/dvd.inc is missing here. I've added Lucas in case he wishes/is available to provide a follow-up here. 6) For the 'other' request type, having no input fields is expected I believe as there's no way what 'other' would have as input hence only considering the custom fields.

Thanks Pedro! Please add my sign off to the bug. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

27 May 27 May

3:32 p.m.

New subject: [Bug 36197] Allow for OPAC unauthenticated ILL request

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3 Jul 3 Jul

3:21 p.m.

New subject: [Bug 36197] Allow for OPAC unauthenticated ILL request

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|36221 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 [Bug 36221] Improve styling of Standard backend create OPAC form -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #21 from David Cook <dcook@prosentient.com.au> --- As Matthias mentioned during the Kohacon ILL workshop, there's nothing preventing bots from abusing this at the moment. But it would be similar to anonymous/unauthenticated purchase suggestions with AnonSuggestions enabled. -- That said, perhaps a magic token for EDS to include in the generated URL or a referrer check could be useful to reduce robot spam (which is an existing problem with AnonSuggestions currently). -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

30 Sep 30 Sep

9:56 a.m.

New subject: [Bug 36197] Allow for OPAC unauthenticated ILL request

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 --- Comment #22 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to David Cook from comment #21)

...

As Matthias mentioned during the Kohacon ILL workshop, there's nothing preventing bots from abusing this at the moment.

But it would be similar to anonymous/unauthenticated purchase suggestions with AnonSuggestions enabled.

--

That said, perhaps a magic token for EDS to include in the generated URL or a referrer check could be useful to reduce robot spam (which is an existing problem with AnonSuggestions currently).

There is already an existing captcha system present in opac-memberentry.pl (for patron self registration). Would it make more sense to make use of this here by re utilizing it (doing any necessary refactoring), thus having a single place to extend and maintain going forward and perhaps establish a pattern for public facing forms in Koha, e.g. also apply it to unauthenticated purchase suggestions in the future? -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1 Oct 1 Oct

12:36 a.m.

New subject: [Bug 36197] Allow for OPAC unauthenticated ILL request

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 --- Comment #23 from David Cook <dcook@prosentient.com.au> --- (In reply to Pedro Amorim from comment #22)

...

There is already an existing captcha system present in opac-memberentry.pl (for patron self registration). Would it make more sense to make use of this here by re utilizing it (doing any necessary refactoring), thus having a single place to extend and maintain going forward and perhaps establish a pattern for public facing forms in Koha, e.g. also apply it to unauthenticated purchase suggestions in the future?

Hmm there's a thought. That would potentially help against bots. Off the top of my head, I don't think I've heard complaints of bots doing self-registrations. I just remembered that somewhere had a negative captcha, and it looks like opac-suggestions.tt is the one implementing that, but I think most bots can easily bypass that one these days. I think I still feel a bit weird about unauthenticated ILLs, but I suppose they're not really that different to unauthenticated purchase suggestions, although I don't love those either. But then in both cases they're staff mediated anyway... so I suppose that's all right. But yeah... some kind of capture is needed I think. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

31 Oct 31 Oct

7:30 a.m.

New subject: [Bug 36197] Allow for OPAC unauthenticated ILL request

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

7:33 a.m.

New subject: [Bug 36197] Allow for OPAC unauthenticated ILL request

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |roadmap_24_05, | |roadmap_24_11 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11 Nov 11 Nov

4:56 p.m.

New subject: [Bug 36197] Allow for OPAC unauthenticated ILL request

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_11_candidate, |rel_25_05_candidate |Sandbox | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

14 Nov 14 Nov

bugzilla-daemon＠bugs.koha-community.org

1:11 p.m.

New subject: [Bug 36197] Allow for OPAC unauthenticated ILL request

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 --- Comment #39 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 176565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176565&action=edit Bug 36197: (QA follow-up): Fix PluginRoutes.t prove t/db_dependent/Koha/REST/Plugin/PluginRoutes.t -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

16 Jan 16 Jan

3:52 p.m.

New subject: [Bug 36197] Allow for OPAC unauthenticated ILL request

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 --- Comment #40 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 176680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176680&action=edit Bug 36197: (QA follow-up): Make ConfirmAuto::get_priority_backends respect opac_available_backends if OPAC This makes it so that the Auto ILL stage on OPAC only queries opac_available_backends. Fix is submitted here and not in bug 35604 because it's here that opac_available_backends is implemented. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

17 Jan 17 Jan

12:04 p.m.

New subject: [Bug 36197] Allow for OPAC unauthenticated ILL request

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 --- Comment #41 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 176723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176723&action=edit Bug 36197: (QA follow-up): Fix backends filtering in opac_available_backends This was incorrectly keeping backends that don't support unauthenticated ILL requests if more than one existed. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:04 p.m.

New subject: [Bug 36197] Allow for OPAC unauthenticated ILL request

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 --- Comment #42 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 176724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176724&action=edit Bug 36197: (QA follow-up): Pass the filtered OPAC backends to OPAC template The list of backends in the dropdown in this page: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?op=create If unauthenticated is enabled, this is listing all backends, instead of making use of opac_available_backends. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:03 p.m.

New subject: [Bug 36197] Allow for OPAC unauthenticated ILL request

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 --- Comment #43 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 176726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176726&action=edit Bug 36197: (QA follow-up): Move unauthenticated_notes to core Move this out of Standard specific logic. Other backends that support unauthenticated requests may want to make use of this and not duplicate code. Also make these notes translatable. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:12 p.m.

New subject: [Bug 36197] Allow for OPAC unauthenticated ILL request

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 --- Comment #44 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 176727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176727&action=edit Bug 36197: (QA follow-up): Move unauth_request_data_check to core Move this out of Standard specific logic. Other backends that support unauthenticated requests may want to make use of this and not duplicate code. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

27 Mar 27 Mar

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 --- Comment #66 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Rebased and tidied on top of tidied bug 35604 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

31 Mar 31 Mar

3:50 p.m.

New subject: [Bug 36197] Allow for OPAC unauthenticated ILL request

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39092 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39092 [Bug 39092] When loading an ILL backend plugin it should be cached -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2 Apr 2 Apr

2:47 p.m.

New subject: [Bug 36197] Allow for OPAC unauthenticated ILL request

bugzilla-daemon＠bugs.koha-community.org

2:49 p.m.

New subject: [Bug 36197] Allow for OPAC unauthenticated ILL request

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 --- Comment #68 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- TODO's from Hackfest's QA session: 1) Use "We'll contact you shortly" instead of "Check your email" after an unauthenticated request has been placed 2) unauthenticated fields should use their own respective illrequestattributes, removed from notes and staffnotes 3) update request page template to list all 3 unauthenticated fields 4) Update history check request matches from OPAC with Staff UI -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:50 p.m.

New subject: [Bug 36197] Allow for OPAC unauthenticated ILL request

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 --- Comment #69 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- TODO's from Hackfest's QA session: 1) Use "We'll contact you shortly" instead of "Check your email" after an unauthenticated request has been placed 2) unauthenticated fields should use their own respective illrequestattributes, removed from notes and staffnotes 3) update request page template to list all 3 unauthenticated fields -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:24 p.m.

New subject: [Bug 36197] Allow for OPAC unauthenticated ILL request

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 --- Comment #91 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180871&action=edit Bug 36197: (QA follow-up): Hackfest followup WIP Moved unauth data to their respective illrequestattributes entries instead of staffnotes + opacnotes. Update confirmation message -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:24 p.m.

New subject: [Bug 36197] Allow for OPAC unauthenticated ILL request

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 --- Comment #92 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180872&action=edit Bug 36197: (QA follow-up): Add public form captcha Feedback provided by David Cook + Matthias Meusburger at KohaCon24 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:24 p.m.

New subject: [Bug 36197] Allow for OPAC unauthenticated ILL request

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 --- Comment #93 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180873&action=edit Bug 36197: (QA follow-up): Adopt POST REDIRECT GET pattern Upon submitting the unauthenticated request, the user is now redirected to a different page and the request details are passed through a session variable. This is to prevent the user from being able to resubmit the same unauthenticated request multiple times (see security bug 39611) -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:25 p.m.

New subject: [Bug 36197] Allow for OPAC unauthenticated ILL request

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 --- Comment #94 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Hi guys, this last submission adds the following changes: 1) Rebase on top of QA changes made by Tomas to bug 35604, including moving the opac_available_backends method from the no longer existent Backends.pm file into ILL::Request::Config instead 2) Hackfest QA feedback addressed 3) Added a new captcha to the public facing form 4) Upon revisiting and testing further, I discovered the user was able to resubmit the same form multiple times, so I've addressed that in the last patch. I've also found this behavior somewhere else in Koha and have filed a security bug for that. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

17 Apr 17 Apr

bugzilla-daemon＠bugs.koha-community.org

21 Apr 21 Apr

9:52 a.m.

New subject: [Bug 36197] Allow for OPAC unauthenticated ILL request

bugzilla-daemon＠bugs.koha-community.org

22 Apr 22 Apr

2:51 p.m.

New subject: [Bug 36197] Allow for OPAC unauthenticated ILL request

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39697 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39697 [Bug 39697] ILL OPAC unauthenticated form is not centered -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

23 Apr 23 Apr

3:12 p.m.

New subject: [Bug 36197] Allow for OPAC unauthenticated ILL request

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

24 Apr 24 Apr

2:17 a.m.

New subject: [Bug 36197] Allow for OPAC unauthenticated ILL request

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 --- Comment #123 from David Nind <david@davidnind.com> --- Thanks for the release note! -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

25 Apr 25 Apr

7:41 a.m.

New subject: [Bug 36197] Allow unauthenticated ILL requests in the OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow for OPAC |Allow unauthenticated ILL |unauthenticated ILL request |requests in the OPAC --- Comment #124 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #121)

...

Pedro, thanks for taking care of the feedback we provided during the hackfest.

This looks great now. There's only two false negative errors.

Thanks for the warning about the false positive(?) errors :) Some tiny tiny stuff: 1) Spelling: E-mail vs. email It looks like the patron form and other places in Koha prefer email over e-mail, so it would be nice to standardize. There is also a mix here between some validation messages and the form for unauthenticated ILL requests. 2) Terminology: Collection library <label for="branchcode">Collection library:</label> Wondering if this should be "Pickup library" instead. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

7:42 a.m.

New subject: [Bug 36197] Allow unauthenticated ILL requests in the OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

7:48 a.m.

New subject: [Bug 36197] Allow unauthenticated ILL requests in the OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

7:48 a.m.

New subject: [Bug 36197] Allow unauthenticated ILL requests in the OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 --- Comment #125 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

7:05 p.m.

New subject: [Bug 36197] Allow unauthenticated ILL requests in the OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_25_05_candidate | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

28 Apr 28 Apr

1:10 p.m.

New subject: [Bug 36197] Allow unauthenticated ILL requests in the OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 --- Comment #126 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181592&action=edit Bug 36197: (QA follow-up): Update terminology: - Library input: Change 'Collection library' to 'Pickup library'. - Update 'e-mail' to 'email' -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

29 Apr 29 Apr

4:40 p.m.

New subject: [Bug 36197] Allow unauthenticated ILL requests in the OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39774 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39774 [Bug 39774] OPAC ILL Unauthenticated request details table not styled correctly -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

30 Apr 30 Apr

11:52 a.m.

New subject: [Bug 36197] Allow unauthenticated ILL requests in the OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39786 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39786 [Bug 39786] ILL get_notice errors if request does not have a patron -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

16 May 16 May

1:16 p.m.

New subject: [Bug 36197] Allow unauthenticated ILL requests in the OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39918 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39918 [Bug 39918] Unauthenticated request data should show when editing a request -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:18 p.m.

New subject: [Bug 36197] Allow unauthenticated ILL requests in the OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #127 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry for missing this earlier, picked up the follow-up now. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

20 May 20 May

7:19 p.m.

New subject: [Bug 36197] Allow unauthenticated ILL requests in the OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39948 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39948 [Bug 39948] Unauthenticated ILL form cluttered in the OPAC -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4 Aug 4 Aug

2:49 p.m.

New subject: [Bug 36197] Allow unauthenticated ILL requests in the OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #128 from Fridolin Somers <fridolin.somers@biblibre.com> --- New feature not for 24.11.x -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1 Apr 1 Apr

11:48 a.m.

New subject: [Bug 36197] Allow unauthenticated ILL requests in the OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@openfifth.co | |.uk Documentation| |Aude Charillon contact| | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3 Jun 3 Jun

2:33 p.m.

New subject: [Bug 36197] Allow unauthenticated ILL requests in the OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1199 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8 Jun 8 Jun

11:40 a.m.

New subject: [Bug 36197] Allow unauthenticated ILL requests in the OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #129 from Aude Charillon <aude.charillon@openfifth.co.uk> --- Koha Manual updated. -- You are receiving this mail because: You are watching all bug changes.

Age (days ago)

868

Last active (days ago)

List overview

Download

157 comments

1 participants

participants (1)

bugzilla-daemon＠bugs.koha-community.org