[Bug 43182] New: Add <<USER_LIBRARY>> to editor substitutions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43182 Bug ID: 43182 Summary: Add <<USER_LIBRARY>> to editor substitutions Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Target Milestone: --- Currently, <<YYYY>>, <<YY>>, <<MM>>, <<DD>>, and <<USER>> get replaced in the bib and item editors. It would be useful to have <<USER_LIBRARY>> as well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43182 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Should it be replaced by library code or library name? Mabe while we are on it... user_library_marcorgcode could also be useful as that code is often used in cataloguing context - thinking of 003 for example. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43182 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #1)
Should it be replaced by library code or library name?
Oh that's a good point. Maybe we need <USER_LIBRARY_CODE> and <USER_LIBRARY_DESC>?
Mabe while we are on it... user_library_marcorgcode could also be useful as that code is often used in cataloguing context - thinking of 003 for example.
Don't we already have MARCOrgCode system preference and MARC organization code at the library/branch level? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43182 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Cook from comment #2)
(In reply to Katrin Fischer from comment #1)
Should it be replaced by library code or library name?
Oh that's a good point. Maybe we need <USER_LIBRARY_CODE> and <USER_LIBRARY_DESC>?
I think I'd use "NAME" instead of desc, matching branchname/library name in other spots.
Mabe while we are on it... user_library_marcorgcode could also be useful as that code is often used in cataloguing context - thinking of 003 for example.
Don't we already have MARCOrgCode system preference and MARC organization code at the library/branch level?
We do, but no way to insert it into the frameworks automatically depending on the cataloguer's home branch :) 003 is maybe not the best example as we have some logic there already, but there are also $0 $w subfields. But this idea can also go on another bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43182 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Shouldnt we look for TT replacements instead of extending the old style ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43182 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Marcel de Rooy from comment #4)
Shouldnt we look for TT replacements instead of extending the old style ?
Not sure if that applies here, it's replacements in the MARC record. But maybe? https://koha-community.org/manual/latest/en/html/administration.html#edit-a-... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43182 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #5)
(In reply to Marcel de Rooy from comment #4)
Shouldnt we look for TT replacements instead of extending the old style ?
Not sure if that applies here, it's replacements in the MARC record. But maybe? https://koha-community.org/manual/latest/en/html/administration.html#edit-a- marc-subfield-label
OK, apparently I interpreted in the wrong context :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43182 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- (In reply to Marcel de Rooy from comment #4)
Shouldnt we look for TT replacements instead of extending the old style ?
It's a good question. Honestly, I think allowing non-system users the ability to provide TT code is a security problem. TT is so powerful and flexible. We try to hobble it as much as we can for end users, but it has a large surface, so it's a big target. I think we'd be better off using a simpler template syntax like Mustache or Handlebars: https://metacpan.org/pod/Text::MustacheTemplate https://metacpan.org/pod/Text::Handlebars Much less potential for abuse. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org